<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>69397</bug_id>
          
          <creation_ts>2011-10-04 21:05:25 -0700</creation_ts>
          <short_desc>Focus rings are missing in WebKitTestRunner snapshots</short_desc>
          <delta_ts>2011-10-06 12:10:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>42688</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Fraser (smfr)">simon.fraser</reporter>
          <assigned_to name="Simon Fraser (smfr)">simon.fraser</assigned_to>
          <cc>jonlee</cc>
    
    <cc>sam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>478147</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2011-10-04 21:05:25 -0700</bug_when>
    <thetext>In WebKitTestRunner pixel results, form controls don&apos;t look highlighted. They have the appearance that they have in background windows. Also, focus rings don&apos;t show up, and the caret is disabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478148</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2011-10-04 21:06:02 -0700</bug_when>
    <thetext>&lt;rdar://problem/10235607&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478804</commentid>
    <comment_count>2</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2011-10-05 17:23:53 -0700</bug_when>
    <thetext>Actually form controls look OK, but just different in Lion. Focus rings are still missing though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478854</commentid>
    <comment_count>3</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2011-10-05 18:26:06 -0700</bug_when>
    <thetext>DRT/WK1 have some smarts here that we may need to replicate:

in - (void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)frame:
   
    gLayoutTestController-&gt;setWindowIsKey(true);
    NSView *documentView = [[mainFrame frameView] documentView];
    [[[mainFrame webView] window] makeFirstResponder:documentView];


void LayoutTestController::setWindowIsKey(bool windowIsKey)
{
    m_windowIsKey = windowIsKey;
    [[mainFrame webView] _updateActiveState];
}

WebView:
- (void)_updateActiveState
{
    if (_private &amp;&amp; _private-&gt;page)
        _private-&gt;page-&gt;focusController()-&gt;setActive([[self window] isKeyWindow]);
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>479371</commentid>
    <comment_count>4</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2011-10-06 12:10:36 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 42688 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>