69389 2011-10-04 18:11:55 -0700 Mask underlying RENDERER and VENDOR strings 2011-10-05 11:06:32 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr cmarrin mdelaney7 senorblanco vangelis webkit.review.bot zmo oldest_to_newest 478099 0 kbr 2011-10-04 18:11:55 -0700 After extensive discussion in the WebGL working group, it appears that the consensus among browser vendors is that exposing the underlying GPU's GL_RENDERER and GL_VENDOR strings via WebGL is problematic. The reasons presented are twofold. First, they expose a certain number of bits of personally identifiable information. Second, they have similar properties to the browser's user-agent string, which has been an extremely problematic construct in the development of the web. The plan is to stop reporting the underlying GPU's strings and instead report something generic, and to do so for all of WebKit's ports, to maintain parity. It's possible this decision might be revisited in the future, but for the time being, this change seems necessary in order to match the behavior of Firefox and Opera. 478102 1 109725 kbr 2011-10-04 18:21:16 -0700 Created attachment 109725 Patch 478132 2 109725 sam 2011-10-04 20:09:34 -0700 Comment on attachment 109725 Patch What is the point of exposing VENDOR or RENDERER at all? 478469 3 kbr 2011-10-05 10:16:08 -0700 (In reply to comment #2) > (From update of attachment 109725 [details]) > What is the point of exposing VENDOR or RENDERER at all? They're part of the OpenGL ES 2.0 specification, and an early design principle for WebGL was not to arbitrarily subset the API. Some sophisticated applications also have wanted to change their behavior slightly based on the values of these strings to achieve the best performance on various graphics cards. The authors of these applications aren't happy that the real information will be masked, but we're still working toward a solution that works for everybody. 478513 4 109725 webkit.review.bot 2011-10-05 11:06:28 -0700 Comment on attachment 109725 Patch Clearing flags on attachment: 109725 Committed r96726: <http://trac.webkit.org/changeset/96726> 478514 5 webkit.review.bot 2011-10-05 11:06:32 -0700 All reviewed patches have been landed. Closing bug. 109725 2011-10-04 18:21:16 -0700 2011-10-05 11:06:28 -0700 Patch bug-69389-20111004182115.patch text/plain 6702 kbr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2NjcwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMDQgIEtlbm5ldGgg UnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIE1hc2sgdW5kZXJseWluZyBSRU5E RVJFUiBhbmQgVkVORE9SIHN0cmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY5Mzg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9jYW52YXMvd2ViZ2wvcmVuZGVyZXItYW5kLXZlbmRv ci1zdHJpbmdzLmh0bWwKKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMR2V0SW5mby5oOgor ICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFBhcmFtZXRlcik6CisKIDIwMTEt MTAtMDQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBJ Z25vcmUgdGhlIHdhcm5pbmcgYWJvdXQgdXNpbmcgJ292ZXJyaWRlJy4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMR2V0SW5mby5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMR2V0SW5mby5oCShyZXZpc2lvbiA5NjY2MSkKKysrIFNv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMR2V0SW5mby5oCSh3b3JraW5nIGNvcHkpCkBA IC03MCwyNSArNzAsMjUgQEAgcHVibGljOgogICAgICAgICBrVHlwZVdlYkdMVmVydGV4QXJyYXlP YmplY3RPRVMsCiAgICAgfTsKIAotICAgIFdlYkdMR2V0SW5mbyhib29sIHZhbHVlKTsKKyAgICBl eHBsaWNpdCBXZWJHTEdldEluZm8oYm9vbCB2YWx1ZSk7CiAgICAgV2ViR0xHZXRJbmZvKGNvbnN0 IGJvb2wqIHZhbHVlLCBpbnQgc2l6ZSk7Ci0gICAgV2ViR0xHZXRJbmZvKGZsb2F0IHZhbHVlKTsK LSAgICBXZWJHTEdldEluZm8oaW50IHZhbHVlKTsKKyAgICBleHBsaWNpdCBXZWJHTEdldEluZm8o ZmxvYXQgdmFsdWUpOworICAgIGV4cGxpY2l0IFdlYkdMR2V0SW5mbyhpbnQgdmFsdWUpOwogICAg IC8vIFJlcHJlc2VudHMgdGhlIG51bGwgdmFsdWUgYW5kIHR5cGUuCiAgICAgV2ViR0xHZXRJbmZv KCk7Ci0gICAgV2ViR0xHZXRJbmZvKGNvbnN0IFN0cmluZyYgdmFsdWUpOwotICAgIFdlYkdMR2V0 SW5mbyh1bnNpZ25lZCBpbnQgdmFsdWUpOwotICAgIFdlYkdMR2V0SW5mbyhQYXNzUmVmUHRyPFdl YkdMQnVmZmVyPiB2YWx1ZSk7Ci0gICAgV2ViR0xHZXRJbmZvKFBhc3NSZWZQdHI8RmxvYXQzMkFy cmF5PiB2YWx1ZSk7Ci0gICAgV2ViR0xHZXRJbmZvKFBhc3NSZWZQdHI8V2ViR0xGcmFtZWJ1ZmZl cj4gdmFsdWUpOwotICAgIFdlYkdMR2V0SW5mbyhQYXNzUmVmUHRyPEludDMyQXJyYXk+IHZhbHVl KTsKKyAgICBleHBsaWNpdCBXZWJHTEdldEluZm8oY29uc3QgU3RyaW5nJiB2YWx1ZSk7CisgICAg ZXhwbGljaXQgV2ViR0xHZXRJbmZvKHVuc2lnbmVkIGludCB2YWx1ZSk7CisgICAgZXhwbGljaXQg V2ViR0xHZXRJbmZvKFBhc3NSZWZQdHI8V2ViR0xCdWZmZXI+IHZhbHVlKTsKKyAgICBleHBsaWNp dCBXZWJHTEdldEluZm8oUGFzc1JlZlB0cjxGbG9hdDMyQXJyYXk+IHZhbHVlKTsKKyAgICBleHBs aWNpdCBXZWJHTEdldEluZm8oUGFzc1JlZlB0cjxXZWJHTEZyYW1lYnVmZmVyPiB2YWx1ZSk7Cisg ICAgZXhwbGljaXQgV2ViR0xHZXRJbmZvKFBhc3NSZWZQdHI8SW50MzJBcnJheT4gdmFsdWUpOwog ICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQgV2ViR0xPYmplY3RBcnJheQogICAgIC8vIFdlYkdMR2V0 SW5mbyhQYXNzUmVmUHRyPFdlYkdMT2JqZWN0QXJyYXk+IHZhbHVlKTsKLSAgICBXZWJHTEdldElu Zm8oUGFzc1JlZlB0cjxXZWJHTFByb2dyYW0+IHZhbHVlKTsKLSAgICBXZWJHTEdldEluZm8oUGFz c1JlZlB0cjxXZWJHTFJlbmRlcmJ1ZmZlcj4gdmFsdWUpOwotICAgIFdlYkdMR2V0SW5mbyhQYXNz UmVmUHRyPFdlYkdMVGV4dHVyZT4gdmFsdWUpOwotICAgIFdlYkdMR2V0SW5mbyhQYXNzUmVmUHRy PFVpbnQ4QXJyYXk+IHZhbHVlKTsKLSAgICBXZWJHTEdldEluZm8oUGFzc1JlZlB0cjxXZWJHTFZl cnRleEFycmF5T2JqZWN0T0VTPiB2YWx1ZSk7CisgICAgZXhwbGljaXQgV2ViR0xHZXRJbmZvKFBh c3NSZWZQdHI8V2ViR0xQcm9ncmFtPiB2YWx1ZSk7CisgICAgZXhwbGljaXQgV2ViR0xHZXRJbmZv KFBhc3NSZWZQdHI8V2ViR0xSZW5kZXJidWZmZXI+IHZhbHVlKTsKKyAgICBleHBsaWNpdCBXZWJH TEdldEluZm8oUGFzc1JlZlB0cjxXZWJHTFRleHR1cmU+IHZhbHVlKTsKKyAgICBleHBsaWNpdCBX ZWJHTEdldEluZm8oUGFzc1JlZlB0cjxVaW50OEFycmF5PiB2YWx1ZSk7CisgICAgZXhwbGljaXQg V2ViR0xHZXRJbmZvKFBhc3NSZWZQdHI8V2ViR0xWZXJ0ZXhBcnJheU9iamVjdE9FUz4gdmFsdWUp OwogCiAgICAgdmlydHVhbCB+V2ViR0xHZXRJbmZvKCk7CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkocmV2aXNp b24gOTY2NjEpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0Nv bnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTcxLDcgKzIxNzEsNyBAQCBXZWJHTEdldElu Zm8gV2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRQCiAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQz RDo6UkVOREVSQlVGRkVSX0JJTkRJTkc6CiAgICAgICAgIHJldHVybiBXZWJHTEdldEluZm8oUGFz c1JlZlB0cjxXZWJHTFJlbmRlcmJ1ZmZlcj4obV9yZW5kZXJidWZmZXJCaW5kaW5nKSk7CiAgICAg Y2FzZSBHcmFwaGljc0NvbnRleHQzRDo6UkVOREVSRVI6Ci0gICAgICAgIHJldHVybiBXZWJHTEdl dEluZm8obV9jb250ZXh0LT5nZXRTdHJpbmcoR3JhcGhpY3NDb250ZXh0M0Q6OlJFTkRFUkVSKSk7 CisgICAgICAgIHJldHVybiBXZWJHTEdldEluZm8oU3RyaW5nKCJXZWJLaXQgV2ViR0wiKSk7CiAg ICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6U0FNUExFX0JVRkZFUlM6CiAgICAgICAgIHJldHVy biBnZXRJbnRQYXJhbWV0ZXIocG5hbWUpOwogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlNB TVBMRV9DT1ZFUkFHRV9JTlZFUlQ6CkBAIC0yMjM1LDcgKzIyMzUsNyBAQCBXZWJHTEdldEluZm8g V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRQCiAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6 VU5QQUNLX0NPTE9SU1BBQ0VfQ09OVkVSU0lPTl9XRUJHTDoKICAgICAgICAgcmV0dXJuIFdlYkdM R2V0SW5mbyhtX3VucGFja0NvbG9yc3BhY2VDb252ZXJzaW9uKTsKICAgICBjYXNlIEdyYXBoaWNz Q29udGV4dDNEOjpWRU5ET1I6Ci0gICAgICAgIHJldHVybiBXZWJHTEdldEluZm8oIldlYmtpdCAo IiArIG1fY29udGV4dC0+Z2V0U3RyaW5nKEdyYXBoaWNzQ29udGV4dDNEOjpWRU5ET1IpICsgIiki KTsKKyAgICAgICAgcmV0dXJuIFdlYkdMR2V0SW5mbyhTdHJpbmcoIldlYktpdCIpKTsKICAgICBj YXNlIEdyYXBoaWNzQ29udGV4dDNEOjpWRVJTSU9OOgogICAgICAgICByZXR1cm4gV2ViR0xHZXRJ bmZvKCJXZWJHTCAxLjAgKCIgKyBtX2NvbnRleHQtPmdldFN0cmluZyhHcmFwaGljc0NvbnRleHQz RDo6VkVSU0lPTikgKyAiKSIpOwogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlZJRVdQT1JU OgpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gOTY2NzApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0xMC0wNCAgS2VubmV0aCBSdXNzZWxs ICA8a2JyQGdvb2dsZS5jb20+CisKKyAgICAgICAgTWFzayB1bmRlcmx5aW5nIFJFTkRFUkVSIGFu ZCBWRU5ET1Igc3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjkzODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3JlbmRlcmVyLWFuZC12ZW5kb3Itc3RyaW5ncy1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3JlbmRlcmVy LWFuZC12ZW5kb3Itc3RyaW5ncy5odG1sOiBBZGRlZC4KKwogMjAxMS0xMC0wNCAgRGF2aWQgQmFy ciAgPGRhdmlkYmFyckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVXBkYXRlIHRlc3QgZXhwZWN0 YXRpb25zIGFmdGVyIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0Lzk2NDQ5CkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9yZW5kZXJlci1hbmQtdmVuZG9yLXN0cmlu Z3MtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dl YmdsL3JlbmRlcmVyLWFuZC12ZW5kb3Itc3RyaW5ncy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9yZW5kZXJlci1hbmQtdmVuZG9yLXN0 cmluZ3MtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACitWZXJpZmll cyB0aGUgY29udGVudHMgb2YgdGhlIFJFTkRFUkVSIGFuZCBWRU5ET1Igc3RyaW5ncyB0byBhdm9p ZCByZWdyZXNzaW9ucy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQ QVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCitQQVNTIGdsLmdl dFBhcmFtZXRlcihnbC5SRU5ERVJFUikgaXMgIldlYktpdCBXZWJHTCIKK1BBU1MgZ2wuZ2V0UGFy YW1ldGVyKGdsLlZFTkRPUikgaXMgIldlYktpdCIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93 ZWJnbC9yZW5kZXJlci1hbmQtdmVuZG9yLXN0cmluZ3MuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9yZW5kZXJlci1hbmQtdmVuZG9yLXN0cmluZ3MuaHRt bAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3JlbmRlcmVy LWFuZC12ZW5kb3Itc3RyaW5ncy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMxIEBACis8 aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vanMvcmVzb3VyY2VzL2pz LXRlc3Qtc3R5bGUuY3NzIi8+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvd2ViZ2wtdGVzdC5q cyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9ImRlc2NyaXB0aW9uIj48L2Rp dj4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlZl cmlmaWVzIHRoZSBjb250ZW50cyBvZiB0aGUgUkVOREVSRVIgYW5kIFZFTkRPUiBzdHJpbmdzIHRv IGF2b2lkIHJlZ3Jlc3Npb25zLiIpCisKK2lmICh3aW5kb3cuaW5pdE5vbktocm9ub3NGcmFtZXdv cmspCisgICAgd2luZG93LmluaXROb25LaHJvbm9zRnJhbWV3b3JrKGZhbHNlKTsKKwordmFyIGds ID0gY3JlYXRlM0RDb250ZXh0KCk7CisKKy8vIENvbnNlbnN1cyBpbiB0aGUgV2ViR0wgd29ya2lu ZyBncm91cCBoYXMgYmVlbiB0byBtYXNrIHRoZQorLy8gdW5kZXJseWluZyBoYXJkd2FyZSdzIFJF TkRFUkVSIGFuZCBWRU5ET1Igc3RyaW5ncywgd2hpY2ggbGVhayBhCisvLyBjZXJ0YWluIGFtb3Vu dCBvZiBwZXJzb25hbGx5IGlkZW50aWZpYWJsZSBpbmZvcm1hdGlvbi4gVGhpcyB0ZXN0IGlzCisv LyBpbnRlbmRlZCBvbmx5IHRvIGNhdGNoIGFjY2lkZW50YWwgcmVncmVzc2lvbnMsIG5vdCB0byBl bmZvcmNlIHRoZQorLy8gc3BlY2lmaWMgc3RyaW5ncy4KKworc2hvdWxkQmUoImdsLmdldFBhcmFt ZXRlcihnbC5SRU5ERVJFUikiLCAnIldlYktpdCBXZWJHTCInKTsKK3Nob3VsZEJlKCJnbC5nZXRQ YXJhbWV0ZXIoZ2wuVkVORE9SKSIsICciV2ViS2l0IicpOworCitzdWNjZXNzZnVsbHlQYXJzZWQg PSB0cnVlOworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4K