69370 2011-10-04 13:46:18 -0700 WebKit not ensure font load before calling Skia to drawPosText during Chrome printing 2011-10-13 17:16:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://code.google.com/p/chromium/issues/detail?id=94421 P2 Normal --- 69684 0 arthurhsu webkit-unassigned agl jamesr simonjam webkit.review.bot oldest_to_newest 477896 0 arthurhsu 2011-10-04 13:46:18 -0700 In Chrome sandbox model, GDI calls such as GetOutlineTextMetrics() can fail if the font is not loaded in memory already. Chrome browser process implements a hack that will force GDI to load the desired font into memory, and in WebKit terms, it's called PlatformSupport::ensureFontLoaded(). This means that WebKit renderer must call PlatformSupport::ensureFontLoaded() right before calling Skia to draw glyphs because they are both in sandbox. 477936 1 109685 arthurhsu 2011-10-04 14:15:44 -0700 Created attachment 109685 Patch 477943 2 109685 jamesr 2011-10-04 14:19:37 -0700 Comment on attachment 109685 Patch Is there any way to construct a test case for this? What is the failure mode if this doesn't happen? 477954 3 arthurhsu 2011-10-04 14:24:56 -0700 (In reply to comment #2) > (From update of attachment 109685 [details]) > Is there any way to construct a test case for this? This currently causes problem only in Chrome printing code because Skia needs to query GDI outline text metrics for generating PDF data. I'm not sure how that sandbox/PDF generation can fit in WebKit testing. > What is the failure mode if this doesn't happen? In Chrome it will crash the renderer and the printing will fail. 478789 4 jamesr 2011-10-05 16:53:15 -0700 So this is just a fix for printing? You should update the bug title to reflect that. 478845 5 arthurhsu 2011-10-05 18:09:04 -0700 (In reply to comment #4) > So this is just a fix for printing? You should update the bug title to reflect that. Done. 479331 6 agl 2011-10-06 11:38:12 -0700 This LGTM, but I am not a WebKit reviewer. You need an r+ from a real WebKit reviewer before committing. 479332 7 109685 jamesr 2011-10-06 11:39:24 -0700 Comment on attachment 109685 Patch agl's LGTM is good enough for me. 479387 8 109685 webkit.review.bot 2011-10-06 12:26:42 -0700 Comment on attachment 109685 Patch Clearing flags on attachment: 109685 Committed r96847: <http://trac.webkit.org/changeset/96847> 479388 9 webkit.review.bot 2011-10-06 12:26:47 -0700 All reviewed patches have been landed. Closing bug. 480434 10 simonjam 2011-10-07 18:56:58 -0700 There's a pretty significant memory regression on Chromium Windows. This is the only Windows change in the regression range, so we're going to try rolling it out and see if memory returns to normal. If it turns out this isn't causing it, I'll roll it back in. 483447 11 110897 simonjam 2011-10-13 13:45:10 -0700 Created attachment 110897 Patch for landing 483670 12 simonjam 2011-10-13 17:16:34 -0700 Committed r97426: <http://trac.webkit.org/changeset/97426> 109685 2011-10-04 14:15:44 -0700 2011-10-13 13:45:07 -0700 Patch bug-69370-20111004141543.patch text/plain 1257 arthurhsu SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2NjQxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMDQgIEFydGh1ciBI c3UgIDxhcnRodXJoc3VAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEVuc3VyZSBmb250IGxvYWRl ZCBiZWZvcmUgY2FsbGluZyBTa2lhIHRvIGRyYXdQb3NUZXh0IGluIENocm9tZSBzYW5kYm94Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTM3MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vRm9udENocm9taXVtV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkZvbnQ6OmRyYXdHbHlwaHMpOgorCiAyMDExLTEwLTA0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCBy ZWZlcmVuY2VzIHdoZXJlIHBvc3NpYmxlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9Gb250Q2hyb21pdW1XaW4uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDaHJvbWl1bVdpbi5jcHAJ KHJldmlzaW9uIDk2NjMxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vRm9udENocm9taXVtV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjksNiArNjksNyBA QCB2b2lkIEZvbnQ6OmRyYXdHbHlwaHMoR3JhcGhpY3NDb250ZXh0KiBnCiAgICAgICAgIHJldHVy bjsKIAogICAgIEhGT05UIGhmb250ID0gZm9udC0+cGxhdGZvcm1EYXRhKCkuaGZvbnQoKTsKKyAg ICBQbGF0Zm9ybVN1cHBvcnQ6OmVuc3VyZUZvbnRMb2FkZWQoaGZvbnQpOwogCiAgICAgLy8gV2Ug ZHJhdyB0aGUgZ2x5cGhzIGluIGNodW5rcyB0byBhdm9pZCBoYXZpbmcgdG8gZG8gYSBoZWFwIGFs bG9jYXRpb24gZm9yCiAgICAgLy8gdGhlIGFycmF5cyBvZiBjaGFyYWN0ZXJzIGFuZCBhZHZhbmNl cy4K 110897 2011-10-13 13:45:10 -0700 2011-10-13 17:16:55 -0700 Patch for landing bug-69370-20111013134509.patch text/plain 1388 simonjam U3VidmVyc2lvbiBSZXZpc2lvbjogOTczOTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3ZjRjN2FlMDgzM2Q1Zjcw NTNlNDQ4NzJkMzRlODU0OTdlODA2NTY2Li5lYmJkNTk5OTVlN2VmNTNlYTJkOGU2N2E0ZmI5YzQ0 Y2ZmZDI2OGQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMTMgIEFydGh1 ciBIc3UgIDxhcnRodXJoc3VAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEVuc3VyZSBmb250IGxv YWRlZCBiZWZvcmUgY2FsbGluZyBTa2lhIHRvIGRyYXdQb3NUZXh0IGluIENocm9tZSBzYW5kYm94 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTM3MAor CisgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENocm9taXVtV2luLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkZvbnQ6OmRyYXdHbHlwaHMpOgorCiAyMDExLTEwLTEzICBEYXZpZCBIeWF0dCAgPGh5YXR0 QGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzAwNDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0ZvbnRDaHJvbWl1bVdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9Gb250Q2hyb21pdW1XaW4uY3BwCmluZGV4IDIzMzRjZTdjMjdkNzAy YmRiMjlmNmRlYzk5OWNjMGMwODVkYzk5MTQuLmJmNWZjMjM0YjcyNGVjYjBlZTg4ZGQwNzY5MmJl MDAwNjgzZjZlOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0ZvbnRDaHJvbWl1bVdpbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENocm9taXVtV2luLmNwcApAQCAtMzk1LDYgKzM5NSw3 IEBAIHZvaWQgRm9udDo6ZHJhd0dseXBocyhHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4 dCwKICAgICAgICAgcmV0dXJuOwogCiAgICAgSEZPTlQgaGZvbnQgPSBmb250LT5wbGF0Zm9ybURh dGEoKS5oZm9udCgpOworICAgIFBsYXRmb3JtU3VwcG9ydDo6ZW5zdXJlRm9udExvYWRlZChoZm9u dCk7CiAKICAgICAvLyBXZSBkcmF3IHRoZSBnbHlwaHMgaW4gY2h1bmtzIHRvIGF2b2lkIGhhdmlu ZyB0byBkbyBhIGhlYXAgYWxsb2NhdGlvbiBmb3IKICAgICAvLyB0aGUgYXJyYXlzIG9mIGNoYXJh Y3RlcnMgYW5kIGFkdmFuY2VzLgo=