69349 2011-10-04 10:36:22 -0700 garden-o-matic doesn't launch its UI on Lion 2011-10-05 12:25:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth darin dglazkov levin webkit.review.bot oldest_to_newest 477700 0 abarth 2011-10-04 10:36:22 -0700 garden-o-matic doesn't launch it's UI on Lion 477708 1 109643 abarth 2011-10-04 10:38:07 -0700 Created attachment 109643 Patch 477724 2 109643 darin 2011-10-04 10:46:39 -0700 Comment on attachment 109643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109643&action=review > Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:92 > + return 'file://' + os.path.join(GardeningHTTPRequestHandler.STATIC_FILE_DIRECTORY, 'garden-o-matic.html') Strictly speaking, prepending "file://" does not make a file URL. It would be better if there was a function that did the necessary escaping as well. 477727 3 abarth 2011-10-04 10:47:51 -0700 > Strictly speaking, prepending "file://" does not make a file URL. It would be better if there was a function that did the necessary escaping as well. Very true. I looked for one in the Python standard library, but I couldn't find one. I suppose I could write one. 477842 4 109643 webkit.review.bot 2011-10-04 12:23:15 -0700 Comment on attachment 109643 Patch Attachment 109643 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9954132 New failing tests: inspector/debugger/debugger-activation-crash2.html 478096 5 109643 abarth 2011-10-04 17:51:14 -0700 Comment on attachment 109643 Patch Clearing flags on attachment: 109643 Committed r96666: <http://trac.webkit.org/changeset/96666> 109643 2011-10-04 10:38:07 -0700 2011-10-04 17:51:14 -0700 Patch bug-69349-20111004103829.patch text/plain 1552 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk2NjA1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMTAtMDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBnYXJkZW4tby1tYXRpYyBkb2Vzbid0IGxhdW5jaCBpdCdzIFVJIG9uIExpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MzQ5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgdHVybnMgb3V0 IHRoYXQgTGlvbiBpcyBhIGJpdCBtb3JlIHBpY2t5IGFib3V0IGZpbGUgVVJMcy4gIFRoaXMgcGF0 Y2gKKyAgICAgICAgc3dpdGNoZXMgdXMgZnJvbSB1c2luZyBhIHBhdGggdG8gdXNpbmcgYW4gYWN0 dWFsIGZpbGUgVVJMLCBzaWxlbmNpbmcKKyAgICAgICAgdGhlIHdhcm5pbmcgYW5kIG1ha2luZyB0 aGUgdG9vbCBhY3R1YWxseSBsYXVuY2ggb24gTGlvbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlci5weToKKwogMjAxMS0xMC0wMyAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIGdhcmRlbi1vLW1hdGljIHNo b3VsZCByZW1vdmUgYnVpbGRlcnMgZnJvbSB0aGUgZmFpbHVyZSBncmlkIG9uY2UgdGhleSBzdGFy dCB0byBwYXNzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9nYXJk ZW5pbmdzZXJ2ZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVyLnB5CShyZXZpc2lvbiA5NjU5NikKKysrIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlci5weQkod29ya2luZyBj b3B5KQpAQCAtODksNyArODksNyBAQCBjbGFzcyBHYXJkZW5pbmdIVFRQU2VydmVyKEJhc2VIVFRQ U2VydmVyCiAgICAgICAgIEJhc2VIVFRQU2VydmVyLkhUVFBTZXJ2ZXIuX19pbml0X18oc2VsZiwg KHNlcnZlcl9uYW1lLCBodHRwZF9wb3J0KSwgR2FyZGVuaW5nSFRUUFJlcXVlc3RIYW5kbGVyKQog CiAgICAgZGVmIHVybChzZWxmKToKLSAgICAgICAgcmV0dXJuIG9zLnBhdGguam9pbihHYXJkZW5p bmdIVFRQUmVxdWVzdEhhbmRsZXIuU1RBVElDX0ZJTEVfRElSRUNUT1JZLCAnZ2FyZGVuLW8tbWF0 aWMuaHRtbCcpCisgICAgICAgIHJldHVybiAnZmlsZTovLycgKyBvcy5wYXRoLmpvaW4oR2FyZGVu aW5nSFRUUFJlcXVlc3RIYW5kbGVyLlNUQVRJQ19GSUxFX0RJUkVDVE9SWSwgJ2dhcmRlbi1vLW1h dGljLmh0bWwnKQogCiAKIGNsYXNzIEdhcmRlbmluZ0hUVFBSZXF1ZXN0SGFuZGxlcihSZWZsZWN0 aW9uSGFuZGxlcik6Cg==