69347 2011-10-04 10:31:17 -0700 Shrink HTMLTableCellElement. 2011-10-04 13:38:55 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling darin koivisto webkit.review.bot oldest_to_newest 477695 0 kling 2011-10-04 10:31:17 -0700 We don't need to cache the rowspan and colspan attributes on the element. 477696 1 109640 kling 2011-10-04 10:32:06 -0700 Created attachment 109640 Proposed patch 477703 2 koivisto 2011-10-04 10:37:05 -0700 r=me 477723 3 109640 darin 2011-10-04 10:45:41 -0700 Comment on attachment 109640 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=109640&action=review > Source/WebCore/ChangeLog:10 > + Don't cache the rowspan and colspan attributes on the element. > + This shrinks HTMLTabelCellElement by one CPU word, reducing memory > + consumption by 80 kB (on 64-bit) when loading the full HTML5 spec. What’s the performance impact? How often are these functions called? > Source/WebCore/html/HTMLTableCellElement.cpp:59 > + if (colSpanValue.isNull()) > + return 1; Null check seems unneeded, the next line gives 1 without a special case. > Source/WebCore/html/HTMLTableCellElement.cpp:67 > + if (rowSpanValue.isNull()) > + return 1; Null check seems unneeded, the next line gives 1 without a special case. 477728 4 kling 2011-10-04 10:48:18 -0700 (In reply to comment #3) > (From update of attachment 109640 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109640&action=review > > > Source/WebCore/ChangeLog:10 > > + Don't cache the rowspan and colspan attributes on the element. > > + This shrinks HTMLTabelCellElement by one CPU word, reducing memory > > + consumption by 80 kB (on 64-bit) when loading the full HTML5 spec. > > What’s the performance impact? How often are these functions called? Sorry, I responded to Antti on IRC about this. They are only called once from RenderTableCell::updateFromElement(). They are then cached on the renderer as well. > > Source/WebCore/html/HTMLTableCellElement.cpp:59 > > + if (colSpanValue.isNull()) > > + return 1; > > Null check seems unneeded, the next line gives 1 without a special case. You are right, thanks! I'll land without that. > > Source/WebCore/html/HTMLTableCellElement.cpp:67 > > + if (rowSpanValue.isNull()) > > + return 1; > > Null check seems unneeded, the next line gives 1 without a special case. Ditto. 477733 5 109646 kling 2011-10-04 10:50:33 -0700 Created attachment 109646 Patch for landing (r=anttik) 477886 6 109646 webkit.review.bot 2011-10-04 13:38:50 -0700 Comment on attachment 109646 Patch for landing (r=anttik) Clearing flags on attachment: 109646 Committed r96638: <http://trac.webkit.org/changeset/96638> 477887 7 webkit.review.bot 2011-10-04 13:38:55 -0700 All reviewed patches have been landed. Closing bug. 109640 2011-10-04 10:32:06 -0700 2011-10-04 10:50:33 -0700 Proposed patch bug-69347.diff text/plain 3558 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNzA3NmVlLi42MDYxOWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg QEAKIDIwMTEtMTAtMDQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFNocmluayBIVE1MVGFibGVDZWxsRWxlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgY2FjaGUgdGhlIHJvd3NwYW4gYW5kIGNvbHNw YW4gYXR0cmlidXRlcyBvbiB0aGUgZWxlbWVudC4KKyAgICAgICAgVGhpcyBzaHJpbmtzIEhUTUxU YWJlbENlbGxFbGVtZW50IGJ5IG9uZSBDUFUgd29yZCwgcmVkdWNpbmcgbWVtb3J5CisgICAgICAg IGNvbnN1bXB0aW9uIGJ5IDgwIGtCIChvbiA2NC1iaXQpIHdoZW4gbG9hZGluZyB0aGUgZnVsbCBI VE1MNSBzcGVjLgorCisgICAgICAgICogaHRtbC9IVE1MVGFibGVDZWxsRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MVGFibGVDZWxsRWxlbWVudDo6SFRNTFRhYmxlQ2VsbEVsZW1l bnQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRhYmxlQ2VsbEVsZW1lbnQ6OmNvbFNwYW4pOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTFRhYmxlQ2VsbEVsZW1lbnQ6OnJvd1NwYW4pOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTFRhYmxlQ2VsbEVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKToK KyAgICAgICAgKiBodG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50Lmg6CisKKzIwMTEtMTAtMDQgIEFu ZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCiAgICAgICAgIFNocmluayBTdHlsZVJh cmVOb25Jbmhlcml0ZWREYXRhLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjkzMzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M VGFibGVDZWxsRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZUNlbGxF bGVtZW50LmNwcAppbmRleCBjMWZiNWVlLi40YWU5NGRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50LmNwcApAQCAtNDQsOCArNDQsNiBAQCB1c2luZyBuYW1l c3BhY2UgSFRNTE5hbWVzOwogCiBpbmxpbmUgSFRNTFRhYmxlQ2VsbEVsZW1lbnQ6OkhUTUxUYWJs ZUNlbGxFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50KiBkb2N1 bWVudCkKICAgICA6IEhUTUxUYWJsZVBhcnRFbGVtZW50KHRhZ05hbWUsIGRvY3VtZW50KQotICAg ICwgbV9yb3dTcGFuKDEpCi0gICAgLCBtX2NvbFNwYW4oMSkKIHsKIH0KIApAQCAtNTQsNiArNTIs MjIgQEAgUGFzc1JlZlB0cjxIVE1MVGFibGVDZWxsRWxlbWVudD4gSFRNTFRhYmxlQ2VsbEVsZW1l bnQ6OmNyZWF0ZShjb25zdCBRdWFsaWZpZWROYW0KICAgICByZXR1cm4gYWRvcHRSZWYobmV3IEhU TUxUYWJsZUNlbGxFbGVtZW50KHRhZ05hbWUsIGRvY3VtZW50KSk7CiB9CiAKK2ludCBIVE1MVGFi bGVDZWxsRWxlbWVudDo6Y29sU3BhbigpIGNvbnN0Cit7CisgICAgY29uc3QgQXRvbWljU3RyaW5n JiBjb2xTcGFuVmFsdWUgPSBmYXN0R2V0QXR0cmlidXRlKGNvbHNwYW5BdHRyKTsKKyAgICBpZiAo Y29sU3BhblZhbHVlLmlzTnVsbCgpKQorICAgICAgICByZXR1cm4gMTsKKyAgICByZXR1cm4gbWF4 KDEsIGNvbFNwYW5WYWx1ZS50b0ludCgpKTsKK30KKworaW50IEhUTUxUYWJsZUNlbGxFbGVtZW50 Ojpyb3dTcGFuKCkgY29uc3QKK3sKKyAgICBjb25zdCBBdG9taWNTdHJpbmcmIHJvd1NwYW5WYWx1 ZSA9IGZhc3RHZXRBdHRyaWJ1dGUocm93c3BhbkF0dHIpOworICAgIGlmIChyb3dTcGFuVmFsdWUu aXNOdWxsKCkpCisgICAgICAgIHJldHVybiAxOworICAgIHJldHVybiBtYXgoMSwgbWluKHJvd1Nw YW5WYWx1ZS50b0ludCgpLCBtYXhSb3dzcGFuKSk7Cit9CisKIGludCBIVE1MVGFibGVDZWxsRWxl bWVudDo6Y2VsbEluZGV4KCkgY29uc3QKIHsKICAgICBpbnQgaW5kZXggPSAwOwpAQCAtODQsMTEg Kzk4LDkgQEAgYm9vbCBIVE1MVGFibGVDZWxsRWxlbWVudDo6bWFwVG9FbnRyeShjb25zdCBRdWFs aWZpZWROYW1lJiBhdHRyTmFtZSwgTWFwcGVkQXR0cmkKIHZvaWQgSFRNTFRhYmxlQ2VsbEVsZW1l bnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKEF0dHJpYnV0ZSogYXR0cikKIHsKICAgICBpZiAoYXR0 ci0+bmFtZSgpID09IHJvd3NwYW5BdHRyKSB7Ci0gICAgICAgIG1fcm93U3BhbiA9IG1heCgxLCBt aW4oYXR0ci0+dmFsdWUoKS50b0ludCgpLCBtYXhSb3dzcGFuKSk7CiAgICAgICAgIGlmIChyZW5k ZXJlcigpICYmIHJlbmRlcmVyKCktPmlzVGFibGVDZWxsKCkpCiAgICAgICAgICAgICB0b1JlbmRl clRhYmxlQ2VsbChyZW5kZXJlcigpKS0+dXBkYXRlRnJvbUVsZW1lbnQoKTsKICAgICB9IGVsc2Ug aWYgKGF0dHItPm5hbWUoKSA9PSBjb2xzcGFuQXR0cikgewotICAgICAgICBtX2NvbFNwYW4gPSBt YXgoMSwgYXR0ci0+dmFsdWUoKS50b0ludCgpKTsKICAgICAgICAgaWYgKHJlbmRlcmVyKCkgJiYg cmVuZGVyZXIoKS0+aXNUYWJsZUNlbGwoKSkKICAgICAgICAgICAgIHRvUmVuZGVyVGFibGVDZWxs KHJlbmRlcmVyKCkpLT51cGRhdGVGcm9tRWxlbWVudCgpOwogICAgIH0gZWxzZSBpZiAoYXR0ci0+ bmFtZSgpID09IG5vd3JhcEF0dHIpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFRhYmxlQ2VsbEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlQ2Vs bEVsZW1lbnQuaAppbmRleCA5YTY4NGYyLi44NTRkNjg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MVGFibGVDZWxsRWxlbWVudC5oCkBAIC0zNiw4ICszNiw4IEBAIHB1YmxpYzoKIAogICAg IGludCBjZWxsSW5kZXgoKSBjb25zdDsKIAotICAgIGludCBjb2xTcGFuKCkgY29uc3QgeyByZXR1 cm4gbV9jb2xTcGFuOyB9Ci0gICAgaW50IHJvd1NwYW4oKSBjb25zdCB7IHJldHVybiBtX3Jvd1Nw YW47IH0KKyAgICBpbnQgY29sU3BhbigpIGNvbnN0OworICAgIGludCByb3dTcGFuKCkgY29uc3Q7 CiAKICAgICB2b2lkIHNldENlbGxJbmRleChpbnQpOwogCkBAIC02Myw5ICs2Myw2IEBAIHByaXZh dGU6CiAgICAgdmlydHVhbCBib29sIGlzVVJMQXR0cmlidXRlKEF0dHJpYnV0ZSopIGNvbnN0Owog CiAgICAgdmlydHVhbCB2b2lkIGFkZFN1YnJlc291cmNlQXR0cmlidXRlVVJMcyhMaXN0SGFzaFNl dDxLVVJMPiYpIGNvbnN0OwotCi0gICAgaW50IG1fcm93U3BhbjsKLSAgICBpbnQgbV9jb2xTcGFu OwogfTsKIAogfSAvLyBuYW1lc3BhY2UK 109646 2011-10-04 10:50:33 -0700 2011-10-04 13:38:50 -0700 Patch for landing (r=anttik) bug-69347-landing.diff text/plain 3456 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNzA3NmVlLi5hMjkzMTYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg QEAKIDIwMTEtMTAtMDQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFNocmluayBIVE1MVGFibGVDZWxsRWxlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW50 dGkgS29pdmlzdG8uCisKKyAgICAgICAgRG9uJ3QgY2FjaGUgdGhlIHJvd3NwYW4gYW5kIGNvbHNw YW4gYXR0cmlidXRlcyBvbiB0aGUgZWxlbWVudC4KKyAgICAgICAgVGhpcyBzaHJpbmtzIEhUTUxU YWJsZUNlbGxFbGVtZW50IGJ5IG9uZSBDUFUgd29yZCwgcmVkdWNpbmcgbWVtb3J5CisgICAgICAg IGNvbnN1bXB0aW9uIGJ5IDgwIGtCIChvbiA2NC1iaXQpIHdoZW4gbG9hZGluZyB0aGUgZnVsbCBI VE1MNSBzcGVjLgorCisgICAgICAgICogaHRtbC9IVE1MVGFibGVDZWxsRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MVGFibGVDZWxsRWxlbWVudDo6SFRNTFRhYmxlQ2VsbEVsZW1l bnQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRhYmxlQ2VsbEVsZW1lbnQ6OmNvbFNwYW4pOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTFRhYmxlQ2VsbEVsZW1lbnQ6OnJvd1NwYW4pOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTFRhYmxlQ2VsbEVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKToK KyAgICAgICAgKiBodG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50Lmg6CisKKzIwMTEtMTAtMDQgIEFu ZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCiAgICAgICAgIFNocmluayBTdHlsZVJh cmVOb25Jbmhlcml0ZWREYXRhLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjkzMzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M VGFibGVDZWxsRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZUNlbGxF bGVtZW50LmNwcAppbmRleCBjMWZiNWVlLi4zN2ZlNWU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50LmNwcApAQCAtNDQsOCArNDQsNiBAQCB1c2luZyBuYW1l c3BhY2UgSFRNTE5hbWVzOwogCiBpbmxpbmUgSFRNTFRhYmxlQ2VsbEVsZW1lbnQ6OkhUTUxUYWJs ZUNlbGxFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50KiBkb2N1 bWVudCkKICAgICA6IEhUTUxUYWJsZVBhcnRFbGVtZW50KHRhZ05hbWUsIGRvY3VtZW50KQotICAg ICwgbV9yb3dTcGFuKDEpCi0gICAgLCBtX2NvbFNwYW4oMSkKIHsKIH0KIApAQCAtNTQsNiArNTIs MTggQEAgUGFzc1JlZlB0cjxIVE1MVGFibGVDZWxsRWxlbWVudD4gSFRNTFRhYmxlQ2VsbEVsZW1l bnQ6OmNyZWF0ZShjb25zdCBRdWFsaWZpZWROYW0KICAgICByZXR1cm4gYWRvcHRSZWYobmV3IEhU TUxUYWJsZUNlbGxFbGVtZW50KHRhZ05hbWUsIGRvY3VtZW50KSk7CiB9CiAKK2ludCBIVE1MVGFi bGVDZWxsRWxlbWVudDo6Y29sU3BhbigpIGNvbnN0Cit7CisgICAgY29uc3QgQXRvbWljU3RyaW5n JiBjb2xTcGFuVmFsdWUgPSBmYXN0R2V0QXR0cmlidXRlKGNvbHNwYW5BdHRyKTsKKyAgICByZXR1 cm4gbWF4KDEsIGNvbFNwYW5WYWx1ZS50b0ludCgpKTsKK30KKworaW50IEhUTUxUYWJsZUNlbGxF bGVtZW50Ojpyb3dTcGFuKCkgY29uc3QKK3sKKyAgICBjb25zdCBBdG9taWNTdHJpbmcmIHJvd1Nw YW5WYWx1ZSA9IGZhc3RHZXRBdHRyaWJ1dGUocm93c3BhbkF0dHIpOworICAgIHJldHVybiBtYXgo MSwgbWluKHJvd1NwYW5WYWx1ZS50b0ludCgpLCBtYXhSb3dzcGFuKSk7Cit9CisKIGludCBIVE1M VGFibGVDZWxsRWxlbWVudDo6Y2VsbEluZGV4KCkgY29uc3QKIHsKICAgICBpbnQgaW5kZXggPSAw OwpAQCAtODQsMTEgKzk0LDkgQEAgYm9vbCBIVE1MVGFibGVDZWxsRWxlbWVudDo6bWFwVG9FbnRy eShjb25zdCBRdWFsaWZpZWROYW1lJiBhdHRyTmFtZSwgTWFwcGVkQXR0cmkKIHZvaWQgSFRNTFRh YmxlQ2VsbEVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKEF0dHJpYnV0ZSogYXR0cikKIHsK ICAgICBpZiAoYXR0ci0+bmFtZSgpID09IHJvd3NwYW5BdHRyKSB7Ci0gICAgICAgIG1fcm93U3Bh biA9IG1heCgxLCBtaW4oYXR0ci0+dmFsdWUoKS50b0ludCgpLCBtYXhSb3dzcGFuKSk7CiAgICAg ICAgIGlmIChyZW5kZXJlcigpICYmIHJlbmRlcmVyKCktPmlzVGFibGVDZWxsKCkpCiAgICAgICAg ICAgICB0b1JlbmRlclRhYmxlQ2VsbChyZW5kZXJlcigpKS0+dXBkYXRlRnJvbUVsZW1lbnQoKTsK ICAgICB9IGVsc2UgaWYgKGF0dHItPm5hbWUoKSA9PSBjb2xzcGFuQXR0cikgewotICAgICAgICBt X2NvbFNwYW4gPSBtYXgoMSwgYXR0ci0+dmFsdWUoKS50b0ludCgpKTsKICAgICAgICAgaWYgKHJl bmRlcmVyKCkgJiYgcmVuZGVyZXIoKS0+aXNUYWJsZUNlbGwoKSkKICAgICAgICAgICAgIHRvUmVu ZGVyVGFibGVDZWxsKHJlbmRlcmVyKCkpLT51cGRhdGVGcm9tRWxlbWVudCgpOwogICAgIH0gZWxz ZSBpZiAoYXR0ci0+bmFtZSgpID09IG5vd3JhcEF0dHIpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTFRhYmxlQ2VsbEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFRhYmxlQ2VsbEVsZW1lbnQuaAppbmRleCA5YTY4NGYyLi44NTRkNjg0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50LmgKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MVGFibGVDZWxsRWxlbWVudC5oCkBAIC0zNiw4ICszNiw4IEBAIHB1 YmxpYzoKIAogICAgIGludCBjZWxsSW5kZXgoKSBjb25zdDsKIAotICAgIGludCBjb2xTcGFuKCkg Y29uc3QgeyByZXR1cm4gbV9jb2xTcGFuOyB9Ci0gICAgaW50IHJvd1NwYW4oKSBjb25zdCB7IHJl dHVybiBtX3Jvd1NwYW47IH0KKyAgICBpbnQgY29sU3BhbigpIGNvbnN0OworICAgIGludCByb3dT cGFuKCkgY29uc3Q7CiAKICAgICB2b2lkIHNldENlbGxJbmRleChpbnQpOwogCkBAIC02Myw5ICs2 Myw2IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIGlzVVJMQXR0cmlidXRlKEF0dHJpYnV0 ZSopIGNvbnN0OwogCiAgICAgdmlydHVhbCB2b2lkIGFkZFN1YnJlc291cmNlQXR0cmlidXRlVVJM cyhMaXN0SGFzaFNldDxLVVJMPiYpIGNvbnN0OwotCi0gICAgaW50IG1fcm93U3BhbjsKLSAgICBp bnQgbV9jb2xTcGFuOwogfTsKIAogfSAvLyBuYW1lc3BhY2UK