69338 2011-10-04 08:00:51 -0700 Fails to build when sqlite is not in /usr/include 2011-10-04 11:03:31 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 0 remi.duraffort webkit-unassigned gyuyoung.kim leandro lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 477600 0 109622 remi.duraffort 2011-10-04 08:00:51 -0700 Created attachment 109622 Fix compilation flags typos WebKit/EFL fails to build when SQLite3 is no installed in /usr/include. Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:32:21: error: sqlite3.h: No such file or directory Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:36: error: 'SQLITE_OK' was not declared in this scope Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:37: error: 'SQLITE_IGNORE' was not declared in this scope Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:38: error: 'SQLITE_DENY' was not declared in this scope 477603 1 webkit.review.bot 2011-10-04 08:03:21 -0700 Attachment 109622 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeListsEfl.txt', u'Sourc..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 477606 2 109622 leandro 2011-10-04 08:09:45 -0700 Comment on attachment 109622 Fix compilation flags typos View in context: https://bugs.webkit.org/attachment.cgi?id=109622&action=review Informal r-. > Source/WebCore/CMakeListsEfl.txt:243 > - ${ICU_INCLUDE_DIRS} > + ${ICU_INCLUDE_DIR} FindICU actually sets ICU_INCLUDE_DIRS. > Source/WebCore/CMakeListsEfl.txt:246 > - ${LIBXSLT_INCLUDE_DIRS} > - ${SQLITE_INCLUDE_DIRS} > + ${LIBXSLT_INCLUDE_DIR} > + ${SQLITE_INCLUDE_DIR} This looks fine; however, please mention xslt as well in the ChangeLog entry. > Source/WebCore/ChangeLog:1 > +2011-10-04 Rémi Duraffort <remi.duraffort@st.com> I'll assume this encoding error is Bugzilla's fault. 477607 3 leandro 2011-10-04 08:12:08 -0700 (In reply to comment #1) > Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Please add the URL to this bug as well to make the bots happy. (Also, since this is a build fix, it does not require formal review; you can say 'Unreviewed build fix', and I'll be able to commit it as soon as these small issues are ironed out.) 477613 4 109623 remi.duraffort 2011-10-04 08:18:12 -0700 Created attachment 109623 Fix compilation flags typos Second patch, taking reviews into account. 477650 5 109623 leandro 2011-10-04 09:39:09 -0700 Comment on attachment 109623 Fix compilation flags typos Thanks. 477754 6 109623 webkit.review.bot 2011-10-04 11:03:26 -0700 Comment on attachment 109623 Fix compilation flags typos Clearing flags on attachment: 109623 Committed r96612: <http://trac.webkit.org/changeset/96612> 477755 7 webkit.review.bot 2011-10-04 11:03:31 -0700 All reviewed patches have been landed. Closing bug. 109622 2011-10-04 08:00:51 -0700 2011-10-04 08:18:12 -0700 Fix compilation flags typos 0001-Efl-fix-compilation-flags-typos.patch text/plain 1981 remi.duraffort ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHNFZmwudHh0IGIvU291cmNlL1dl YkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKaW5kZXggMGYwMTc5NS4uNGFhNWE2NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKKysrIGIvU291cmNlL1dlYkNvcmUv Q01ha2VMaXN0c0VmbC50eHQKQEAgLTI0MCwxMCArMjQwLDEwIEBAIExJU1QoQVBQRU5EIFdlYkNv cmVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAke0VGTERFUFNfSU5DTFVERV9ESVJTfQogICAke0VW QVNfSU5DTFVERV9ESVJTfQogICAke0ZSRUVUWVBFX0lOQ0xVREVfRElSU30KLSAgJHtJQ1VfSU5D TFVERV9ESVJTfQorICAke0lDVV9JTkNMVURFX0RJUn0KICAgJHtMSUJYTUwyX0lOQ0xVREVfRElS fQotICAke0xJQlhTTFRfSU5DTFVERV9ESVJTfQotICAke1NRTElURV9JTkNMVURFX0RJUlN9Cisg ICR7TElCWFNMVF9JTkNMVURFX0RJUn0KKyAgJHtTUUxJVEVfSU5DTFVERV9ESVJ9CiApCiAKIElG IChFTkFCTEVfVklERU8pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVjMmVlZC4uMjYwYWRlZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDExIEBACisyMDExLTEwLTA0ICBSw6ltaSBEdXJhZmZvcnQgIDxyZW1pLmR1 cmFmZm9ydEBzdC5jb20+CisKKyAgICAgICAgW0VGTF0gRml4IGNvbXBpbGF0aW9uIHdoZW4gU1FM aXRlIGlzIG5vdCBpbnN0YWxsZWQgaW4gL3Vzci9pbmNsdWRlCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzRWZsLnR4dDoKKwogMjAx MS0xMC0wMyAgUsOpbWkgRHVyYWZmb3J0ICA8cmVtaS5kdXJhZmZvcnRAc3QuY29tPgogCiAgICAg ICAgIFBvcnQgVjggdG8gV2ViS2l0LUdUSwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwv Q01ha2VMaXN0c0VmbC50eHQgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DTWFrZUxpc3RzRWZsLnR4dApp bmRleCBmOWRiMzVjLi4wZjc0YWZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DTWFr ZUxpc3RzRWZsLnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DTWFrZUxpc3RzRWZsLnR4dApA QCAtMTgsOCArMTgsOCBAQCBMSVNUKEFQUEVORCBXZWJLaXRfSU5DTFVERV9ESVJFQ1RPUklFUwog ICAgICR7RUZMREVQU19JTkNMVURFX0RJUlN9CiAgICAgJHtFVkFTX0lOQ0xVREVfRElSU30KICAg ICAke0xJQlhNTDJfSU5DTFVERV9ESVJ9Ci0gICAgJHtMSUJYU0xUX0lOQ0xVREVfRElSU30KLSAg ICAke1NRTElURV9JTkNMVURFX0RJUlN9CisgICAgJHtMSUJYU0xUX0lOQ0xVREVfRElSfQorICAg ICR7U1FMSVRFX0lOQ0xVREVfRElSfQogKQogCiBJRiAoRU5BQkxFX1ZJREVPKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdl TG9nCmluZGV4IGIzNDI2MzIuLjc0OTU4ZmUgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MSBAQAorMjAxMS0xMC0wNCAgUsOpbWkgRHVyYWZmb3J0ICA8cmVtaS5kdXJhZmZvcnRAc3QuY29t PgorCisgICAgICAgIFtFRkxdIEZpeCBjb21waWxhdGlvbiB3aGVuIFNRTGl0ZSBpcyBub3QgaW5z dGFsbGVkIGluIC91c3IvaW5jbHVkZQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQ01ha2VMaXN0c0VmbC50eHQ6CisKIDIwMTEtMDktMjkgIEd5dXlv dW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBVc2Ug QysrIHR5cGUgY2FzdCBpbnN0ZWFkIG9mIEMgc3R5bGUgdHlwZSBjYXN0Cg== 109623 2011-10-04 08:18:12 -0700 2011-10-04 11:03:26 -0700 Fix compilation flags typos 0001-Efl-fix-compilation-flags-typos.patch text/plain 2034 remi.duraffort ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHNFZmwudHh0IGIvU291cmNlL1dl YkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKaW5kZXggMGYwMTc5NS4uN2UxOTA3NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKKysrIGIvU291cmNlL1dlYkNvcmUv Q01ha2VMaXN0c0VmbC50eHQKQEAgLTI0Miw4ICsyNDIsOCBAQCBMSVNUKEFQUEVORCBXZWJDb3Jl X0lOQ0xVREVfRElSRUNUT1JJRVMKICAgJHtGUkVFVFlQRV9JTkNMVURFX0RJUlN9CiAgICR7SUNV X0lOQ0xVREVfRElSU30KICAgJHtMSUJYTUwyX0lOQ0xVREVfRElSfQotICAke0xJQlhTTFRfSU5D TFVERV9ESVJTfQotICAke1NRTElURV9JTkNMVURFX0RJUlN9CisgICR7TElCWFNMVF9JTkNMVURF X0RJUn0KKyAgJHtTUUxJVEVfSU5DTFVERV9ESVJ9CiApCiAKIElGIChFTkFCTEVfVklERU8pCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggOWVjMmVlZC4uMGQ0NTYxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBA CisyMDExLTEwLTA0ICBSw6ltaSBEdXJhZmZvcnQgIDxyZW1pLmR1cmFmZm9ydEBzdC5jb20+CisK KyAgICAgICAgW0VGTF0gRml4IGNvbXBpbGF0aW9uIHdoZW4gU1FMaXRlIGFuZC9vciBsaWJ4c2x0 IGFyZSBub3QgaW5zdGFsbGVkIGluIC91c3IvaW5jbHVkZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkzMzgKKworICAgICAgICBVbnJldmlld2VkIGJ1 aWxkIGZpeAorCisgICAgICAgICogQ01ha2VMaXN0c0VmbC50eHQ6CisKIDIwMTEtMTAtMDMgIFLD qW1pIER1cmFmZm9ydCAgPHJlbWkuZHVyYWZmb3J0QHN0LmNvbT4KIAogICAgICAgICBQb3J0IFY4 IHRvIFdlYktpdC1HVEsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NNYWtlTGlzdHNF ZmwudHh0IGIvU291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0c0VmbC50eHQKaW5kZXggZjlkYjM1 Yy4uMGY3NGFmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0c0VmbC50 eHQKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0c0VmbC50eHQKQEAgLTE4LDggKzE4 LDggQEAgTElTVChBUFBFTkQgV2ViS2l0X0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAke0VGTERF UFNfSU5DTFVERV9ESVJTfQogICAgICR7RVZBU19JTkNMVURFX0RJUlN9CiAgICAgJHtMSUJYTUwy X0lOQ0xVREVfRElSfQotICAgICR7TElCWFNMVF9JTkNMVURFX0RJUlN9Ci0gICAgJHtTUUxJVEVf SU5DTFVERV9ESVJTfQorICAgICR7TElCWFNMVF9JTkNMVURFX0RJUn0KKyAgICAke1NRTElURV9J TkNMVURFX0RJUn0KICkKIAogSUYgKEVOQUJMRV9WSURFTykKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBi MzQyNjMyLi44ZDFkMTAyIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEt MTAtMDQgIFLDqW1pIER1cmFmZm9ydCAgPHJlbWkuZHVyYWZmb3J0QHN0LmNvbT4KKworICAgICAg ICBbRUZMXSBGaXggY29tcGlsYXRpb24gd2hlbiBTUUxpdGUgYW5kL29yIGxpYnhzbHQgYXJlIG5v dCBpbnN0YWxsZWQgaW4gL3Vzci9pbmNsdWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02OTMzOAorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4 CisKKyAgICAgICAgKiBDTWFrZUxpc3RzRWZsLnR4dDoKKwogMjAxMS0wOS0yOSAgR3l1eW91bmcg S2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIFVzZSBDKysg dHlwZSBjYXN0IGluc3RlYWQgb2YgQyBzdHlsZSB0eXBlIGNhc3QK