69331 2011-10-04 04:22:44 -0700 Shrink StyleRareNonInheritedData. 2011-10-05 04:18:49 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling aroben darin dglazkov koivisto vangelis webkit.review.bot oldest_to_newest 477533 0 kling 2011-10-04 04:22:44 -0700 We can shrink StyleRareNonInheritedData by two CPU words if we rearrange its members. This would cut memory usage by 140 kB (on 64-bit) when loading the full HTML5 spec. 477541 1 109606 kling 2011-10-04 04:37:36 -0700 Created attachment 109606 Proposed patch 477542 2 109606 webkit-ews 2011-10-04 04:47:44 -0700 Comment on attachment 109606 Proposed patch Attachment 109606 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9944281 477567 3 109606 koivisto 2011-10-04 06:12:00 -0700 Comment on attachment 109606 Proposed patch r=me if you fix whatever Qt bot is whining about. 477569 4 109606 webkit.review.bot 2011-10-04 06:20:50 -0700 Comment on attachment 109606 Proposed patch Attachment 109606 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9936528 New failing tests: plugins/fullscreen-plugins-dont-reload.html 477583 5 109606 kling 2011-10-04 07:15:09 -0700 Comment on attachment 109606 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=109606&action=review > Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:69 > + printf("sizeof(StyleRareNonInheritedData) = %lu\n", sizeof(StyleRareNonInheritedData)); Looks like I pulled an Antti here. :) 477584 6 109619 kling 2011-10-04 07:16:43 -0700 Created attachment 109619 Patch for landing (r=anttik) 477608 7 109619 webkit.review.bot 2011-10-04 08:12:52 -0700 Comment on attachment 109619 Patch for landing (r=anttik) Clearing flags on attachment: 109619 Committed r96594: <http://trac.webkit.org/changeset/96594> 477609 8 webkit.review.bot 2011-10-04 08:12:56 -0700 All reviewed patches have been landed. Closing bug. 477694 9 109606 darin 2011-10-04 10:30:30 -0700 Comment on attachment 109606 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=109606&action=review > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:132 > + RegionOverflow m_regionOverflow : 1; Won’t we run into signed/unsigned problems with this with the Windows compiler? > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:140 > + PageSizeType m_pageSizeType : 2; > + ETransformStyle3D m_transformStyle3D : 1; > + EBackfaceVisibility m_backfaceVisibility : 1; Won’t we run into signed/unsigned problems with these with the Windows compiler? 477713 10 kling 2011-10-04 10:39:50 -0700 (In reply to comment #9) > (From update of attachment 109606 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109606&action=review > > > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:132 > > + RegionOverflow m_regionOverflow : 1; > > Won’t we run into signed/unsigned problems with this with the Windows compiler? > > > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:140 > > + PageSizeType m_pageSizeType : 2; > > + ETransformStyle3D m_transformStyle3D : 1; > > + EBackfaceVisibility m_backfaceVisibility : 1; > > Won’t we run into signed/unsigned problems with these with the Windows compiler? Will we? I was not aware of this issue. CC'ing Adam who might know more. 477715 11 koivisto 2011-10-04 10:41:18 -0700 (In reply to comment #9) > Won’t we run into signed/unsigned problems with these with the Windows compiler? Oh is that the reason why we have so many enum fields specified as "unsigned"? I didn't know. 477720 12 darin 2011-10-04 10:44:02 -0700 (In reply to comment #11) > (In reply to comment #9) > > Won’t we run into signed/unsigned problems with these with the Windows compiler? > > Oh is that the reason why we have so many enum fields specified as "unsigned"? Yes. 477725 13 aroben 2011-10-04 10:47:00 -0700 http://trac.webkit.org/changeset/25329 has a little more info. 477737 14 109648 kling 2011-10-04 10:54:14 -0700 Created attachment 109648 Follow-up patch to make enum bitfields explicitly unsigned. Here we go. Thanks a bunch for pointing this out! 478167 15 vangelis 2011-10-04 22:41:10 -0700 (In reply to comment #10) > (In reply to comment #9) > > (From update of attachment 109606 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=109606&action=review > > > > > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:132 > > > + RegionOverflow m_regionOverflow : 1; > > > > Won’t we run into signed/unsigned problems with this with the Windows compiler? > > > > > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:140 > > > + PageSizeType m_pageSizeType : 2; > > > + ETransformStyle3D m_transformStyle3D : 1; > > > + EBackfaceVisibility m_backfaceVisibility : 1; > > > > Won’t we run into signed/unsigned problems with these with the Windows compiler? > > Will we? I was not aware of this issue. CC'ing Adam who might know more. Definitely an issue with the windows compiler. It did break Chrome on windows where the preserves3d property stopped working due to a (-1 != 1 comparison). Thanks for checking in a fix. 478268 16 kling 2011-10-05 04:18:49 -0700 Committed r96691: <http://trac.webkit.org/changeset/96691> 109606 2011-10-04 04:37:36 -0700 2011-10-04 10:30:30 -0700 Proposed patch bug-69331.diff text/plain 9380 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxYjE0MDk2Li42OWE0ZTBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMTAtMDQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFNocmluayBTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkzMzEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWFycmFuZ2UgdGhlIG1lbWJlcnMgYW5kIG1v dmUgYWxsIHNtYWxsIHR5cGVzIGludG8gdGhlIGJpdGZpZWxkLgorICAgICAgICBUaGlzIHNocmlu a3MgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSBieSB0d28gQ1BVIHdvcmRzLCByZWR1Y2luZyBt ZW1vcnkKKyAgICAgICAgY29uc3VtcHRpb24gYnkgMTQwIGtCIChvbiA2NC1iaXQpIHdoZW4gbG9h ZGluZyB0aGUgZnVsbCBIVE1MNSBzcGVjLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1N0 eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVSYXJl Tm9uSW5oZXJpdGVkRGF0YTo6U3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSk6CisgICAgICAgICog cmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuaDoKKwogMjAxMS0xMC0w MyAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRm9udEZhbGxi YWNrTGlzdDogR2x5cGggcGFnZXMgd2FzdGUgYSBsb3Qgb2YgbWVtb3J5LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRl ZERhdGEuY3BwCmluZGV4IDdiYzY2ODEuLjNjMzQyNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5j cHAKQEAgLTM2LDM2ICszNiwzNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBTdHlsZVJhcmVOb25J bmhlcml0ZWREYXRhOjpTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhKCkKICAgICA6IGxpbmVDbGFt cChSZW5kZXJTdHlsZTo6aW5pdGlhbExpbmVDbGFtcCgpKQogICAgICwgb3BhY2l0eShSZW5kZXJT dHlsZTo6aW5pdGlhbE9wYWNpdHkoKSkKLSAgICAsIHVzZXJEcmFnKFJlbmRlclN0eWxlOjppbml0 aWFsVXNlckRyYWcoKSkKLSAgICAsIHRleHRPdmVyZmxvdyhSZW5kZXJTdHlsZTo6aW5pdGlhbFRl eHRPdmVyZmxvdygpKQotICAgICwgbWFyZ2luQmVmb3JlQ29sbGFwc2UoTUNPTExBUFNFKQotICAg ICwgbWFyZ2luQWZ0ZXJDb2xsYXBzZShNQ09MTEFQU0UpCi0gICAgLCBtYXRjaE5lYXJlc3RNYWls QmxvY2txdW90ZUNvbG9yKFJlbmRlclN0eWxlOjppbml0aWFsTWF0Y2hOZWFyZXN0TWFpbEJsb2Nr cXVvdGVDb2xvcigpKQotICAgICwgbV9hcHBlYXJhbmNlKFJlbmRlclN0eWxlOjppbml0aWFsQXBw ZWFyYW5jZSgpKQotICAgICwgbV9ib3JkZXJGaXQoUmVuZGVyU3R5bGU6OmluaXRpYWxCb3JkZXJG aXQoKSkKLSAgICAsIG1fdGV4dENvbWJpbmUoUmVuZGVyU3R5bGU6OmluaXRpYWxUZXh0Q29tYmlu ZSgpKQotICAgICwgbV9jb3VudGVySW5jcmVtZW50KDApCi0gICAgLCBtX2NvdW50ZXJSZXNldCgw KQotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICAsIG1fcnVubmluZ0FjY2Vs ZXJhdGVkQW5pbWF0aW9uKGZhbHNlKQotI2VuZGlmCiAgICAgLCBtX21hc2soRmlsbExheWVyKE1h c2tGaWxsTGF5ZXIpKQotICAgICwgbV90cmFuc2Zvcm1TdHlsZTNEKFJlbmRlclN0eWxlOjppbml0 aWFsVHJhbnNmb3JtU3R5bGUzRCgpKQotICAgICwgbV9iYWNrZmFjZVZpc2liaWxpdHkoUmVuZGVy U3R5bGU6OmluaXRpYWxCYWNrZmFjZVZpc2liaWxpdHkoKSkKICAgICAsIG1fcGVyc3BlY3RpdmUo UmVuZGVyU3R5bGU6OmluaXRpYWxQZXJzcGVjdGl2ZSgpKQogICAgICwgbV9wZXJzcGVjdGl2ZU9y aWdpblgoUmVuZGVyU3R5bGU6OmluaXRpYWxQZXJzcGVjdGl2ZU9yaWdpblgoKSkKICAgICAsIG1f cGVyc3BlY3RpdmVPcmlnaW5ZKFJlbmRlclN0eWxlOjppbml0aWFsUGVyc3BlY3RpdmVPcmlnaW5Z KCkpCiAgICAgLCBtX3BhZ2VTaXplKCkKLSAgICAsIG1fcGFnZVNpemVUeXBlKFBBR0VfU0laRV9B VVRPKQorICAgICwgbV93cmFwU2hhcGUoUmVuZGVyU3R5bGU6OmluaXRpYWxXcmFwU2hhcGUoKSkK ICAgICAsIG1fZmxvd1RocmVhZChSZW5kZXJTdHlsZTo6aW5pdGlhbEZsb3dUaHJlYWQoKSkKICAg ICAsIG1fcmVnaW9uVGhyZWFkKFJlbmRlclN0eWxlOjppbml0aWFsUmVnaW9uVGhyZWFkKCkpCiAg ICAgLCBtX3JlZ2lvbkluZGV4KFJlbmRlclN0eWxlOjppbml0aWFsUmVnaW9uSW5kZXgoKSkKICAg ICAsIG1fcmVnaW9uT3ZlcmZsb3coUmVuZGVyU3R5bGU6OmluaXRpYWxSZWdpb25PdmVyZmxvdygp KQotICAgICwgbV93cmFwU2hhcGUoUmVuZGVyU3R5bGU6OmluaXRpYWxXcmFwU2hhcGUoKSkKICAg ICAsIG1fcmVnaW9uQnJlYWtBZnRlcihSZW5kZXJTdHlsZTo6aW5pdGlhbFBhZ2VCcmVhaygpKQog ICAgICwgbV9yZWdpb25CcmVha0JlZm9yZShSZW5kZXJTdHlsZTo6aW5pdGlhbFBhZ2VCcmVhaygp KQogICAgICwgbV9yZWdpb25CcmVha0luc2lkZShSZW5kZXJTdHlsZTo6aW5pdGlhbFBhZ2VCcmVh aygpKQorICAgICwgbV9wYWdlU2l6ZVR5cGUoUEFHRV9TSVpFX0FVVE8pCisgICAgLCBtX3RyYW5z Zm9ybVN0eWxlM0QoUmVuZGVyU3R5bGU6OmluaXRpYWxUcmFuc2Zvcm1TdHlsZTNEKCkpCisgICAg LCBtX2JhY2tmYWNlVmlzaWJpbGl0eShSZW5kZXJTdHlsZTo6aW5pdGlhbEJhY2tmYWNlVmlzaWJp bGl0eSgpKQorICAgICwgdXNlckRyYWcoUmVuZGVyU3R5bGU6OmluaXRpYWxVc2VyRHJhZygpKQor ICAgICwgdGV4dE92ZXJmbG93KFJlbmRlclN0eWxlOjppbml0aWFsVGV4dE92ZXJmbG93KCkpCisg ICAgLCBtYXJnaW5CZWZvcmVDb2xsYXBzZShNQ09MTEFQU0UpCisgICAgLCBtYXJnaW5BZnRlckNv bGxhcHNlKE1DT0xMQVBTRSkKKyAgICAsIG1hdGNoTmVhcmVzdE1haWxCbG9ja3F1b3RlQ29sb3Io UmVuZGVyU3R5bGU6OmluaXRpYWxNYXRjaE5lYXJlc3RNYWlsQmxvY2txdW90ZUNvbG9yKCkpCisg ICAgLCBtX2FwcGVhcmFuY2UoUmVuZGVyU3R5bGU6OmluaXRpYWxBcHBlYXJhbmNlKCkpCisgICAg LCBtX2JvcmRlckZpdChSZW5kZXJTdHlsZTo6aW5pdGlhbEJvcmRlckZpdCgpKQorICAgICwgbV90 ZXh0Q29tYmluZShSZW5kZXJTdHlsZTo6aW5pdGlhbFRleHRDb21iaW5lKCkpCisjaWYgVVNFKEFD Q0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgICwgbV9ydW5uaW5nQWNjZWxlcmF0ZWRBbmltYXRp b24oZmFsc2UpCisjZW5kaWYKKyAgICAsIG1fY291bnRlckluY3JlbWVudCgwKQorICAgICwgbV9j b3VudGVyUmVzZXQoMCkKIHsKKyAgICBwcmludGYoInNpemVvZihTdHlsZVJhcmVOb25Jbmhlcml0 ZWREYXRhKSA9ICVsdVxuIiwgc2l6ZW9mKFN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEpKTsKICAg ICBtX21hc2tCb3hJbWFnZS5zZXRNYXNrRGVmYXVsdHMoKTsKIH0KIApAQCAtODUsNDAgKzg2LDQw IEBAIFN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGE6OlN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEo Y29uc3QgU3R5bGVSYXJlTm9uSW5oZXJpdGVkCiAjZW5kaWYKICAgICAsIG1fY29udGVudChvLm1f Y29udGVudCA/IG8ubV9jb250ZW50LT5jbG9uZSgpIDogbnVsbHB0cikKICAgICAsIG1fY291bnRl ckRpcmVjdGl2ZXMoby5tX2NvdW50ZXJEaXJlY3RpdmVzID8gY2xvbmUoKm8ubV9jb3VudGVyRGly ZWN0aXZlcykgOiBudWxscHRyKQotICAgICwgdXNlckRyYWcoby51c2VyRHJhZykKLSAgICAsIHRl eHRPdmVyZmxvdyhvLnRleHRPdmVyZmxvdykKLSAgICAsIG1hcmdpbkJlZm9yZUNvbGxhcHNlKG8u bWFyZ2luQmVmb3JlQ29sbGFwc2UpCi0gICAgLCBtYXJnaW5BZnRlckNvbGxhcHNlKG8ubWFyZ2lu QWZ0ZXJDb2xsYXBzZSkKLSAgICAsIG1hdGNoTmVhcmVzdE1haWxCbG9ja3F1b3RlQ29sb3Ioby5t YXRjaE5lYXJlc3RNYWlsQmxvY2txdW90ZUNvbG9yKQotICAgICwgbV9hcHBlYXJhbmNlKG8ubV9h cHBlYXJhbmNlKQotICAgICwgbV9ib3JkZXJGaXQoby5tX2JvcmRlckZpdCkKLSAgICAsIG1fdGV4 dENvbWJpbmUoby5tX3RleHRDb21iaW5lKQotICAgICwgbV9jb3VudGVySW5jcmVtZW50KG8ubV9j b3VudGVySW5jcmVtZW50KQotICAgICwgbV9jb3VudGVyUmVzZXQoby5tX2NvdW50ZXJSZXNldCkK LSNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCi0gICAgLCBtX3J1bm5pbmdBY2NlbGVy YXRlZEFuaW1hdGlvbihvLm1fcnVubmluZ0FjY2VsZXJhdGVkQW5pbWF0aW9uKQotI2VuZGlmCiAg ICAgLCBtX2JveFNoYWRvdyhvLm1fYm94U2hhZG93ID8gYWRvcHRQdHIobmV3IFNoYWRvd0RhdGEo Km8ubV9ib3hTaGFkb3cpKSA6IG51bGxwdHIpCiAgICAgLCBtX2JveFJlZmxlY3Qoby5tX2JveFJl ZmxlY3QpCiAgICAgLCBtX2FuaW1hdGlvbnMoby5tX2FuaW1hdGlvbnMgPyBhZG9wdFB0cihuZXcg QW5pbWF0aW9uTGlzdCgqby5tX2FuaW1hdGlvbnMpKSA6IG51bGxwdHIpCiAgICAgLCBtX3RyYW5z aXRpb25zKG8ubV90cmFuc2l0aW9ucyA/IGFkb3B0UHRyKG5ldyBBbmltYXRpb25MaXN0KCpvLm1f dHJhbnNpdGlvbnMpKSA6IG51bGxwdHIpCiAgICAgLCBtX21hc2soby5tX21hc2spCiAgICAgLCBt X21hc2tCb3hJbWFnZShvLm1fbWFza0JveEltYWdlKQotICAgICwgbV90cmFuc2Zvcm1TdHlsZTNE KG8ubV90cmFuc2Zvcm1TdHlsZTNEKQotICAgICwgbV9iYWNrZmFjZVZpc2liaWxpdHkoby5tX2Jh Y2tmYWNlVmlzaWJpbGl0eSkKICAgICAsIG1fcGVyc3BlY3RpdmUoby5tX3BlcnNwZWN0aXZlKQog ICAgICwgbV9wZXJzcGVjdGl2ZU9yaWdpblgoby5tX3BlcnNwZWN0aXZlT3JpZ2luWCkKICAgICAs IG1fcGVyc3BlY3RpdmVPcmlnaW5ZKG8ubV9wZXJzcGVjdGl2ZU9yaWdpblkpCiAgICAgLCBtX3Bh Z2VTaXplKG8ubV9wYWdlU2l6ZSkKLSAgICAsIG1fcGFnZVNpemVUeXBlKG8ubV9wYWdlU2l6ZVR5 cGUpCisgICAgLCBtX3dyYXBTaGFwZShvLm1fd3JhcFNoYXBlKQogICAgICwgbV9mbG93VGhyZWFk KG8ubV9mbG93VGhyZWFkKQogICAgICwgbV9yZWdpb25UaHJlYWQoby5tX3JlZ2lvblRocmVhZCkK ICAgICAsIG1fcmVnaW9uSW5kZXgoby5tX3JlZ2lvbkluZGV4KQogICAgICwgbV9yZWdpb25PdmVy ZmxvdyhvLm1fcmVnaW9uT3ZlcmZsb3cpCi0gICAgLCBtX3dyYXBTaGFwZShvLm1fd3JhcFNoYXBl KQogICAgICwgbV9yZWdpb25CcmVha0FmdGVyKG8ubV9yZWdpb25CcmVha0FmdGVyKQogICAgICwg bV9yZWdpb25CcmVha0JlZm9yZShvLm1fcmVnaW9uQnJlYWtCZWZvcmUpCiAgICAgLCBtX3JlZ2lv bkJyZWFrSW5zaWRlKG8ubV9yZWdpb25CcmVha0luc2lkZSkKKyAgICAsIG1fcGFnZVNpemVUeXBl KG8ubV9wYWdlU2l6ZVR5cGUpCisgICAgLCBtX3RyYW5zZm9ybVN0eWxlM0Qoby5tX3RyYW5zZm9y bVN0eWxlM0QpCisgICAgLCBtX2JhY2tmYWNlVmlzaWJpbGl0eShvLm1fYmFja2ZhY2VWaXNpYmls aXR5KQorICAgICwgdXNlckRyYWcoby51c2VyRHJhZykKKyAgICAsIHRleHRPdmVyZmxvdyhvLnRl eHRPdmVyZmxvdykKKyAgICAsIG1hcmdpbkJlZm9yZUNvbGxhcHNlKG8ubWFyZ2luQmVmb3JlQ29s bGFwc2UpCisgICAgLCBtYXJnaW5BZnRlckNvbGxhcHNlKG8ubWFyZ2luQWZ0ZXJDb2xsYXBzZSkK KyAgICAsIG1hdGNoTmVhcmVzdE1haWxCbG9ja3F1b3RlQ29sb3Ioby5tYXRjaE5lYXJlc3RNYWls QmxvY2txdW90ZUNvbG9yKQorICAgICwgbV9hcHBlYXJhbmNlKG8ubV9hcHBlYXJhbmNlKQorICAg ICwgbV9ib3JkZXJGaXQoby5tX2JvcmRlckZpdCkKKyAgICAsIG1fdGV4dENvbWJpbmUoby5tX3Rl eHRDb21iaW5lKQorI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKyAgICAsIG1fcnVu bmluZ0FjY2VsZXJhdGVkQW5pbWF0aW9uKG8ubV9ydW5uaW5nQWNjZWxlcmF0ZWRBbmltYXRpb24p CisjZW5kaWYKKyAgICAsIG1fY291bnRlckluY3JlbWVudChvLm1fY291bnRlckluY3JlbWVudCkK KyAgICAsIG1fY291bnRlclJlc2V0KG8ubV9jb3VudGVyUmVzZXQpCiB7CiB9CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWRE YXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJp dGVkRGF0YS5oCmluZGV4IGQ5MzhlMGQuLjY3NTZhNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuaApA QCAtMTA4LDIxICsxMDgsNiBAQCBwdWJsaWM6CiAgICAgT3duUHRyPENvbnRlbnREYXRhPiBtX2Nv bnRlbnQ7CiAgICAgT3duUHRyPENvdW50ZXJEaXJlY3RpdmVNYXA+IG1fY291bnRlckRpcmVjdGl2 ZXM7CiAKLSAgICB1bnNpZ25lZCB1c2VyRHJhZyA6IDI7IC8vIEVVc2VyRHJhZwotICAgIHVuc2ln bmVkIHRleHRPdmVyZmxvdyA6IDE7IC8vIFdoZXRoZXIgb3Igbm90IGxpbmVzIHRoYXQgc3BpbGwg b3V0IHNob3VsZCBiZSB0cnVuY2F0ZWQgd2l0aCAiLi4uIgotICAgIHVuc2lnbmVkIG1hcmdpbkJl Zm9yZUNvbGxhcHNlIDogMjsgLy8gRU1hcmdpbkNvbGxhcHNlCi0gICAgdW5zaWduZWQgbWFyZ2lu QWZ0ZXJDb2xsYXBzZSA6IDI7IC8vIEVNYXJnaW5Db2xsYXBzZQotICAgIHVuc2lnbmVkIG1hdGNo TmVhcmVzdE1haWxCbG9ja3F1b3RlQ29sb3IgOiAxOyAvLyBFTWF0Y2hOZWFyZXN0TWFpbEJsb2Nr cXVvdGVDb2xvciwgRklYTUU6IFRoaXMgcHJvcGVydHkgbmVlZHMgdG8gYmUgZWxpbWluYXRlZC4g SXQgc2hvdWxkIG5ldmVyIGhhdmUgYmVlbiBhZGRlZC4KLSAgICB1bnNpZ25lZCBtX2FwcGVhcmFu Y2UgOiA2OyAvLyBFQXBwZWFyYW5jZQotICAgIHVuc2lnbmVkIG1fYm9yZGVyRml0IDogMTsgLy8g RUJvcmRlckZpdAotICAgIHVuc2lnbmVkIG1fdGV4dENvbWJpbmUgOiAxOyAvLyBDU1MzIHRleHQt Y29tYmluZSBwcm9wZXJ0aWVzCi0gICAgCi0gICAgc2hvcnQgbV9jb3VudGVySW5jcmVtZW50Owot ICAgIHNob3J0IG1fY291bnRlclJlc2V0OwotCi0jaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lU SU5HKQotICAgIGJvb2wgbV9ydW5uaW5nQWNjZWxlcmF0ZWRBbmltYXRpb24gOiAxOwotI2VuZGlm CiAgICAgT3duUHRyPFNoYWRvd0RhdGE+IG1fYm94U2hhZG93OyAgLy8gRm9yIGJveC1zaGFkb3cg ZGVjb3JhdGlvbnMuCiAgICAgCiAgICAgUmVmUHRyPFN0eWxlUmVmbGVjdGlvbj4gbV9ib3hSZWZs ZWN0OwpAQCAtMTMzLDI2ICsxMTgsNDMgQEAgcHVibGljOgogICAgIEZpbGxMYXllciBtX21hc2s7 CiAgICAgTmluZVBpZWNlSW1hZ2UgbV9tYXNrQm94SW1hZ2U7CiAKLSAgICBFVHJhbnNmb3JtU3R5 bGUzRCBtX3RyYW5zZm9ybVN0eWxlM0Q7Ci0gICAgRUJhY2tmYWNlVmlzaWJpbGl0eSBtX2JhY2tm YWNlVmlzaWJpbGl0eTsKICAgICBmbG9hdCBtX3BlcnNwZWN0aXZlOwogICAgIExlbmd0aCBtX3Bl cnNwZWN0aXZlT3JpZ2luWDsKICAgICBMZW5ndGggbV9wZXJzcGVjdGl2ZU9yaWdpblk7CiAKICAg ICBMZW5ndGhTaXplIG1fcGFnZVNpemU7Ci0gICAgUGFnZVNpemVUeXBlIG1fcGFnZVNpemVUeXBl OworCisgICAgUmVmUHRyPENTU1dyYXBTaGFwZT4gbV93cmFwU2hhcGU7CiAKICAgICBBdG9taWNT dHJpbmcgbV9mbG93VGhyZWFkOwogICAgIEF0b21pY1N0cmluZyBtX3JlZ2lvblRocmVhZDsKICAg ICBpbnQgbV9yZWdpb25JbmRleDsKLSAgICBSZWdpb25PdmVyZmxvdyBtX3JlZ2lvbk92ZXJmbG93 OwotCi0gICAgUmVmUHRyPENTU1dyYXBTaGFwZT4gbV93cmFwU2hhcGU7CisgICAgUmVnaW9uT3Zl cmZsb3cgbV9yZWdpb25PdmVyZmxvdyA6IDE7CiAKICAgICB1bnNpZ25lZCBtX3JlZ2lvbkJyZWFr QWZ0ZXIgOiAyOyAvLyBFUGFnZUJyZWFrCiAgICAgdW5zaWduZWQgbV9yZWdpb25CcmVha0JlZm9y ZSA6IDI7IC8vIEVQYWdlQnJlYWsKICAgICB1bnNpZ25lZCBtX3JlZ2lvbkJyZWFrSW5zaWRlIDog MjsgLy8gRVBhZ2VCcmVhawogCisgICAgUGFnZVNpemVUeXBlIG1fcGFnZVNpemVUeXBlIDogMjsK KyAgICBFVHJhbnNmb3JtU3R5bGUzRCBtX3RyYW5zZm9ybVN0eWxlM0QgOiAxOworICAgIEVCYWNr ZmFjZVZpc2liaWxpdHkgbV9iYWNrZmFjZVZpc2liaWxpdHkgOiAxOworCisgICAgdW5zaWduZWQg dXNlckRyYWcgOiAyOyAvLyBFVXNlckRyYWcKKyAgICB1bnNpZ25lZCB0ZXh0T3ZlcmZsb3cgOiAx OyAvLyBXaGV0aGVyIG9yIG5vdCBsaW5lcyB0aGF0IHNwaWxsIG91dCBzaG91bGQgYmUgdHJ1bmNh dGVkIHdpdGggIi4uLiIKKyAgICB1bnNpZ25lZCBtYXJnaW5CZWZvcmVDb2xsYXBzZSA6IDI7IC8v IEVNYXJnaW5Db2xsYXBzZQorICAgIHVuc2lnbmVkIG1hcmdpbkFmdGVyQ29sbGFwc2UgOiAyOyAv LyBFTWFyZ2luQ29sbGFwc2UKKyAgICB1bnNpZ25lZCBtYXRjaE5lYXJlc3RNYWlsQmxvY2txdW90 ZUNvbG9yIDogMTsgLy8gRU1hdGNoTmVhcmVzdE1haWxCbG9ja3F1b3RlQ29sb3IsIEZJWE1FOiBU aGlzIHByb3BlcnR5IG5lZWRzIHRvIGJlIGVsaW1pbmF0ZWQuIEl0IHNob3VsZCBuZXZlciBoYXZl IGJlZW4gYWRkZWQuCisgICAgdW5zaWduZWQgbV9hcHBlYXJhbmNlIDogNjsgLy8gRUFwcGVhcmFu Y2UKKyAgICB1bnNpZ25lZCBtX2JvcmRlckZpdCA6IDE7IC8vIEVCb3JkZXJGaXQKKyAgICB1bnNp Z25lZCBtX3RleHRDb21iaW5lIDogMTsgLy8gQ1NTMyB0ZXh0LWNvbWJpbmUgcHJvcGVydGllcwor CisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgIGJvb2wgbV9ydW5uaW5nQWNj ZWxlcmF0ZWRBbmltYXRpb24gOiAxOworI2VuZGlmCisKKyAgICBzaG9ydCBtX2NvdW50ZXJJbmNy ZW1lbnQ7CisgICAgc2hvcnQgbV9jb3VudGVyUmVzZXQ7CisKIHByaXZhdGU6CiAgICAgU3R5bGVS YXJlTm9uSW5oZXJpdGVkRGF0YSgpOwogICAgIFN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEoY29u c3QgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSYpOwo= 109619 2011-10-04 07:16:43 -0700 2011-10-04 08:12:51 -0700 Patch for landing (r=anttik) bug-69331-landing.diff text/plain 9285 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxYjE0MDk2Li5jNzA3NmVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMTAtMDQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFNocmluayBTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkzMzEKKworICAgICAgICBSZXZpZXdlZCBi eSBBbnR0aSBLb2l2aXN0by4KKworICAgICAgICBSZWFycmFuZ2UgdGhlIG1lbWJlcnMgYW5kIG1v dmUgYWxsIHNtYWxsIHR5cGVzIGludG8gdGhlIGJpdGZpZWxkLgorICAgICAgICBUaGlzIHNocmlu a3MgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSBieSB0d28gQ1BVIHdvcmRzLCByZWR1Y2luZyBt ZW1vcnkKKyAgICAgICAgY29uc3VtcHRpb24gYnkgMTQwIGtCIChvbiA2NC1iaXQpIHdoZW4gbG9h ZGluZyB0aGUgZnVsbCBIVE1MNSBzcGVjLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1N0 eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVSYXJl Tm9uSW5oZXJpdGVkRGF0YTo6U3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSk6CisgICAgICAgICog cmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuaDoKKwogMjAxMS0xMC0w MyAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRm9udEZhbGxi YWNrTGlzdDogR2x5cGggcGFnZXMgd2FzdGUgYSBsb3Qgb2YgbWVtb3J5LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRl ZERhdGEuY3BwCmluZGV4IDdiYzY2ODEuLjdhM2E0MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5j cHAKQEAgLTM2LDM1ICszNiwzNSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBTdHlsZVJhcmVOb25J bmhlcml0ZWREYXRhOjpTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhKCkKICAgICA6IGxpbmVDbGFt cChSZW5kZXJTdHlsZTo6aW5pdGlhbExpbmVDbGFtcCgpKQogICAgICwgb3BhY2l0eShSZW5kZXJT dHlsZTo6aW5pdGlhbE9wYWNpdHkoKSkKLSAgICAsIHVzZXJEcmFnKFJlbmRlclN0eWxlOjppbml0 aWFsVXNlckRyYWcoKSkKLSAgICAsIHRleHRPdmVyZmxvdyhSZW5kZXJTdHlsZTo6aW5pdGlhbFRl eHRPdmVyZmxvdygpKQotICAgICwgbWFyZ2luQmVmb3JlQ29sbGFwc2UoTUNPTExBUFNFKQotICAg ICwgbWFyZ2luQWZ0ZXJDb2xsYXBzZShNQ09MTEFQU0UpCi0gICAgLCBtYXRjaE5lYXJlc3RNYWls QmxvY2txdW90ZUNvbG9yKFJlbmRlclN0eWxlOjppbml0aWFsTWF0Y2hOZWFyZXN0TWFpbEJsb2Nr cXVvdGVDb2xvcigpKQotICAgICwgbV9hcHBlYXJhbmNlKFJlbmRlclN0eWxlOjppbml0aWFsQXBw ZWFyYW5jZSgpKQotICAgICwgbV9ib3JkZXJGaXQoUmVuZGVyU3R5bGU6OmluaXRpYWxCb3JkZXJG aXQoKSkKLSAgICAsIG1fdGV4dENvbWJpbmUoUmVuZGVyU3R5bGU6OmluaXRpYWxUZXh0Q29tYmlu ZSgpKQotICAgICwgbV9jb3VudGVySW5jcmVtZW50KDApCi0gICAgLCBtX2NvdW50ZXJSZXNldCgw KQotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICAsIG1fcnVubmluZ0FjY2Vs ZXJhdGVkQW5pbWF0aW9uKGZhbHNlKQotI2VuZGlmCiAgICAgLCBtX21hc2soRmlsbExheWVyKE1h c2tGaWxsTGF5ZXIpKQotICAgICwgbV90cmFuc2Zvcm1TdHlsZTNEKFJlbmRlclN0eWxlOjppbml0 aWFsVHJhbnNmb3JtU3R5bGUzRCgpKQotICAgICwgbV9iYWNrZmFjZVZpc2liaWxpdHkoUmVuZGVy U3R5bGU6OmluaXRpYWxCYWNrZmFjZVZpc2liaWxpdHkoKSkKICAgICAsIG1fcGVyc3BlY3RpdmUo UmVuZGVyU3R5bGU6OmluaXRpYWxQZXJzcGVjdGl2ZSgpKQogICAgICwgbV9wZXJzcGVjdGl2ZU9y aWdpblgoUmVuZGVyU3R5bGU6OmluaXRpYWxQZXJzcGVjdGl2ZU9yaWdpblgoKSkKICAgICAsIG1f cGVyc3BlY3RpdmVPcmlnaW5ZKFJlbmRlclN0eWxlOjppbml0aWFsUGVyc3BlY3RpdmVPcmlnaW5Z KCkpCiAgICAgLCBtX3BhZ2VTaXplKCkKLSAgICAsIG1fcGFnZVNpemVUeXBlKFBBR0VfU0laRV9B VVRPKQorICAgICwgbV93cmFwU2hhcGUoUmVuZGVyU3R5bGU6OmluaXRpYWxXcmFwU2hhcGUoKSkK ICAgICAsIG1fZmxvd1RocmVhZChSZW5kZXJTdHlsZTo6aW5pdGlhbEZsb3dUaHJlYWQoKSkKICAg ICAsIG1fcmVnaW9uVGhyZWFkKFJlbmRlclN0eWxlOjppbml0aWFsUmVnaW9uVGhyZWFkKCkpCiAg ICAgLCBtX3JlZ2lvbkluZGV4KFJlbmRlclN0eWxlOjppbml0aWFsUmVnaW9uSW5kZXgoKSkKICAg ICAsIG1fcmVnaW9uT3ZlcmZsb3coUmVuZGVyU3R5bGU6OmluaXRpYWxSZWdpb25PdmVyZmxvdygp KQotICAgICwgbV93cmFwU2hhcGUoUmVuZGVyU3R5bGU6OmluaXRpYWxXcmFwU2hhcGUoKSkKICAg ICAsIG1fcmVnaW9uQnJlYWtBZnRlcihSZW5kZXJTdHlsZTo6aW5pdGlhbFBhZ2VCcmVhaygpKQog ICAgICwgbV9yZWdpb25CcmVha0JlZm9yZShSZW5kZXJTdHlsZTo6aW5pdGlhbFBhZ2VCcmVhaygp KQogICAgICwgbV9yZWdpb25CcmVha0luc2lkZShSZW5kZXJTdHlsZTo6aW5pdGlhbFBhZ2VCcmVh aygpKQorICAgICwgbV9wYWdlU2l6ZVR5cGUoUEFHRV9TSVpFX0FVVE8pCisgICAgLCBtX3RyYW5z Zm9ybVN0eWxlM0QoUmVuZGVyU3R5bGU6OmluaXRpYWxUcmFuc2Zvcm1TdHlsZTNEKCkpCisgICAg LCBtX2JhY2tmYWNlVmlzaWJpbGl0eShSZW5kZXJTdHlsZTo6aW5pdGlhbEJhY2tmYWNlVmlzaWJp bGl0eSgpKQorICAgICwgdXNlckRyYWcoUmVuZGVyU3R5bGU6OmluaXRpYWxVc2VyRHJhZygpKQor ICAgICwgdGV4dE92ZXJmbG93KFJlbmRlclN0eWxlOjppbml0aWFsVGV4dE92ZXJmbG93KCkpCisg ICAgLCBtYXJnaW5CZWZvcmVDb2xsYXBzZShNQ09MTEFQU0UpCisgICAgLCBtYXJnaW5BZnRlckNv bGxhcHNlKE1DT0xMQVBTRSkKKyAgICAsIG1hdGNoTmVhcmVzdE1haWxCbG9ja3F1b3RlQ29sb3Io UmVuZGVyU3R5bGU6OmluaXRpYWxNYXRjaE5lYXJlc3RNYWlsQmxvY2txdW90ZUNvbG9yKCkpCisg ICAgLCBtX2FwcGVhcmFuY2UoUmVuZGVyU3R5bGU6OmluaXRpYWxBcHBlYXJhbmNlKCkpCisgICAg LCBtX2JvcmRlckZpdChSZW5kZXJTdHlsZTo6aW5pdGlhbEJvcmRlckZpdCgpKQorICAgICwgbV90 ZXh0Q29tYmluZShSZW5kZXJTdHlsZTo6aW5pdGlhbFRleHRDb21iaW5lKCkpCisjaWYgVVNFKEFD Q0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgICwgbV9ydW5uaW5nQWNjZWxlcmF0ZWRBbmltYXRp b24oZmFsc2UpCisjZW5kaWYKKyAgICAsIG1fY291bnRlckluY3JlbWVudCgwKQorICAgICwgbV9j b3VudGVyUmVzZXQoMCkKIHsKICAgICBtX21hc2tCb3hJbWFnZS5zZXRNYXNrRGVmYXVsdHMoKTsK IH0KQEAgLTg1LDQwICs4NSw0MCBAQCBTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhOjpTdHlsZVJh cmVOb25Jbmhlcml0ZWREYXRhKGNvbnN0IFN0eWxlUmFyZU5vbkluaGVyaXRlZAogI2VuZGlmCiAg ICAgLCBtX2NvbnRlbnQoby5tX2NvbnRlbnQgPyBvLm1fY29udGVudC0+Y2xvbmUoKSA6IG51bGxw dHIpCiAgICAgLCBtX2NvdW50ZXJEaXJlY3RpdmVzKG8ubV9jb3VudGVyRGlyZWN0aXZlcyA/IGNs b25lKCpvLm1fY291bnRlckRpcmVjdGl2ZXMpIDogbnVsbHB0cikKLSAgICAsIHVzZXJEcmFnKG8u dXNlckRyYWcpCi0gICAgLCB0ZXh0T3ZlcmZsb3coby50ZXh0T3ZlcmZsb3cpCi0gICAgLCBtYXJn aW5CZWZvcmVDb2xsYXBzZShvLm1hcmdpbkJlZm9yZUNvbGxhcHNlKQotICAgICwgbWFyZ2luQWZ0 ZXJDb2xsYXBzZShvLm1hcmdpbkFmdGVyQ29sbGFwc2UpCi0gICAgLCBtYXRjaE5lYXJlc3RNYWls QmxvY2txdW90ZUNvbG9yKG8ubWF0Y2hOZWFyZXN0TWFpbEJsb2NrcXVvdGVDb2xvcikKLSAgICAs IG1fYXBwZWFyYW5jZShvLm1fYXBwZWFyYW5jZSkKLSAgICAsIG1fYm9yZGVyRml0KG8ubV9ib3Jk ZXJGaXQpCi0gICAgLCBtX3RleHRDb21iaW5lKG8ubV90ZXh0Q29tYmluZSkKLSAgICAsIG1fY291 bnRlckluY3JlbWVudChvLm1fY291bnRlckluY3JlbWVudCkKLSAgICAsIG1fY291bnRlclJlc2V0 KG8ubV9jb3VudGVyUmVzZXQpCi0jaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotICAg ICwgbV9ydW5uaW5nQWNjZWxlcmF0ZWRBbmltYXRpb24oby5tX3J1bm5pbmdBY2NlbGVyYXRlZEFu aW1hdGlvbikKLSNlbmRpZgogICAgICwgbV9ib3hTaGFkb3coby5tX2JveFNoYWRvdyA/IGFkb3B0 UHRyKG5ldyBTaGFkb3dEYXRhKCpvLm1fYm94U2hhZG93KSkgOiBudWxscHRyKQogICAgICwgbV9i b3hSZWZsZWN0KG8ubV9ib3hSZWZsZWN0KQogICAgICwgbV9hbmltYXRpb25zKG8ubV9hbmltYXRp b25zID8gYWRvcHRQdHIobmV3IEFuaW1hdGlvbkxpc3QoKm8ubV9hbmltYXRpb25zKSkgOiBudWxs cHRyKQogICAgICwgbV90cmFuc2l0aW9ucyhvLm1fdHJhbnNpdGlvbnMgPyBhZG9wdFB0cihuZXcg QW5pbWF0aW9uTGlzdCgqby5tX3RyYW5zaXRpb25zKSkgOiBudWxscHRyKQogICAgICwgbV9tYXNr KG8ubV9tYXNrKQogICAgICwgbV9tYXNrQm94SW1hZ2Uoby5tX21hc2tCb3hJbWFnZSkKLSAgICAs IG1fdHJhbnNmb3JtU3R5bGUzRChvLm1fdHJhbnNmb3JtU3R5bGUzRCkKLSAgICAsIG1fYmFja2Zh Y2VWaXNpYmlsaXR5KG8ubV9iYWNrZmFjZVZpc2liaWxpdHkpCiAgICAgLCBtX3BlcnNwZWN0aXZl KG8ubV9wZXJzcGVjdGl2ZSkKICAgICAsIG1fcGVyc3BlY3RpdmVPcmlnaW5YKG8ubV9wZXJzcGVj dGl2ZU9yaWdpblgpCiAgICAgLCBtX3BlcnNwZWN0aXZlT3JpZ2luWShvLm1fcGVyc3BlY3RpdmVP cmlnaW5ZKQogICAgICwgbV9wYWdlU2l6ZShvLm1fcGFnZVNpemUpCi0gICAgLCBtX3BhZ2VTaXpl VHlwZShvLm1fcGFnZVNpemVUeXBlKQorICAgICwgbV93cmFwU2hhcGUoby5tX3dyYXBTaGFwZSkK ICAgICAsIG1fZmxvd1RocmVhZChvLm1fZmxvd1RocmVhZCkKICAgICAsIG1fcmVnaW9uVGhyZWFk KG8ubV9yZWdpb25UaHJlYWQpCiAgICAgLCBtX3JlZ2lvbkluZGV4KG8ubV9yZWdpb25JbmRleCkK ICAgICAsIG1fcmVnaW9uT3ZlcmZsb3coby5tX3JlZ2lvbk92ZXJmbG93KQotICAgICwgbV93cmFw U2hhcGUoby5tX3dyYXBTaGFwZSkKICAgICAsIG1fcmVnaW9uQnJlYWtBZnRlcihvLm1fcmVnaW9u QnJlYWtBZnRlcikKICAgICAsIG1fcmVnaW9uQnJlYWtCZWZvcmUoby5tX3JlZ2lvbkJyZWFrQmVm b3JlKQogICAgICwgbV9yZWdpb25CcmVha0luc2lkZShvLm1fcmVnaW9uQnJlYWtJbnNpZGUpCisg ICAgLCBtX3BhZ2VTaXplVHlwZShvLm1fcGFnZVNpemVUeXBlKQorICAgICwgbV90cmFuc2Zvcm1T dHlsZTNEKG8ubV90cmFuc2Zvcm1TdHlsZTNEKQorICAgICwgbV9iYWNrZmFjZVZpc2liaWxpdHko by5tX2JhY2tmYWNlVmlzaWJpbGl0eSkKKyAgICAsIHVzZXJEcmFnKG8udXNlckRyYWcpCisgICAg LCB0ZXh0T3ZlcmZsb3coby50ZXh0T3ZlcmZsb3cpCisgICAgLCBtYXJnaW5CZWZvcmVDb2xsYXBz ZShvLm1hcmdpbkJlZm9yZUNvbGxhcHNlKQorICAgICwgbWFyZ2luQWZ0ZXJDb2xsYXBzZShvLm1h cmdpbkFmdGVyQ29sbGFwc2UpCisgICAgLCBtYXRjaE5lYXJlc3RNYWlsQmxvY2txdW90ZUNvbG9y KG8ubWF0Y2hOZWFyZXN0TWFpbEJsb2NrcXVvdGVDb2xvcikKKyAgICAsIG1fYXBwZWFyYW5jZShv Lm1fYXBwZWFyYW5jZSkKKyAgICAsIG1fYm9yZGVyRml0KG8ubV9ib3JkZXJGaXQpCisgICAgLCBt X3RleHRDb21iaW5lKG8ubV90ZXh0Q29tYmluZSkKKyNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9T SVRJTkcpCisgICAgLCBtX3J1bm5pbmdBY2NlbGVyYXRlZEFuaW1hdGlvbihvLm1fcnVubmluZ0Fj Y2VsZXJhdGVkQW5pbWF0aW9uKQorI2VuZGlmCisgICAgLCBtX2NvdW50ZXJJbmNyZW1lbnQoby5t X2NvdW50ZXJJbmNyZW1lbnQpCisgICAgLCBtX2NvdW50ZXJSZXNldChvLm1fY291bnRlclJlc2V0 KQogewogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5 bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxl L1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuaAppbmRleCBkOTM4ZTBkLi42NzU2YTUyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJp dGVkRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVO b25Jbmhlcml0ZWREYXRhLmgKQEAgLTEwOCwyMSArMTA4LDYgQEAgcHVibGljOgogICAgIE93blB0 cjxDb250ZW50RGF0YT4gbV9jb250ZW50OwogICAgIE93blB0cjxDb3VudGVyRGlyZWN0aXZlTWFw PiBtX2NvdW50ZXJEaXJlY3RpdmVzOwogCi0gICAgdW5zaWduZWQgdXNlckRyYWcgOiAyOyAvLyBF VXNlckRyYWcKLSAgICB1bnNpZ25lZCB0ZXh0T3ZlcmZsb3cgOiAxOyAvLyBXaGV0aGVyIG9yIG5v dCBsaW5lcyB0aGF0IHNwaWxsIG91dCBzaG91bGQgYmUgdHJ1bmNhdGVkIHdpdGggIi4uLiIKLSAg ICB1bnNpZ25lZCBtYXJnaW5CZWZvcmVDb2xsYXBzZSA6IDI7IC8vIEVNYXJnaW5Db2xsYXBzZQot ICAgIHVuc2lnbmVkIG1hcmdpbkFmdGVyQ29sbGFwc2UgOiAyOyAvLyBFTWFyZ2luQ29sbGFwc2UK LSAgICB1bnNpZ25lZCBtYXRjaE5lYXJlc3RNYWlsQmxvY2txdW90ZUNvbG9yIDogMTsgLy8gRU1h dGNoTmVhcmVzdE1haWxCbG9ja3F1b3RlQ29sb3IsIEZJWE1FOiBUaGlzIHByb3BlcnR5IG5lZWRz IHRvIGJlIGVsaW1pbmF0ZWQuIEl0IHNob3VsZCBuZXZlciBoYXZlIGJlZW4gYWRkZWQuCi0gICAg dW5zaWduZWQgbV9hcHBlYXJhbmNlIDogNjsgLy8gRUFwcGVhcmFuY2UKLSAgICB1bnNpZ25lZCBt X2JvcmRlckZpdCA6IDE7IC8vIEVCb3JkZXJGaXQKLSAgICB1bnNpZ25lZCBtX3RleHRDb21iaW5l IDogMTsgLy8gQ1NTMyB0ZXh0LWNvbWJpbmUgcHJvcGVydGllcwotICAgIAotICAgIHNob3J0IG1f Y291bnRlckluY3JlbWVudDsKLSAgICBzaG9ydCBtX2NvdW50ZXJSZXNldDsKLQotI2lmIFVTRShB Q0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICBib29sIG1fcnVubmluZ0FjY2VsZXJhdGVkQW5p bWF0aW9uIDogMTsKLSNlbmRpZgogICAgIE93blB0cjxTaGFkb3dEYXRhPiBtX2JveFNoYWRvdzsg IC8vIEZvciBib3gtc2hhZG93IGRlY29yYXRpb25zLgogICAgIAogICAgIFJlZlB0cjxTdHlsZVJl ZmxlY3Rpb24+IG1fYm94UmVmbGVjdDsKQEAgLTEzMywyNiArMTE4LDQzIEBAIHB1YmxpYzoKICAg ICBGaWxsTGF5ZXIgbV9tYXNrOwogICAgIE5pbmVQaWVjZUltYWdlIG1fbWFza0JveEltYWdlOwog Ci0gICAgRVRyYW5zZm9ybVN0eWxlM0QgbV90cmFuc2Zvcm1TdHlsZTNEOwotICAgIEVCYWNrZmFj ZVZpc2liaWxpdHkgbV9iYWNrZmFjZVZpc2liaWxpdHk7CiAgICAgZmxvYXQgbV9wZXJzcGVjdGl2 ZTsKICAgICBMZW5ndGggbV9wZXJzcGVjdGl2ZU9yaWdpblg7CiAgICAgTGVuZ3RoIG1fcGVyc3Bl Y3RpdmVPcmlnaW5ZOwogCiAgICAgTGVuZ3RoU2l6ZSBtX3BhZ2VTaXplOwotICAgIFBhZ2VTaXpl VHlwZSBtX3BhZ2VTaXplVHlwZTsKKworICAgIFJlZlB0cjxDU1NXcmFwU2hhcGU+IG1fd3JhcFNo YXBlOwogCiAgICAgQXRvbWljU3RyaW5nIG1fZmxvd1RocmVhZDsKICAgICBBdG9taWNTdHJpbmcg bV9yZWdpb25UaHJlYWQ7CiAgICAgaW50IG1fcmVnaW9uSW5kZXg7Ci0gICAgUmVnaW9uT3ZlcmZs b3cgbV9yZWdpb25PdmVyZmxvdzsKLQotICAgIFJlZlB0cjxDU1NXcmFwU2hhcGU+IG1fd3JhcFNo YXBlOworICAgIFJlZ2lvbk92ZXJmbG93IG1fcmVnaW9uT3ZlcmZsb3cgOiAxOwogCiAgICAgdW5z aWduZWQgbV9yZWdpb25CcmVha0FmdGVyIDogMjsgLy8gRVBhZ2VCcmVhawogICAgIHVuc2lnbmVk IG1fcmVnaW9uQnJlYWtCZWZvcmUgOiAyOyAvLyBFUGFnZUJyZWFrCiAgICAgdW5zaWduZWQgbV9y ZWdpb25CcmVha0luc2lkZSA6IDI7IC8vIEVQYWdlQnJlYWsKIAorICAgIFBhZ2VTaXplVHlwZSBt X3BhZ2VTaXplVHlwZSA6IDI7CisgICAgRVRyYW5zZm9ybVN0eWxlM0QgbV90cmFuc2Zvcm1TdHls ZTNEIDogMTsKKyAgICBFQmFja2ZhY2VWaXNpYmlsaXR5IG1fYmFja2ZhY2VWaXNpYmlsaXR5IDog MTsKKworICAgIHVuc2lnbmVkIHVzZXJEcmFnIDogMjsgLy8gRVVzZXJEcmFnCisgICAgdW5zaWdu ZWQgdGV4dE92ZXJmbG93IDogMTsgLy8gV2hldGhlciBvciBub3QgbGluZXMgdGhhdCBzcGlsbCBv dXQgc2hvdWxkIGJlIHRydW5jYXRlZCB3aXRoICIuLi4iCisgICAgdW5zaWduZWQgbWFyZ2luQmVm b3JlQ29sbGFwc2UgOiAyOyAvLyBFTWFyZ2luQ29sbGFwc2UKKyAgICB1bnNpZ25lZCBtYXJnaW5B ZnRlckNvbGxhcHNlIDogMjsgLy8gRU1hcmdpbkNvbGxhcHNlCisgICAgdW5zaWduZWQgbWF0Y2hO ZWFyZXN0TWFpbEJsb2NrcXVvdGVDb2xvciA6IDE7IC8vIEVNYXRjaE5lYXJlc3RNYWlsQmxvY2tx dW90ZUNvbG9yLCBGSVhNRTogVGhpcyBwcm9wZXJ0eSBuZWVkcyB0byBiZSBlbGltaW5hdGVkLiBJ dCBzaG91bGQgbmV2ZXIgaGF2ZSBiZWVuIGFkZGVkLgorICAgIHVuc2lnbmVkIG1fYXBwZWFyYW5j ZSA6IDY7IC8vIEVBcHBlYXJhbmNlCisgICAgdW5zaWduZWQgbV9ib3JkZXJGaXQgOiAxOyAvLyBF Qm9yZGVyRml0CisgICAgdW5zaWduZWQgbV90ZXh0Q29tYmluZSA6IDE7IC8vIENTUzMgdGV4dC1j b21iaW5lIHByb3BlcnRpZXMKKworI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKyAg ICBib29sIG1fcnVubmluZ0FjY2VsZXJhdGVkQW5pbWF0aW9uIDogMTsKKyNlbmRpZgorCisgICAg c2hvcnQgbV9jb3VudGVySW5jcmVtZW50OworICAgIHNob3J0IG1fY291bnRlclJlc2V0OworCiBw cml2YXRlOgogICAgIFN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEoKTsKICAgICBTdHlsZVJhcmVO b25Jbmhlcml0ZWREYXRhKGNvbnN0IFN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEmKTsK 109648 2011-10-04 10:54:14 -0700 2011-10-05 00:57:03 -0700 Follow-up patch to make enum bitfields explicitly unsigned. bug-69331-followup.diff text/plain 1758 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMjkzMTYzLi4zZDI0NTM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTEtMTAtMDQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFNocmluayBTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkzMzEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXb3JrYXJvdW5kIE1TVkMgcXVpcmsgYnkgbWFr aW5nIGVudW0gYml0ZmllbGRzICJ1bnNpZ25lZCIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5 bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5oOgorCisyMDExLTEwLTA0ICBBbmRyZWFzIEts aW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KKwogICAgICAgICBTaHJpbmsgSFRNTFRhYmxlQ2VsbEVs ZW1lbnQuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 OTM0NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVS YXJlTm9uSW5oZXJpdGVkRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0 eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuaAppbmRleCA2NzU2YTUyLi45OTFiYTg4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVk RGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25J bmhlcml0ZWREYXRhLmgKQEAgLTEyOSwxNSArMTI5LDE1IEBAIHB1YmxpYzoKICAgICBBdG9taWNT dHJpbmcgbV9mbG93VGhyZWFkOwogICAgIEF0b21pY1N0cmluZyBtX3JlZ2lvblRocmVhZDsKICAg ICBpbnQgbV9yZWdpb25JbmRleDsKLSAgICBSZWdpb25PdmVyZmxvdyBtX3JlZ2lvbk92ZXJmbG93 IDogMTsKKyAgICB1bnNpZ25lZCBtX3JlZ2lvbk92ZXJmbG93IDogMTsgLy8gUmVnaW9uT3ZlcmZs b3cKIAogICAgIHVuc2lnbmVkIG1fcmVnaW9uQnJlYWtBZnRlciA6IDI7IC8vIEVQYWdlQnJlYWsK ICAgICB1bnNpZ25lZCBtX3JlZ2lvbkJyZWFrQmVmb3JlIDogMjsgLy8gRVBhZ2VCcmVhawogICAg IHVuc2lnbmVkIG1fcmVnaW9uQnJlYWtJbnNpZGUgOiAyOyAvLyBFUGFnZUJyZWFrCiAKLSAgICBQ YWdlU2l6ZVR5cGUgbV9wYWdlU2l6ZVR5cGUgOiAyOwotICAgIEVUcmFuc2Zvcm1TdHlsZTNEIG1f dHJhbnNmb3JtU3R5bGUzRCA6IDE7Ci0gICAgRUJhY2tmYWNlVmlzaWJpbGl0eSBtX2JhY2tmYWNl VmlzaWJpbGl0eSA6IDE7CisgICAgdW5zaWduZWQgbV9wYWdlU2l6ZVR5cGUgOiAyOyAvLyBQYWdl U2l6ZVR5cGUKKyAgICB1bnNpZ25lZCBtX3RyYW5zZm9ybVN0eWxlM0QgOiAxOyAvLyBFVHJhbnNm b3JtU3R5bGUzRAorICAgIHVuc2lnbmVkIG1fYmFja2ZhY2VWaXNpYmlsaXR5IDogMTsgLy8gRUJh Y2tmYWNlVmlzaWJpbGl0eQogCiAgICAgdW5zaWduZWQgdXNlckRyYWcgOiAyOyAvLyBFVXNlckRy YWcKICAgICB1bnNpZ25lZCB0ZXh0T3ZlcmZsb3cgOiAxOyAvLyBXaGV0aGVyIG9yIG5vdCBsaW5l cyB0aGF0IHNwaWxsIG91dCBzaG91bGQgYmUgdHJ1bmNhdGVkIHdpdGggIi4uLiIK