69323 2011-10-04 00:08:23 -0700 watchlist: Add more rules for chromium public api and sort the file. 2011-10-05 02:28:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69303 1 levin levin webkit.review.bot oldest_to_newest 477467 0 levin 2011-10-04 00:08:23 -0700 See summary. 477468 1 levin 2011-10-04 00:09:38 -0700 It would be best if bug 69303 were fixed before this change is checked in. 477470 2 109586 levin 2011-10-04 00:10:36 -0700 Created attachment 109586 Patch 477734 3 109586 abarth 2011-10-04 10:51:24 -0700 Comment on attachment 109586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109586&action=review > Tools/Scripts/webkitpy/common/config/watchlist:31 > + "ChromiumPublicApi": [ "Please wait for approval from darin@chromium.org before submitting " darin@chromium.org => fishd@chromium.org > Tools/Scripts/webkitpy/common/config/watchlist:32 > + "because this patch contains changes to the Chromium public api.", ], api => API. 478244 4 levin 2011-10-05 02:28:48 -0700 Addressed comments and committed as http://trac.webkit.org/changeset/96688 109586 2011-10-04 00:10:36 -0700 2011-10-04 10:51:23 -0700 Patch bug-69323-20111004001035.patch text/plain 2767 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTY1NzMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMTJjZGJhMTk0NGI2NGUxZmRlOTEzMWUxMGJhZTJlYWM2 ZjgxZGU2Li40OGZjYjRlNTk1YTJkYmZiMzE5MDRhOTA4MjU5YWVjYWE5ZWEzOWJjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMTAtMDQgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIHdhdGNobGlzdDogQWRkIG1vcmUgcnVsZXMgZm9yIGNocm9taXVtIHB1YmxpYyBhcGkgYW5k IHNvcnQgdGhlIGZpbGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02OTMyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNobGlzdDoKKwogMjAx MS0xMC0wMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIGdhcmRl bi1vLW1hdGljIHNob3VsZCByZW1vdmUgYnVpbGRlcnMgZnJvbSB0aGUgZmFpbHVyZSBncmlkIG9u Y2UgdGhleSBzdGFydCB0byBwYXNzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL3dhdGNobGlzdAppbmRleCBkMWVkMjgwYWM3YTcxODMwMzI0ZWI5NWIzY2E0ZWVjY2Ey Y2IxYTFiLi41MmNmZTZkZDdmZWJlYWZhYTYxNDQ2OTZiZWNkYTczMjMxYzlhYjFjIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3QKQEAgLTEsOCAr MSwxMSBAQAogIyAgLSotIG1vZGU6IFB5dGhvbjstKi0KIHsKICAgICAiREVGSU5JVElPTlMiOiB7 Ci0gICAgICAgICJXYXRjaExpc3RTY3JpcHQiOiB7Ci0gICAgICAgICAgICAiZmlsZW5hbWUiOiBy IlRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3dhdGNobGlzdC8uKiIsCisgICAgICAgICJD aHJvbWl1bUdyYXBoaWNzIjogeworICAgICAgICAgICAgImZpbGVuYW1lIjogciJTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS8uKiIsCisgICAgICAgIH0sCisgICAgICAg ICJDaHJvbWl1bVB1YmxpY0FwaSI6IHsKKyAgICAgICAgICAgICJmaWxlbmFtZSI6IHIiU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvLioiCiAgICAgICAgIH0sCiAgICAgICAgICJUaHJlYWRp bmdGaWxlcyI6IHsKICAgICAgICAgICAgICJmaWxlbmFtZSI6IHIiU291cmNlL0phdmFTY3JpcHRD b3JlL3d0Zi9UaHJlYWRTYWZlUmVmQ291bnRlZFwuaCIKQEAgLTExLDE2ICsxNCwyMSBAQAogICAg ICAgICAiVGhyZWFkaW5nVXNhZ2UiOiB7CiAgICAgICAgICAgICAibW9yZSI6IHIiZGVwcmVjYXRl ZFR1cm5PZmZWZXJpZmllcnxjcm9zc1RocmVhZFN0cmluZ3x0aHJlYWRzYWZlQ29weXxUaHJlYWRT YWZlUmVmQ291bnRlZHxDcm9zc1RocmVhZFJlZkNvdW50ZWQiLAogICAgICAgICB9LAotICAgICAg ICAiQ2hyb21pdW1HcmFwaGljcyI6IHsKLSAgICAgICAgICAgICJmaWxlbmFtZSI6IHIiU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vLioiLAorICAgICAgICAiV2F0Y2hM aXN0U2NyaXB0IjogeworICAgICAgICAgICAgImZpbGVuYW1lIjogciJUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi93YXRjaGxpc3QvLioiLAogICAgICAgICB9LAogICAgIH0sCiAgICAgIkND X1JVTEVTIjogewogICAgICAgICAjIE5vdGU6IEFsbCBlbWFpbCBhZGRyZXNzZXMgbGlzdGVkIG11 c3QgYmUgcmVnaXN0ZXJlZCB3aXRoIGJ1Z3ppbGxhLgogICAgICAgICAjIFNwZWNpZmljYWxseSwg bGV2aW5AY2hyb21pdW0ub3JnIGFuZCBsZXZpbit0aHJlYWRpbmdAY2hyb21pdW0ub3JnIGFyZQog ICAgICAgICAjIHR3byBkaWZmZXJlbnQgYWNjb3VudHMgYXMgZmFyIGFzIGJ1Z3ppbGxhIGlzIGNv bmNlcm5lZC4KLSAgICAgICAgIldhdGNoTGlzdFNjcmlwdCI6IFsgImxldmluK3dhdGNobGlzdEBj aHJvbWl1bS5vcmciLCBdLAotICAgICAgICAiVGhyZWFkaW5nRmlsZXN8VGhyZWFkaW5nVXNhZ2Ui OiBbICJsZXZpbit0aHJlYWRpbmdAY2hyb21pdW0ub3JnIiwgXSwKICAgICAgICAgIkNocm9taXVt R3JhcGhpY3MiOiBbICJqYW1lc3JAY2hyb21pdW0ub3JnIiwgXSwKKyAgICAgICAgIkNocm9taXVt UHVibGljQXBpIjogWyAiZmlzaGRAY2hyb21pdW0ub3JnIiwgXSwKKyAgICAgICAgIlRocmVhZGlu Z0ZpbGVzfFRocmVhZGluZ1VzYWdlIjogWyAibGV2aW4rdGhyZWFkaW5nQGNocm9taXVtLm9yZyIs IF0sCisgICAgICAgICJXYXRjaExpc3RTY3JpcHQiOiBbICJsZXZpbit3YXRjaGxpc3RAY2hyb21p dW0ub3JnIiwgXSwKKyAgICB9LAorICAgICJNRVNTQUdFX1JVTEVTIjogeworICAgICAgICAiQ2hy b21pdW1QdWJsaWNBcGkiOiBbICJQbGVhc2Ugd2FpdCBmb3IgYXBwcm92YWwgZnJvbSBkYXJpbkBj aHJvbWl1bS5vcmcgYmVmb3JlIHN1Ym1pdHRpbmcgIgorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICJiZWNhdXNlIHRoaXMgcGF0Y2ggY29udGFpbnMgY2hhbmdlcyB0byB0aGUgQ2hyb21p dW0gcHVibGljIGFwaS4iLCBdLAogICAgIH0sCiB9Cg==