69315 2011-10-03 19:10:59 -0700 REGRESSION(r94274): setting input.value erroneously triggers focus event 2011-10-04 20:34:40 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED GoogleBug P1 Normal --- 69395 1 rniwa rniwa ap darin enrica ojan sullivan tkent oldest_to_newest 477406 0 rniwa 2011-10-03 19:10:59 -0700 After http://trac.webkit.org/changeset/94274, WebKit sets focus on an input element when setting the value attribute of the element if the element has a selection in its inner text element. http://b/issue?id=5362152 477428 1 109577 rniwa 2011-10-03 20:32:56 -0700 Created attachment 109577 manual test I've spent last 1.5 hours trying to create a reproduction without a success. It seems like I'd have to create a manual test here :( 477429 2 109578 rniwa 2011-10-03 20:38:31 -0700 Created attachment 109578 Patch 477451 3 109578 tkent 2011-10-03 23:22:03 -0700 Comment on attachment 109578 Patch The change looks good, but why did r94274 make the problem? 477457 4 rniwa 2011-10-03 23:40:22 -0700 (In reply to comment #3) > (From update of attachment 109578 [details]) > The change looks good, but why did r94274 make the problem? r94274 added a call to updateInnerTextValue in setValue. We used to update the inner text value in updateFromElement so this had never been an issue (although we may had a use-after-free back then). 477469 5 109578 tkent 2011-10-04 00:10:30 -0700 Comment on attachment 109578 Patch ok, I understand. 477495 6 tkent 2011-10-04 01:51:29 -0700 I have just remembered Bug 59071. I can remove the change for Bug 59071 when this patch is landed. 477820 7 rniwa 2011-10-04 12:01:42 -0700 Committed r96628: <http://trac.webkit.org/changeset/96628> 109577 2011-10-03 20:32:56 -0700 2011-10-03 20:32:56 -0700 manual test mutate-unfocused-text-with-selection.html text/html 1000 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPHA+VGhpcyB0ZXN0cyBtb2RpZnlpbmcgYSB0 ZXh0IG5vZGUgd2l0aCBzZWxlY3Rpb24gYnV0IHdpdGhvdXQgYSBmb2N1cy4KV2ViS2l0IHVzZWQg dG8gYXV0b21hdGljYWxseSBzZXQgdGhlIGZvY3VzIHRvIHRoZSByb290IGVkaXRhYmxlIGVsZW1l bnQgb2YgdGhpcyBub2RlIGJ1dCBpdCBzaG91bGQgbm90LgpZb3Ugc2hvdWxkIHNlZSAnUEFTUycg YmVsb3c6PC9wPgo8ZGl2IGlkPSJ0YXJnZXQiIG9uZm9jdXM9InRhcmdldC5pbm5lclRleHQ9J0ZB SUwnIiBjb250ZW50ZWRpdGFibGU+aGVsbG88L2Rpdj4KPGRpdiBpZD0iZm9jdXNlZCIgY29udGVu dGVkaXRhYmxlPndvcmxkPC9kaXY+CjxzY3JpcHQ+CgppZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKSB7CiAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CiAgICBsYXlv dXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cn0KCnZhciB0YXJnZXQgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgndGFyZ2V0Jyk7CnZhciBmb2N1c2VkID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ2ZvY3VzZWQnKTsKZm9jdXNlZC5mb2N1cygpOwpnZXRTZWxlY3Rpb24oKS5zZXRC YXNlQW5kRXh0ZW50KHRhcmdldC5maXJzdENoaWxkLCAxLCB0YXJnZXQuZmlyc3RDaGlsZCwgMyk7 CgovLyBUaGUgYnVnIGRvZXNuJ3QgcmVwcm9kdWNlIGlmIHRoaXMgZnVuY3Rpb24gd2FzIHJhbiBo ZXJlIG9yIGluc2lkZSBsb2FkIGV2ZW50IGhhbmRsZXIKc2V0VGltZW91dChmdW5jdGlvbigpIHsK ICAgIHRhcmdldC5maXJzdENoaWxkLmRhdGEgPSAnUEFTUyc7CiAgICBhbGVydCgnYWN0aXZlRWxl bWVudDonICsgZG9jdW1lbnQuYWN0aXZlRWxlbWVudC5pZCk7IC8vIG5lY2Vzc2FyeSB0byByZXBy b2R1Y2UgdGhlIGJ1ZwogICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwp9LCA1 MCk7Cgo8L3NjcmlwdD4KPC9ib2R5Pgo8L2h0bWw+Cg== 109578 2011-10-03 20:38:31 -0700 2011-10-04 00:10:30 -0700 Patch bug-69315-20111003203830.patch text/plain 4088 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2NTY5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMTAtMDMgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyOTQyNzQpOiBz ZXR0aW5nIGlucHV0LnZhbHVlIGVycm9uZW91c2x5IHRyaWdnZXJzIGZvY3VzIGV2ZW50CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTMxNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHRoZSBidWcg YnkgYWRkaW5nIGEgbmV3IGZsYWcgdG8gc2V0U2VsZWN0aW9uIHRvIGF2b2lkIGNhbGxpbmcgc2V0 Rm9jdXNlZE5vZGVJZk5lZWRlZAorICAgICAgICB3aGVuIGNhbGxlZCBieSBub2RlV2lsbEJlUmVt b3ZlZCBhbmQgdGV4dFdpbGxCZVJlcGxhY2VkLgorCisgICAgICAgIEFkZGVkIGEgbWFudWFsIHRl c3QuIFVuZm9ydHVuYXRlbHksIHRoZSB0ZXN0IGFsd2F5cyBwYXNzZXMgaW4gRFJULgorCisgICAg ICAgICogZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFt ZVNlbGVjdGlvbjo6c2V0U2VsZWN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0 aW9uOjpyZXNwb25kVG9Ob2RlTW9kaWZpY2F0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1l U2VsZWN0aW9uOjp0ZXh0V2lsbEJlUmVwbGFjZWQpOgorICAgICAgICAqIGVkaXRpbmcvRnJhbWVT ZWxlY3Rpb24uaDoKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvbXV0YXRlLXVuZm9jdXNlZC10ZXh0 LXdpdGgtc2VsZWN0aW9uLmh0bWw6IEFkZGVkLgorCiAyMDExLTEwLTAzICBTaGlueWEgS2F3YW5h a2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CiAKICAgICAgICAgU2hvdWxkIGNhbGwgY2hlY2tUZXh0 T2ZQYXJhZ3JhcGgoKSBpbmRpcmVjdGx5IHRvIG1ha2UgdW5pZnlpbmcgc3BlbGwtY2hlY2tpbmcg Y29kZSBwYXRoIGVhc3kuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0 aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0 aW9uLmNwcAkocmV2aXNpb24gOTUzODkpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1l U2VsZWN0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIwLDcgKzIyMCw3IEBAIHZvaWQgRnJh bWVTZWxlY3Rpb246OnNldFNlbGVjdGlvbihjb25zdCAKICAgICBtX3NlbGVjdGlvbiA9IHM7CiAg ICAgc2V0Q2FyZXRSZWN0TmVlZHNVcGRhdGUoKTsKICAgICAKLSAgICBpZiAoIXMuaXNOb25lKCkp CisgICAgaWYgKCFzLmlzTm9uZSgpICYmICEob3B0aW9ucyAmIERvTm90U2V0Rm9jdXMpKQogICAg ICAgICBzZXRGb2N1c2VkTm9kZUlmTmVlZGVkKCk7CiAgICAgCiAgICAgdXBkYXRlQXBwZWFyYW5j ZSgpOwpAQCAtMzI2LDcgKzMyNiw3IEBAIHZvaWQgRnJhbWVTZWxlY3Rpb246OnJlc3BvbmRUb05v ZGVNb2RpZmkKICAgICAgICAgY2xlYXJSZW5kZXJWaWV3U2VsZWN0aW9uKG1fc2VsZWN0aW9uLnN0 YXJ0KCkpOwogCiAgICAgaWYgKGNsZWFyRE9NVHJlZVNlbGVjdGlvbikKLSAgICAgICAgc2V0U2Vs ZWN0aW9uKFZpc2libGVTZWxlY3Rpb24oKSwgMCk7CisgICAgICAgIHNldFNlbGVjdGlvbihWaXNp YmxlU2VsZWN0aW9uKCksIERvTm90U2V0Rm9jdXMpOwogfQogCiBlbnVtIEVuZFBvaW50VHlwZSB7 IEVuZFBvaW50SXNTdGFydCwgRW5kUG9pbnRJc0VuZCB9OwpAQCAtMzc3LDcgKzM3Nyw3IEBAIHZv aWQgRnJhbWVTZWxlY3Rpb246OnRleHRXaWxsQmVSZXBsYWNlZCgKICAgICAgICAgICAgICAgICBu ZXdTZWxlY3Rpb24uc2V0V2l0aG91dFZhbGlkYXRpb24oZW5kLCBzdGFydCk7CiAgICAgICAgIH0K ICAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+dXBkYXRlTGF5b3V0KCk7Ci0gICAgICAgIHNl dFNlbGVjdGlvbihuZXdTZWxlY3Rpb24sIDApOworICAgICAgICBzZXRTZWxlY3Rpb24obmV3U2Vs ZWN0aW9uLCBEb05vdFNldEZvY3VzKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIApJbmRleDog U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uaAkocmV2aXNpb24gOTUzODkpCisr KyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmgJKHdvcmtpbmcgY29weSkK QEAgLTExNSw2ICsxMTUsNyBAQCBwdWJsaWM6CiAgICAgICAgIENsb3NlVHlwaW5nID0gMSA8PCAx LAogICAgICAgICBDbGVhclR5cGluZ1N0eWxlID0gMSA8PCAyLAogICAgICAgICBTcGVsbENvcnJl Y3Rpb25UcmlnZ2VyZWQgPSAxIDw8IDMsCisgICAgICAgIERvTm90U2V0Rm9jdXMgPSAxIDw8IDQs CiAgICAgfTsKICAgICB0eXBlZGVmIHVuc2lnbmVkIFNldFNlbGVjdGlvbk9wdGlvbnM7IC8vIFVu aW9uIG9mIHZhbHVlcyBpbiBTZXRTZWxlY3Rpb25PcHRpb24gYW5kIEVVc2VyVHJpZ2dlcmVkCiAg ICAgc3RhdGljIGlubGluZSBFVXNlclRyaWdnZXJlZCBzZWxlY3Rpb25PcHRpb25zVG9Vc2VyVHJp Z2dlcmVkKFNldFNlbGVjdGlvbk9wdGlvbnMgb3B0aW9ucykKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L21hbnVhbC10ZXN0cy9tdXRhdGUtdW5mb2N1c2VkLXRleHQtd2l0aC1zZWxlY3Rpb24uaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvbXV0YXRlLXVuZm9jdXNl ZC10ZXh0LXdpdGgtc2VsZWN0aW9uLmh0bWwJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvV2ViQ29y ZS9tYW51YWwtdGVzdHMvbXV0YXRlLXVuZm9jdXNlZC10ZXh0LXdpdGgtc2VsZWN0aW9uLmh0bWwJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjQgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8 Ym9keT4KKzxwPlRoaXMgdGVzdHMgbW9kaWZ5aW5nIGEgdGV4dCBub2RlIHdpdGggc2VsZWN0aW9u IGJ1dCB3aXRob3V0IGEgZm9jdXMuCitXZWJLaXQgdXNlZCB0byBhdXRvbWF0aWNhbGx5IHNldCB0 aGUgZm9jdXMgdG8gdGhlIHJvb3QgZWRpdGFibGUgZWxlbWVudCBvZiB0aGlzIG5vZGUgYnV0IGl0 IHNob3VsZCBub3QuCitZb3Ugc2hvdWxkIHNlZSAnUEFTUycgYmVsb3c6PC9wPgorPGRpdiBpZD0i dGFyZ2V0IiBvbmZvY3VzPSJ0YXJnZXQuaW5uZXJUZXh0PSdGQUlMJyIgY29udGVudGVkaXRhYmxl PmhlbGxvPC9kaXY+Cis8ZGl2IGlkPSJmb2N1c2VkIiBjb250ZW50ZWRpdGFibGU+d29ybGQ8L2Rp dj4KKzxzY3JpcHQ+CisKK3ZhciB0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGFy Z2V0Jyk7Cit2YXIgZm9jdXNlZCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmb2N1c2VkJyk7 Citmb2N1c2VkLmZvY3VzKCk7CitnZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50KHRhcmdl dC5maXJzdENoaWxkLCAxLCB0YXJnZXQuZmlyc3RDaGlsZCwgMyk7CisKKy8vIFRoZSBidWcgZG9l c24ndCByZXByb2R1Y2UgaWYgdGhpcyBmdW5jdGlvbiB3YXMgcmFuIGhlcmUgb3IgaW5zaWRlIGxv YWQgZXZlbnQgaGFuZGxlcgorc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICB0YXJnZXQuZmly c3RDaGlsZC5kYXRhID0gJ1BBU1MnOworICAgIGFsZXJ0KCdhY3RpdmVFbGVtZW50OicgKyBkb2N1 bWVudC5hY3RpdmVFbGVtZW50LmlkKTsgLy8gbmVjZXNzYXJ5IHRvIHJlcHJvZHVjZSB0aGUgYnVn Cit9LCA1MCk7CisKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=