69301 2011-10-03 15:53:35 -0700 [Chromium] WebFileChooserParams needs a value to specify a "Save As" dialog. 2011-10-07 00:03:57 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 bbudge webkit-unassigned darin fishd webkit.review.bot oldest_to_newest 477306 0 bbudge 2011-10-03 15:53:35 -0700 Adds a field, "saving", to present the file chooser dialog in "Save As" mode (allows the user to choose a possibly non-existent file or directory). 477307 1 109544 bbudge 2011-10-03 15:58:36 -0700 Created attachment 109544 Proposed Patch This is used by PPB_FileChooser_Impl to specify the dialog's mode. So to implement 'SaveAs' we'll need this change. 478933 2 109544 fishd 2011-10-05 21:40:22 -0700 Comment on attachment 109544 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109544&action=review > Source/WebKit/chromium/public/WebFileChooserParams.h:47 > + bool saving; I struggle a bit with the wording here. I considered suggesting "saveAs". Then at least you could say "saveAs" chooser, just as you can say "multiSelect" chooser or "directory" chooser. I'm not sure though. I feel like the properties here should either describe the dialog or the resulting file(s). The other existing property names are not so great. I can imagine something like {return,select,choose}{Multiple,Directory,Writable} might be nice. Those would very clearly describe the file(s) being returned. Anyways, maybe that's just fodder for a future patch as changes like that would be pretty out-of-scope for what you are trying to do now. I think there are still some details to work out about what it means to return a writable file as a result of presenting a "save as" dialog. 479269 3 109975 bbudge 2011-10-06 10:38:57 -0700 Created attachment 109975 Proposed Patch My first thought was to name it 'saveAs' and probably that's better. My second thought was that 'saving' was a little prettier. I've changed it back to 'saveAs' and also fixed the license and a few other comments as well. 479273 4 webkit.review.bot 2011-10-06 10:46:25 -0700 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 479301 5 109975 webkit.review.bot 2011-10-06 11:15:13 -0700 Comment on attachment 109975 Proposed Patch Rejecting attachment 109975 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: f4972aa6d2bdb3722a5d9e3757eb399c682deaa9 r96835 = fcda564b0a1d32358131790ee6e3524adb70b465 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9976287 479500 6 110027 bbudge 2011-10-06 14:41:28 -0700 Created attachment 110027 Proposed Patch Sorry Darin, I'm juggling 2 patches and missed the ChangeLog. I need to learn git. 479839 7 110027 webkit.review.bot 2011-10-07 00:03:52 -0700 Comment on attachment 110027 Proposed Patch Clearing flags on attachment: 110027 Committed r96910: <http://trac.webkit.org/changeset/96910> 479840 8 webkit.review.bot 2011-10-07 00:03:57 -0700 All reviewed patches have been landed. Closing bug. 109544 2011-10-03 15:58:36 -0700 2011-10-06 10:38:57 -0700 Proposed Patch aab.txt text/plain 1955 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5NjU1MCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMDMgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIEFkZHMgYSBmaWVsZCwgInNhdmluZyIsIHRvIFdlYkZpbGVDaG9vc2VyUGFyYW1zIHRvIHBy ZXNlbnQgdGhlIGZpbGUgY2hvb3NlcgorICAgICAgICBkaWFsb2cgaW4gIlNhdmUgQXMiIG1vZGUg KGFsbG93cyB0aGUgdXNlciB0byBjaG9vc2UgYSBwb3NzaWJseSBub24tZXhpc3RlbnQgZmlsZQor ICAgICAgICBvciBkaXJlY3RvcnkpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjkzMDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHB1YmxpYy9XZWJGaWxlQ2hvb3NlclBhcmFtcy5oOgorICAgICAgICAo V2ViS2l0OjpXZWJGaWxlQ2hvb3NlclBhcmFtczo6V2ViRmlsZUNob29zZXJQYXJhbXMpOgorCiAy MDExLTEwLTAzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVtb3ZlIGN1c3RvbSBzY3JvbGxiYXIgcGFpbnRpbmcgaG9va3MKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZpbGVDaG9vc2VyUGFyYW1zLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRmlsZUNob29zZXJQYXJhbXMuaAko cmV2aXNpb24gOTYxNzIpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGaWxl Q2hvb3NlclBhcmFtcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOCwxMCArMzgsMTMgQEAKIG5hbWVz cGFjZSBXZWJLaXQgewogCiBzdHJ1Y3QgV2ViRmlsZUNob29zZXJQYXJhbXMgewotICAgIC8vIElm IHxtdWx0aVNlbGVjdHwgaXMgdHJ1ZSwgdGhlIGRpYWxvZyBhbGxvdyB0byBzZWxlY3QgbXVsdGlw bGUgZmlsZXMuCisgICAgLy8gSWYgfG11bHRpU2VsZWN0fCBpcyB0cnVlLCB0aGUgZGlhbG9nIGFs bG93cyB0aGUgdXNlciB0byBzZWxlY3QgbXVsdGlwbGUgZmlsZXMuCiAgICAgYm9vbCBtdWx0aVNl bGVjdDsKICAgICAvLyBJZiB8ZGlyZWN0b3J5fCBpcyB0cnVlLCB0aGUgZGlhbG9nIGFsbG93cyB0 aGUgdXNlciB0byBzZWxlY3QgYSBkaXJlY3RvcnkuCiAgICAgYm9vbCBkaXJlY3Rvcnk7CisgICAg Ly8gSWYgfHNhdmluZ3wgaXMgdHJ1ZSwgdGhlIGRpYWxvZyBhbGxvd3MgdGhlIHVzZXIgdG8gc2Vs ZWN0IGEgcG9zc2libHkKKyAgICAvLyBub24tZXhpc3RlbnQgZmlsZSBvciBkaXJlY3RvcnkuIFRo aXMgY2FuIGJlIHVzZWQgZm9yIGEgIlNhdmUgQXMiIGRpYWxvZy4KKyAgICBib29sIHNhdmluZzsK ICAgICAvLyB8dGl0bGV8IGlzIGEgdGl0bGUgb2YgYSBmaWxlIGNob29zZXIgZGlhbG9nLiBJdCBj YW4gYmUgYW4gZW1wdHkgc3RyaW5nLgogICAgIFdlYlN0cmluZyB0aXRsZTsKICAgICAvLyB8aW5p dGlhbFZhbHVlfCBpcyBhIGZpbGVuYW1lIHdoaWNoIHRoZSBkaWFsb2cgc2hvdWxkIHNlbGVjdCBi eSBkZWZhdWx0LgpAQCAtNjMsNiArNjYsNyBAQCBzdHJ1Y3QgV2ViRmlsZUNob29zZXJQYXJhbXMg ewogICAgIFdlYkZpbGVDaG9vc2VyUGFyYW1zKCkKICAgICAgICAgOiBtdWx0aVNlbGVjdChmYWxz ZSkKICAgICAgICAgLCBkaXJlY3RvcnkoZmFsc2UpCisgICAgICAgICwgc2F2aW5nKGZhbHNlKQog ICAgIHsKICAgICB9CiB9Owo= 109975 2011-10-06 10:38:57 -0700 2011-10-06 14:41:28 -0700 Proposed Patch aab.txt text/plain 2367 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZpbGVDaG9vc2VyUGFyYW1z LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRmlsZUNo b29zZXJQYXJhbXMuaAkocmV2aXNpb24gOTY3NjApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJGaWxlQ2hvb3NlclBhcmFtcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEs NSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEwLCAyMDExIEdvb2dsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5k IGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJt aXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCkBAIC0zOCwy MSArMzgsMjQgQEAKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBzdHJ1Y3QgV2ViRmlsZUNob29zZXJQ YXJhbXMgewotICAgIC8vIElmIHxtdWx0aVNlbGVjdHwgaXMgdHJ1ZSwgdGhlIGRpYWxvZyBhbGxv dyB0byBzZWxlY3QgbXVsdGlwbGUgZmlsZXMuCisgICAgLy8gSWYgfG11bHRpU2VsZWN0fCBpcyB0 cnVlLCB0aGUgZGlhbG9nIGFsbG93cyB0aGUgdXNlciB0byBzZWxlY3QgbXVsdGlwbGUgZmlsZXMu CiAgICAgYm9vbCBtdWx0aVNlbGVjdDsKICAgICAvLyBJZiB8ZGlyZWN0b3J5fCBpcyB0cnVlLCB0 aGUgZGlhbG9nIGFsbG93cyB0aGUgdXNlciB0byBzZWxlY3QgYSBkaXJlY3RvcnkuCiAgICAgYm9v bCBkaXJlY3Rvcnk7Ci0gICAgLy8gfHRpdGxlfCBpcyBhIHRpdGxlIG9mIGEgZmlsZSBjaG9vc2Vy IGRpYWxvZy4gSXQgY2FuIGJlIGFuIGVtcHR5IHN0cmluZy4KKyAgICAvLyBJZiB8c2F2ZUFzfCBp cyB0cnVlLCB0aGUgZGlhbG9nIGFsbG93cyB0aGUgdXNlciB0byBzZWxlY3QgYSBwb3NzaWJseQor ICAgIC8vIG5vbi1leGlzdGVudCBmaWxlLiBUaGlzIGNhbiBiZSB1c2VkIGZvciBhICJTYXZlIEFz IiBkaWFsb2cuCisgICAgYm9vbCBzYXZlQXM7CisgICAgLy8gfHRpdGxlfCBpcyB0aGUgdGl0bGUg Zm9yIGEgZmlsZSBjaG9vc2VyIGRpYWxvZy4gSXQgY2FuIGJlIGFuIGVtcHR5IHN0cmluZy4KICAg ICBXZWJTdHJpbmcgdGl0bGU7CiAgICAgLy8gfGluaXRpYWxWYWx1ZXwgaXMgYSBmaWxlbmFtZSB3 aGljaCB0aGUgZGlhbG9nIHNob3VsZCBzZWxlY3QgYnkgZGVmYXVsdC4KICAgICAvLyBJdCBjYW4g YmUgYW4gZW1wdHkgc3RyaW5nLgogICAgIFdlYlN0cmluZyBpbml0aWFsVmFsdWU7CiAgICAgLy8g fGFjY2VwdFR5cGVzfCBoYXMgYSBjb21tYS1zZXBhcmF0ZWQgTUlNRSB0eXBlcyBzdWNoIGFzICJh dWRpby8qLHRleHQvcGxhaW4iLgogICAgIC8vIFRoZSBkaWFsb2cgbWF5IHJlc3RyaWN0IHNlbGVj dGFibGUgZmlsZXMgdG8gdGhlIHNwZWNpZmllZCBNSU1FIHR5cGVzLgotICAgIC8vIFRoaXMgdmFs dWUgY29tZXMgZnJvbSBhbiAnYWNjZXB0JyBhdHRyaWJ1dGUgdmFsdWUgb2YgYW4gSU5QVVQgZWxl bWVudC4KLSAgICAvLyBTbyBpdCBtaWdodCBiZSBhIHdyb25nIGZvcm1hdHRlZCBzdHJpbmcuCisg ICAgLy8gVGhpcyB2YWx1ZSBjb21lcyBmcm9tIGFuICdhY2NlcHQnIGF0dHJpYnV0ZSB2YWx1ZSBv ZiBhbiBJTlBVVCBlbGVtZW50LCBzbyBpdAorICAgIC8vIG1pZ2h0IGJlIGFuIGluY29ycmVjdGx5 IGZvcm1hdHRlZCBzdHJpbmcuCiAgICAgV2ViU3RyaW5nIGFjY2VwdFR5cGVzOwotICAgIC8vIHxz ZWxlY3RlZEZpbGVzfCBoYXMgZmlsZW5hbWVzIHdoaWNoIGEgZmlsZSB1cGxvYWQgY29udHJvbCBh bHJlYWR5IHNlbGVjdC4KKyAgICAvLyB8c2VsZWN0ZWRGaWxlc3wgaGFzIGZpbGVuYW1lcyB3aGlj aCBhIGZpbGUgdXBsb2FkIGNvbnRyb2wgYWxyZWFkeSBzZWxlY3RlZC4KICAgICAvLyBBIFdlYlZp ZXdDbGllbnQgaW1wbGVtZW50YXRpb24gbWF5IGFzayBhIHVzZXIgdG8gc2VsZWN0CiAgICAgLy8g IC0gcmVtb3ZpbmcgYSBmaWxlIGZyb20gdGhlIHNlbGVjdGVkIGZpbGVzLAogICAgIC8vICAtIGFw cGVuZGluZyBvdGhlciBmaWxlcywgb3IKQEAgLTYzLDYgKzY2LDcgQEAgc3RydWN0IFdlYkZpbGVD aG9vc2VyUGFyYW1zIHsKICAgICBXZWJGaWxlQ2hvb3NlclBhcmFtcygpCiAgICAgICAgIDogbXVs dGlTZWxlY3QoZmFsc2UpCiAgICAgICAgICwgZGlyZWN0b3J5KGZhbHNlKQorICAgICAgICAsIHNh dmVBcyhmYWxzZSkKICAgICB7CiAgICAgfQogfTsK 110027 2011-10-06 14:41:28 -0700 2011-10-07 00:03:52 -0700 Proposed Patch aab.txt text/plain 3146 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5Njg1OSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMDYgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIEFkZHMgYSBmaWVsZCwgInNhdmVBcyIsIHRvIFdlYkZpbGVDaG9vc2VyUGFyYW1zIHRvIHBy ZXNlbnQgdGhlIGZpbGUgY2hvb3NlcgorICAgICAgICBkaWFsb2cgaW4gIlNhdmUgQXMiIG1vZGUg KGFsbG93cyB0aGUgdXNlciB0byBjaG9vc2UgYSBwb3NzaWJseSBub24tZXhpc3RlbnQgZmlsZQor ICAgICAgICBmb3Igc2F2aW5nKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY5MzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwdWJsaWMvV2ViRmlsZUNob29zZXJQYXJhbXMuaDoKKyAgICAgICAgKFdl YktpdDo6V2ViRmlsZUNob29zZXJQYXJhbXM6OldlYkZpbGVDaG9vc2VyUGFyYW1zKToKKwogMjAx MS0xMC0wNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjk2NzkxLgpJbmRleDogU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViRmlsZUNob29zZXJQYXJhbXMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGaWxlQ2hvb3NlclBhcmFtcy5oCShyZXZp c2lvbiA5Njc2MCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZpbGVDaG9v c2VyUGFyYW1zLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJp Z2h0IChDKSAyMDEwIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmln aHQgKEMpIDIwMTAsIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAg KiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRo IG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0 IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTM4LDIxICszOCwyNCBAQAogbmFtZXNw YWNlIFdlYktpdCB7CiAKIHN0cnVjdCBXZWJGaWxlQ2hvb3NlclBhcmFtcyB7Ci0gICAgLy8gSWYg fG11bHRpU2VsZWN0fCBpcyB0cnVlLCB0aGUgZGlhbG9nIGFsbG93IHRvIHNlbGVjdCBtdWx0aXBs ZSBmaWxlcy4KKyAgICAvLyBJZiB8bXVsdGlTZWxlY3R8IGlzIHRydWUsIHRoZSBkaWFsb2cgYWxs b3dzIHRoZSB1c2VyIHRvIHNlbGVjdCBtdWx0aXBsZSBmaWxlcy4KICAgICBib29sIG11bHRpU2Vs ZWN0OwogICAgIC8vIElmIHxkaXJlY3Rvcnl8IGlzIHRydWUsIHRoZSBkaWFsb2cgYWxsb3dzIHRo ZSB1c2VyIHRvIHNlbGVjdCBhIGRpcmVjdG9yeS4KICAgICBib29sIGRpcmVjdG9yeTsKLSAgICAv LyB8dGl0bGV8IGlzIGEgdGl0bGUgb2YgYSBmaWxlIGNob29zZXIgZGlhbG9nLiBJdCBjYW4gYmUg YW4gZW1wdHkgc3RyaW5nLgorICAgIC8vIElmIHxzYXZlQXN8IGlzIHRydWUsIHRoZSBkaWFsb2cg YWxsb3dzIHRoZSB1c2VyIHRvIHNlbGVjdCBhIHBvc3NpYmx5CisgICAgLy8gbm9uLWV4aXN0ZW50 IGZpbGUuIFRoaXMgY2FuIGJlIHVzZWQgZm9yIGEgIlNhdmUgQXMiIGRpYWxvZy4KKyAgICBib29s IHNhdmVBczsKKyAgICAvLyB8dGl0bGV8IGlzIHRoZSB0aXRsZSBmb3IgYSBmaWxlIGNob29zZXIg ZGlhbG9nLiBJdCBjYW4gYmUgYW4gZW1wdHkgc3RyaW5nLgogICAgIFdlYlN0cmluZyB0aXRsZTsK ICAgICAvLyB8aW5pdGlhbFZhbHVlfCBpcyBhIGZpbGVuYW1lIHdoaWNoIHRoZSBkaWFsb2cgc2hv dWxkIHNlbGVjdCBieSBkZWZhdWx0LgogICAgIC8vIEl0IGNhbiBiZSBhbiBlbXB0eSBzdHJpbmcu CiAgICAgV2ViU3RyaW5nIGluaXRpYWxWYWx1ZTsKICAgICAvLyB8YWNjZXB0VHlwZXN8IGhhcyBh IGNvbW1hLXNlcGFyYXRlZCBNSU1FIHR5cGVzIHN1Y2ggYXMgImF1ZGlvLyosdGV4dC9wbGFpbiIu CiAgICAgLy8gVGhlIGRpYWxvZyBtYXkgcmVzdHJpY3Qgc2VsZWN0YWJsZSBmaWxlcyB0byB0aGUg c3BlY2lmaWVkIE1JTUUgdHlwZXMuCi0gICAgLy8gVGhpcyB2YWx1ZSBjb21lcyBmcm9tIGFuICdh Y2NlcHQnIGF0dHJpYnV0ZSB2YWx1ZSBvZiBhbiBJTlBVVCBlbGVtZW50LgotICAgIC8vIFNvIGl0 IG1pZ2h0IGJlIGEgd3JvbmcgZm9ybWF0dGVkIHN0cmluZy4KKyAgICAvLyBUaGlzIHZhbHVlIGNv bWVzIGZyb20gYW4gJ2FjY2VwdCcgYXR0cmlidXRlIHZhbHVlIG9mIGFuIElOUFVUIGVsZW1lbnQs IHNvIGl0CisgICAgLy8gbWlnaHQgYmUgYW4gaW5jb3JyZWN0bHkgZm9ybWF0dGVkIHN0cmluZy4K ICAgICBXZWJTdHJpbmcgYWNjZXB0VHlwZXM7Ci0gICAgLy8gfHNlbGVjdGVkRmlsZXN8IGhhcyBm aWxlbmFtZXMgd2hpY2ggYSBmaWxlIHVwbG9hZCBjb250cm9sIGFscmVhZHkgc2VsZWN0LgorICAg IC8vIHxzZWxlY3RlZEZpbGVzfCBoYXMgZmlsZW5hbWVzIHdoaWNoIGEgZmlsZSB1cGxvYWQgY29u dHJvbCBhbHJlYWR5IHNlbGVjdGVkLgogICAgIC8vIEEgV2ViVmlld0NsaWVudCBpbXBsZW1lbnRh dGlvbiBtYXkgYXNrIGEgdXNlciB0byBzZWxlY3QKICAgICAvLyAgLSByZW1vdmluZyBhIGZpbGUg ZnJvbSB0aGUgc2VsZWN0ZWQgZmlsZXMsCiAgICAgLy8gIC0gYXBwZW5kaW5nIG90aGVyIGZpbGVz LCBvcgpAQCAtNjMsNiArNjYsNyBAQCBzdHJ1Y3QgV2ViRmlsZUNob29zZXJQYXJhbXMgewogICAg IFdlYkZpbGVDaG9vc2VyUGFyYW1zKCkKICAgICAgICAgOiBtdWx0aVNlbGVjdChmYWxzZSkKICAg ICAgICAgLCBkaXJlY3RvcnkoZmFsc2UpCisgICAgICAgICwgc2F2ZUFzKGZhbHNlKQogICAgIHsK ICAgICB9CiB9Owo=