69300 2011-10-03 15:40:18 -0700 [Chromium] Remove setShouldPaintCustomScrollbars, which has no callers 2011-10-07 09:34:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth andersca dglazkov fishd webkit.review.bot oldest_to_newest 477296 0 abarth 2011-10-03 15:40:18 -0700 Remove setShouldPaintCustomScrollbars, which has no callers 477297 1 109542 abarth 2011-10-03 15:41:04 -0700 Created attachment 109542 Patch 477321 2 109542 webkit.review.bot 2011-10-03 16:19:42 -0700 Comment on attachment 109542 Patch Attachment 109542 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9944040 477322 3 abarth 2011-10-03 16:20:50 -0700 Looks like this function does have at least one caller: Source/WebKit/chromium/webkit/glue/webpreferences.cc: In member function 'void WebPreferences::Apply(WebKit::WebView*) const': Source/WebKit/chromium/webkit/glue/webpreferences.cc:217: error: 'class WebKit::WebSettings' has no member named 'setShouldPaintCustomScrollbars' 477324 4 abarth 2011-10-03 16:21:41 -0700 Despite appearances, that function is actually located here: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?view=markup 477328 5 abarth 2011-10-03 16:27:06 -0700 abarth: andersca: does the setShouldPaintCustomScrollbars now have the behavior of being true or false? andersca_: abarth|gardener: false abarth|gardener: that seems problematic because http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?view=markup sets it to true andersca_: abarth|gardener: custom scrollbars really meant "should delegate painting scrollbars to the client" abarth|gardener: // Turn this on to cause WebCore to paint the resize corner for us. abarth|gardener: settings->setShouldPaintCustomScrollbars(true); andersca_: abarth|gardener: you should be able to remove that - the resize corner will be painted anyway abarth|gardener: sounds like the author of that code was confused andersca_: yup abarth|gardener: okiedokes 477331 6 abarth 2011-10-03 16:29:26 -0700 Removing the callers is http://codereview.chromium.org/8122010/ 480073 7 109542 webkit.review.bot 2011-10-07 09:34:36 -0700 Comment on attachment 109542 Patch Clearing flags on attachment: 109542 Committed r96946: <http://trac.webkit.org/changeset/96946> 480074 8 webkit.review.bot 2011-10-07 09:34:40 -0700 All reviewed patches have been landed. Closing bug. 109542 2011-10-03 15:41:04 -0700 2011-10-07 09:34:36 -0700 Patch bug-69300-20111003154102.patch text/plain 2789 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5NjU1MCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMTAtMDMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZW1vdmUgc2V0U2hvdWxkUGFpbnRDdXN0b21TY3JvbGxiYXJzLCB3aGljaCBoYXMgbm8gY2Fs bGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njkz MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbmRl cnMgdGVsbHMgbWUgdGhpcyBmdW5jdGlvbiBubyBsb25nZXIgaGFzIGFueSBjYWxsZXJzLiAgV2Ug c2hvdWxkCisgICAgICAgIHJlbW92ZSBpdCBiZWZvcmUgaXQgZ3Jvd3MgYW55IQorCisgICAgICAg ICogcHVibGljL1dlYlNldHRpbmdzLmg6CisgICAgICAgICogc3JjL1dlYlNldHRpbmdzSW1wbC5j cHA6CisgICAgICAgICogc3JjL1dlYlNldHRpbmdzSW1wbC5oOgorCiAyMDExLTEwLTAzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGN1c3Rv bSBzY3JvbGxiYXIgcGFpbnRpbmcgaG9va3MKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYlNldHRpbmdzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViU2V0dGluZ3MuaAkocmV2aXNpb24gOTY1NTApCisrKyBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oCSh3b3JraW5nIGNvcHkpCkBAIC04OCw3ICs4 OCw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0RWRpdGFibGVMaW5rQmVoYXZpb3JO ZXZlckxpdmUoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldEZyYW1lRmxhdHRlbmluZ0VuYWJs ZWQoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRGb250UmVuZGVyaW5nTW9kZU5vcm1h bCgpID0gMDsKLSAgICB2aXJ0dWFsIHZvaWQgc2V0U2hvdWxkUGFpbnRDdXN0b21TY3JvbGxiYXJz KGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0QWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9t RmlsZVVSTHMoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRBbGxvd0ZpbGVBY2Nlc3NG cm9tRmlsZVVSTHMoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRUZXh0RGlyZWN0aW9u U3VibWVudUluY2x1c2lvbkJlaGF2aW9yTmV2ZXJJbmNsdWRlZCgpID0gMDsKSW5kZXg6IFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAkocmV2aXNpb24g OTY1NTApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yNDUsMTEgKzI0NSw2IEBAIHZvaWQgV2ViU2V0dGluZ3NJbXBs OjpzZXRGb250UmVuZGVyaW5nTW8KICAgICBtX3NldHRpbmdzLT5zZXRGb250UmVuZGVyaW5nTW9k ZShXZWJDb3JlOjpOb3JtYWxSZW5kZXJpbmdNb2RlKTsKIH0KIAotdm9pZCBXZWJTZXR0aW5nc0lt cGw6OnNldFNob3VsZFBhaW50Q3VzdG9tU2Nyb2xsYmFycyhib29sIGVuYWJsZWQpCi17Ci0gICAg Ly8gRklYTUU6IFRoaXMgc2hvdWxkIGJlIHJlbW92ZWQuCi19Ci0KIHZvaWQgV2ViU2V0dGluZ3NJ bXBsOjpzZXRBbGxvd1VuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJMcyhib29sIGFsbG93KQogewog ICAgIG1fc2V0dGluZ3MtPnNldEFsbG93VW5pdmVyc2FsQWNjZXNzRnJvbUZpbGVVUkxzKGFsbG93 KTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5o CShyZXZpc2lvbiA5NjU1MCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRp bmdzSW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC04MCw3ICs4MCw2IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIHZvaWQgc2V0RWRpdGFibGVMaW5rQmVoYXZpb3JOZXZlckxpdmUoKTsKICAgICB2aXJ0 dWFsIHZvaWQgc2V0RnJhbWVGbGF0dGVuaW5nRW5hYmxlZChib29sKTsKICAgICB2aXJ0dWFsIHZv aWQgc2V0Rm9udFJlbmRlcmluZ01vZGVOb3JtYWwoKTsKLSAgICB2aXJ0dWFsIHZvaWQgc2V0U2hv dWxkUGFpbnRDdXN0b21TY3JvbGxiYXJzKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRBbGxv d1VuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJMcyhib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0 QWxsb3dGaWxlQWNjZXNzRnJvbUZpbGVVUkxzKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRU ZXh0RGlyZWN0aW9uU3VibWVudUluY2x1c2lvbkJlaGF2aW9yTmV2ZXJJbmNsdWRlZCgpOwo=