69288 2011-10-03 13:34:46 -0700 watchlist: Allow specified a bug to attach the watchlist info to. 2011-10-03 14:44:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68822 68974 1 levin levin abarth eric oldest_to_newest 477200 0 levin 2011-10-03 13:34:46 -0700 This is for the apply-watchlist-local command which is what the bot will use since the patch will already be downloaded. 477205 1 109521 levin 2011-10-03 13:38:42 -0700 Created attachment 109521 Patch 477210 2 109521 eric 2011-10-03 13:44:01 -0700 Comment on attachment 109521 Patch OK. 477233 3 109521 abarth 2011-10-03 14:12:20 -0700 Comment on attachment 109521 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109521&action=review > Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal.py:45 > + if len(args) > 1: > + raise Exception("Too many arguments given: %s" % (' '.join(args))) The Command infrastructure should do most of this work for you by parsing argument_names > Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal.py:47 > + if not args: > + return {} Should we try to get the bug information from the ChangeLog if it's not given on the command line? There's a bunch of infrastructure for doing that. 477252 4 levin 2011-10-03 14:44:41 -0700 Committed as http://trac.webkit.org/changeset/96540 (In reply to comment #3) > (From update of attachment 109521 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109521&action=review > > > Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal.py:45 > > + if len(args) > 1: > > + raise Exception("Too many arguments given: %s" % (' '.join(args))) > > The Command infrastructure should do most of this work for you by parsing argument_names It looks like it only handles required arguments but BUGID is an optional argument. > > > Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal.py:47 > > + if not args: > > + return {} > > Should we try to get the bug information from the ChangeLog if it's not given on the command line? There's a bunch of infrastructure for doing that. Yeah, I saw a lot of commands that do this. I feel like actually putting the results on a bug is the rare case that only the bot will use but other folks will use this for trying out local changes to the watchlist, so I'd rather only but the results on a bug if the given is given explicitly. 109521 2011-10-03 13:38:42 -0700 2011-10-03 14:12:20 -0700 Patch bug-69288-20111003133841.patch text/plain 5597 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTY1MjIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0YTVjMjAyYjY2ZTU4ZTY4MGMwOGI4MzZmMDNhMzQ4MjJj OTZhZjcxLi4zZWI5MjgyYTBkMDM3YWI5OGZlM2YxNDBhNjQyNzkwZTdlNjY4ZGFjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMTAtMDMgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIHdhdGNobGlzdDogQWxsb3cgc3BlY2lmaWVkIGEgYnVnIHRvIGF0dGFjaCB0aGUgd2F0Y2hs aXN0IGluZm8gdG8uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02OTI4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2FwcGx5d2F0Y2hsaXN0bG9jYWwu cHk6IEFkZCBzdXBwb3J0IGZvciBidWdpZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rv b2wvY29tbWFuZHMvYXBwbHl3YXRjaGxpc3Rsb2NhbF91bml0dGVzdC5weToKKyAgICAgICAgQWRk IHRlc3RzIGFuZCBmaXggYW4gZXhpc3RpbmcgdGVzdCBiZWNhdXNlIHRoZSB1bml0IHRlc3RzIGRv IG5vdCBnbyB0aHJvdWdoIHRoZQorICAgICAgICBub3JtYWwgY29tbWFuZCBsaW5lIHByb2Nlc3Np bmcgKHNvIHRoZSAtZyBhcmd1bWVudCByZW1haW5lZCB3aGVuIHdlIGRldGVybWluZWQgYnVnIGlk cykuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2NvbW1hbmR0ZXN0 LnB5OiBDaGFuZ2UgdGhlIGRlcml2YXRpb24gdG8KKyAgICAgICAgZ2V0IHRoZSBhc3NlcnQgcmFp c2VzIHJlZ2V4IG1ldGhvZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvZG93bmxvYWQucHk6IEZpeCB0aGUgY29tbWFuZCBoZWxwIHRvIGJlIG1vcmUgdW5peHkuCisK IDIwMTEtMTAtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHVEtdIEZpeCBtZW1vcnkgbGVhayB3aGVuIGxvYWRpbmcgdXJsCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvYXBwbHl3YXRjaGxpc3Rs b2NhbC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9hcHBseXdhdGNo bGlzdGxvY2FsLnB5CmluZGV4IGE2NTZhYjNhNWE3OTI3YmY0Yjg3MWMyYThiM2ZhZGIwZmRkNzFh NjYuLjY3MzVkNDg0MmJkMDI4YjFlNzZmYTQzZDBlNGUyNmVmNDU3NmIxN2IgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9hcHBseXdhdGNobGlzdGxvY2Fs LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9hcHBseXdhdGNo bGlzdGxvY2FsLnB5CkBAIC0zMiw5ICszMiwxOSBAQCBmcm9tIHdlYmtpdHB5LnRvb2wgaW1wb3J0 IHN0ZXBzCiAKIGNsYXNzIEFwcGx5V2F0Y2hMaXN0TG9jYWwoQWJzdHJhY3RTZXF1ZW5jZWRDb21t YW5kKToKICAgICBuYW1lID0gImFwcGx5LXdhdGNobGlzdC1sb2NhbCIKLSAgICBoZWxwX3RleHQg PSAiQXBwbGllcyB0aGUgd2F0Y2hsaXN0IHRvIGxvY2FsIGNoYW5nZXMuIgorICAgIGhlbHBfdGV4 dCA9ICJBcHBsaWVzIHRoZSB3YXRjaGxpc3QgdG8gbG9jYWwgY2hhbmdlcyIKKyAgICBhcmd1bWVu dF9uYW1lcyA9ICJbQlVHSURdIgogICAgIHN0ZXBzID0gWwogICAgICAgICBzdGVwcy5BcHBseVdh dGNoTGlzdCwKICAgICBdCiAgICAgbG9uZ19oZWxwID0gIiIiIkFwcGxpZXMgdGhlIHdhdGNobGlz dCB0byBsb2NhbCBjaGFuZ2VzLgotVGhlIHJlc3VsdHMgaXMgbG9nZ2VkIGJ1dCBub3QgYXBwbGll ZCB0byBhbnkgYnVnLiBUaGlzIG1heSBiZSB1c2VkIHRvIHRyeSBvdXQgYSB3YXRjaGxpc3QgY2hh bmdlLiIiIgorVGhlIHJlc3VsdHMgaXMgbG9nZ2VkIGlmIGEgYnVnIGlzIG5vIGdpdmVuLiBUaGlz IG1heSBiZSB1c2VkIHRvIHRyeSBvdXQgYSB3YXRjaGxpc3QgY2hhbmdlLiIiIgorCisgICAgZGVm IF9wcmVwYXJlX3N0YXRlKHNlbGYsIG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgorICAgICAgICBpZiBs ZW4oYXJncykgPiAxOgorICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCJUb28gbWFueSBhcmd1 bWVudHMgZ2l2ZW46ICVzIiAlICgnICcuam9pbihhcmdzKSkpCisgICAgICAgIGlmIG5vdCBhcmdz OgorICAgICAgICAgICAgcmV0dXJuIHt9CisgICAgICAgIHJldHVybiB7CisgICAgICAgICAgICAi YnVnX2lkIjogYXJnc1swXSwKKyAgICAgICAgfQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL2FwcGx5d2F0Y2hsaXN0bG9jYWxfdW5pdHRlc3QucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvYXBwbHl3YXRjaGxpc3Rsb2NhbF91 bml0dGVzdC5weQppbmRleCA5OTViY2Q2YjI5ZTI3ZWIwYjBhYTVkNTVhODg0ZGFkMzAyMTc4NmUz Li4wMmYzMjMwNGZhNDJmMThkZWJhMTMyZGVlNDU1OTU1MTUwMWQyM2ZiIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvYXBwbHl3YXRjaGxpc3Rsb2NhbF91 bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvYXBw bHl3YXRjaGxpc3Rsb2NhbF91bml0dGVzdC5weQpAQCAtMzIsNSArMzIsMTIgQEAgZnJvbSB3ZWJr aXRweS50b29sLmNvbW1hbmRzLmFwcGx5d2F0Y2hsaXN0bG9jYWwgaW1wb3J0IEFwcGx5V2F0Y2hM aXN0TG9jYWwKIAogY2xhc3MgQXBwbHlXYXRjaExpc3RMb2NhbFRlc3QoQ29tbWFuZHNUZXN0KToK ICAgICBkZWYgdGVzdF9hcmdzX3BhcnNpbmcoc2VsZik6Ci0gICAgICAgIGV4cGVjdGVkX3N0ZGVy ciA9ICJNb2NrV2F0Y2hMaXN0OiBkZXRlcm1pbmVfY2NfYW5kX21lc3NhZ2VzXG4iCi0gICAgICAg IHNlbGYuYXNzZXJ0X2V4ZWN1dGVfb3V0cHV0cyhBcHBseVdhdGNoTGlzdExvY2FsKCksIFsiLWcg MmVkNmYiXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKKyAgICAgICAgZXhwZWN0 ZWRfc3RkZXJyID0gJ01vY2tXYXRjaExpc3Q6IGRldGVybWluZV9jY19hbmRfbWVzc2FnZXNcbicK KyAgICAgICAgc2VsZi5hc3NlcnRfZXhlY3V0ZV9vdXRwdXRzKEFwcGx5V2F0Y2hMaXN0TG9jYWwo KSwgWycnXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKKworICAgIGRlZiB0ZXN0 X2FyZ3NfcGFyc2luZ193aXRoX2J1ZyhzZWxmKToKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0g Ik1vY2tXYXRjaExpc3Q6IGRldGVybWluZV9jY19hbmRfbWVzc2FnZXNcbk1PQ0sgYnVnIGNvbW1l bnQ6IGJ1Z19pZD0xMjM0LCBjYz1bJ2xldmluQGNocm9taXVtLm9yZyddXG4tLS0gQmVnaW4gY29t bWVudCAtLS1cbk1lc3NhZ2UxLlxuXG5NZXNzYWdlMi5cbi0tLSBFbmQgY29tbWVudCAtLS1cblxu IgorICAgICAgICBzZWxmLmFzc2VydF9leGVjdXRlX291dHB1dHMoQXBwbHlXYXRjaExpc3RMb2Nh bCgpLCBbJzEyMzQnXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKKworICAgIGRl ZiB0ZXN0X2FyZ3NfcGFyc2luZ193aXRoX3R3b19idWdzKHNlbGYpOgorICAgICAgICBzZWxmLl9h c3NlcnRSYWlzZXNSZWdleHAoJ1RvbyBtYW55IGFyZ3VtZW50cyBnaXZlbjogMTIzNCA1Njc4Jywg c2VsZi5hc3NlcnRfZXhlY3V0ZV9vdXRwdXRzLCBBcHBseVdhdGNoTGlzdExvY2FsKCksIFsnMTIz NCcsICc1Njc4J10pCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvY29tbWFuZHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvY29tbWFuZHRlc3QucHkKaW5kZXggYzQ4ZjcwNjJhOWVlNDdlYzdhMjljODIwZmFmZjYyZGY4 NzMwMmZlMy4uZWVhMGE2MTU2MWUwNmM5ODZkOWFlZTUyY2JkOTdlN2I0MmYxNWRhMSAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2NvbW1hbmR0ZXN0LnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9jb21tYW5kdGVzdC5w eQpAQCAtMjYsMTIgKzI2LDEyIEBACiAjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJ U0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBPRiBUSElTIFNPRlRXQVJF LCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCi1p bXBvcnQgdW5pdHRlc3QKLQogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLm91dHB1dGNhcHR1 cmUgaW1wb3J0IE91dHB1dENhcHR1cmUKK2Zyb20gd2Via2l0cHkuY29tbW9uLndlYmtpdHVuaXR0 ZXN0IGltcG9ydCBUZXN0Q2FzZQogZnJvbSB3ZWJraXRweS50b29sLm1vY2t0b29sIGltcG9ydCBN b2NrT3B0aW9ucywgTW9ja1Rvb2wKIAotY2xhc3MgQ29tbWFuZHNUZXN0KHVuaXR0ZXN0LlRlc3RD YXNlKToKKworY2xhc3MgQ29tbWFuZHNUZXN0KFRlc3RDYXNlKToKICAgICBkZWYgYXNzZXJ0X2V4 ZWN1dGVfb3V0cHV0cyhzZWxmLCBjb21tYW5kLCBhcmdzPVtdLCBleHBlY3RlZF9zdGRvdXQ9IiIs IGV4cGVjdGVkX3N0ZGVycj0iIiwgZXhwZWN0ZWRfZXhjZXB0aW9uPU5vbmUsIG9wdGlvbnM9TW9j a09wdGlvbnMoKSwgdG9vbD1Nb2NrVG9vbCgpKToKICAgICAgICAgb3B0aW9ucy5ibG9ja3MgPSBO b25lCiAgICAgICAgIG9wdGlvbnMuY2MgPSAnTU9DSyBjYycKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZC5weQppbmRleCAyM2ViZjg5OTA4M2Y0ZWIw MjA5NTIxODBhZTk2MTExZTVjMTFmY2Q1Li5iNTllM2JkMmU1NjIxN2UzNTNhMDU2NjcyNDNkYmZk MjkyNTU2MzhjIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvZG93bmxvYWQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRz L2Rvd25sb2FkLnB5CkBAIC0yNTIsNyArMjUyLDcgQEAgY2xhc3MgQXBwbHlGcm9tQnVnKEFic3Ry YWN0UGF0Y2hBcHBseWluZ0NvbW1hbmQsIFByb2Nlc3NCdWdzTWl4aW4pOgogCiBjbGFzcyBBcHBs eVdhdGNoTGlzdChBYnN0cmFjdFBhdGNoU2VxdWVuY2luZ0NvbW1hbmQsIFByb2Nlc3NBdHRhY2ht ZW50c01peGluKToKICAgICBuYW1lID0gImFwcGx5LXdhdGNobGlzdCIKLSAgICBoZWxwX3RleHQg PSAiQXBwbGllcyB0aGUgd2F0Y2hsaXN0IHRvIHRoZSBzcGVjaWZpZWQgYXR0YWNobWVudHMuIgor ICAgIGhlbHBfdGV4dCA9ICJBcHBsaWVzIHRoZSB3YXRjaGxpc3QgdG8gdGhlIHNwZWNpZmllZCBh dHRhY2htZW50cyIKICAgICBhcmd1bWVudF9uYW1lcyA9ICJBVFRBQ0hNRU5UX0lEIFtBVFRBQ0hN RU5UX0lEU10iCiAgICAgbWFpbl9zdGVwcyA9IFsKICAgICAgICAgc3RlcHMuQ2xlYW5Xb3JraW5n RGlyZWN0b3J5LAo=