69279 2011-10-03 12:18:52 -0700 allow failure of most Chromium-Mac-Skia tests while we clean up that port 2011-10-04 07:44:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 epoger epoger abarth caryclark webkit.review.bot oldest_to_newest 477135 0 epoger 2011-10-03 12:18:52 -0700 caryclark and epoger are hard at work getting the Chromium-Mac-Skia port stable. This will make the test results unstable for a while. Disabling most tests of this port so as not to distract Webkit Gardeners with excess noise (as happened in https://bugs.webkit.org/show_bug.cgi?id=69166 ) 477215 1 109524 epoger 2011-10-03 13:47:11 -0700 Created attachment 109524 Patch 477217 2 epoger 2011-10-03 13:49:31 -0700 I have confirmed locally that this would have hidden all layout test failures caused by the CL in https://bugs.webkit.org/show_bug.cgi?id=69166 . After it passes the trybots, I will request review from a human... 477236 3 109524 abarth 2011-10-03 14:14:40 -0700 Comment on attachment 109524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109524&action=review What about LEOPARD? Probably all these SNOWLEOPARDs should just be MAC. > LayoutTests/platform/chromium/test_expectations.txt:3699 > +BUGWK69279 SNOWLEOPARD CPU : media = PASS TEXT IMAGE IMAGE+TEXT CRASH No GPU here? > LayoutTests/platform/chromium/test_expectations.txt:3706 > +BUGWK69279 SNOWLEOPARD CPU GPU : transitions = PASS TEXT IMAGE IMAGE+TEXT CRASH I think "TEXT IMAGE IMAGE+TEXT" and all be combined into FAIL. 477237 4 abarth 2011-10-03 14:15:51 -0700 > I think "TEXT IMAGE IMAGE+TEXT" and all be combined into FAIL. Actually, CRASH is covered too. You can just mark these as PASS FAIL. (I'm happy to take another look at this patch if you'd like me to before you land it.) 477241 5 109531 epoger 2011-10-03 14:25:44 -0700 Created attachment 109531 Patch 477243 6 109524 epoger 2011-10-03 14:26:55 -0700 Comment on attachment 109524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109524&action=review >> LayoutTests/platform/chromium/test_expectations.txt:3699 >> +BUGWK69279 SNOWLEOPARD CPU : media = PASS TEXT IMAGE IMAGE+TEXT CRASH > > No GPU here? Added. (Previously, I was mindlessly copying from the Leopard section above) >> LayoutTests/platform/chromium/test_expectations.txt:3706 >> +BUGWK69279 SNOWLEOPARD CPU GPU : transitions = PASS TEXT IMAGE IMAGE+TEXT CRASH > > I think "TEXT IMAGE IMAGE+TEXT" and all be combined into FAIL. Done. 477244 7 epoger 2011-10-03 14:27:34 -0700 (In reply to comment #3) > (From update of attachment 109524 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109524&action=review > > What about LEOPARD? Probably all these SNOWLEOPARDs should just be MAC. I'd like to keep the LEOPARD and SNOWLEOPARD sections separate if that's OK with you. (I think we can turn them back on at different times.) 477245 8 109531 abarth 2011-10-03 14:30:07 -0700 Comment on attachment 109531 Patch Looks great. 477268 9 109531 abarth 2011-10-03 15:00:11 -0700 Comment on attachment 109531 Patch I don't understand. If you make a change that causes these tests to fail on both LEOPARD and SNOWLEOPARD, the SNOWLEOPARD bot will stay green but the LEOPARD bot will go red. Is that what you intend? 477572 10 epoger 2011-10-04 06:40:22 -0700 (In reply to comment #9) > (From update of attachment 109531 [details]) > I don't understand. If you make a change that causes these tests to fail on both LEOPARD and SNOWLEOPARD, the SNOWLEOPARD bot will stay green but the LEOPARD bot will go red. Is that what you intend? There is already a section of the test_expectations file that deals with the LEOPARD tests, allowing most of them to fail for now. 477595 11 109531 webkit.review.bot 2011-10-04 07:44:45 -0700 Comment on attachment 109531 Patch Clearing flags on attachment: 109531 Committed r96592: <http://trac.webkit.org/changeset/96592> 477596 12 webkit.review.bot 2011-10-04 07:44:49 -0700 All reviewed patches have been landed. Closing bug. 109524 2011-10-03 13:47:11 -0700 2011-10-03 14:26:55 -0700 Patch bug-69279-20111003164709.patch text/plain 2683 epoger SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk2NTM1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTAtMDMgIEVsbGlvdCBQb2dlciAgPGVw b2dlckBnb29nbGUuY29tPgorCisgICAgICAgIGFsbG93IGZhaWx1cmUgb2YgbW9zdCBDaHJvbWl1 bS1NYWMtU2tpYSB0ZXN0cyB3aGlsZSB3ZSBjbGVhbiB1cCB0aGF0IHBvcnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5Mjc5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTEtMTAtMDMgIFNoZXJpZmYgQm90ICA8d2Via2l0 LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHI5NjUzMi4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0 YXRpb25zLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHJldmlzaW9uIDk2NTM0KQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0z Njg2LDYgKzM2ODYsMjUgQEAgQlVHV0s2ODI3MCBMRU9QQVJEIENQVSBHUFUgOiB0YWJsZXMgPSBQ QQogQlVHV0s2ODI3MCBMRU9QQVJEIENQVSBHUFUgOiB0cmFuc2Zvcm1zID0gUEFTUyBURVhUIElN QUdFIElNQUdFK1RFWFQKIEJVR1dLNjgyNzAgTEVPUEFSRCBDUFUgR1BVIDogdHJhbnNpdGlvbnMg PSBQQVNTIFRFWFQgSU1BR0UgSU1BR0UrVEVYVAogCisvLyBUZW1wb3JhcmlseSBhbGxvd2luZyBt YW55IGZhaWx1cmVzIGZvciBNYWMxMC42IHdpdGggU2tpYSBncmFwaGljcywgd2hpbGUgd2Ugd29y ayBvdXQga2lua3MuCisvLyBlcG9nZXIgcHJvbWlzZXMgdG8gcmVtb3ZlIHRoZXNlIGV4cGVjdGF0 aW9ucyBieSAxMCBPY3RvYmVyIDIwMTEuCitCVUdXSzY5Mjc5IFNOT1dMRU9QQVJEIENQVSBHUFUg OiBhbmltYXRpb25zID0gUEFTUyBURVhUIElNQUdFIElNQUdFK1RFWFQgQ1JBU0gKK0JVR1dLNjky NzkgU05PV0xFT1BBUkQgQ1BVIEdQVSA6IGNzczEgPSBQQVNTIFRFWFQgSU1BR0UgSU1BR0UrVEVY VCBDUkFTSAorQlVHV0s2OTI3OSBTTk9XTEVPUEFSRCBDUFUgR1BVIDogY3NzMi4xID0gUEFTUyBU RVhUIElNQUdFIElNQUdFK1RFWFQgQ1JBU0gKK0JVR1dLNjkyNzkgU05PV0xFT1BBUkQgQ1BVIEdQ VSA6IGNzczMgPSBQQVNTIFRFWFQgSU1BR0UgSU1BR0UrVEVYVCBDUkFTSAorQlVHV0s2OTI3OSBT Tk9XTEVPUEFSRCBDUFUgR1BVIDogZWRpdGluZyA9IFBBU1MgVEVYVCBJTUFHRSBJTUFHRStURVhU IENSQVNICitCVUdXSzY5Mjc5IFNOT1dMRU9QQVJEIENQVSBHUFUgOiBmYXN0ID0gUEFTUyBURVhU IElNQUdFIElNQUdFK1RFWFQgQ1JBU0gKK0JVR1dLNjkyNzkgU05PV0xFT1BBUkQgQ1BVIEdQVSA6 IGZvbnRzID0gUEFTUyBURVhUIElNQUdFIElNQUdFK1RFWFQgQ1JBU0gKK0JVR1dLNjkyNzkgU05P V0xFT1BBUkQgQ1BVIEdQVSA6IGh0dHAgPSBQQVNTIFRFWFQgSU1BR0UgSU1BR0UrVEVYVCBDUkFT SAorQlVHV0s2OTI3OSBTTk9XTEVPUEFSRCBDUFUgOiBtZWRpYSA9IFBBU1MgVEVYVCBJTUFHRSBJ TUFHRStURVhUIENSQVNICitCVUdXSzY5Mjc5IFNOT1dMRU9QQVJEIENQVSBHUFUgOiBwbGF0Zm9y bSA9IFBBU1MgVEVYVCBJTUFHRSBJTUFHRStURVhUIENSQVNICitCVUdXSzY5Mjc5IFNOT1dMRU9Q QVJEIENQVSBHUFUgOiBwbHVnaW5zID0gUEFTUyBURVhUIElNQUdFIElNQUdFK1RFWFQgQ1JBU0gK K0JVR1dLNjkyNzkgU05PV0xFT1BBUkQgQ1BVIEdQVSA6IHNjcm9sbGJhcnMgPSBQQVNTIFRFWFQg SU1BR0UgSU1BR0UrVEVYVCBDUkFTSAorQlVHV0s2OTI3OSBTTk9XTEVPUEFSRCBDUFUgR1BVIDog c3ZnID0gUEFTUyBURVhUIElNQUdFIElNQUdFK1RFWFQgQ1JBU0gKK0JVR1dLNjkyNzkgU05PV0xF T1BBUkQgQ1BVIEdQVSA6IHRhYmxlcyA9IFBBU1MgVEVYVCBJTUFHRSBJTUFHRStURVhUIENSQVNI CitCVUdXSzY5Mjc5IFNOT1dMRU9QQVJEIENQVSBHUFUgOiB0cmFuc2Zvcm1zID0gUEFTUyBURVhU IElNQUdFIElNQUdFK1RFWFQgQ1JBU0gKK0JVR1dLNjkyNzkgU05PV0xFT1BBUkQgQ1BVIEdQVSA6 IHRyYW5zaXRpb25zID0gUEFTUyBURVhUIElNQUdFIElNQUdFK1RFWFQgQ1JBU0gKKwogLy8gVGhl ICotcHNldWRvLWNsYXNzIHRlc3RzIGFyZSBhbHJlYWR5IG1hcmtlZCBmbGFreSAoZm9yIFRFWFQg ZmFpbHVyZSkgb24gYWxsIHBsYXRmb3JtcywKIC8vIGJ1dCByZWxpYWJseSBmYWlsIHdpdGggSU1B R0Ugb24gTWFjMTAuNSB3aXRoIFNraWEgZ3JhcGhpY3MuCiBCVUdXSzY4MjcwIExFT1BBUkQgQ1BV IERFQlVHIDogZmFzdC9jc3MvZW1wdHktcHNldWRvLWNsYXNzLmh0bWwgPSBJTUFHRSBJTUFHRStU RVhUCg== 109531 2011-10-03 14:25:44 -0700 2011-10-04 07:44:45 -0700 Patch bug-69279-20111003172543.patch text/plain 2319 epoger SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk2NTM1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTAtMDMgIEVsbGlvdCBQb2dlciAgPGVw b2dlckBnb29nbGUuY29tPgorCisgICAgICAgIGFsbG93IGZhaWx1cmUgb2YgbW9zdCBDaHJvbWl1 bS1NYWMtU2tpYSB0ZXN0cyB3aGlsZSB3ZSBjbGVhbiB1cCB0aGF0IHBvcnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5Mjc5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTEtMTAtMDMgIFNoZXJpZmYgQm90ICA8d2Via2l0 LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHI5NjUzMi4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0 YXRpb25zLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHJldmlzaW9uIDk2NTM0KQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0z Njg2LDYgKzM2ODYsMjUgQEAgQlVHV0s2ODI3MCBMRU9QQVJEIENQVSBHUFUgOiB0YWJsZXMgPSBQ QQogQlVHV0s2ODI3MCBMRU9QQVJEIENQVSBHUFUgOiB0cmFuc2Zvcm1zID0gUEFTUyBURVhUIElN QUdFIElNQUdFK1RFWFQKIEJVR1dLNjgyNzAgTEVPUEFSRCBDUFUgR1BVIDogdHJhbnNpdGlvbnMg PSBQQVNTIFRFWFQgSU1BR0UgSU1BR0UrVEVYVAogCisvLyBUZW1wb3JhcmlseSBhbGxvd2luZyBt YW55IGZhaWx1cmVzIGZvciBNYWMxMC42IHdpdGggU2tpYSBncmFwaGljcywgd2hpbGUgd2Ugd29y ayBvdXQga2lua3MuCisvLyBlcG9nZXIgcHJvbWlzZXMgdG8gcmVtb3ZlIHRoZXNlIGV4cGVjdGF0 aW9ucyBieSAxMCBPY3RvYmVyIDIwMTEuCitCVUdXSzY5Mjc5IFNOT1dMRU9QQVJEIENQVSBHUFUg OiBhbmltYXRpb25zID0gUEFTUyBGQUlMCitCVUdXSzY5Mjc5IFNOT1dMRU9QQVJEIENQVSBHUFUg OiBjc3MxID0gUEFTUyBGQUlMCitCVUdXSzY5Mjc5IFNOT1dMRU9QQVJEIENQVSBHUFUgOiBjc3My LjEgPSBQQVNTIEZBSUwKK0JVR1dLNjkyNzkgU05PV0xFT1BBUkQgQ1BVIEdQVSA6IGNzczMgPSBQ QVNTIEZBSUwKK0JVR1dLNjkyNzkgU05PV0xFT1BBUkQgQ1BVIEdQVSA6IGVkaXRpbmcgPSBQQVNT IEZBSUwKK0JVR1dLNjkyNzkgU05PV0xFT1BBUkQgQ1BVIEdQVSA6IGZhc3QgPSBQQVNTIEZBSUwK K0JVR1dLNjkyNzkgU05PV0xFT1BBUkQgQ1BVIEdQVSA6IGZvbnRzID0gUEFTUyBGQUlMCitCVUdX SzY5Mjc5IFNOT1dMRU9QQVJEIENQVSBHUFUgOiBodHRwID0gUEFTUyBGQUlMCitCVUdXSzY5Mjc5 IFNOT1dMRU9QQVJEIENQVSBHUFUgOiBtZWRpYSA9IFBBU1MgRkFJTAorQlVHV0s2OTI3OSBTTk9X TEVPUEFSRCBDUFUgR1BVIDogcGxhdGZvcm0gPSBQQVNTIEZBSUwKK0JVR1dLNjkyNzkgU05PV0xF T1BBUkQgQ1BVIEdQVSA6IHBsdWdpbnMgPSBQQVNTIEZBSUwKK0JVR1dLNjkyNzkgU05PV0xFT1BB UkQgQ1BVIEdQVSA6IHNjcm9sbGJhcnMgPSBQQVNTIEZBSUwKK0JVR1dLNjkyNzkgU05PV0xFT1BB UkQgQ1BVIEdQVSA6IHN2ZyA9IFBBU1MgRkFJTAorQlVHV0s2OTI3OSBTTk9XTEVPUEFSRCBDUFUg R1BVIDogdGFibGVzID0gUEFTUyBGQUlMCitCVUdXSzY5Mjc5IFNOT1dMRU9QQVJEIENQVSBHUFUg OiB0cmFuc2Zvcm1zID0gUEFTUyBGQUlMCitCVUdXSzY5Mjc5IFNOT1dMRU9QQVJEIENQVSBHUFUg OiB0cmFuc2l0aW9ucyA9IFBBU1MgRkFJTAorCiAvLyBUaGUgKi1wc2V1ZG8tY2xhc3MgdGVzdHMg YXJlIGFscmVhZHkgbWFya2VkIGZsYWt5IChmb3IgVEVYVCBmYWlsdXJlKSBvbiBhbGwgcGxhdGZv cm1zLAogLy8gYnV0IHJlbGlhYmx5IGZhaWwgd2l0aCBJTUFHRSBvbiBNYWMxMC41IHdpdGggU2tp YSBncmFwaGljcy4KIEJVR1dLNjgyNzAgTEVPUEFSRCBDUFUgREVCVUcgOiBmYXN0L2Nzcy9lbXB0 eS1wc2V1ZG8tY2xhc3MuaHRtbCA9IElNQUdFIElNQUdFK1RFWFQK