69276 2011-10-03 12:03:55 -0700 BiquadFilterNode should explicitly expose filter type constants in IDL 2012-03-15 15:04:45 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 crogers crogers crogers rtoy oldest_to_newest 477121 0 crogers 2011-10-03 12:03:55 -0700 In the Web Audio API specification, the BiquadFilterNode interface defines filter type constants: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#BiquadFilterNode-section These need to be exposed to JavaScript in the IDL. 506012 1 115861 rtoy 2011-11-18 13:31:24 -0800 Created attachment 115861 Possible implementation A possible patch for BiquadFilterNode to expose the filter constants in IDL. This was tested on chromium and it works. Did not test with Safari. 506138 2 rtoy 2011-11-18 15:34:43 -0800 That patch isn't needed. If filter is a BiquadFilterNode, then filter.LOWPASS is 0, filter.HIGHPASS is 1, and so on. 579783 3 crogers 2012-03-15 15:04:45 -0700 filter constants are already defined - closing 115861 2011-11-18 13:31:24 -0800 2011-11-18 13:31:24 -0800 Possible implementation biquad-filter-name.patch text/plain 2301 rtoy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0JpcXVhZEZpbHRlck5vZGUuaCBi L1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0JpcXVhZEZpbHRlck5vZGUuaAppbmRleCA1NDViMDYw Li45MWExNDY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9CaXF1YWRGaWx0 ZXJOb2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQmlxdWFkRmlsdGVyTm9kZS5o CkBAIC01OCw2ICs1OCwxNyBAQCBwdWJsaWM6CiAgICAgQXVkaW9QYXJhbSogcSgpIHsgcmV0dXJu IGJpcXVhZFByb2Nlc3NvcigpLT5wYXJhbWV0ZXIyKCk7IH0KICAgICBBdWRpb1BhcmFtKiBnYWlu KCkgeyByZXR1cm4gYmlxdWFkUHJvY2Vzc29yKCktPnBhcmFtZXRlcjMoKTsgfQogCisgICAgLy8g RnVua3kgbmFtZXMgdG8gbWFrZSBpdCB3b3JrIHdpdGggdGhlIGFsbCB1cHBlcmNhc2UgbmFtZXMg aW4gdGhlCisgICAgLy8gSURMIGZpbGUuCisgICAgdW5zaWduZWQgc2hvcnQgbE9XUEFTUygpIHsg cmV0dXJuIExPV1BBU1M7IH0KKyAgICB1bnNpZ25lZCBzaG9ydCBoSUdIUEFTUygpIHsgcmV0dXJu IEhJR0hQQVNTOyB9CisgICAgdW5zaWduZWQgc2hvcnQgYkFORFBBU1MoKSB7IHJldHVybiBCQU5E UEFTUzsgfQorICAgIHVuc2lnbmVkIHNob3J0IGxPV1NIRUxGKCkgeyByZXR1cm4gTE9XU0hFTEY7 IH0KKyAgICB1bnNpZ25lZCBzaG9ydCBoSUdIU0hFTEYoKSB7IHJldHVybiBISUdIU0hFTEY7IH0K KyAgICB1bnNpZ25lZCBzaG9ydCBwRUFLSU5HKCkgeyByZXR1cm4gUEVBS0lORzsgfQorICAgIHVu c2lnbmVkIHNob3J0IG5PVENIKCkgeyByZXR1cm4gTk9UQ0g7IH0KKyAgICB1bnNpZ25lZCBzaG9y dCBhTExQQVNTKCkgeyByZXR1cm4gQUxMUEFTUzsgfQorCiAgICAgLy8gR2V0IHRoZSBtYWduaXR1 ZGUgYW5kIHBoYXNlIHJlc3BvbnNlIG9mIHRoZSBmaWx0ZXIgYXQgdGhlIGdpdmVuCiAgICAgLy8g c2V0IG9mIGZyZXF1ZW5jaWVzIChpbiBIeikuIFRoZSBwaGFzZSByZXNwb25zZSBpcyBpbiByYWRp YW5zLgogICAgIHZvaWQgZ2V0RnJlcXVlbmN5UmVzcG9uc2UoY29uc3QgRmxvYXQzMkFycmF5KiBm cmVxdWVuY3lIeiwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0JpcXVhZEZp bHRlck5vZGUuaWRsIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQmlxdWFkRmlsdGVyTm9kZS5p ZGwKaW5kZXggODRlMDE1YS4uOGY4N2E4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd2Vi YXVkaW8vQmlxdWFkRmlsdGVyTm9kZS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8v QmlxdWFkRmlsdGVyTm9kZS5pZGwKQEAgLTI4LDE0ICsyOCwxNCBAQCBtb2R1bGUgYXVkaW8gewog ICAgICAgICBHZW5lcmF0ZVRvSlMKICAgICBdIEJpcXVhZEZpbHRlck5vZGUgOiBBdWRpb05vZGUg ewogICAgICAgICAvLyBGaWx0ZXIgdHlwZS4KLSAgICAgICAgY29uc3QgdW5zaWduZWQgc2hvcnQg TE9XUEFTUyA9IDA7Ci0gICAgICAgIGNvbnN0IHVuc2lnbmVkIHNob3J0IEhJR0hQQVNTID0gMTsK LSAgICAgICAgY29uc3QgdW5zaWduZWQgc2hvcnQgQkFORFBBU1MgPSAyOwotICAgICAgICBjb25z dCB1bnNpZ25lZCBzaG9ydCBMT1dTSEVMRiA9IDM7Ci0gICAgICAgIGNvbnN0IHVuc2lnbmVkIHNo b3J0IEhJR0hTSEVMRiA9IDQ7Ci0gICAgICAgIGNvbnN0IHVuc2lnbmVkIHNob3J0IFBFQUtJTkcg PSA1OwotICAgICAgICBjb25zdCB1bnNpZ25lZCBzaG9ydCBOT1RDSCA9IDY7Ci0gICAgICAgIGNv bnN0IHVuc2lnbmVkIHNob3J0IEFMTFBBU1MgPSA3OworICAgICAgICByZWFkb25seSBhdHRyaWJ1 dGUgdW5zaWduZWQgc2hvcnQgTE9XUEFTUzsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIHVu c2lnbmVkIHNob3J0IEhJR0hQQVNTOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5zaWdu ZWQgc2hvcnQgQkFORFBBU1M7CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBz aG9ydCBMT1dTSEVMRjsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIHNob3J0 IEhJR0hTSEVMRjsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIHNob3J0IFBF QUtJTkc7CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBzaG9ydCBOT1RDSDsK KyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIHNob3J0IEFMTFBBU1M7CiAKICAg ICAgICAgYXR0cmlidXRlIHVuc2lnbmVkIHNob3J0IHR5cGUKICAgICAgICAgICAgIHNldHRlciBy YWlzZXMoRE9NRXhjZXB0aW9uKTsK