69260 2011-10-03 08:21:36 -0700 FontFallbackList: Glyph pages waste a lot of memory. 2011-10-03 09:50:04 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling koivisto mitz webkit.review.bot oldest_to_newest 476984 0 kling 2011-10-03 08:21:36 -0700 The m_pages hash map in FontFallbackList is defined as follows: typedef HashMap<int, GlyphPageTreeNode*> GlyphPages; GlyphPages m_pages; This uses the default HashMap minimum table size of 64 buckets which is quite wasteful in many cases. One idea is to lower the minimum table size using hash traits. A patch will follow that lowers it to 16, which reduces memory consumption by ~900 kB when loading the full HTML5 spec. 476986 1 109486 kling 2011-10-03 08:25:23 -0700 Created attachment 109486 Proposed patch 477044 2 109486 webkit.review.bot 2011-10-03 09:50:00 -0700 Comment on attachment 109486 Proposed patch Clearing flags on attachment: 109486 Committed r96512: <http://trac.webkit.org/changeset/96512> 477045 3 webkit.review.bot 2011-10-03 09:50:04 -0700 All reviewed patches have been landed. Closing bug. 109486 2011-10-03 08:25:23 -0700 2011-10-03 09:49:59 -0700 Proposed patch bug-69260.diff text/plain 1732 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NzlkYjJiLi4xYjE0MDk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTEtMTAtMDMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIEZvbnRGYWxsYmFja0xpc3Q6IEdseXBoIHBhZ2VzIHdhc3RlIGEgbG90IG9mIG1lbW9yeS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MjYwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIGEgbWlu aW11bSBoYXNoIHRhYmxlIHNpemUgb2YgMTYgKGRvd24gZnJvbSA2NCkgZm9yIEZvbnRGYWxsYmFj a0xpc3QncworICAgICAgICBnbHlwaCBwYWdlcy4gVGhpcyByZWR1Y2VzIG1lbW9yeSBjb25zdW1w dGlvbiBieSB+OTAwIGtCIHdoZW4gbG9hZGluZyB0aGUKKyAgICAgICAgZnVsbCBIVE1MNSBzcGVj LgorCisgICAgICAgIFRoZSBjb3N0IGlzIHR3byBhZGRpdGlvbmFsIHJlaGFzaCgpZXMgb2YgRm9u dEZhbGxiYWNrTGlzdDo6bV9wYWdlcyB3aGVuCisgICAgICAgIGFkZGluZyB0aGUgMzJuZCBhbmQg NjR0aCBwYWdlcyB0byB0aGUgaGFzaCBtYXAuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9Gb250RmFsbGJhY2tMaXN0Lmg6CisKKzIwMTEtMTAtMDMgIEFuZHJlYXMgS2xpbmcgIDxrbGlu Z0B3ZWJraXQub3JnPgorCiAgICAgICAgIFNocmluayBIVE1MTElFbGVtZW50LgogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkyNTAKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEZhbGxiYWNrTGlzdC5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEZhbGxiYWNrTGlzdC5oCmluZGV4 IDQ1OWJhYmEuLjA3MjAzM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0ZvbnRGYWxsYmFja0xpc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9Gb250RmFsbGJhY2tMaXN0LmgKQEAgLTUzLDcgKzUzLDEwIEBAIHB1YmxpYzoKICAg ICBGb250U2VsZWN0b3IqIGZvbnRTZWxlY3RvcigpIGNvbnN0IHsgcmV0dXJuIG1fZm9udFNlbGVj dG9yLmdldCgpOyB9CiAgICAgdW5zaWduZWQgZ2VuZXJhdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1f Z2VuZXJhdGlvbjsgfQogCi0gICAgdHlwZWRlZiBIYXNoTWFwPGludCwgR2x5cGhQYWdlVHJlZU5v ZGUqPiBHbHlwaFBhZ2VzOworICAgIHN0cnVjdCBHbHlwaFBhZ2VzSGFzaFRyYWl0cyA6IEhhc2hU cmFpdHM8aW50PiB7CisgICAgICAgIHN0YXRpYyBjb25zdCBpbnQgbWluaW11bVRhYmxlU2l6ZSA9 IDE2OworICAgIH07CisgICAgdHlwZWRlZiBIYXNoTWFwPGludCwgR2x5cGhQYWdlVHJlZU5vZGUq LCBEZWZhdWx0SGFzaDxpbnQ+OjpIYXNoLCBHbHlwaFBhZ2VzSGFzaFRyYWl0cz4gR2x5cGhQYWdl czsKICAgICBHbHlwaFBhZ2VUcmVlTm9kZSogZ2x5cGhQYWdlWmVybygpIGNvbnN0IHsgcmV0dXJu IG1fcGFnZVplcm87IH0KICAgICBjb25zdCBHbHlwaFBhZ2VzJiBnbHlwaFBhZ2VzKCkgY29uc3Qg eyByZXR1cm4gbV9wYWdlczsgfQogCg==