69250 2011-10-03 04:24:56 -0700 Shrink HTMLLIElement. 2011-10-03 07:15:55 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling webkit.review.bot oldest_to_newest 476889 0 kling 2011-10-03 04:24:56 -0700 I don't believe we need to cache the "value" attribute on HTMLLIElement. 476891 1 109467 kling 2011-10-03 04:27:14 -0700 Created attachment 109467 Proposed patch 476939 2 109467 koivisto 2011-10-03 06:34:38 -0700 Comment on attachment 109467 Proposed patch r=me 476953 3 109467 webkit.review.bot 2011-10-03 07:15:51 -0700 Comment on attachment 109467 Proposed patch Clearing flags on attachment: 109467 Committed r96496: <http://trac.webkit.org/changeset/96496> 476954 4 webkit.review.bot 2011-10-03 07:15:55 -0700 All reviewed patches have been landed. Closing bug. 109467 2011-10-03 04:27:14 -0700 2011-10-03 07:15:51 -0700 Proposed patch bug-69250.diff text/plain 3127 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZmQxNzA0Li43NzlkYjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTEtMTAtMDMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFNocmluayBIVE1MTElFbGVtZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjkyNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBEb24ndCBjYWNoZSB0aGUgZXhwbGljaXQgInZhbHVlIiBhdHRyaWJ1 dGUgb24gdGhlIEhUTUxMSUVsZW1lbnQsCisgICAgICAgIGJ1dCBmZXRjaCBpdCB3aXRoIGZhc3RH ZXRBdHRyaWJ1dGUgd2hlbiBuZWVkZWQuCisgICAgICAgIFRoaXMgc2hyaW5rcyBIVE1MTElFbGVt ZW50IGJ5IG9uZSBDUFUgd29yZC4KKworICAgICAgICAqIGh0bWwvSFRNTExJRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MTElFbGVtZW50OjpIVE1MTElFbGVtZW50KToKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxMSUVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKToKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxMSUVsZW1lbnQ6OmF0dGFjaCk6CisgICAgICAgICogaHRtbC9IVE1M TElFbGVtZW50Lmg6CisKKzIwMTEtMTAtMDMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQu b3JnPgorCiAgICAgICAgIFJFR1JFU1NJT04ocjgyNjExKSBJbmxpbmVCb3ggaGFzIDMzIGJpdHMg b2YgYml0c2V0LCBjYXVzaW5nIGFsaWdubWVudCBpc3N1ZXMgYW5kIGV4dHJhIG1lbW9yeSB1c2Uu CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDkxNAog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMSUVsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTElFbGVtZW50LmNwcAppbmRleCA5YWJlYTlmLi5kOWQyNTEx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMSUVsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExJRWxlbWVudC5jcHAKQEAgLTM1LDcgKzM1LDYgQEAg dXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIAogSFRNTExJRWxlbWVudDo6SFRNTExJRWxlbWVu dChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVudCogZG9jdW1lbnQpCiAgICAg OiBIVE1MRWxlbWVudCh0YWdOYW1lLCBkb2N1bWVudCkKLSAgICAsIG1fcmVxdWVzdGVkVmFsdWUo MCkKIHsKICAgICBBU1NFUlQoaGFzVGFnTmFtZShsaVRhZykpOwogfQpAQCAtNjMsMTAgKzYyLDEw IEBAIGJvb2wgSFRNTExJRWxlbWVudDo6bWFwVG9FbnRyeShjb25zdCBRdWFsaWZpZWROYW1lJiBh dHRyTmFtZSwgTWFwcGVkQXR0cmlidXRlRW50CiB2b2lkIEhUTUxMSUVsZW1lbnQ6OnBhcnNlTWFw cGVkQXR0cmlidXRlKEF0dHJpYnV0ZSogYXR0cikKIHsKICAgICBpZiAoYXR0ci0+bmFtZSgpID09 IHZhbHVlQXR0cikgewotICAgICAgICBtX3JlcXVlc3RlZFZhbHVlID0gYXR0ci0+dmFsdWUoKS50 b0ludCgpOwogICAgICAgICBpZiAocmVuZGVyZXIoKSAmJiByZW5kZXJlcigpLT5pc0xpc3RJdGVt KCkpIHsKLSAgICAgICAgICAgIGlmIChtX3JlcXVlc3RlZFZhbHVlID4gMCkKLSAgICAgICAgICAg ICAgICB0b1JlbmRlckxpc3RJdGVtKHJlbmRlcmVyKCkpLT5zZXRFeHBsaWNpdFZhbHVlKG1fcmVx dWVzdGVkVmFsdWUpOworICAgICAgICAgICAgaW50IHJlcXVlc3RlZFZhbHVlID0gYXR0ci0+dmFs dWUoKS50b0ludCgpOworICAgICAgICAgICAgaWYgKHJlcXVlc3RlZFZhbHVlID4gMCkKKyAgICAg ICAgICAgICAgICB0b1JlbmRlckxpc3RJdGVtKHJlbmRlcmVyKCkpLT5zZXRFeHBsaWNpdFZhbHVl KHJlcXVlc3RlZFZhbHVlKTsKICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICB0b1Jl bmRlckxpc3RJdGVtKHJlbmRlcmVyKCkpLT5jbGVhckV4cGxpY2l0VmFsdWUoKTsKICAgICAgICAg fQpAQCAtMTA5LDEwICsxMDgsMTYgQEAgdm9pZCBIVE1MTElFbGVtZW50OjphdHRhY2goKQogICAg ICAgICBpZiAoIWxpc3ROb2RlKQogICAgICAgICAgICAgcmVuZGVyLT5zZXROb3RJbkxpc3QodHJ1 ZSk7CiAKLSAgICAgICAgaWYgKG1fcmVxdWVzdGVkVmFsdWUgPiAwKQotICAgICAgICAgICAgcmVu ZGVyLT5zZXRFeHBsaWNpdFZhbHVlKG1fcmVxdWVzdGVkVmFsdWUpOwotICAgICAgICBlbHNlCisg ICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgcmVxdWVzdGVkVmFsdWVTdHJpbmcgPSBmYXN0R2V0 QXR0cmlidXRlKHZhbHVlQXR0cik7CisgICAgICAgIGlmIChyZXF1ZXN0ZWRWYWx1ZVN0cmluZy5p c051bGwoKSkKICAgICAgICAgICAgIHJlbmRlci0+Y2xlYXJFeHBsaWNpdFZhbHVlKCk7CisgICAg ICAgIGVsc2UgeworICAgICAgICAgICAgaW50IHJlcXVlc3RlZFZhbHVlID0gcmVxdWVzdGVkVmFs dWVTdHJpbmcudG9JbnQoKTsKKyAgICAgICAgICAgIGlmIChyZXF1ZXN0ZWRWYWx1ZSA+IDApCisg ICAgICAgICAgICAgICAgcmVuZGVyLT5zZXRFeHBsaWNpdFZhbHVlKHJlcXVlc3RlZFZhbHVlKTsK KyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICByZW5kZXItPmNsZWFyRXhwbGljaXRW YWx1ZSgpOworICAgICAgICB9CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxMSUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExJRWxlbWVu dC5oCmluZGV4IGFkMTJiNjcuLmU4NzM1NDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTExJRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExJRWxlbWVu dC5oCkBAIC0zOSw4ICszOSw2IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHBhcnNlTWFw cGVkQXR0cmlidXRlKEF0dHJpYnV0ZSopOwogCiAgICAgdmlydHVhbCB2b2lkIGF0dGFjaCgpOwot Ci0gICAgaW50IG1fcmVxdWVzdGVkVmFsdWU7CiB9OwogCiB9IC8vbmFtZXNwYWNlCg==