69247 2011-10-03 04:03:21 -0700 [GTK] Fix memory leak when loading url 2011-10-03 09:17:02 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned pnormand xan.lopez oldest_to_newest 476877 0 cgarcia 2011-10-03 04:03:21 -0700 We are leaking the url created with WKURLCreateWithUTF8CString() when loading pages in GTK+ API and MiniBrowser 476878 1 109465 cgarcia 2011-10-03 04:05:44 -0700 Created attachment 109465 Patch 476999 2 109465 mrobinson 2011-10-03 08:49:56 -0700 Comment on attachment 109465 Patch Excellent. 477017 3 cgarcia 2011-10-03 09:17:02 -0700 Committed r96508: <http://trac.webkit.org/changeset/96508> 109465 2011-10-03 04:05:44 -0700 2011-10-03 08:49:56 -0700 Patch wk2-memleaks.diff text/plain 3504 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZDdjZWFiLi42Njg0ZjUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEZpeCBtZW1vcnkgbGVhayB3aGVuIGxvYWRpbmcgdXJsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTI0NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbGVhc2UgVVJMIGNy ZWF0ZWQgd2l0aCBXS1VSTENyZWF0ZVdpdGhVVEY4Q1N0cmluZygpLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3Zp ZXdfbG9hZF91cmkpOgorCiAyMDExLTEwLTAyICBaZW5vIEFsYmlzc2VyICA8emVuby5hbGJpc3Nl ckBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XVtXSzJdW01hY10gV2ViS2l0MiBkb2VzIG5vdCBi dWlsZCBvbiBtYWMgYWZ0ZXIgbWVyZ2Ugb2YgUXQ1IHJlZmFjdG9yIGJyYW5jaC4KZGlmZiAtLWdp dCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMGNiNDI3Li44N2Vi YjlhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBtZW1vcnkgbGVhayB3aGVuIGxvYWRp bmcgdXJsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 OTI0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl bGVhc2UgVVJMIGNyZWF0ZWQgd2l0aCBXS1VSTENyZWF0ZVdpdGhVVEY4Q1N0cmluZygpLgorCisg ICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYzoKKyAgICAgICAgKGFjdGl2 YXRlVXJpRW50cnlDYWxsYmFjayk6CisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL21haW4uYzoK KyAgICAgICAgKGxvYWRVUkkpOgorCiAyMDExLTEwLTAyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQ2xlYW4gdXAgb2Jzb2xldGUgY29kZSBpbiBnYXJkZW5pbmdz ZXJ2ZXIucHkgcmVsYXRlZCB0bwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJWaWV3LmNwcAppbmRleCA5MmRhYTI0Li44OTNlYzRkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcApAQCAt MjE2LDggKzIxNiwxMCBAQCB2b2lkIHdlYmtpdF93ZWJfdmlld19sb2FkX3VyaShXZWJLaXRXZWJW aWV3KiB3ZWJWaWV3LCBjb25zdCBnY2hhciogdXJpKQogICAgIGdfcmV0dXJuX2lmX2ZhaWwoV0VC S0lUX0lTX1dFQl9WSUVXKHdlYlZpZXcpKTsKICAgICBnX3JldHVybl9pZl9mYWlsKHVyaSk7CiAK KyAgICBXS1VSTFJlZiB1cmwgPSBXS1VSTENyZWF0ZVdpdGhVVEY4Q1N0cmluZyh1cmkpOwogICAg IFdlYlBhZ2VQcm94eSogcGFnZSA9IHdlYmtpdFdlYlZpZXdCYXNlR2V0UGFnZShXRUJLSVRfV0VC X1ZJRVdfQkFTRSh3ZWJWaWV3KSk7Ci0gICAgV0tQYWdlTG9hZFVSTCh0b0FQSShwYWdlKSwgV0tV UkxDcmVhdGVXaXRoVVRGOENTdHJpbmcodXJpKSk7CisgICAgV0tQYWdlTG9hZFVSTCh0b0FQSShw YWdlKSwgdXJsKTsKKyAgICBXS1JlbGVhc2UodXJsKTsKIH0KIAogLyoqCmRpZmYgLS1naXQgYS9U b29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jIGIvVG9vbHMvTWluaUJyb3dzZXIv Z3RrL0Jyb3dzZXJXaW5kb3cuYwppbmRleCA3OWU4ZDIwLi4wMjhiZTUxIDEwMDY0NAotLS0gYS9U b29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCisrKyBiL1Rvb2xzL01pbmlCcm93 c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKQEAgLTY0LDggKzY0LDkgQEAgR19ERUZJTkVfVFlQRShC cm93c2VyV2luZG93LCBicm93c2VyX3dpbmRvdywgR1RLX1RZUEVfV0lORE9XKQogCiBzdGF0aWMg dm9pZCBhY3RpdmF0ZVVyaUVudHJ5Q2FsbGJhY2soQnJvd3NlcldpbmRvdyogd2luZG93KQogewot ICAgIGNvbnN0IGdjaGFyICp1cmkgPSBndGtfZW50cnlfZ2V0X3RleHQoR1RLX0VOVFJZKHdpbmRv dy0+dXJpRW50cnkpKTsKLSAgICBXS1BhZ2VMb2FkVVJMKFdLVmlld0dldFBhZ2Uod2luZG93LT53 ZWJWaWV3KSwgV0tVUkxDcmVhdGVXaXRoVVRGOENTdHJpbmcodXJpKSk7CisgICAgV0tVUkxSZWYg dXJsID0gV0tVUkxDcmVhdGVXaXRoVVRGOENTdHJpbmcoZ3RrX2VudHJ5X2dldF90ZXh0KEdUS19F TlRSWSh3aW5kb3ctPnVyaUVudHJ5KSkpOworICAgIFdLUGFnZUxvYWRVUkwoV0tWaWV3R2V0UGFn ZSh3aW5kb3ctPndlYlZpZXcpLCB1cmwpOworICAgIFdLUmVsZWFzZSh1cmwpOwogfQogCiBzdGF0 aWMgdm9pZCBnb0JhY2tDYWxsYmFjayhCcm93c2VyV2luZG93KiB3aW5kb3cpCmRpZmYgLS1naXQg YS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL21h aW4uYwppbmRleCAzY2JmMmJjLi43Mzg3Mjc5IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nl ci9ndGsvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMKQEAgLTYxLDgg KzYxLDEwIEBAIHN0YXRpYyB2b2lkIGxvYWRVUkkoY29uc3QgZ2NoYXIgKnVyaSwgV0tDb250ZXh0 UmVmIHByb2Nlc3NDb250ZXh0KQogICAgIFdLVmlld1JlZiB3ZWJWaWV3ID0gV0tWaWV3Q3JlYXRl KHByb2Nlc3NDb250ZXh0LCAwKTsKICAgICBHdGtXaWRnZXQgKm1haW5XaW5kb3cgPSBicm93c2Vy X3dpbmRvd19uZXcod2ViVmlldyk7CiAgICAgZ2NoYXIgKnVybCA9IGFyZ3VtZW50VG9VUkwodXJp KTsKLSAgICBXS1BhZ2VMb2FkVVJMKFdLVmlld0dldFBhZ2Uod2ViVmlldyksIFdLVVJMQ3JlYXRl V2l0aFVURjhDU3RyaW5nKHVybCkpOworICAgIFdLVVJMUmVmIHdrVVJMID0gV0tVUkxDcmVhdGVX aXRoVVRGOENTdHJpbmcodXJsKTsKICAgICBnX2ZyZWUodXJsKTsKKyAgICBXS1BhZ2VMb2FkVVJM KFdLVmlld0dldFBhZ2Uod2ViVmlldyksIHdrVVJMKTsKKyAgICBXS1JlbGVhc2Uod2tVUkwpOwog CiAgICAgZ3RrX3dpZGdldF9ncmFiX2ZvY3VzKEdUS19XSURHRVQod2ViVmlldykpOwogICAgIGd0 a193aWRnZXRfc2hvdyhtYWluV2luZG93KTsK