69217 2011-10-01 15:44:35 -0700 [chromium] Regression: Composited layers always draw with an identity transform 2011-10-01 19:21:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vangelis vangelis enne jamesr webkit.review.bot oldest_to_newest 476602 0 vangelis 2011-10-01 15:44:35 -0700 A regression caused by: http://trac.webkit.org/changeset/96454 TiledLayerChromium no longer updates the value of m_tiledTransform on the CCTiledLayerImpl. Computation of the tiledTransform was moved to the Impl but is not actually getting used at draw time. 476607 1 jamesr 2011-10-01 17:02:03 -0700 d'oh, my bad for flipping bits too early. Can you revert? 476609 2 109411 vangelis 2011-10-01 17:18:55 -0700 Created attachment 109411 Patch 476619 3 109411 webkit.review.bot 2011-10-01 19:20:56 -0700 Comment on attachment 109411 Patch Clearing flags on attachment: 109411 Committed r96467: <http://trac.webkit.org/changeset/96467> 476620 4 webkit.review.bot 2011-10-01 19:21:01 -0700 All reviewed patches have been landed. Closing bug. 109411 2011-10-01 17:18:55 -0700 2011-10-01 19:20:56 -0700 Patch bug-69217-20111001171854.patch text/plain 5333 vangelis SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2NDY0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMDEgIFZhbmdlbGlz IEtva2tldmlzICA8dmFuZ2VsaXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Rml4aW5nIGRyYXcgbWF0cml4IGZvciBjb21wb3NpdGVkIGxheWVycy4gVGhpcworICAgICAgICB3 YXMgYSByZWdyZXNzaW9uIGludHJvZHVjZWQgYnk6CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0Lzk2NDU0CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY5MjE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGVzdHM6IGNvbXBvc2l0b3IgdGVzdCBub3cgcGFzcworCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaWxlZExheWVySW1wbC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDQ1RpbGVkTGF5ZXJJbXBsOjpkcmF3KToKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1RpbGVkTGF5ZXJJbXBsLmg6CisKIDIwMTEtMTAt MDEgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5NjQyMS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGlsZWRMYXllckltcGwuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGls ZWRMYXllckltcGwuY3BwCShyZXZpc2lvbiA5NjQ2NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGlsZWRMYXllckltcGwuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMTcsNyArMTE3LDggQEAgdm9pZCBDQ1RpbGVkTGF5ZXJJbXBsOjpkcmF3KExheWVy UmVuZGVyZQogICAgIGlmIChtX3NraXBzRHJhdyB8fCAhbV90aWxlciB8fCBtX3RpbGVyLT5pc0Vt cHR5KCkgfHwgbGF5ZXJSZWN0LmlzRW1wdHkoKSB8fCAhbGF5ZXJSZW5kZXJlcikKICAgICAgICAg cmV0dXJuOwogCi0gICAgVHJhbnNmb3JtYXRpb25NYXRyaXggZGV2aWNlTWF0cml4ID0gVHJhbnNm b3JtYXRpb25NYXRyaXgobGF5ZXJSZW5kZXJlci0+d2luZG93TWF0cml4KCkgKiBsYXllclJlbmRl cmVyLT5wcm9qZWN0aW9uTWF0cml4KCkgKiBtX3RpbGluZ1RyYW5zZm9ybSkudG8yZFRyYW5zZm9y bSgpOworICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IGxheWVyVHJhbnNmb3JtID0gdGlsaW5nVHJh bnNmb3JtKCk7CisgICAgVHJhbnNmb3JtYXRpb25NYXRyaXggZGV2aWNlTWF0cml4ID0gVHJhbnNm b3JtYXRpb25NYXRyaXgobGF5ZXJSZW5kZXJlci0+d2luZG93TWF0cml4KCkgKiBsYXllclJlbmRl cmVyLT5wcm9qZWN0aW9uTWF0cml4KCkgKiBsYXllclRyYW5zZm9ybSkudG8yZFRyYW5zZm9ybSgp OwogCiAgICAgLy8gRG9uJ3QgZHJhdyBhbnkgdGlsZXMgd2hlbiBkZXZpY2UgbWF0cml4IGlzIG5v dCBpbnZlcnRpYmxlLgogICAgIGlmICghZGV2aWNlTWF0cml4LmlzSW52ZXJ0aWJsZSgpKQpAQCAt MTUwLDE5ICsxNTEsMTkgQEAgdm9pZCBDQ1RpbGVkTGF5ZXJJbXBsOjpkcmF3KExheWVyUmVuZGVy ZQogICAgIGNhc2UgTGF5ZXJUZXh0dXJlVXBkYXRlcjo6U2FtcGxlZFRleGVsRm9ybWF0UkdCQToK ICAgICAgICAgaWYgKHVzZUFBKSB7CiAgICAgICAgICAgICBjb25zdCBQcm9ncmFtQUEqIHByb2dy YW0gPSBsYXllclJlbmRlcmVyLT50aWxlclByb2dyYW1BQSgpOwotICAgICAgICAgICAgZHJhd1Rp bGVzKGxheWVyUmVuZGVyZXIsIGxheWVyUmVjdCwgbV90aWxpbmdUcmFuc2Zvcm0sIGRldmljZU1h dHJpeCwgZGV2aWNlUmVjdCwgbGF5ZXJRdWFkLCBkcmF3T3BhY2l0eSgpLCBwcm9ncmFtLCBwcm9n cmFtLT5mcmFnbWVudFNoYWRlcigpLmZyYWdtZW50VGV4VHJhbnNmb3JtTG9jYXRpb24oKSwgcHJv Z3JhbS0+ZnJhZ21lbnRTaGFkZXIoKS5lZGdlTG9jYXRpb24oKSk7CisgICAgICAgICAgICBkcmF3 VGlsZXMobGF5ZXJSZW5kZXJlciwgbGF5ZXJSZWN0LCBsYXllclRyYW5zZm9ybSwgZGV2aWNlTWF0 cml4LCBkZXZpY2VSZWN0LCBsYXllclF1YWQsIGRyYXdPcGFjaXR5KCksIHByb2dyYW0sIHByb2dy YW0tPmZyYWdtZW50U2hhZGVyKCkuZnJhZ21lbnRUZXhUcmFuc2Zvcm1Mb2NhdGlvbigpLCBwcm9n cmFtLT5mcmFnbWVudFNoYWRlcigpLmVkZ2VMb2NhdGlvbigpKTsKICAgICAgICAgfSBlbHNlIHsK ICAgICAgICAgICAgIGNvbnN0IFByb2dyYW0qIHByb2dyYW0gPSBsYXllclJlbmRlcmVyLT50aWxl clByb2dyYW0oKTsKLSAgICAgICAgICAgIGRyYXdUaWxlcyhsYXllclJlbmRlcmVyLCBsYXllclJl Y3QsIG1fdGlsaW5nVHJhbnNmb3JtLCBkZXZpY2VNYXRyaXgsIGRldmljZVJlY3QsIGxheWVyUXVh ZCwgZHJhd09wYWNpdHkoKSwgcHJvZ3JhbSwgLTEsIC0xKTsKKyAgICAgICAgICAgIGRyYXdUaWxl cyhsYXllclJlbmRlcmVyLCBsYXllclJlY3QsIGxheWVyVHJhbnNmb3JtLCBkZXZpY2VNYXRyaXgs IGRldmljZVJlY3QsIGxheWVyUXVhZCwgZHJhd09wYWNpdHkoKSwgcHJvZ3JhbSwgLTEsIC0xKTsK ICAgICAgICAgfQogICAgICAgICBicmVhazsKICAgICBjYXNlIExheWVyVGV4dHVyZVVwZGF0ZXI6 OlNhbXBsZWRUZXhlbEZvcm1hdEJHUkE6CiAgICAgICAgIGlmICh1c2VBQSkgewogICAgICAgICAg ICAgY29uc3QgUHJvZ3JhbVN3aXp6bGVBQSogcHJvZ3JhbSA9IGxheWVyUmVuZGVyZXItPnRpbGVy UHJvZ3JhbVN3aXp6bGVBQSgpOwotICAgICAgICAgICAgZHJhd1RpbGVzKGxheWVyUmVuZGVyZXIs IGxheWVyUmVjdCwgbV90aWxpbmdUcmFuc2Zvcm0sIGRldmljZU1hdHJpeCwgZGV2aWNlUmVjdCwg bGF5ZXJRdWFkLCBkcmF3T3BhY2l0eSgpLCBwcm9ncmFtLCBwcm9ncmFtLT5mcmFnbWVudFNoYWRl cigpLmZyYWdtZW50VGV4VHJhbnNmb3JtTG9jYXRpb24oKSwgcHJvZ3JhbS0+ZnJhZ21lbnRTaGFk ZXIoKS5lZGdlTG9jYXRpb24oKSk7CisgICAgICAgICAgICBkcmF3VGlsZXMobGF5ZXJSZW5kZXJl ciwgbGF5ZXJSZWN0LCBsYXllclRyYW5zZm9ybSwgZGV2aWNlTWF0cml4LCBkZXZpY2VSZWN0LCBs YXllclF1YWQsIGRyYXdPcGFjaXR5KCksIHByb2dyYW0sIHByb2dyYW0tPmZyYWdtZW50U2hhZGVy KCkuZnJhZ21lbnRUZXhUcmFuc2Zvcm1Mb2NhdGlvbigpLCBwcm9ncmFtLT5mcmFnbWVudFNoYWRl cigpLmVkZ2VMb2NhdGlvbigpKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIGNvbnN0 IFByb2dyYW1Td2l6emxlKiBwcm9ncmFtID0gbGF5ZXJSZW5kZXJlci0+dGlsZXJQcm9ncmFtU3dp enpsZSgpOwotICAgICAgICAgICAgZHJhd1RpbGVzKGxheWVyUmVuZGVyZXIsIGxheWVyUmVjdCwg bV90aWxpbmdUcmFuc2Zvcm0sIGRldmljZU1hdHJpeCwgZGV2aWNlUmVjdCwgbGF5ZXJRdWFkLCBk cmF3T3BhY2l0eSgpLCBwcm9ncmFtLCAtMSwgLTEpOworICAgICAgICAgICAgZHJhd1RpbGVzKGxh eWVyUmVuZGVyZXIsIGxheWVyUmVjdCwgbGF5ZXJUcmFuc2Zvcm0sIGRldmljZU1hdHJpeCwgZGV2 aWNlUmVjdCwgbGF5ZXJRdWFkLCBkcmF3T3BhY2l0eSgpLCBwcm9ncmFtLCAtMSwgLTEpOwogICAg ICAgICB9CiAgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1RpbGVkTGF5ZXJJbXBsLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NU aWxlZExheWVySW1wbC5oCShyZXZpc2lvbiA5NjQ2NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGlsZWRMYXllckltcGwuaAkod29ya2luZyBjb3B5 KQpAQCAtNDgsNyArNDgsNiBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQgZHVtcExheWVy UHJvcGVydGllcyhUZXh0U3RyZWFtJiwgaW50IGluZGVudCkgY29uc3Q7CiAKLSAgICB2b2lkIHNl dFRpbGluZ1RyYW5zZm9ybShjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgdGlsaW5nVHJhbnNm b3JtKSB7IG1fdGlsaW5nVHJhbnNmb3JtID0gdGlsaW5nVHJhbnNmb3JtOyB9CiAgICAgdm9pZCBz ZXRTa2lwc0RyYXcoYm9vbCBza2lwc0RyYXcpIHsgbV9za2lwc0RyYXcgPSBza2lwc0RyYXc7IH0K ICAgICB2b2lkIHNldFRleHR1cmVPcmllbnRhdGlvbihMYXllclRleHR1cmVVcGRhdGVyOjpPcmll bnRhdGlvbiB0ZXh0dXJlT3JpZW50YXRpb24pIHsgbV90ZXh0dXJlT3JpZW50YXRpb24gPSB0ZXh0 dXJlT3JpZW50YXRpb247IH0KICAgICB2b2lkIHNldFNhbXBsZWRUZXhlbEZvcm1hdChMYXllclRl eHR1cmVVcGRhdGVyOjpTYW1wbGVkVGV4ZWxGb3JtYXQgc2FtcGxlZFRleGVsRm9ybWF0KSB7IG1f c2FtcGxlZFRleGVsRm9ybWF0ID0gc2FtcGxlZFRleGVsRm9ybWF0OyB9CkBAIC04MSw3ICs4MCw2 IEBAIHByaXZhdGU6CiAgICAgdGVtcGxhdGUgPGNsYXNzIFQ+CiAgICAgdm9pZCBkcmF3VGlsZXMo TGF5ZXJSZW5kZXJlckNocm9taXVtKiwgY29uc3QgSW50UmVjdCYgY29udGVudFJlY3QsIGNvbnN0 IFRyYW5zZm9ybWF0aW9uTWF0cml4JiBnbG9iYWxUcmFuc2Zvcm0sIGNvbnN0IFRyYW5zZm9ybWF0 aW9uTWF0cml4JiBkZXZpY2VUcmFuc2Zvcm0sIGNvbnN0IENDTGF5ZXJRdWFkJiBkZXZpY2VSZWN0 LCBjb25zdCBDQ0xheWVyUXVhZCYgY29udGVudFF1YWQsIGZsb2F0IG9wYWNpdHksIGNvbnN0IFQq IHByb2dyYW0sIGludCBmcmFnbWVudFRleFRyYW5zZm9ybUxvY2F0aW9uLCBpbnQgZWRnZUxvY2F0 aW9uKTsKIAotICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IG1fdGlsaW5nVHJhbnNmb3JtOwogICAg IGJvb2wgbV9za2lwc0RyYXc7CiAgICAgTGF5ZXJUZXh0dXJlVXBkYXRlcjo6T3JpZW50YXRpb24g bV90ZXh0dXJlT3JpZW50YXRpb247CiAgICAgTGF5ZXJUZXh0dXJlVXBkYXRlcjo6U2FtcGxlZFRl eGVsRm9ybWF0IG1fc2FtcGxlZFRleGVsRm9ybWF0Owo=