69205 2011-09-30 22:49:47 -0700 JSVALUE32_64 DFG JIT - unboxed integers and cells in register file must be reboxed before exiting from DFG JIT 2011-10-01 12:20:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 476538 0 yuqiang.xian 2011-09-30 22:49:47 -0700 If there are unboxed integers and cells in register file (e.g. by SetLocal), they must be reboxed before exiting from the speculative DFG JIT execution. 476541 1 109397 yuqiang.xian 2011-09-30 23:06:15 -0700 Created attachment 109397 the patch This scrubs all obvious crashes of DFG32_64 on SunSpider and kraken cases. Also the number of mozilla test failure cases is reduced to 65/1127 if with op_call/op_construct enabled in DFG32_64 (comparing to the 57/1127 if without op_call/op_construct support). - Tested on Linux x86. 476542 2 109397 fpizlo 2011-09-30 23:08:42 -0700 Comment on attachment 109397 the patch This looks great. I'd r+ if I officially had review privileges. :-) 476583 3 109397 webkit.review.bot 2011-10-01 12:20:50 -0700 Comment on attachment 109397 the patch Clearing flags on attachment: 109397 Committed r96458: <http://trac.webkit.org/changeset/96458> 476584 4 webkit.review.bot 2011-10-01 12:20:54 -0700 All reviewed patches have been landed. Closing bug. 109397 2011-09-30 23:06:15 -0700 2011-10-01 12:20:50 -0700 the patch 69205.patch text/plain 6790 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTY0NTQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAK KzIwMTEtMDktMzAgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgSlNWQUxVRTMyXzY0IERGRyBKSVQgLSB1bmJveGVkIGludGVnZXJzIGFuZCBjZWxscyBp biByZWdpc3RlciBmaWxlIG11c3QgYmUgcmVib3hlZCBiZWZvcmUgZXhpdGluZyBmcm9tIERGRyBK SVQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MjA1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhl cmUgYXJlIHVuYm94ZWQgaW50ZWdlcnMgYW5kIGNlbGxzIGluIHJlZ2lzdGVyIGZpbGUgKGUuZy4g YnkgU2V0TG9jYWwpLCAKKyAgICAgICAgdGhleSBtdXN0IGJlIHJlYm94ZWQgYmVmb3JlIGV4aXRp bmcgZnJvbSB0aGUgc3BlY3VsYXRpdmUgREZHIEpJVCBleGVjdXRpb24uCisgICAgICAgIFRoaXMg cGF0Y2ggYWxzbyBhZGRzIGEgbmV3IFZhbHVlU291cmNlS2luZCAoQ2VsbEluUmVnaXN0ZXJGaWxl KSBhbmQgYSBuZXcKKyAgICAgICAgVmFsdWVSZWNvdmVyeVRlY2huaXF1ZSAoQWxyZWFkeUluUmVn aXN0ZXJGaWxlQXNDZWxsKS4KKworICAgICAgICAqIGRmZy9ERkdKSVRDb21waWxlcjMyXzY0LmNw cDoKKyAgICAgICAgKEpTQzo6REZHOjpKSVRDb21waWxlcjo6ZXhpdFNwZWN1bGF0aXZlV2l0aE9T Uik6CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6 REZHOjpWYWx1ZVNvdXJjZTo6ZHVtcCk6CisgICAgICAgIChKU0M6OkRGRzo6VmFsdWVSZWNvdmVy eTo6ZHVtcCk6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXB1dGVWYWx1 ZVJlY292ZXJ5Rm9yKToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuaDoKKyAgICAg ICAgKEpTQzo6REZHOjpWYWx1ZVNvdXJjZTo6Zm9yUHJlZGljdGlvbik6CisgICAgICAgIChKU0M6 OkRGRzo6VmFsdWVSZWNvdmVyeTo6YWxyZWFkeUluUmVnaXN0ZXJGaWxlQXNVbmJveGVkQ2VsbCk6 CisKIDIwMTEtMDktMzAgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgogCiAgICAg ICAgIEF0dGVtcHQgdG8gZml4IHRoZSBBcHBsZSBXaW5kb3dzIGFuZCBXaW5DYWlybyBEZWJ1ZyBi dWlsZHMgYWZ0ZXIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGls ZXIzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdK SVRDb21waWxlcjMyXzY0LmNwcAkocmV2aXNpb24gOTY0NTQpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0pJVENvbXBpbGVyMzJfNjQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDYs NyArMTQ2LDggQEAgdm9pZCBKSVRDb21waWxlcjo6ZXhpdFNwZWN1bGF0aXZlV2l0aE9TUgogICAg IC8vIEludDMycywgaGF2ZSBubyBGUFJzLCBhbmQgaGF2ZSBubyBjb25zdGFudHMuIElmIHRoZXJl IGFyZSBjb25zdGFudHMsIHdlCiAgICAgLy8gZXhwZWN0IG1vc3Qgb2YgdGhlbSB0byBiZSBqc1Vu ZGVmaW5lZCgpOyBpZiB0aGF0J3MgdHJ1ZSB0aGVuIHdlIGhhbmRsZSB0aGF0CiAgICAgLy8gc3Bl Y2lhbGx5IHRvIG1pbmltaXplIGNvZGUgc2l6ZSBhbmQgZXhlY3V0aW9uIHRpbWUuCi0gICAgYm9v bCBoYXZlVW5ib3hlZEludDMycyA9IGZhbHNlOworICAgIGJvb2wgaGF2ZVVuYm94ZWRJbnQzMklu UmVnaXN0ZXJGaWxlID0gZmFsc2U7CisgICAgYm9vbCBoYXZlVW5ib3hlZENlbGxJblJlZ2lzdGVy RmlsZSA9IGZhbHNlOwogICAgIGJvb2wgaGF2ZUZQUnMgPSBmYWxzZTsKICAgICBib29sIGhhdmVD b25zdGFudHMgPSBmYWxzZTsKICAgICBib29sIGhhdmVVbmRlZmluZWQgPSBmYWxzZTsKQEAgLTE4 Miw4ICsxODMsMTIgQEAgdm9pZCBKSVRDb21waWxlcjo6ZXhpdFNwZWN1bGF0aXZlV2l0aE9TUgog ICAgICAgICAgICAgfQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAKLSAgICAgICAg Y2FzZSBVbmJveGVkSW50MzJJbkdQUjoKLSAgICAgICAgICAgIGhhdmVVbmJveGVkSW50MzJzID0g dHJ1ZTsKKyAgICAgICAgY2FzZSBBbHJlYWR5SW5SZWdpc3RlckZpbGVBc1VuYm94ZWRJbnQzMjoK KyAgICAgICAgICAgIGhhdmVVbmJveGVkSW50MzJJblJlZ2lzdGVyRmlsZSA9IHRydWU7CisgICAg ICAgICAgICBicmVhazsKKyAgICAgICAgICAgIAorICAgICAgICBjYXNlIEFscmVhZHlJblJlZ2lz dGVyRmlsZUFzVW5ib3hlZENlbGw6CisgICAgICAgICAgICBoYXZlVW5ib3hlZENlbGxJblJlZ2lz dGVyRmlsZSA9IHRydWU7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIAogICAgICAg ICBjYXNlIEluRlBSOgpAQCAtMjA2LDkgKzIxMSwyNiBAQCB2b2lkIEpJVENvbXBpbGVyOjpleGl0 U3BlY3VsYXRpdmVXaXRoT1NSCiAgICAgLy8gRnJvbSBoZXJlIG9uLCB0aGUgY29kZSBhc3N1bWVz IHRoYXQgaXQgaXMgcHJvZml0YWJsZSB0byBtYXhpbWl6ZSB0aGUgZGlzdGFuY2UKICAgICAvLyBi ZXR3ZWVuIHdoZW4gc29tZXRoaW5nIGlzIGNvbXB1dGVkIGFuZCB3aGVuIGl0IGlzIHN0b3JlZC4K ICAgICAKLSAgICAvLyA0KSBQZXJmb3JtIGFsbCByZWJveGluZyBvZiBpbnRlZ2Vycy4KLSAgICAv LyAgICBDdXJyZW50bHkgd2UgZG9uJ3QgcmVib3ggZm9yIEpTVmFsdWUzMl82NC4KLSAgICAKKyAg ICAvLyA0KSBQZXJmb3JtIGFsbCByZWJveGluZyBvZiBpbnRlZ2VycyBhbmQgY2VsbHMsIGV4Y2Vw dCBmb3IgdGhvc2UgaW4gcmVnaXN0ZXJzLgorCisgICAgaWYgKGhhdmVVbmJveGVkSW50MzJJblJl Z2lzdGVyRmlsZSB8fCBoYXZlVW5ib3hlZENlbGxJblJlZ2lzdGVyRmlsZSkgeworICAgICAgICBm b3IgKGludCBpbmRleCA9IDA7IGluZGV4IDwgZXhpdC5udW1iZXJPZlJlY292ZXJpZXMoKTsgKytp bmRleCkgeworICAgICAgICAgICAgY29uc3QgVmFsdWVSZWNvdmVyeSYgcmVjb3ZlcnkgPSBleGl0 LnZhbHVlUmVjb3ZlcnkoaW5kZXgpOworICAgICAgICAgICAgc3dpdGNoIChyZWNvdmVyeS50ZWNo bmlxdWUoKSkgeworICAgICAgICAgICAgY2FzZSBBbHJlYWR5SW5SZWdpc3RlckZpbGVBc1VuYm94 ZWRJbnQzMjoKKyAgICAgICAgICAgICAgICBzdG9yZTMyKFRydXN0ZWRJbW0zMihKU1ZhbHVlOjpJ bnQzMlRhZyksIHRhZ0ZvcihzdGF0aWNfY2FzdDxWaXJ0dWFsUmVnaXN0ZXI+KGV4aXQub3BlcmFu ZEZvckluZGV4KGluZGV4KSkpKTsKKyAgICAgICAgICAgICAgICBicmVhazsKKworICAgICAgICAg ICAgY2FzZSBBbHJlYWR5SW5SZWdpc3RlckZpbGVBc1VuYm94ZWRDZWxsOgorICAgICAgICAgICAg ICAgIHN0b3JlMzIoVHJ1c3RlZEltbTMyKEpTVmFsdWU6OkNlbGxUYWcpLCB0YWdGb3Ioc3RhdGlj X2Nhc3Q8VmlydHVhbFJlZ2lzdGVyPihleGl0Lm9wZXJhbmRGb3JJbmRleChpbmRleCkpKSk7Cisg ICAgICAgICAgICAgICAgYnJlYWs7CisKKyAgICAgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAg ICAgICAgYnJlYWs7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9CisKICAgICAvLyA1 KSBEdW1wIGFsbCBub24tcG9pc29uZWQgR1BScy4gRm9yIHBvaXNvbmVkIEdQUnMsIHNhdmUgdGhl bSBpbnRvIHRoZSBzY3JhdGNoIHN0b3JhZ2UuCiAgICAgLy8gICAgTm90ZSB0aGF0IEdQUnMgZG8g bm90IGhhdmUgYSBmYXN0IGNoYW5nZSAobGlrZSBoYXZlRlBScykgYmVjYXVzZSB3ZSBleHBlY3Qg dGhhdAogICAgIC8vICAgIG1vc3QgT1NSIGZhaWx1cmUgcG9pbnRzIHdpbGwgaGF2ZSBhdCBsZWFz dCBvbmUgR1BSIHRoYXQgbmVlZHMgdG8gYmUgZHVtcGVkLgpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHJldmlzaW9uIDk2NDU0KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQ0LDYgKzQ0LDkgQEAgdm9pZCBWYWx1ZVNvdXJjZTo6ZHVtcChGSUxFKiBv dXQpIGNvbnN0CiAgICAgY2FzZSBJbnQzMkluUmVnaXN0ZXJGaWxlOgogICAgICAgICBmcHJpbnRm KG91dCwgIkludDMyIik7CiAgICAgICAgIGJyZWFrOworICAgIGNhc2UgQ2VsbEluUmVnaXN0ZXJG aWxlOgorICAgICAgICBmcHJpbnRmKG91dCwgIkNlbGwiKTsKKyAgICAgICAgYnJlYWs7CiAgICAg Y2FzZSBIYXZlTm9kZToKICAgICAgICAgZnByaW50ZihvdXQsICJOb2RlKCVkKSIsIG1fbm9kZUlu ZGV4KTsKICAgICAgICAgYnJlYWs7CkBAIC01OSw2ICs2Miw5IEBAIHZvaWQgVmFsdWVSZWNvdmVy eTo6ZHVtcChGSUxFKiBvdXQpIGNvbnMKICAgICBjYXNlIEFscmVhZHlJblJlZ2lzdGVyRmlsZUFz VW5ib3hlZEludDMyOgogICAgICAgICBmcHJpbnRmKG91dCwgIihpbnQzMikiKTsKICAgICAgICAg YnJlYWs7CisgICAgY2FzZSBBbHJlYWR5SW5SZWdpc3RlckZpbGVBc1VuYm94ZWRDZWxsOgorICAg ICAgICBmcHJpbnRmKG91dCwgIihjZWxsKSIpOworICAgICAgICBicmVhazsKICAgICBjYXNlIElu R1BSOgogICAgICAgICBmcHJpbnRmKG91dCwgIiUlJXMiLCBHUFJJbmZvOjpkZWJ1Z05hbWUoZ3By KCkpKTsKICAgICAgICAgYnJlYWs7CkBAIC0zOTksNiArNDA1LDkgQEAgVmFsdWVSZWNvdmVyeSBT cGVjdWxhdGl2ZUpJVDo6Y29tcHV0ZVZhbAogICAgIGNhc2UgSW50MzJJblJlZ2lzdGVyRmlsZToK ICAgICAgICAgcmV0dXJuIFZhbHVlUmVjb3Zlcnk6OmFscmVhZHlJblJlZ2lzdGVyRmlsZUFzVW5i b3hlZEludDMyKCk7CiAKKyAgICBjYXNlIENlbGxJblJlZ2lzdGVyRmlsZToKKyAgICAgICAgcmV0 dXJuIFZhbHVlUmVjb3Zlcnk6OmFscmVhZHlJblJlZ2lzdGVyRmlsZUFzVW5ib3hlZENlbGwoKTsK KwogICAgIGNhc2UgSGF2ZU5vZGU6IHsKICAgICAgICAgaWYgKG1faml0LmlzQ29uc3RhbnQodmFs dWVTb3VyY2Uubm9kZUluZGV4KCkpKQogICAgICAgICAgICAgcmV0dXJuIFZhbHVlUmVjb3Zlcnk6 OmNvbnN0YW50KG1faml0LnZhbHVlT2ZKU0NvbnN0YW50KHZhbHVlU291cmNlLm5vZGVJbmRleCgp KSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VC5oCShyZXZpc2lvbiA5NjQ1NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Bl Y3VsYXRpdmVKSVQuaAkod29ya2luZyBjb3B5KQpAQCAtNzAsNiArNzAsNyBAQCBlbnVtIFZhbHVl U291cmNlS2luZCB7CiAgICAgU291cmNlTm90U2V0LAogICAgIFZhbHVlSW5SZWdpc3RlckZpbGUs CiAgICAgSW50MzJJblJlZ2lzdGVyRmlsZSwKKyAgICBDZWxsSW5SZWdpc3RlckZpbGUsCiAgICAg SGF2ZU5vZGUKIH07CiAKQEAgLTk3LDYgKzk4LDggQEAgcHVibGljOgogICAgIHsKICAgICAgICAg aWYgKGlzSW50MzJQcmVkaWN0aW9uKHByZWRpY3Rpb24pKQogICAgICAgICAgICAgcmV0dXJuIFZh bHVlU291cmNlKEludDMySW5SZWdpc3RlckZpbGUpOworICAgICAgICBpZiAoaXNDZWxsUHJlZGlj dGlvbihwcmVkaWN0aW9uKSkKKyAgICAgICAgICAgIHJldHVybiBWYWx1ZVNvdXJjZShDZWxsSW5S ZWdpc3RlckZpbGUpOwogICAgICAgICByZXR1cm4gVmFsdWVTb3VyY2UoVmFsdWVJblJlZ2lzdGVy RmlsZSk7CiAgICAgfQogICAgIApAQCAtMTQ1LDYgKzE0OCw3IEBAIGVudW0gVmFsdWVSZWNvdmVy eVRlY2huaXF1ZSB7CiAgICAgQWxyZWFkeUluUmVnaXN0ZXJGaWxlLAogICAgIC8vIEl0J3MgYWxy ZWFkeSBpbiB0aGUgcmVnaXN0ZXIgZmlsZSBidXQgdW5ib3hlZC4KICAgICBBbHJlYWR5SW5SZWdp c3RlckZpbGVBc1VuYm94ZWRJbnQzMiwKKyAgICBBbHJlYWR5SW5SZWdpc3RlckZpbGVBc1VuYm94 ZWRDZWxsLAogICAgIC8vIEl0J3MgaW4gYSByZWdpc3Rlci4KICAgICBJbkdQUiwKICAgICBVbmJv eGVkSW50MzJJbkdQUiwKQEAgLTE4MSw2ICsxODUsMTMgQEAgcHVibGljOgogICAgICAgICByZXR1 cm4gcmVzdWx0OwogICAgIH0KICAgICAKKyAgICBzdGF0aWMgVmFsdWVSZWNvdmVyeSBhbHJlYWR5 SW5SZWdpc3RlckZpbGVBc1VuYm94ZWRDZWxsKCkKKyAgICB7CisgICAgICAgIFZhbHVlUmVjb3Zl cnkgcmVzdWx0OworICAgICAgICByZXN1bHQubV90ZWNobmlxdWUgPSBBbHJlYWR5SW5SZWdpc3Rl ckZpbGVBc1VuYm94ZWRDZWxsOworICAgICAgICByZXR1cm4gcmVzdWx0OworICAgIH0KKyAgICAK ICAgICBzdGF0aWMgVmFsdWVSZWNvdmVyeSBpbkdQUihHUFJSZWcgZ3ByLCBEYXRhRm9ybWF0IGRh dGFGb3JtYXQpCiAgICAgewogICAgICAgICBBU1NFUlQoZGF0YUZvcm1hdCAhPSBEYXRhRm9ybWF0 Tm9uZSk7Cg==