69191 2011-09-30 17:04:59 -0700 [WinCairo] Correct build settings to allow DumpRenderTree (etc) to run 2011-10-01 21:35:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham webkit.review.bot oldest_to_newest 476421 0 bfulgham 2011-09-30 17:04:59 -0700 The existing project files are set up so that DumpRenderTree's post-build step copies various necessary files to the target location, which allows tests, etc., to run. Unfortunately, the WinCairo target does not use CoreFoundation.dll, and therefore skips the file copy step. This change modifies the post-build step so that the CFLite.dll case is handled properly. 476424 1 109376 bfulgham 2011-09-30 17:07:38 -0700 Created attachment 109376 Patch 476563 2 109376 webkit.review.bot 2011-10-01 00:59:08 -0700 Comment on attachment 109376 Patch Rejecting attachment 109376 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: iewer', u'Brian Weinstein', u'--..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file TOols/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file TOols/DumpRenderTree/win/DumpRenderTreePostBuild.cmd Hunk #1 FAILED at 4. Hunk #2 FAILED at 36. 2 out of 2 hunks FAILED -- saving rejects to file TOols/DumpRenderTree/win/DumpRenderTreePostBuild.cmd.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Brian Weinstein', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/9901619 476629 3 bfulgham 2011-10-01 21:35:14 -0700 Landed in r96468. 109376 2011-09-30 17:07:38 -0700 2011-10-01 00:59:08 -0700 Patch bug-69191-20110930170737.patch text/plain 3843 bfulgham SW5kZXg6IFRPb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUT29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk2NDM4KQorKysgVE9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDktMzAgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3Jn PgorCisgICAgICAgIENvcnJlY3QgcG9zdC1idWlsZCBzdGVwIGZvciBXaW5DYWlybyB0ZXN0IHJ1 bnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTE5 MSAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZVBvc3RCdWlsZC5jbWQ6IEFkZCBhZGRpdGlv bmFsCisgICAgICAgIHNoZWxsIGNhc2UgdG8gaGFuZGxlIHRoZSBDRkxpdGUgYnVpbGQuCisKIDIw MTEtMDktMzAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgZmFzdC9mb3Jtcy90ZXh0LWNvbnRyb2wtaW50cmluc2ljLXdpZHRocy5odG1sIGZhaWxzIG9u IE1hYyBpZiBXb3JkL09mZmljZSBmb250cyBhcmUgaW5zdGFsbGVkCkluZGV4OiBUT29scy9EdW1w UmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWVQb3N0QnVpbGQuY21kCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRPb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZVBvc3RCdWlsZC5jbWQJKHJl dmlzaW9uIDk2MzQ2KQorKysgVE9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVl UG9zdEJ1aWxkLmNtZAkod29ya2luZyBjb3B5KQpAQCAtNCw3ICs0LDcgQEAgaWYgbm90IGRlZmlu ZWQgQVJDSElWRV9CVUlMRCAoaWYgZGVmaW5lZAogCiBta2RpciAyPk5VTCAiJUNPTkZJR1VSQVRJ T05CVUlMRERJUiVcYmluIgogCi1pZiBub3QgZXhpc3QgIiVXRUJLSVRMSUJSQVJJRVNESVIlXGJp blxDb3JlRm91bmRhdGlvbiVMSUJSQVJZQ09ORklHU1VGRklYJS5kbGwiIGV4aXQgL2IKK2lmIG5v dCBleGlzdCAiJVdFQktJVExJQlJBUklFU0RJUiVcYmluXENvcmVGb3VuZGF0aW9uJUxJQlJBUllD T05GSUdTVUZGSVglLmRsbCIgR09UTzpDRkxJVEUKIAogeGNvcHkgL3kgL2QgIiVXRUJLSVRMSUJS QVJJRVNESVIlXGJpblxDb3JlRm91bmRhdGlvbiVMSUJSQVJZQ09ORklHU1VGRklYJS5kbGwiICIl Q09ORklHVVJBVElPTkJVSUxERElSJVxiaW4iCiB4Y29weSAveSAvZCAiJVdFQktJVExJQlJBUklF U0RJUiVcYmluXENvcmVGb3VuZGF0aW9uJUxJQlJBUllDT05GSUdTVUZGSVglLnBkYiIgIiVDT05G SUdVUkFUSU9OQlVJTERESVIlXGJpbiIKQEAgLTM2LDMgKzM2LDI3IEBAIHhjb3B5IC95IC9kICIl V0VCS0lUTElCUkFSSUVTRElSJVxiaW5cU1EKIHhjb3B5IC95IC9kICIlV0VCS0lUTElCUkFSSUVT RElSJVxiaW5cU1FMaXRlMyVMSUJSQVJZQ09ORklHU1VGRklYJS5wZGIiICIlQ09ORklHVVJBVElP TkJVSUxERElSJVxiaW4iCiB4Y29weSAveSAvZCAiJVdFQktJVExJQlJBUklFU0RJUiVcYmluXHps aWIxJUxJQlJBUllDT05GSUdTVUZGSVglLmRsbCIgIiVDT05GSUdVUkFUSU9OQlVJTERESVIlXGJp biIKIHhjb3B5IC95IC9kICIlV0VCS0lUTElCUkFSSUVTRElSJVxiaW5cemxpYjElTElCUkFSWUNP TkZJR1NVRkZJWCUucGRiIiAiJUNPTkZJR1VSQVRJT05CVUlMRERJUiVcYmluIgorZXhpdCAvYgor Cis6Q0ZMSVRFCitpZiBub3QgZXhpc3QgIiVXRUJLSVRMSUJSQVJJRVNESVIlXGJpblxDRkxpdGUl TElCUkFSWUNPTkZJR1NVRkZJWCUuZGxsIiBleGl0IC9iCisKK3hjb3B5IC95IC9kICIlV0VCS0lU TElCUkFSSUVTRElSJVxiaW5cQ0ZMaXRlJUxJQlJBUllDT05GSUdTVUZGSVglLmRsbCIgIiVDT05G SUdVUkFUSU9OQlVJTERESVIlXGJpbiIKK3hjb3B5IC95IC9kICIlV0VCS0lUTElCUkFSSUVTRElS JVxiaW5cQ0ZMaXRlJUxJQlJBUllDT05GSUdTVUZGSVglLnBkYiIgIiVDT05GSUdVUkFUSU9OQlVJ TERESVIlXGJpbiIKK3hjb3B5IC95IC9kIC9lIC9pICIlV0VCS0lUTElCUkFSSUVTRElSJVxiaW5c Q0ZMaXRlLnJlc291cmNlcyIgIiVDT05GSUdVUkFUSU9OQlVJTERESVIlXGJpblxDRkxpdGUucmVz b3VyY2VzIgoreGNvcHkgL3kgL2QgIiVXRUJLSVRMSUJSQVJJRVNESVIlXGJpblxsaWJjdXJsLmRs bCIgIiVDT05GSUdVUkFUSU9OQlVJTERESVIlXGJpbiIKK3hjb3B5IC95IC9kICIlV0VCS0lUTElC UkFSSUVTRElSJVxiaW5cbGliZWF5MzIuZGxsIiAiJUNPTkZJR1VSQVRJT05CVUlMRERJUiVcYmlu IgoreGNvcHkgL3kgL2QgIiVXRUJLSVRMSUJSQVJJRVNESVIlXGJpblxzc2xlYXkzMi5kbGwiICIl Q09ORklHVVJBVElPTkJVSUxERElSJVxiaW4iCit4Y29weSAveSAvZCAiJVdFQktJVExJQlJBUklF U0RJUiVcYmluXGNhaXJvLmRsbCIgIiVDT05GSUdVUkFUSU9OQlVJTERESVIlXGJpbiIKK3hjb3B5 IC95IC9kICIlV0VCS0lUTElCUkFSSUVTRElSJVxiaW5caWN1ZHQ0Ni5kbGwiICIlQ09ORklHVVJB VElPTkJVSUxERElSJVxiaW4iCit4Y29weSAveSAvZCAiJVdFQktJVExJQlJBUklFU0RJUiVcYmlu XGxpYmljdXVjLmRsbCIgIiVDT05GSUdVUkFUSU9OQlVJTERESVIlXGJpbiIKK3hjb3B5IC95IC9k ICIlV0VCS0lUTElCUkFSSUVTRElSJVxiaW5cbGliaWN1aW4uZGxsIiAiJUNPTkZJR1VSQVRJT05C VUlMRERJUiVcYmluIgorCit4Y29weSAveSAvZCAiJVdFQktJVExJQlJBUklFU0RJUiVcYmluXGxp YnhtbDIlTElCUkFSWUNPTkZJR1NVRkZJWCUuZGxsIiAiJUNPTkZJR1VSQVRJT05CVUlMRERJUiVc YmluIgoreGNvcHkgL3kgL2QgIiVXRUJLSVRMSUJSQVJJRVNESVIlXGJpblxsaWJ4c2x0JUxJQlJB UllDT05GSUdTVUZGSVglLmRsbCIgIiVDT05GSUdVUkFUSU9OQlVJTERESVIlXGJpbiIKK3hjb3B5 IC95IC9kICIlV0VCS0lUTElCUkFSSUVTRElSJVxiaW5ccHRocmVhZFZDMiVMSUJSQVJZQ09ORklH U1VGRklYJS5kbGwiICIlQ09ORklHVVJBVElPTkJVSUxERElSJVxiaW4iCitpZiBleGlzdCAiJVdF QktJVExJQlJBUklFU0RJUiVcYmluXHB0aHJlYWRWQzIlTElCUkFSWUNPTkZJR1NVRkZJWCUucGRi IiB4Y29weSAveSAvZCAiJVdFQktJVExJQlJBUklFU0RJUiVcYmluXHB0aHJlYWRWQzIlTElCUkFS WUNPTkZJR1NVRkZJWCUucGRiIiAiJUNPTkZJR1VSQVRJT05CVUlMRERJUiVcYmluIgoreGNvcHkg L3kgL2QgIiVXRUJLSVRMSUJSQVJJRVNESVIlXGJpblxTUUxpdGUzJUxJQlJBUllDT05GSUdTVUZG SVglLmRsbCIgIiVDT05GSUdVUkFUSU9OQlVJTERESVIlXGJpbiIKK2lmIGV4aXN0ICIlV0VCS0lU TElCUkFSSUVTRElSJVxiaW5cU1FMaXRlMyVMSUJSQVJZQ09ORklHU1VGRklYJS5wZGIiIHhjb3B5 IC95IC9kICIlV0VCS0lUTElCUkFSSUVTRElSJVxiaW5cU1FMaXRlMyVMSUJSQVJZQ09ORklHU1VG RklYJS5wZGIiICIlQ09ORklHVVJBVElPTkJVSUxERElSJVxiaW4iCit4Y29weSAveSAvZCAiJVdF QktJVExJQlJBUklFU0RJUiVcYmluXHpsaWIxJUxJQlJBUllDT05GSUdTVUZGSVglLmRsbCIgIiVD T05GSUdVUkFUSU9OQlVJTERESVIlXGJpbiIKK2lmIGV4aXN0ICIlV0VCS0lUTElCUkFSSUVTRElS JVxiaW5cemxpYjElTElCUkFSWUNPTkZJR1NVRkZJWCUucGRiIiB4Y29weSAveSAvZCAiJVdFQktJ VExJQlJBUklFU0RJUiVcYmluXHpsaWIxJUxJQlJBUllDT05GSUdTVUZGSVglLnBkYiIgIiVDT05G SUdVUkFUSU9OQlVJTERESVIlXGJpbiIK