69172 2011-09-30 14:38:19 -0700 respect other paint flags when setting flags for the font. No need to fiddle with DC(0) in paintSkiaText. 2011-10-03 10:19:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed jamesr senorblanco webkit.review.bot oldest_to_newest 476328 0 reed 2011-09-30 14:38:19 -0700 respect other paint flags when setting flags for the font. No need to fiddle with DC(0) in paintSkiaText. 476332 1 109351 reed 2011-09-30 14:42:19 -0700 Created attachment 109351 Patch 476333 2 reed 2011-09-30 14:43:32 -0700 ran DRT locally with no failures 477041 3 109351 senorblanco 2011-10-03 09:46:20 -0700 Comment on attachment 109351 Patch Looks good. r=me 477046 4 109351 reed 2011-10-03 09:50:47 -0700 Comment on attachment 109351 Patch thanks 477056 5 109351 webkit.review.bot 2011-10-03 10:19:43 -0700 Comment on attachment 109351 Patch Clearing flags on attachment: 109351 Committed r96515: <http://trac.webkit.org/changeset/96515> 477057 6 webkit.review.bot 2011-10-03 10:19:47 -0700 All reviewed patches have been landed. Closing bug. 109351 2011-09-30 14:42:19 -0700 2011-10-03 10:19:43 -0700 Patch bug-69172-20110930174218.patch text/plain 3625 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2NDI4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMzAgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICByZXNwZWN0IG90aGVyIHBhaW50IGZsYWdz IHdoZW4gc2V0dGluZyBmbGFncyBmb3IgdGhlIGZvbnQuIE5vIG5lZWQgdG8gZmlkZGxlIHdpdGgg REMoMCkgaW4gcGFpbnRTa2lhVGV4dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY5MTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGlzIGEgY2xlYW51cC9vcHRpbWl6YXRp b24sIGV4aXN0aW5nIHRlc3RzIGFwcGx5CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9z a2lhL1NraWFGb250V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldERlZmF1bHRHRElUZXh0 RmxhZ3MpOgorICAgICAgICAoV2ViQ29yZTo6c2V0dXBQYWludEZvckZvbnQpOgorICAgICAgICAo V2ViQ29yZTo6cGFpbnRTa2lhVGV4dCk6CisKIDIwMTEtMDktMzAgIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTAyMDgyOTE+IGZpcnN0 LWxldHRlciBpbiBnZW5lcmF0ZWQgYmVmb3JlIGNvbnRlbnQgd2l0aCBkaXNwbGF5OiB0YWJsZSBp cyBub3QgdXBkYXRlZApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9Ta2lhRm9udFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAJKHJldmlzaW9uIDk2Mzk5KQorKysgU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEwOCw2ICsxMDgsNyBAQCBzdGF0aWMgdWludDMyX3QgZ2V0RGVmYXVsdEdESVRl eHRGbGFncygpCiAgICAgc3RhdGljIHVpbnQzMl90IGdGbGFnczsKICAgICBpZiAoIWdJbml0ZWQp IHsKICAgICAgICAgQk9PTCBlbmFibGVkOworICAgICAgICBnRmxhZ3MgPSAwOwogICAgICAgICBp ZiAoU3lzdGVtUGFyYW1ldGVyc0luZm8oU1BJX0dFVEZPTlRTTU9PVEhJTkcsIDAsICZlbmFibGVk LCAwKSAmJiBlbmFibGVkKSB7CiAgICAgICAgICAgICBnRmxhZ3MgfD0gU2tQYWludDo6a0FudGlB bGlhc19GbGFnOwogCkBAIC0xNDAsMzEgKzE0MSwzMyBAQCBzdGF0aWMgdm9pZCBzZXR1cFBhaW50 Rm9yRm9udChIRk9OVCBoZm9uCiAgICAgcGFpbnQtPnNldFR5cGVmYWNlKGZhY2UpOwogICAgIFNr U2FmZVVucmVmKGZhY2UpOwogCi0gICAgdWludDMyX3QgZmxhZ3MgPSBwYWludC0+Z2V0RmxhZ3Mo KTsKLSAgICAvLyBjbGVhciBvdXIgZmxhZ3MgaW5pdGlhbGx5LCBhbmQgdGhlbiBzZWxlY3RpdmVs eSBzZXQgdGhlbQotICAgIC8vIGJhc2VkIG9uIHRoZSBMT0dGT05UIHF1YWxpdHkKLSAgICBmbGFn cyAmPSBTa1BhaW50OjprQW50aUFsaWFzX0ZsYWc7Ci0gICAgZmxhZ3MgJj0gU2tQYWludDo6a0xD RFJlbmRlclRleHRfRmxhZzsKLQorICAgIC8vIHR1cm4gbGZRdWFsaXR5IGludG8gdGV4dCBmbGFn cworICAgIHVpbnQzMl90IHRleHRGbGFnczsKICAgICBzd2l0Y2ggKGluZm8ubGZRdWFsaXR5KSB7 CiAgICAgY2FzZSBOT05BTlRJQUxJQVNFRF9RVUFMSVRZOgorICAgICAgICB0ZXh0RmxhZ3MgPSAw OwogICAgICAgICBicmVhazsKICAgICBjYXNlIEFOVElBTElBU0VEX1FVQUxJVFk6Ci0gICAgICAg IGZsYWdzIHw9IFNrUGFpbnQ6OmtBbnRpQWxpYXNfRmxhZzsKKyAgICAgICAgdGV4dEZsYWdzID0g U2tQYWludDo6a0FudGlBbGlhc19GbGFnOwogICAgICAgICBicmVhazsKICAgICBjYXNlIENMRUFS VFlQRV9RVUFMSVRZOgotICAgICAgICBmbGFncyB8PSBTa1BhaW50OjprQW50aUFsaWFzX0ZsYWc7 Ci0gICAgICAgIGZsYWdzIHw9IFNrUGFpbnQ6OmtMQ0RSZW5kZXJUZXh0X0ZsYWc7CisgICAgICAg IHRleHRGbGFncyA9IChTa1BhaW50OjprQW50aUFsaWFzX0ZsYWcgfCBTa1BhaW50OjprTENEUmVu ZGVyVGV4dF9GbGFnKTsKICAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKLSAgICAgICAgZmxh Z3MgfD0gZ2V0RGVmYXVsdEdESVRleHRGbGFncygpOworICAgICAgICB0ZXh0RmxhZ3MgPSBnZXRE ZWZhdWx0R0RJVGV4dEZsYWdzKCk7CiAgICAgICAgIGJyZWFrOwogICAgIH0KKyAgICAvLyBvbmx5 IGFsbG93IGZlYXR1cmVzIHRoYXQgU3lzdGVtUGFyYW1ldGVyc0luZm8gYWxsb3dzCisgICAgdGV4 dEZsYWdzICY9IGdldERlZmF1bHRHRElUZXh0RmxhZ3MoKTsKIAogICAgIC8vIGRvIHRoaXMgY2hl Y2sgYWZ0ZXIgb3VyIHN3aXRjaCBvbiBsZlF1YWxpdHkKICAgICBpZiAoZGlzYWJsZVRleHRMQ0Qo cGNzKSkKLSAgICAgICAgZmxhZ3MgJj0gflNrUGFpbnQ6OmtMQ0RSZW5kZXJUZXh0X0ZsYWc7Cisg ICAgICAgIHRleHRGbGFncyAmPSB+U2tQYWludDo6a0xDRFJlbmRlclRleHRfRmxhZzsKIAorICAg IC8vIG5vdyBjb3B5IGluIGp1c3QgdGhlIHRleHQgZmxhZ3MKKyAgICB1aW50MzJfdCBmbGFncyA9 IHBhaW50LT5nZXRGbGFncygpOworICAgIGZsYWdzICY9IH4oU2tQYWludDo6a0FudGlBbGlhc19G bGFnIHwgU2tQYWludDo6a0xDRFJlbmRlclRleHRfRmxhZyk7CisgICAgZmxhZ3MgfD0gdGV4dEZs YWdzOwogICAgIHBhaW50LT5zZXRGbGFncyhmbGFncyk7CiB9CiAKQEAgLTE3Niw5ICsxNzksNiBA QCB2b2lkIHBhaW50U2tpYVRleHQoR3JhcGhpY3NDb250ZXh0KiBjb250CiAgICAgICAgICAgICAg ICAgICAgY29uc3QgR09GRlNFVCogb2Zmc2V0cywKICAgICAgICAgICAgICAgICAgICBjb25zdCBT a1BvaW50KiBvcmlnaW4pCiB7Ci0gICAgSERDIGRjID0gR2V0REMoMCk7Ci0gICAgSEdESU9CSiBv bGRGb250ID0gU2VsZWN0T2JqZWN0KGRjLCBoZm9udCk7Ci0KICAgICBQbGF0Zm9ybUNvbnRleHRT a2lhKiBwbGF0Zm9ybUNvbnRleHQgPSBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKTsKICAgICBT a0NhbnZhcyogY2FudmFzID0gcGxhdGZvcm1Db250ZXh0LT5jYW52YXMoKTsKICAgICBUZXh0RHJh d2luZ01vZGVGbGFncyB0ZXh0TW9kZSA9IHBsYXRmb3JtQ29udGV4dC0+Z2V0VGV4dERyYXdpbmdN b2RlKCk7CkBAIC0yMjEsOSArMjIxLDYgQEAgdm9pZCBwYWludFNraWFUZXh0KEdyYXBoaWNzQ29u dGV4dCogY29udAogCiAgICAgICAgIHNraWFEcmF3VGV4dChjYW52YXMsICpvcmlnaW4sICZwYWlu dCwgJmdseXBoc1swXSwgJmFkdmFuY2VzWzBdLCAmb2Zmc2V0c1swXSwgbnVtR2x5cGhzKTsKICAg ICB9Ci0KLSAgICBTZWxlY3RPYmplY3QoZGMsIG9sZEZvbnQpOwotICAgIFJlbGVhc2VEQygwLCBk Yyk7CiB9CiAKIH0gIC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==