69153 2011-09-30 10:19:03 -0700 Remove unused ReplaceSelectionCommand::copyStyleToChildren 2011-09-30 11:27:25 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68874 1 rniwa rniwa abarth adele darin enrica eric morrita ojan tkent webkit.review.bot oldest_to_newest 476149 0 rniwa 2011-09-30 10:19:03 -0700 ReplaceSelectionCommand::copyStyleToChildren is not called anywhere. We should just get rid of it. 476153 1 109308 rniwa 2011-09-30 10:21:10 -0700 Created attachment 109308 cleanup 476200 2 109308 webkit.review.bot 2011-09-30 11:27:20 -0700 Comment on attachment 109308 cleanup Clearing flags on attachment: 109308 Committed r96410: <http://trac.webkit.org/changeset/96410> 476201 3 webkit.review.bot 2011-09-30 11:27:25 -0700 All reviewed patches have been landed. Closing bug. 109308 2011-09-30 10:21:10 -0700 2011-09-30 11:27:20 -0700 cleanup bug-69153-20110930102108.patch text/plain 3744 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2NDA0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMzAgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBSZXBsYWNl U2VsZWN0aW9uQ29tbWFuZDo6Y29weVN0eWxlVG9DaGlsZHJlbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkxNTMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIHRoZSBmdW5jdGlvbiBiZWNhdXNl IGl0J3Mgbm8gY2FsbGVkIGFueXdoZXJlLgorCisgICAgICAgICogZWRpdGluZy9SZXBsYWNlU2Vs ZWN0aW9uQ29tbWFuZC5jcHA6CisgICAgICAgICogZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29t bWFuZC5oOgorCiAyMDExLTA5LTMwICBOZWQgSG9sYnJvb2sgIDxuaG9sYnJvb2tAYXBwbGUuY29t PgogCiAgICAgICAgIENvbXBsZXggc3BhY2VzIHdpdGggc3ludGhldGljIGJvbGQgYXJlIHRvbyB3 aWRlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5k LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rp b25Db21tYW5kLmNwcAkocmV2aXNpb24gOTYzOTApCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5n L1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzAzLDQxICs3 MDMsNiBAQCB2b2lkIFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpoYW5kbGVTdHlsCiAgICAgICAg IHNldE5vZGVBdHRyaWJ1dGUod3JhcHBpbmdTdHlsZVNwYW4sIHN0eWxlQXR0ciwgc3R5bGUtPnN0 eWxlKCktPmNzc1RleHQoKSk7CiB9CiAKLS8vIFRha2UgdGhlIHN0eWxlIGF0dHJpYnV0ZSBvZiBh IHNwYW4gYW5kIGFwcGx5IGl0IHRvIGl0J3MgY2hpbGRyZW4gaW5zdGVhZC4gIFRoaXMgYWxsb3dz IHVzIHRvCi0vLyBjb252ZXJ0IGludmFsaWQgSFRNTCB3aGVyZSBhIHNwYW4gY29udGFpbnMgYmxv Y2sgZWxlbWVudHMgaW50byB2YWxpZCBIVE1MIHdoaWxlIHByZXNlcnZpbmcKLS8vIHN0eWxlcy4K LXZvaWQgUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6OmNvcHlTdHlsZVRvQ2hpbGRyZW4oTm9kZSog cGFyZW50Tm9kZSwgY29uc3QgQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24qIHBhcmVudFN0eWxl KQotewotICAgIEFTU0VSVChwYXJlbnROb2RlLT5oYXNUYWdOYW1lKHNwYW5UYWcpKTsKLSAgICBO b2RlVmVjdG9yIGNoaWxkTm9kZXM7Ci0gICAgZm9yIChSZWZQdHI8Tm9kZT4gY2hpbGROb2RlID0g cGFyZW50Tm9kZS0+Zmlyc3RDaGlsZCgpOyBjaGlsZE5vZGU7IGNoaWxkTm9kZSA9IGNoaWxkTm9k ZS0+bmV4dFNpYmxpbmcoKSkKLSAgICAgICAgY2hpbGROb2Rlcy5hcHBlbmQoY2hpbGROb2RlKTsK LSAgICAgICAgCi0gICAgZm9yIChOb2RlVmVjdG9yOjpjb25zdF9pdGVyYXRvciBpdCA9IGNoaWxk Tm9kZXMuYmVnaW4oKTsgaXQgIT0gY2hpbGROb2Rlcy5lbmQoKTsgaXQrKykgewotICAgICAgICBO b2RlKiBjaGlsZE5vZGUgPSBpdC0+Z2V0KCk7Ci0gICAgICAgIGlmIChjaGlsZE5vZGUtPmlzVGV4 dE5vZGUoKSB8fCAhaXNCbG9jayhjaGlsZE5vZGUpIHx8IGNoaWxkTm9kZS0+aGFzVGFnTmFtZShw cmVUYWcpKSB7Ci0gICAgICAgICAgICAvLyBJbiB0aGlzIGNhc2UsIHB1dCBhIHNwYW4gdGFnIGFy b3VuZCB0aGUgY2hpbGQgbm9kZS4KLSAgICAgICAgICAgIFJlZlB0cjxOb2RlPiBuZXdOb2RlID0g cGFyZW50Tm9kZS0+Y2xvbmVOb2RlKGZhbHNlKTsKLSAgICAgICAgICAgIEFTU0VSVChuZXdOb2Rl LT5oYXNUYWdOYW1lKHNwYW5UYWcpKTsKLSAgICAgICAgICAgIEhUTUxFbGVtZW50KiBuZXdTcGFu ID0gdG9IVE1MRWxlbWVudChuZXdOb2RlLmdldCgpKTsKLSAgICAgICAgICAgIHNldE5vZGVBdHRy aWJ1dGUobmV3U3Bhbiwgc3R5bGVBdHRyLCBwYXJlbnRTdHlsZS0+Y3NzVGV4dCgpKTsKLSAgICAg ICAgICAgIGluc2VydE5vZGVBZnRlcihuZXdTcGFuLCBjaGlsZE5vZGUpOwotICAgICAgICAgICAg RXhjZXB0aW9uQ29kZSBlYyA9IDA7Ci0gICAgICAgICAgICBuZXdTcGFuLT5hcHBlbmRDaGlsZChj aGlsZE5vZGUsIGVjKTsKLSAgICAgICAgICAgIEFTU0VSVCghZWMpOwotICAgICAgICAgICAgY2hp bGROb2RlID0gbmV3U3BhbjsKLSAgICAgICAgfSBlbHNlIGlmIChjaGlsZE5vZGUtPmlzSFRNTEVs ZW1lbnQoKSkgewotICAgICAgICAgICAgLy8gQ29weSB0aGUgc3R5bGUgYXR0cmlidXRlIGFuZCBt ZXJnZSB0aGVtIGludG8gdGhlIGNoaWxkIG5vZGUuICBXZSBkb24ndCB3YW50IHRvIG92ZXJyaWRl Ci0gICAgICAgICAgICAvLyBleGlzdGluZyBzdHlsZXMsIHNvIGRvbid0IGNsb2JiZXIgb24gbWVy Z2UuCi0gICAgICAgICAgICBSZWZQdHI8Q1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24+IG5ld1N0 eWxlID0gcGFyZW50U3R5bGUtPmNvcHkoKTsKLSAgICAgICAgICAgIEhUTUxFbGVtZW50KiBjaGls ZEVsZW1lbnQgPSB0b0hUTUxFbGVtZW50KGNoaWxkTm9kZSk7Ci0gICAgICAgICAgICBSZWZQdHI8 Q1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24+IGV4aXN0aW5nU3R5bGVzID0gY2hpbGRFbGVtZW50 LT5nZXRJbmxpbmVTdHlsZURlY2woKS0+Y29weSgpOwotICAgICAgICAgICAgZXhpc3RpbmdTdHls ZXMtPm1lcmdlKG5ld1N0eWxlLmdldCgpLCBmYWxzZSk7Ci0gICAgICAgICAgICBzZXROb2RlQXR0 cmlidXRlKGNoaWxkRWxlbWVudCwgc3R5bGVBdHRyLCBleGlzdGluZ1N0eWxlcy0+Y3NzVGV4dCgp KTsKLSAgICAgICAgfQotICAgIH0KLX0KLQogdm9pZCBSZXBsYWNlU2VsZWN0aW9uQ29tbWFuZDo6 bWVyZ2VFbmRJZk5lZWRlZCgpCiB7CiAgICAgaWYgKCFtX3Nob3VsZE1lcmdlRW5kKQpJbmRleDog U291cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuaAko cmV2aXNpb24gOTYzOTApCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rp b25Db21tYW5kLmgJKHdvcmtpbmcgY29weSkKQEAgLTg5LDcgKzg5LDYgQEAgcHJpdmF0ZToKICAg ICAKICAgICB2b2lkIHJlbW92ZVJlZHVuZGFudFN0eWxlc0FuZEtlZXBTdHlsZVNwYW5JbmxpbmUo SW5zZXJ0ZWROb2RlcyYpOwogICAgIHZvaWQgaGFuZGxlU3R5bGVTcGFucyhOb2RlKiBmaXJzdE5v ZGVJbnNlcnRlZCk7Ci0gICAgdm9pZCBjb3B5U3R5bGVUb0NoaWxkcmVuKE5vZGUqIHBhcmVudE5v ZGUsIGNvbnN0IENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uKiBwYXJlbnRTdHlsZSk7CiAgICAg dm9pZCBoYW5kbGVQYXN0ZUFzUXVvdGF0aW9uTm9kZSgpOwogICAgIAogICAgIHZpcnR1YWwgdm9p ZCByZW1vdmVOb2RlUHJlc2VydmluZ0NoaWxkcmVuKE5vZGUqKTsK