69143 2011-09-30 06:12:34 -0700 Replace textInputController.doCommand with eventSender.keyDown in password-echo tests 2011-09-30 07:43:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66561 1 cshu cshu ap darin tonikitoo webkit.review.bot oldest_to_newest 476052 0 cshu 2011-09-30 06:12:34 -0700 textInputController.doCommand is not supported very well across the platforms. Replace it with eventSender.keyDown would make the tests pass on more platforms and potentially WK2. 476055 1 109290 cshu 2011-09-30 06:18:49 -0700 Created attachment 109290 patch 1 476086 2 109290 webkit.review.bot 2011-09-30 07:43:07 -0700 Comment on attachment 109290 patch 1 Clearing flags on attachment: 109290 Committed r96401: <http://trac.webkit.org/changeset/96401> 476087 3 webkit.review.bot 2011-09-30 07:43:12 -0700 All reviewed patches have been landed. Closing bug. 109290 2011-09-30 06:18:49 -0700 2011-09-30 07:43:07 -0700 patch 1 69143_1.patch text/plain 2615 cshu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk2Mzk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMzAgIENoYW5nIFNodSAgPGNzaHVA d2Via2l0Lm9yZz4KKworICAgICAgICBSZXBsYWNlIHRleHRJbnB1dENvbnRyb2xsZXIuZG9Db21t YW5kIHdpdGggZXZlbnRTZW5kZXIua2V5RG93biBpbiBwYXNzd29yZC1lY2hvIHRlc3RzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTE0MworCisgICAg ICAgIHRleHRJbnB1dENvbnRyb2xsZXIuZG9Db21tYW5kIGlzIG5vdCBzdXBwb3J0ZWQgdmVyeSB3 ZWxsIGFjcm9zcyB0aGUgcGxhdGZvcm1zLiBSZXBsYWNlIGl0CisgICAgICAgIHdpdGggZXZlbnRT ZW5kZXIua2V5RG93biB3b3VsZCBtYWtlIHRoZSB0ZXN0cyBwYXNzIG9uIG1vcmUgcGxhdGZvcm1z IGFuZCBwb3RlbnRpYWxseSBXSzIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBlZGl0aW5nL2lucHV0L3Jlc291cmNlcy9wYXNzd29yZC1lY2hvLmpz OgorICAgICAgICAoaW5pdCk6CisKIDIwMTEtMDktMzAgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFt YWppQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIExheW91dCB0ZXN0IGZhaWx1 cmVzIHVuZGVyIFNub3cgTGVvcGFyZApJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9y ZXNvdXJjZXMvcGFzc3dvcmQtZWNoby5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0 aW5nL2lucHV0L3Jlc291cmNlcy9wYXNzd29yZC1lY2hvLmpzCShyZXZpc2lvbiA5NjM5OSkKKysr IExheW91dFRlc3RzL2VkaXRpbmcvaW5wdXQvcmVzb3VyY2VzL3Bhc3N3b3JkLWVjaG8uanMJKHdv cmtpbmcgY29weSkKQEAgLTQyLDcgKzQyLDcgQEAgZnVuY3Rpb24gcnVuKHRlc3RzLCB0ZXN0SWR4 KQogewogICAgIHZhciBleHBlY3RlZFNlY3VyZVRleHRMZW47CiAgICAgaWYgKHRlc3RJZHggPj0g MCkgewotICAgICAgICB0ZXh0SW5wdXRDb250cm9sbGVyLmRvQ29tbWFuZCgibW92ZUZvcndhcmQ6 Iik7CisgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oInJpZ2h0QXJyb3ciKTsKICAgICAgICAg aWYodGVzdHNbdGVzdElkeF1bM10pCiAgICAgICAgICAgICBhc3NlcnQodGVzdHNbdGVzdElkeF1b Ml0sIHdpbmRvdy5maW5kKHNlY3VyZVRleHQodGVzdG5vZGUudmFsdWUubGVuZ3RoKSwgZmFsc2Us IHRydWUpLCAic2VjdXJlZCBhZnRlciBkZWxheS4iKTsKICAgICB9CkBAIC01MywxNSArNTMsMTYg QEAgZnVuY3Rpb24gcnVuKHRlc3RzLCB0ZXN0SWR4KQogICAgIH0KIAogICAgIHRlc3Rub2RlLmZv Y3VzKCk7Ci0gICAgdGV4dElucHV0Q29udHJvbGxlci5kb0NvbW1hbmQoIm1vdmVGb3J3YXJkOiIp OworICAgIGV2ZW50U2VuZGVyLmtleURvd24oInJpZ2h0QXJyb3ciKTsKIAogICAgIHZhciBjaGFy U2VxdWVuY2UgPSB0ZXN0c1t0ZXN0SWR4XVswXTsKICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGNo YXJTZXF1ZW5jZS5sZW5ndGggLSAxOyBpKyspIHsKICAgICAgICAgdGV4dElucHV0Q29udHJvbGxl ci5zZXRNYXJrZWRUZXh0KGNoYXJTZXF1ZW5jZVtpXSwgdGVzdG5vZGUudmFsdWUubGVuZ3RoLCB0 ZXN0bm9kZS52YWx1ZS5sZW5ndGgpOwogICAgIH0KLSAgICBpZiAoY2hhclNlcXVlbmNlW2NoYXJT ZXF1ZW5jZS5sZW5ndGggLSAxXSA9PSAiYmFja3NwYWNlIikKLSAgICAgICAgdGV4dElucHV0Q29u dHJvbGxlci5kb0NvbW1hbmQoImRlbGV0ZUJhY2t3YXJkOiIpOwotICAgIGVsc2UKKyAgICBpZiAo Y2hhclNlcXVlbmNlW2NoYXJTZXF1ZW5jZS5sZW5ndGggLSAxXSA9PSAiYmFja3NwYWNlIikgewor ICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCJsZWZ0QXJyb3ciKTsKKyAgICAgICAgZXZlbnRT ZW5kZXIua2V5RG93bigiZGVsZXRlIik7CisgICAgfSBlbHNlCiAgICAgICAgIHRleHRJbnB1dENv bnRyb2xsZXIuaW5zZXJ0VGV4dChjaGFyU2VxdWVuY2VbY2hhclNlcXVlbmNlLmxlbmd0aCAtIDFd KTsKIAogICAgIGlmKHRlc3RzW3Rlc3RJZHhdWzNdKQpAQCAtNzUsNyArNzYsNyBAQCBmdW5jdGlv biBydW4odGVzdHMsIHRlc3RJZHgpCiAKIGZ1bmN0aW9uIGluaXQodGVzdHMpCiB7Ci0gICAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlciAmJiB3aW5kb3cudGV4dElucHV0Q29udHJvbGxl cikgeworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIgJiYgd2luZG93LnRleHRJ bnB1dENvbnRyb2xsZXIgJiYgd2luZG93LmV2ZW50U2VuZGVyKSB7CiAgICAgICAgIGxheW91dFRl c3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu d2FpdFVudGlsRG9uZSgpOwogICAgICAgICBpZiAod2luZG93LmludGVybmFscykgewo=