6914 2006-01-29 07:37:38 -0800 REGRESSION: fast/block/basic/014.html crashes Safari 2006-01-31 21:20:58 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 VERIFIED FIXED P1 Critical --- 1 ap darin ddkilzer hyatt oldest_to_newest 30516 0 ap 2006-01-29 07:37:38 -0800 Steps to reproduce: open fast/block/basic/014.html in ToT or run run-webkit-tests --pixel fast/block/basic/014.html This test has always failed in pixel mode for me (looked like a color correction issue), but certainly didn't cause crashes. Thread 0 Crashed: 0 com.apple.WebCore 0x01449c10 WebCore::CachedImage::isErrorImage() const + 20 (CachedImage.h:61) 1 com.apple.WebCore 0x014b9a14 WebCore::RenderImage::errorOccurred() const + 40 (render_canvas.h:78) 2 com.apple.WebCore 0x0135f8cc WebCore::RenderImage::paint(WebCore::RenderObject::PaintInfo&, int, int) + 1288 (render_image.cpp:219) 3 com.apple.WebCore 0x01372a30 WebCore::InlineBox::paint(WebCore::RenderObject::PaintInfo&, int, int) + 524 (render_line.cpp:176) 4 com.apple.WebCore 0x013733a4 WebCore::InlineFlowBox::paint(WebCore::RenderObject::PaintInfo&, int, int) + 880 (render_line.cpp:776) 5 com.apple.WebCore 0x013733a4 WebCore::InlineFlowBox::paint(WebCore::RenderObject::PaintInfo&, int, int) + 880 (render_line.cpp:776) 6 com.apple.WebCore 0x0137345c WebCore::RootInlineBox::paint(WebCore::RenderObject::PaintInfo&, int, int) + 60 (render_line.cpp:1184) 7 com.apple.WebCore 0x01351ae8 WebCore::RenderFlow::paintLines(WebCore::RenderObject::PaintInfo&, int, int) + 1980 (render_flow.cpp:380) 8 com.apple.WebCore 0x0132eb80 WebCore::RenderBlock::paintObject(WebCore::RenderObject::PaintInfo&, int, int) + 436 (RenderBlock.cpp:1314) 9 com.apple.WebCore 0x01324a54 WebCore::RenderBlock::paint(WebCore::RenderObject::PaintInfo&, int, int) + 736 (RenderBlock.cpp:1243) 10 com.apple.WebCore 0x01329590 WebCore::RenderBlock::paintChildren(WebCore::RenderObject::PaintInfo&, int, int) + 784 (RenderBlock.cpp:1265) 11 com.apple.WebCore 0x0132eba0 WebCore::RenderBlock::paintObject(WebCore::RenderObject::PaintInfo&, int, int) + 468 (RenderBlock.cpp:1319) 12 com.apple.WebCore 0x01324a54 WebCore::RenderBlock::paint(WebCore::RenderObject::PaintInfo&, int, int) + 736 (RenderBlock.cpp:1243) 13 com.apple.WebCore 0x0136b938 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::QPainter*, WebCore::IntRect const&, bool, bool, WebCore::RenderObject*) + 1520 (render_layer.cpp:1090) 14 com.apple.WebCore 0x0136ba38 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::QPainter*, WebCore::IntRect const&, bool, bool, WebCore::RenderObject*) + 1776 (render_layer.cpp:1101) 15 com.apple.WebCore 0x0136bb18 WebCore::RenderLayer::paint(WebCore::QPainter*, WebCore::IntRect const&, bool, WebCore::RenderObject*) + 72 (render_layer.cpp:990) 16 com.apple.WebCore 0x01233314 Frame::paint(WebCore::QPainter*, WebCore::IntRect const&) + 804 (Frame.cpp:3266) 17 com.apple.WebCore 0x012838fc -[WebCoreFrameBridge drawRect:withPainter:] + 128 (WebCoreFrameBridge.mm:975) 18 com.apple.WebCore 0x01283a10 -[WebCoreFrameBridge drawRect:] + 224 (WebCoreFrameBridge.mm:983) 19 com.apple.WebKit 0x0027c238 -[WebHTMLView drawRect:] + 980 (WebHTMLView.m:2485) 30532 1 ddkilzer 2006-01-29 09:17:10 -0800 Confirmed that this broke with Subversion commit r12447 (Cleanup of RenderImage. Eliminate unneeded members and methods.) on WebKit. Using r12446 the test worked fine. When will build.webkit.org start running pixel tests? :) 30552 2 darin 2006-01-29 14:30:30 -0800 I'm also seeing a failure in fast/replaced that may be the same thing. 30553 3 darin 2006-01-29 14:39:53 -0800 I've got a fix for this in the works. 30554 4 darin 2006-01-29 14:43:55 -0800 Got the fix and it fixed this one test; testing the rest of the layout tests now. 30898 5 eric 2006-01-31 21:20:58 -0800 Removing Regression keyword from bugs already fixed.