<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>69137</bug_id>
          
          <creation_ts>2011-09-30 01:11:01 -0700</creation_ts>
          <short_desc>In input field caret is not blinking after context menu hide</short_desc>
          <delta_ts>2011-10-21 10:26:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>70491</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="chandra shekar vallala">chandra.vallala</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>ap</cc>
    
    <cc>cshu</cc>
    
    <cc>dglazkov</cc>
    
    <cc>enrica</cc>
    
    <cc>fishd</cc>
    
    <cc>kenneth</cc>
    
    <cc>rniwa</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>475966</commentid>
    <comment_count>0</comment_count>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-09-30 01:11:01 -0700</bug_when>
    <thetext>On right click, mouse down event handler suspends the caret blink and opens the context menu. Mouse up event is not comming to renderer when context menu is opened. So caret blink suspend has not resumed.

To match the native application behavior, caretBlinkingSuspended is set to false on close of context menu.

Original issue is reported at http://code.google.com/p/chromium/issues/detail?id=98543</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>475995</commentid>
    <comment_count>1</comment_count>
      <attachid>109272</attachid>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-09-30 02:47:03 -0700</bug_when>
    <thetext>Created attachment 109272
patch with webkit changes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476136</commentid>
    <comment_count>2</comment_count>
      <attachid>109272</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-09-30 09:58:44 -0700</bug_when>
    <thetext>Comment on attachment 109272
patch with webkit changes 

Why doesn&apos;t this problem reproduce on Mac? From what you&apos;ve told me, Mac and Linux have the same behavior, right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476139</commentid>
    <comment_count>3</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-09-30 09:59:50 -0700</bug_when>
    <thetext>To other reviewers, please don&apos;t r+ this patch for now</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476935</commentid>
    <comment_count>4</comment_count>
      <attachid>109479</attachid>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-03 06:09:20 -0700</bug_when>
    <thetext>Created attachment 109479
updated the patch for mac/Linux.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476936</commentid>
    <comment_count>5</comment_count>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-03 06:11:53 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 109272 [details])
&gt; Why doesn&apos;t this problem reproduce on Mac? From what you&apos;ve told me, Mac and Linux have the same behavior, right?

Yes, Linux/Mac both have the same behavior since context menu come up before the mouse up. I updated the patch for mac and Linux.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>477022</commentid>
    <comment_count>6</comment_count>
      <attachid>109479</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-10-03 09:25:02 -0700</bug_when>
    <thetext>Comment on attachment 109479
updated the patch for mac/Linux.

This bug reproduces on Safari as well. We need to fix it in cross-platform code then.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483103</commentid>
    <comment_count>7</comment_count>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-13 04:00:20 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 109479 [details])
&gt; This bug reproduces on Safari as well. We need to fix it in cross-platform code then.


To match the native app behaviour [caret should blink after the context menu hide which is same across all platforms] we should resume the caret blink after the menu hide.  Currently there is no way in which WebCore knows whether the context menu widget is hidden or not and it can even more troublesome in multi-process ports like Chromium or WebKit2 since widget is handled in different process. 

Instead we could resume caret after menu is dismissed which should be handled at WebKit port level rather than in WebCore. Also there might be usecases where action on menu will not dismiss the menu widget in which case with the WebCore solution we may move into an unwanted state of caret blinking even when menu is present.

My understanding is root cause of the bug is because of the way we handle the contextmenu creation/destroy which is defined WebKit port layer for each platform. So IMHO solution should also be in WebKit port layer rather than in WebCore.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483308</commentid>
    <comment_count>8</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-10-13 10:53:13 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (In reply to comment #6)
&gt; &gt; (From update of attachment 109479 [details] [details])
&gt; &gt; This bug reproduces on Safari as well. We need to fix it in cross-platform code then.
&gt; 
&gt; To match the native app behaviour [caret should blink after the context menu hide which is same across all platforms] we should resume the caret blink after the menu hide.  Currently there is no way in which WebCore knows whether the context menu widget is hidden or not and it can even more troublesome in multi-process ports like Chromium or WebKit2 since widget is handled in different process.

So are you saying that ContextMenuController doesn&apos;t get notified at all? That&apos;s hard to believe. If anything, we should be adding some method in ContextMenuController to notify when the context menu hides.

&gt; Instead we could resume caret after menu is dismissed which should be handled at WebKit port level rather than in WebCore.

That&apos;ll be a wrong abstraction layer to deal with this. Suspension of caret blinking is done in EventHandler, and resuming it in WebKit layer is strange to say the least.

&gt; My understanding is root cause of the bug is because of the way we handle the contextmenu creation/destroy which is defined WebKit port layer for each platform.

Then we should add some notification mechanism so that we can notify either EventHandler or ContextMenuController when the context menu disappears. We should definitely NOT resume caret blinking in WebKit layer. In fact, I&apos;d like to make setCaretBlinkingSuspended only accessible from EventHandler.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>485002</commentid>
    <comment_count>9</comment_count>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-17 02:01:46 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; (In reply to comment #7)
&gt; &gt; (In reply to comment #6)
&gt; &gt; &gt; (From update of attachment 109479 [details] [details] [details])
&gt; &gt; &gt; This bug reproduces on Safari as well. We need to fix it in cross-platform code then.
&gt; &gt; 
&gt; &gt; To match the native app behaviour [caret should blink after the context menu hide which is same across all platforms] we should resume the caret blink after the menu hide.  Currently there is no way in which WebCore knows whether the context menu widget is hidden or not and it can even more troublesome in multi-process ports like Chromium or WebKit2 since widget is handled in different process.
&gt; 
&gt; So are you saying that ContextMenuController doesn&apos;t get notified at all? That&apos;s hard to believe. If anything, we should be adding some method in ContextMenuController to notify when the context menu hides.

Yes, ContextMenuController doesn&apos;t get notified from browser. So I added a contextMenuHidden function to controller. This should get called when menu hides.

&gt; 
&gt; &gt; Instead we could resume caret after menu is dismissed which should be handled at WebKit port level rather than in WebCore.
&gt; 
&gt; That&apos;ll be a wrong abstraction layer to deal with this. Suspension of caret blinking is done in EventHandler, and resuming it in WebKit layer is strange to say the least.

Yes, your right. But I am not sure of adding a new function in EventHandler to resume/suspend the caret. EventHandler has a function called lostMouseCapture to do the same. The function name doesn&apos;t match to this case. I added a new one in EventHandler.

&gt; 
&gt; &gt; My understanding is root cause of the bug is because of the way we handle the contextmenu creation/destroy which is defined WebKit port layer for each platform.
&gt; 
&gt; Then we should add some notification mechanism so that we can notify either EventHandler or ContextMenuController when the context menu disappears. We should definitely NOT resume caret blinking in WebKit layer. In fact, I&apos;d like to make setCaretBlinkingSuspended only accessible from EventHandler.

To make the behavior same across all platforms, we should suspend/resume the caret on context menu show/hide respectively.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>485003</commentid>
    <comment_count>10</comment_count>
      <attachid>111226</attachid>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-17 02:03:11 -0700</bug_when>
    <thetext>Created attachment 111226
updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>485308</commentid>
    <comment_count>11</comment_count>
      <attachid>111226</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-10-17 11:23:25 -0700</bug_when>
    <thetext>Comment on attachment 111226
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111226&amp;action=review

&gt; Source/WebCore/page/ContextMenuController.cpp:98
&gt; +void ContextMenuController::contextMenuHidden()

&quot;hidden&quot; doesn&apos;t sound right to me. It&apos;s not like context menu is temporarily hidden from the screen. Dismissed or closed will be better.

&gt; Source/WebCore/page/ContextMenuController.cpp:108
&gt; +    // Resume the caret blinking which suspended in context menu show.

This comment repeats the code.

&gt; Source/WebCore/page/ContextMenuController.cpp:109
&gt; +    frame-&gt;eventHandler()-&gt;suspendCaretBlinking(false);

This function name seems too general to me. I would name to respondToContextMenuDismiss or something like that to avoid tying it to caret blinking.

&gt; Source/WebCore/page/ContextMenuController.cpp:173
&gt; +    Frame* frame = m_hitTestResult.innerNonSharedNode()-&gt;document()-&gt;frame();
&gt; +    // Suspend the caret blinking to match native application behavior.
&gt; +    frame-&gt;eventHandler()-&gt;suspendCaretBlinking(true);

This is not right. We&apos;ve already suspended caret blinking on keydown. We shouldn&apos;t be suspending caret blinking here again.

&gt; Source/WebCore/page/EventHandler.cpp:718
&gt; +void EventHandler::suspendCaretBlinking(bool shouldSuspend)

This function must be renamed to reflect the fact it&apos;s called when context menu is closed. It also shouldn&apos;t take a bool.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>485825</commentid>
    <comment_count>12</comment_count>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-17 23:07:15 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (From update of attachment 111226 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=111226&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/page/ContextMenuController.cpp:98
&gt; &gt; +void ContextMenuController::contextMenuHidden()
&gt; 
&gt; &quot;hidden&quot; doesn&apos;t sound right to me. It&apos;s not like context menu is temporarily hidden from the screen. Dismissed or closed will be better.

I agree.

&gt; &gt; Source/WebCore/page/ContextMenuController.cpp:108
&gt; &gt; +    // Resume the caret blinking which suspended in context menu show.
&gt; 
&gt; This comment repeats the code.
&gt; 
&gt; &gt; Source/WebCore/page/ContextMenuController.cpp:109
&gt; &gt; +    frame-&gt;eventHandler()-&gt;suspendCaretBlinking(false);
&gt; 
&gt; This function name seems too general to me. I would name to respondToContextMenuDismiss or something like that to avoid tying it to 
This function can be general to accept true/false.
caret blinking.
&gt; 
&gt; &gt; Source/WebCore/page/ContextMenuController.cpp:173
&gt; &gt; +    Frame* frame = m_hitTestResult.innerNonSharedNode()-&gt;document()-&gt;frame();
&gt; &gt; +    // Suspend the caret blinking to match native application behavior.
&gt; &gt; +    frame-&gt;eventHandler()-&gt;suspendCaretBlinking(true);
&gt; 
&gt; This is not right. We&apos;ve already suspended caret blinking on keydown. We shouldn&apos;t be suspending caret blinking here again.

In chromium win port, context menu created in mouse up where we resumes the caret blink. As a result of this caret blinks though context menu shown. This behavior differs with IE and native application in windows. To fix this its better to suspends the caret blink in showContextMenu.

&gt; 
&gt; &gt; Source/WebCore/page/EventHandler.cpp:718
&gt; &gt; +void EventHandler::suspendCaretBlinking(bool shouldSuspend)
&gt; 
&gt; This function must be renamed to reflect the fact it&apos;s called when context menu is closed. It also shouldn&apos;t take a bool.

This function can call with either true or false as I explained it above to fix the issue in chromium win port. If we don&apos;t want to alter the behavior in chromium win port, this can be done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>485844</commentid>
    <comment_count>13</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-10-17 23:35:06 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; &gt; This function name seems too general to me. I would name to respondToContextMenuDismiss or something like that to avoid tying it to 
&gt; This function can be general to accept true/false.
&gt; caret blinking.

I don&apos;t think that&apos;s a good idea. I don&apos;t want WebKit code start suspend/resume caret blinking at random timing. We should keep encapsulate the timing inside WebCore.

&gt; &gt; This is not right. We&apos;ve already suspended caret blinking on keydown. We shouldn&apos;t be suspending caret blinking here again.
&gt; 
&gt; In chromium win port, context menu created in mouse up where we resumes the caret blink. As a result of this caret blinks though context menu shown. This behavior differs with IE and native application in windows. To fix this its better to suspends the caret blink in showContextMenu.

Are you saying that the context menu is created on mouse up? Are you saying that Chromium Win&apos;s current behavior matches native Windows apps&apos; behaviors?

Then where is such a logic implemented? I&apos;d think that we should move this logic to EventHandler and make it depend on editing behavior.

&gt; &gt; This function must be renamed to reflect the fact it&apos;s called when context menu is closed. It also shouldn&apos;t take a bool.
&gt; 
&gt; This function can call with either true or false as I explained it above to fix the issue in chromium win port. If we don&apos;t want to alter the behavior in chromium win port, this can be done.

I repeat myself that I don&apos;t want to provide such a generic method to WebKit layer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>485845</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-17 23:35:39 -0700</bug_when>
    <thetext>Attachment 111226 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1

Source/WebCore/page/ContextMenuController.cpp:104:  Declaration has space between type name and * in Frame *frame  [whitespace/declaration] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>485847</commentid>
    <comment_count>15</comment_count>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-17 23:36:06 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; (In reply to comment #11)
&gt; &gt; (From update of attachment 111226 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=111226&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebCore/page/ContextMenuController.cpp:98
&gt; &gt; &gt; +void ContextMenuController::contextMenuHidden()
&gt; &gt; 
&gt; &gt; &quot;hidden&quot; doesn&apos;t sound right to me. It&apos;s not like context menu is temporarily hidden from the screen. Dismissed or closed will be better.
&gt; 
&gt; I agree.
&gt; 
&gt; &gt; &gt; Source/WebCore/page/ContextMenuController.cpp:108
&gt; &gt; &gt; +    // Resume the caret blinking which suspended in context menu show.
&gt; &gt; 
&gt; &gt; This comment repeats the code.
&gt; &gt; 
&gt; &gt; &gt; Source/WebCore/page/ContextMenuController.cpp:109
&gt; &gt; &gt; +    frame-&gt;eventHandler()-&gt;suspendCaretBlinking(false);
&gt; &gt; 
&gt; &gt; This function name seems too general to me. I would name to respondToContextMenuDismiss or something like that to avoid tying it to 
&gt; This function can be general to accept true/false.
&gt; caret blinking.
Oops wrongly added. Please ignore the above statement.
&gt; &gt; 
&gt; &gt; &gt; Source/WebCore/page/ContextMenuController.cpp:173
&gt; &gt; &gt; +    Frame* frame = m_hitTestResult.innerNonSharedNode()-&gt;document()-&gt;frame();
&gt; &gt; &gt; +    // Suspend the caret blinking to match native application behavior.
&gt; &gt; &gt; +    frame-&gt;eventHandler()-&gt;suspendCaretBlinking(true);
&gt; &gt; 
&gt; &gt; This is not right. We&apos;ve already suspended caret blinking on keydown. We shouldn&apos;t be suspending caret blinking here again.
&gt; 
&gt; In chromium win port, context menu created in mouse up where we resumes the caret blink. As a result of this caret blinks though context menu shown. This behavior differs with IE and native application in windows. To fix this its better to suspends the caret blink in showContextMenu.
&gt; 
&gt; &gt; 
&gt; &gt; &gt; Source/WebCore/page/EventHandler.cpp:718
&gt; &gt; &gt; +void EventHandler::suspendCaretBlinking(bool shouldSuspend)
&gt; &gt; 
&gt; &gt; This function must be renamed to reflect the fact it&apos;s called when context menu is closed. It also shouldn&apos;t take a bool.
&gt; 
&gt; This function can call with either true or false as I explained it above to fix the issue in chromium win port. If we don&apos;t want to alter the behavior in chromium win port, this can be done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>486040</commentid>
    <comment_count>16</comment_count>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-18 07:16:18 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; (In reply to comment #12)
&gt; &gt; &gt; This function name seems too general to me. I would name to respondToContextMenuDismiss or something like that to avoid tying it to 
&gt; &gt; This function can be general to accept true/false.
&gt; &gt; caret blinking.
&gt; 
&gt; I don&apos;t think that&apos;s a good idea. I don&apos;t want WebKit code start suspend/resume caret blinking at random timing. We should keep encapsulate the timing inside WebCore.
&gt; 
&gt; &gt; &gt; This is not right. We&apos;ve already suspended caret blinking on keydown. We shouldn&apos;t be suspending caret blinking here again.
&gt; &gt; 
&gt; &gt; In chromium win port, context menu created in mouse up where we resumes the caret blink. As a result of this caret blinks though context menu shown. This behavior differs with IE and native application in windows. To fix this its better to suspends the caret blink in showContextMenu.
&gt; 
&gt; Are you saying that the context menu is created on mouse up? Are you saying that Chromium Win&apos;s current behavior matches native Windows apps&apos; behaviors?

Yes. Context menu event handled in mouse up for chromium-win. The logic is at Source/WebKit/chromium/src/WebViewImpl.cpp:577. The current behavior[caret blinks after context menu open in chrome-win. ] doesn&apos;t match with native win&apos;s app. 

&gt; 
&gt; Then where is such a logic implemented? I&apos;d think that we should move this logic to EventHandler and make it depend on editing behavior.
&gt; 
&gt; &gt; &gt; This function must be renamed to reflect the fact it&apos;s called when context menu is closed. It also shouldn&apos;t take a bool.
&gt; &gt; 
&gt; &gt; This function can call with either true or false as I explained it above to fix the issue in chromium win port. If we don&apos;t want to alter the behavior in chromium win port, this can be done.
&gt; 
&gt; I repeat myself that I don&apos;t want to provide such a generic method to WebKit layer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>486049</commentid>
    <comment_count>17</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2011-10-18 07:35:00 -0700</bug_when>
    <thetext>&gt; 
&gt; &gt; Are you saying that the context menu is created on mouse up? Are you saying that Chromium Win&apos;s current behavior matches native Windows apps&apos; behaviors?
&gt; 
&gt; Yes. Context menu event handled in mouse up for chromium-win. The logic is at Source/WebKit/chromium/src/WebViewImpl.cpp:577. The current behavior[caret blinks after context menu open in chrome-win. ] doesn&apos;t match with native win&apos;s app. 
&gt; 
&gt; &gt; 
&gt; &gt; Then where is such a logic implemented? I&apos;d think that we should move this logic to EventHandler and make it depend on editing behavior.

Definitively sounds like a editing behavior.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>486116</commentid>
    <comment_count>18</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-10-18 09:53:14 -0700</bug_when>
    <thetext>(In reply to comment #16)
&gt; (In reply to comment #13)
&gt; &gt; Are you saying that the context menu is created on mouse up? Are you saying that Chromium Win&apos;s current behavior matches native Windows apps&apos; behaviors?
&gt; 
&gt; Yes. Context menu event handled in mouse up for chromium-win. The logic is at Source/WebKit/chromium/src/WebViewImpl.cpp:577. The current behavior[caret blinks after context menu open in chrome-win. ] doesn&apos;t match with native win&apos;s app. 

I see. It sounds like we should refactor code so that the timing at which context menu is shown can be instructed by EventHandler.

Alternatively, you can add new methods to EventHandler that WebKit layer calls when a context menu is shown or hidden. This approach is less desirable since that would mean that each port will still end up implementing their own timing for showing context menu.

Regardless, an important thing here is that you&apos;d have to make sure you make appropriate changes to all ports.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487379</commentid>
    <comment_count>19</comment_count>
      <attachid>111734</attachid>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-20 00:33:12 -0700</bug_when>
    <thetext>Created attachment 111734
WebCore changes

This patch has only WebCore changes. Port specific changes will update soon..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487385</commentid>
    <comment_count>20</comment_count>
      <attachid>111734</attachid>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2011-10-20 00:42:03 -0700</bug_when>
    <thetext>Comment on attachment 111734
WebCore changes

Attachment 111734 did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10179356</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487388</commentid>
    <comment_count>21</comment_count>
      <attachid>111734</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-20 00:45:23 -0700</bug_when>
    <thetext>Comment on attachment 111734
WebCore changes

Attachment 111734 did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10182328</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487396</commentid>
    <comment_count>22</comment_count>
      <attachid>111734</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-10-20 00:54:05 -0700</bug_when>
    <thetext>Comment on attachment 111734
WebCore changes

View in context: https://bugs.webkit.org/attachment.cgi?id=111734&amp;action=review

&gt; Source/WebCore/page/EventHandler.cpp:2262
&gt; +void respondToContextMenuShown()

We probably need to suspend caret blinking before showing context menu, so I&apos;d rename this function to willShowContextMenu.

Also, you&apos;re missing EventHandler::.

&gt; Source/WebCore/page/EventHandler.cpp:2267
&gt; +void respondToContextMenuDismissed()

Nit: s/respondToContextMenuDismissed/respondToContextMenuDismissal/.

Ditto about missing EventHandler:: r- because of this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487397</commentid>
    <comment_count>23</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-10-20 00:55:14 -0700</bug_when>
    <thetext>By the way since your patch doesn&apos;t actually fix this bug, you should file a new bug and make this bug depend it then upload your patch on that new bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487420</commentid>
    <comment_count>24</comment_count>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-20 02:09:03 -0700</bug_when>
    <thetext>(In reply to comment #23)
&gt; By the way since your patch doesn&apos;t actually fix this bug, you should file a new bug and make this bug depend it then upload your patch on that new(In reply to comment #22)
&gt; (From update of attachment 111734 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=111734&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/page/EventHandler.cpp:2262
&gt; &gt; +void respondToContextMenuShown()
&gt; 
&gt; We probably need to suspend caret blinking before showing context menu, so I&apos;d rename this function to willShowContextMenu.

We are not sure of showing the context menu on every right click since there can be default prevent for context. If we call willShowContextMenu before context menu show from webkit layer there might be no context menu close notify from browser. The issue will exist again ....

&gt; 
&gt; Also, you&apos;re missing EventHandler::.
&gt; 
&gt; &gt; Source/WebCore/page/EventHandler.cpp:2267
&gt; &gt; +void respondToContextMenuDismissed()
&gt; 
&gt; Nit: s/respondToContextMenuDismissed/respondToContextMenuDismissal/.
&gt; 
&gt; Ditto about missing EventHandler:: r- because of this.

Sorry, I uploaded a wrong patch...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487427</commentid>
    <comment_count>25</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-10-20 02:20:15 -0700</bug_when>
    <thetext>(In reply to comment #24)
&gt; We are not sure of showing the context menu on every right click since there can be default prevent for context. If we call willShowContextMenu before context menu show from webkit layer there might be no context menu close notify from browser. The issue will exist again

That&apos;s the whole point of this function, right? WebKit layer or whatever callers of this function ensures that context menu is about to be shown. We shouldn&apos;t be calling this function if the context menu can be prevented to be shown.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487465</commentid>
    <comment_count>26</comment_count>
      <attachid>111750</attachid>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-20 04:05:44 -0700</bug_when>
    <thetext>Created attachment 111750
updated patch

Update the WebCore patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487705</commentid>
    <comment_count>27</comment_count>
      <attachid>111750</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-10-20 10:54:02 -0700</bug_when>
    <thetext>Comment on attachment 111750
updated patch

Please post this patch on the bug 70491. Also your patch needs to modify each port&apos;s code to call these functions. Furthermore, you should be removing the code to suspend caret blinking on mousedown in EventHandler.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>488369</commentid>
    <comment_count>28</comment_count>
      <attachid>111962</attachid>
    <who name="chandra shekar vallala">chandra.vallala</who>
    <bug_when>2011-10-21 07:27:26 -0700</bug_when>
    <thetext>Created attachment 111962
patch for chromium port changes.

Uploaded the patch for chromium port.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>488370</commentid>
    <comment_count>29</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-21 07:29:00 -0700</bug_when>
    <thetext>Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>488376</commentid>
    <comment_count>30</comment_count>
      <attachid>111962</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2011-10-21 07:37:12 -0700</bug_when>
    <thetext>Comment on attachment 111962
patch for chromium port changes.

View in context: https://bugs.webkit.org/attachment.cgi?id=111962&amp;action=review

&gt; Source/WebKit/chromium/public/WebView.h:328
&gt; +    virtual void contextMenuClosed() { }

nit: please use a name like didCloseContextMenu to be more consistent with existing notification-style methods.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>488461</commentid>
    <comment_count>31</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-10-21 10:26:58 -0700</bug_when>
    <thetext>As I&apos;ve repeatedly stated, please upload your patch to add WebKit/WebCore notification API to the bug 70491. This bug should only receive patches that actually fixes the bug you stated.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>109272</attachid>
            <date>2011-09-30 02:47:03 -0700</date>
            <delta_ts>2011-10-03 06:09:20 -0700</delta_ts>
            <desc>patch with webkit changes </desc>
            <filename>caret.patch</filename>
            <type>text/plain</type>
            <size>3320</size>
            <attacher name="chandra shekar vallala">chandra.vallala</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlz
aW9uIDk2Mzk3KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw
CSh3b3JraW5nIGNvcHkpCkBAIC0yMjY3LDYgKzIyNjcsMjEgQEAKICAgICBtX3BhZ2UtPmNvbnRl
eHRNZW51Q29udHJvbGxlcigpLT5jbGVhckNvbnRleHRNZW51KCk7CiB9CiAKK3ZvaWQgV2ViVmll
d0ltcGw6OmNvbnRleHRNZW51Q2xvc2VkKCkKK3sKKworICAgIC8vIE9uIFVuaXgsIHdoZW4gY29u
dGV4dCBtZW51IGlzIG9wZW5kZWQgV2ViVmlldyBkb2Vzbid0IHJlY2VpdmUgbW91c2V1cCBldmVu
dCBzaW5jZQorICAgIC8vIGl0IGlzIHJlY2VpdmVkIGJ5IGNvbnRleHQgbWVudS4gQXMgYSByZXN1
bHQsIGNhcmV0IGJsaW5rIHdoaWNoIGlzIHN1c3BlbmRlZCBpbiBtb3VzZWRvd24KKyAgICAvLyBl
dmVudCBpcyBub3QgcmVzdW1lZCB0aWxsIG5leHQgbW91c2V1cCBldmVudCBpcyByZWNlaXZlZC4K
KyNpZiBPUyhVTklYKQorICAgIEZyYW1lKiBmcmFtZSA9IGZvY3VzZWRXZWJDb3JlRnJhbWUoKTsK
KyAgICBpZiAoIWZyYW1lKQorICAgICAgICByZXR1cm47CisKKyAgICBmcmFtZS0+c2VsZWN0aW9u
KCktPnNldENhcmV0QmxpbmtpbmdTdXNwZW5kZWQoZmFsc2UpOworI2VuZGlmCit9CisKIC8vIFdl
YlZpZXcgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0KIAogdm9pZCBXZWJWaWV3SW1wbDo6c2V0SXNUcmFuc3BhcmVudChi
b29sIGlzVHJhbnNwYXJlbnQpCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW
aWV3SW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp
ZXdJbXBsLmgJKHJldmlzaW9uIDk2Mzk3KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv
V2ViVmlld0ltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtMjE1LDYgKzIxNSw3IEBACiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbmFjdGl2ZUJhY2tncm91bmRD
b2xvciwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGluYWN0
aXZlRm9yZWdyb3VuZENvbG9yKTsKICAgICB2aXJ0dWFsIHZvaWQgcGVyZm9ybUN1c3RvbUNvbnRl
eHRNZW51QWN0aW9uKHVuc2lnbmVkIGFjdGlvbik7CisgICAgdmlydHVhbCB2b2lkIGNvbnRleHRN
ZW51Q2xvc2VkKCk7CiAgICAgdmlydHVhbCB2b2lkIGV4aXRGdWxsc2NyZWVuKCk7CiAKICAgICAv
LyBDQ0xheWVyVHJlZUhvc3RDbGllbnQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShy
ZXZpc2lvbiA5NjM5NykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDktMzAgIGNoYW5kcmEgc2hla2FyIHZh
bGxhbGEgIDxjaGFuZHJhLnZhbGxhbGFAZ21haWwuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV1J
biBpbnB1dCBmaWVsZCBjYXJldCBpcyBub3QgYmxpbmtpbmcgYWZ0ZXIgY29udGV4dCBtZW51IGhp
ZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTEz
NworCisgICAgICAgIEFkZGVkIGNvbnRleHRNZW51Q2xvc2VkIGZ1bmN0aW9uIGluIFdlYlZpZXcu
IFRoaXMgZnVuY3Rpb24gZ2V0IGNhbGxlZCB3aGVuIGNvbnRleHQgbWVudSAKKyAgICAgICAgaXMg
Y2xvc2VkIGluIHRoZSBicm93c2VyLiBJbiBjb250ZXh0TWVudUNsb3NlZCwgcmVzdW1lcyB0aGUg
Y2FyZXQgYmxpbmsgdG8gCisgICAgICAgIGFuaW1hdGUgc3RhdGUgd2hpY2ggd2FzIHN1c3BlbmRl
ZCBiZWZvcmUgdGhlIGNvbnRleHQgbWVudSBvcGVuIGluIG1vdXNlZG93bi4gT24gVW5peCwgV2Vi
VmlldyAKKyAgICAgICAgZG9lc24ndCByZWNlaXZlIHRoZSBtb3VzZXVwIGV2ZW50IHdoZXJlIGNh
cmV0QmxpbmtTdXNwZW5kZWQgaXMgc2V0IHRvIGZhbHNlLiBDYXJldCBkb2Vzbid0IGJsaW5rCisg
ICAgICAgIGFmdGVyIG1lbnUgaXMgY2xvc2VkIHNpbmNlIHdlIGxvc3QgdGhlIG1vdXNlIHVwIGV2
ZW50IHRvIHRoZSBjb250ZXh0IG1lbnUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlldy5oOgorICAgICAgICAoV2ViS2l0OjpX
ZWJWaWV3Ojpjb250ZXh0TWVudUNsb3NlZCk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNw
cDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmNvbnRleHRNZW51Q2xvc2VkKToKKyAg
ICAgICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKwogMjAxMS0wOS0zMCAgSmFtZXMgUm9iaW5zb24g
IDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIFdlYktpdCBB
UEkgZm9yIHNlbmRpbmcgaW5wdXQgZXZlbnRzIHRvIHRoZSBjb21wb3NpdG9yIHRocmVhZApJbmRl
eDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaAkocmV2aXNpb24gOTYzOTcp
CisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgJKHdvcmtpbmcgY29w
eSkKQEAgLTMyNyw3ICszMjcsOSBAQAogCiAgICAgdmlydHVhbCB2b2lkIHBlcmZvcm1DdXN0b21D
b250ZXh0TWVudUFjdGlvbih1bnNpZ25lZCBhY3Rpb24pID0gMDsKIAorICAgIHZpcnR1YWwgdm9p
ZCBjb250ZXh0TWVudUNsb3NlZCgpIHsgfQogCisKICAgICAvLyBQb3B1cCBtZW51IC0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogICAg
IC8vIFNldHMgd2hldGhlciBzZWxlY3QgcG9wdXAgbWVudXMgc2hvdWxkIGJlIHJlbmRlcmVkIGJ5
IHRoZSBicm93c2VyLgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>109479</attachid>
            <date>2011-10-03 06:09:20 -0700</date>
            <delta_ts>2011-10-17 02:03:11 -0700</delta_ts>
            <desc>updated the patch for mac/Linux.</desc>
            <filename>caret1.patch</filename>
            <type>text/plain</type>
            <size>3304</size>
            <attacher name="chandra shekar vallala">chandra.vallala</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlz
aW9uIDk2NDkwKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw
CSh3b3JraW5nIGNvcHkpCkBAIC0yMjY3LDYgKzIyNjcsMjEgQEAKICAgICBtX3BhZ2UtPmNvbnRl
eHRNZW51Q29udHJvbGxlcigpLT5jbGVhckNvbnRleHRNZW51KCk7CiB9CiAKK3ZvaWQgV2ViVmll
d0ltcGw6OmNvbnRleHRNZW51Q2xvc2VkKCkKK3sKKworICAgIC8vIE9uIExpbnV4L01hYywgd2hl
biBjb250ZXh0IG1lbnUgaXMgb3BlbmRlZCBXZWJWaWV3IGRvZXNuJ3QgcmVjZWl2ZSBtb3VzZXVw
IGV2ZW50IHNpbmNlCisgICAgLy8gaXQgaXMgcmVjZWl2ZWQgYnkgY29udGV4dCBtZW51LiBBcyBh
IHJlc3VsdCwgY2FyZXQgYmxpbmsgd2hpY2ggaXMgc3VzcGVuZGVkIGluIG1vdXNlZG93bgorICAg
IC8vIGV2ZW50IGlzIG5vdCByZXN1bWVkIHRpbGwgbmV4dCBtb3VzZXVwIGV2ZW50IGlzIHJlY2Vp
dmVkLgorI2lmIE9TKFVOSVgpIHx8IE9TKERBUldJTikKKyAgICBGcmFtZSogZnJhbWUgPSBmb2N1
c2VkV2ViQ29yZUZyYW1lKCk7CisgICAgaWYgKCFmcmFtZSkKKyAgICAgICAgcmV0dXJuOworCisg
ICAgZnJhbWUtPnNlbGVjdGlvbigpLT5zZXRDYXJldEJsaW5raW5nU3VzcGVuZGVkKGZhbHNlKTsK
KyNlbmRpZgorfQorCiAvLyBXZWJWaWV3IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKIHZvaWQgV2ViVmlld0ltcGw6
OnNldElzVHJhbnNwYXJlbnQoYm9vbCBpc1RyYW5zcGFyZW50KQpJbmRleDogU291cmNlL1dlYktp
dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0
L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCShyZXZpc2lvbiA5NjQ5MCkKKysrIFNvdXJjZS9X
ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTIxNSw2
ICsyMTUsNyBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQg
aW5hY3RpdmVCYWNrZ3JvdW5kQ29sb3IsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICB1bnNpZ25lZCBpbmFjdGl2ZUZvcmVncm91bmRDb2xvcik7CiAgICAgdmlydHVhbCB2b2lk
IHBlcmZvcm1DdXN0b21Db250ZXh0TWVudUFjdGlvbih1bnNpZ25lZCBhY3Rpb24pOworICAgIHZp
cnR1YWwgdm9pZCBjb250ZXh0TWVudUNsb3NlZCgpOwogICAgIHZpcnR1YWwgdm9pZCBleGl0RnVs
bHNjcmVlbigpOwogCiAgICAgLy8gQ0NMYXllclRyZWVIb3N0Q2xpZW50CkluZGV4OiBTb3VyY2Uv
V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gOTY0OTApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t
aXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDExLTEwLTAz
ICBjaGFuZHJhIHNoZWthciB2YWxsYWxhICA8Y2hhbmRyYS52YWxsYWxhQGdtYWlsLmNvbT4KKwor
ICAgICAgICBbY2hyb21pdW1dSW4gaW5wdXQgZmllbGQgY2FyZXQgaXMgbm90IGJsaW5raW5nIGFm
dGVyIGNvbnRleHQgbWVudSBoaWRlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9NjkxMzcKKworICAgICAgICBBZGRlZCBjb250ZXh0TWVudUNsb3NlZCBm
dW5jdGlvbiBpbiBXZWJWaWV3LiBUaGlzIGZ1bmN0aW9uIGdldCBjYWxsZWQgd2hlbiBjb250ZXh0
IG1lbnUgCisgICAgICAgIGlzIGNsb3NlZCBpbiB0aGUgYnJvd3Nlci4gSW4gY29udGV4dE1lbnVD
bG9zZWQsIHJlc3VtZXMgdGhlIGNhcmV0IGJsaW5rIHRvIAorICAgICAgICBhbmltYXRlIHN0YXRl
IHdoaWNoIHdhcyBzdXNwZW5kZWQgYmVmb3JlIHRoZSBjb250ZXh0IG1lbnUgb3BlbiBpbiBtb3Vz
ZWRvd24uIE9uIExpbnV4L01hYywgV2ViVmlldyAKKyAgICAgICAgZG9lc24ndCByZWNlaXZlIHRo
ZSBtb3VzZXVwIGV2ZW50IHdoZXJlIGNhcmV0QmxpbmtTdXNwZW5kZWQgaXMgc2V0IHRvIGZhbHNl
LiBDYXJldCBkb2Vzbid0IGJsaW5rCisgICAgICAgIGFmdGVyIG1lbnUgaXMgY2xvc2VkIHNpbmNl
IHdlIGxvc3QgdGhlIG1vdXNlIHVwIGV2ZW50IHRvIHRoZSBjb250ZXh0IG1lbnUKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJWaWV3
Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXc6OmNvbnRleHRNZW51Q2xvc2VkKToKKyAgICAg
ICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6
Y29udGV4dE1lbnVDbG9zZWQpOgorICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5oOgorCiAyMDEx
LTEwLTAzICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAg
ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByOTY0ODEuCkluZGV4OiBTb3VyY2UvV2ViS2l0
L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9j
aHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCShyZXZpc2lvbiA5NjQ5MCkKKysrIFNvdXJjZS9XZWJL
aXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaAkod29ya2luZyBjb3B5KQpAQCAtMzI3LDcgKzMy
Nyw5IEBACiAKICAgICB2aXJ0dWFsIHZvaWQgcGVyZm9ybUN1c3RvbUNvbnRleHRNZW51QWN0aW9u
KHVuc2lnbmVkIGFjdGlvbikgPSAwOwogCisgICAgdmlydHVhbCB2b2lkIGNvbnRleHRNZW51Q2xv
c2VkKCkgeyB9CiAKKwogICAgIC8vIFBvcHVwIG1lbnUgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiAgICAgLy8gU2V0cyB3aGV0aGVy
IHNlbGVjdCBwb3B1cCBtZW51cyBzaG91bGQgYmUgcmVuZGVyZWQgYnkgdGhlIGJyb3dzZXIuCg==
</data>
<flag name="review"
          id="106728"
          type_id="1"
          status="-"
          setter="rniwa"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>111226</attachid>
            <date>2011-10-17 02:03:11 -0700</date>
            <delta_ts>2011-10-20 00:33:12 -0700</delta_ts>
            <desc>updated patch</desc>
            <filename>bug-69137.patch</filename>
            <type>text/plain</type>
            <size>4053</size>
            <attacher name="chandra shekar vallala">chandra.vallala</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBlOWQ0YTE0Li4yN2ZhNGFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg
QEAKKzIwMTEtMTAtMTcgIENoYW5kcmEgU2hla2FyIFZhbGxhbGEgIDxjaGFuZHJhLnZhbGxhbGFA
bW90b3JvbGEuY29tPgorCisgICAgICAgIEluIGlucHV0IGZpZWxkIGNhcmV0IGlzIG5vdCBibGlu
a2luZyBhZnRlciBjb250ZXh0IG1lbnUgaGlkZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkxMzcKKworICAgICAgICBBZGRlZCBjb250ZXh0TWVudUhp
ZGRlbiBmdW5jdGlvbi4gVGhpcyBmdW5jdGlvbiBzaG91bGQgY2FsbGVkIHdoZW4gY29udGV4dCBt
ZW51IAorICAgICAgICBpcyBkaXNtaXNzZWQgaW4gYnJvd3Nlci4gSW4gY29udGV4dE1lbnVIaWRk
ZW4sIHJlc3VtZXMgdGhlIGNhcmV0IGJsaW5rIHRvIGFuaW1hdGUgc3RhdGUgCisgICAgICAgIHdo
aWNoIHdhcyBzdXNwZW5kZWQgaW4gc2hvd0NvbnRleHRNZW51LgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisg
ICAgICAgICogcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29y
ZTo6Q29udGV4dE1lbnVDb250cm9sbGVyOjpjb250ZXh0TWVudUhpZGRlbik6CisgICAgICAgIChX
ZWJDb3JlOjpDb250ZXh0TWVudUNvbnRyb2xsZXI6OnNob3dDb250ZXh0TWVudSk6CisgICAgICAg
ICogcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFu
ZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OnN1c3BlbmRDYXJldEJs
aW5raW5nKToKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5oOgorCiAyMDExLTEwLTE3ICBB
bmRyZWkgTGF2cmVuaXl1ayAgPGFuZHkubGF2ckBnbWFpbC5jb20+CiAKICAgICAgICAgRml4IGNs
YW5nIFdlYktpdEdUSysgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nv
bnRleHRNZW51Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRleHRNZW51
Q29udHJvbGxlci5jcHAKaW5kZXggYmZkYzdiZS4uMDgzMDkwZSAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD
b3JlL3BhZ2UvQ29udGV4dE1lbnVDb250cm9sbGVyLmNwcApAQCAtOTUsNiArOTUsMjAgQEAgdm9p
ZCBDb250ZXh0TWVudUNvbnRyb2xsZXI6OmNsZWFyQ29udGV4dE1lbnUoKQogICAgIG1fbWVudVBy
b3ZpZGVyID0gMDsKIH0KIAordm9pZCBDb250ZXh0TWVudUNvbnRyb2xsZXI6OmNvbnRleHRNZW51
SGlkZGVuKCkKK3sKKyAgICBOb2RlKiBub2RlID0gbV9oaXRUZXN0UmVzdWx0LmlubmVyTm9uU2hh
cmVkTm9kZSgpOworICAgIGlmICghbm9kZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgRnJhbWUg
KmZyYW1lID0gbm9kZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKTsKKyAgICBpZiAoIWZyYW1lKQorICAg
ICAgICByZXR1cm47CisKKyAgICAvLyBSZXN1bWUgdGhlIGNhcmV0IGJsaW5raW5nIHdoaWNoIHN1
c3BlbmRlZCBpbiBjb250ZXh0IG1lbnUgc2hvdy4KKyAgICBmcmFtZS0+ZXZlbnRIYW5kbGVyKCkt
PnN1c3BlbmRDYXJldEJsaW5raW5nKGZhbHNlKTsKK30KKwogdm9pZCBDb250ZXh0TWVudUNvbnRy
b2xsZXI6OmhhbmRsZUNvbnRleHRNZW51RXZlbnQoRXZlbnQqIGV2ZW50KQogewogICAgIG1fY29u
dGV4dE1lbnUgPSBjcmVhdGVDb250ZXh0TWVudShldmVudCk7CkBAIC0xNTMsNiArMTY3LDEwIEBA
IHZvaWQgQ29udGV4dE1lbnVDb250cm9sbGVyOjpzaG93Q29udGV4dE1lbnUoRXZlbnQqIGV2ZW50
KQogICAgIG1fY29udGV4dE1lbnUtPnNldFBsYXRmb3JtRGVzY3JpcHRpb24oY3VzdG9tTWVudSk7
CiAjZW5kaWYKICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKKworICAgIEZyYW1lKiBm
cmFtZSA9IG1faGl0VGVzdFJlc3VsdC5pbm5lck5vblNoYXJlZE5vZGUoKS0+ZG9jdW1lbnQoKS0+
ZnJhbWUoKTsKKyAgICAvLyBTdXNwZW5kIHRoZSBjYXJldCBibGlua2luZyB0byBtYXRjaCBuYXRp
dmUgYXBwbGljYXRpb24gYmVoYXZpb3IuCisgICAgZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5zdXNw
ZW5kQ2FyZXRCbGlua2luZyh0cnVlKTsKIH0KIAogc3RhdGljIHZvaWQgb3Blbk5ld1dpbmRvdyhj
b25zdCBLVVJMJiB1cmxUb0xvYWQsIEZyYW1lKiBmcmFtZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL3BhZ2UvQ29udGV4dE1lbnVDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdl
L0NvbnRleHRNZW51Q29udHJvbGxlci5oCmluZGV4IGU2YTBhMDAuLmU1ZTQxM2UgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29udGV4dE1lbnVDb250cm9sbGVyLmgKKysrIGIvU291
cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuaApAQCAtNTQsNiArNTQsNyBA
QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgdm9pZCBoYW5kbGVDb250ZXh0TWVudUV2
ZW50KEV2ZW50Kik7CiAgICAgICAgIHZvaWQgc2hvd0NvbnRleHRNZW51KEV2ZW50KiwgUGFzc1Jl
ZlB0cjxDb250ZXh0TWVudVByb3ZpZGVyPik7CisgICAgICAgIHZvaWQgY29udGV4dE1lbnVIaWRk
ZW4oKTsKIAogICAgICAgICB2b2lkIHBvcHVsYXRlKCk7CiAgICAgICAgIHZvaWQgY29udGV4dE1l
bnVJdGVtU2VsZWN0ZWQoQ29udGV4dE1lbnVJdGVtKik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFu
ZGxlci5jcHAKaW5kZXggOTZlYzc3ZC4uZWZjOTIzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRI
YW5kbGVyLmNwcApAQCAtNzE1LDYgKzcxNSwxMiBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6bG9zdE1v
dXNlQ2FwdHVyZSgpCiAgICAgbV9mcmFtZS0+c2VsZWN0aW9uKCktPnNldENhcmV0QmxpbmtpbmdT
dXNwZW5kZWQoZmFsc2UpOwogfQogCit2b2lkIEV2ZW50SGFuZGxlcjo6c3VzcGVuZENhcmV0Qmxp
bmtpbmcoYm9vbCBzaG91bGRTdXNwZW5kKQoreworICAgIC8vIFVzZWQgdG8gc3RvcC9yZXN1bWUg
Y2FyZXQgYmxpbmtpbmcgb24gY29udGV4dCBtZW51IG9wZW4vaGlkZS4KKyAgICBtX2ZyYW1lLT5z
ZWxlY3Rpb24oKS0+c2V0Q2FyZXRCbGlua2luZ1N1c3BlbmRlZChzaG91bGRTdXNwZW5kKTsKK30K
KwogYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlVXAoY29uc3QgTW91c2VFdmVudFdpdGhI
aXRUZXN0UmVzdWx0cyYgZXZlbnQpCiB7CiAgICAgaWYgKGV2ZW50TG9vcEhhbmRsZU1vdXNlVXAo
ZXZlbnQpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaCBi
L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgKaW5kZXggOWNjMDNiZi4uMTJlYzJl
OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAorKysgYi9T
b3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCkBAIC0xNTEsNiArMTUxLDcgQEAgcHVi
bGljOgogICAgIGJvb2wgbW91c2VNb3ZlZChjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQmKTsKIAog
ICAgIHZvaWQgbG9zdE1vdXNlQ2FwdHVyZSgpOworICAgIHZvaWQgc3VzcGVuZENhcmV0Qmxpbmtp
bmcoYm9vbCBzaG91bGRTdXNwZW5kKTsKIAogICAgIGJvb2wgaGFuZGxlTW91c2VQcmVzc0V2ZW50
KGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYpOwogICAgIGJvb2wgaGFuZGxlTW91c2VNb3ZlRXZl
bnQoY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JiwgSGl0VGVzdFJlc3VsdCogaG92ZXJlZE5vZGUg
PSAwKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>111734</attachid>
            <date>2011-10-20 00:33:12 -0700</date>
            <delta_ts>2011-10-20 04:05:44 -0700</delta_ts>
            <desc>WebCore changes</desc>
            <filename>bug-69137-webcore.patch</filename>
            <type>text/plain</type>
            <size>1948</size>
            <attacher name="chandra shekar vallala">chandra.vallala</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBiNDM4ZWE0Li5lMmEwM2ZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTEtMTAtMjAgIENoYW5kcmEgU2hla2FyIFZhbGxhbGEgIDxjaGFuZHJhLnZhbGxhbGFA
bW90b3JvbGEuY29tPgorCisgICAgICAgIEluIGlucHV0IGZpZWxkIGNhcmV0IGlzIG5vdCBibGlu
a2luZyBhZnRlciBjb250ZXh0IG1lbnUgaGlkZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkxMzcKKworICAgICAgICBBZGRlZCB0d28gbmV3IGZ1bmN0
aW9ucyBpbiBFdmVudEhhbmRsZXIgdG8gY2FsbCBmcm9tIFdlYktpdCBsYXllciB3aGVuIGNvbnRl
eHRtZW51IHNob3duL2Nsb3NlZC4KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwYWdlL0V2ZW50
SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZXNwb25kVG9Db250ZXh0TWVudVNob3du
KToKKyAgICAgICAgKFdlYkNvcmU6OnJlc3BvbmRUb0NvbnRleHRNZW51RGlzbWlzc2VkKToKKyAg
ICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5oOgorCiAyMDExLTEwLTE5ICBLZW50YXJvIEhhcmEg
IDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBNZXNzYWdlRXZlbnQuZGF0YSBjYW4g
YmUgc3RvcmVkIGFzIFNjcmlwdFZhbHVlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn
ZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw
CmluZGV4IDk2ZWM3N2QuLmNkMjA0MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv
RXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5j
cHAKQEAgLTIyNTksNiArMjI1OSwxNiBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVy
ZUV2ZW50KGNvbnN0IFBsYXRmb3JtR2VzdHVyZUV2ZW50JiBnZXN0dXJlRXZlbnQpCiAjZW5kaWYK
IAogI2lmIEVOQUJMRShDT05URVhUX01FTlVTKQordm9pZCByZXNwb25kVG9Db250ZXh0TWVudVNo
b3duKCkKK3sKKyAgICBtX2ZyYW1lLT5zZWxlY3Rpb24oKS0+c2V0Q2FyZXRCbGlua2luZ1N1c3Bl
bmRlZCh0cnVlKTsKK30KKwordm9pZCByZXNwb25kVG9Db250ZXh0TWVudURpc21pc3NlZCgpCit7
CisgICAgbV9mcmFtZS0+c2VsZWN0aW9uKCktPnNldENhcmV0QmxpbmtpbmdTdXNwZW5kZWQoZmFs
c2UpOworfQorCiBib29sIEV2ZW50SGFuZGxlcjo6c2VuZENvbnRleHRNZW51RXZlbnQoY29uc3Qg
UGxhdGZvcm1Nb3VzZUV2ZW50JiBldmVudCkKIHsKICAgICBEb2N1bWVudCogZG9jID0gbV9mcmFt
ZS0+ZG9jdW1lbnQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5k
bGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCmluZGV4IDljYzAzYmYu
LjVlZmY3YmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgK
KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaApAQCAtMTYzLDYgKzE2Myw4
IEBAIHB1YmxpYzoKICNlbmRpZgogCiAjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCisgICAgdm9p
ZCByZXNwb25kVG9Db250ZXh0TWVudVNob3duKCk7CisgICAgdm9pZCByZXNwb25kVG9Db250ZXh0
TWVudURpc21pc3NlZCgpOwogICAgIGJvb2wgc2VuZENvbnRleHRNZW51RXZlbnQoY29uc3QgUGxh
dGZvcm1Nb3VzZUV2ZW50Jik7CiAgICAgYm9vbCBzZW5kQ29udGV4dE1lbnVFdmVudEZvcktleSgp
OwogI2VuZGlmCg==
</data>
<flag name="review"
          id="109639"
          type_id="1"
          status="-"
          setter="rniwa"
    />
    <flag name="commit-queue"
          id="109640"
          type_id="3"
          status="-"
          setter="webkit-ews"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>111750</attachid>
            <date>2011-10-20 04:05:44 -0700</date>
            <delta_ts>2011-10-21 07:27:26 -0700</delta_ts>
            <desc>updated patch</desc>
            <filename>bug-69137-webcore.patch</filename>
            <type>text/plain</type>
            <size>1968</size>
            <attacher name="chandra shekar vallala">chandra.vallala</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBiNDM4ZWE0Li44MTRhNWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTEtMTAtMjAgIENoYW5kcmEgU2hla2FyIFZhbGxhbGEgIDxjaGFuZHJhLnZhbGxhbGFA
bW90b3JvbGEuY29tPgorCisgICAgICAgIEluIGlucHV0IGZpZWxkIGNhcmV0IGlzIG5vdCBibGlu
a2luZyBhZnRlciBjb250ZXh0IG1lbnUgaGlkZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkxMzcKKworICAgICAgICBBZGRlZCB0d28gbmV3IGZ1bmN0
aW9ucyBpbiBFdmVudEhhbmRsZXIgdG8gY2FsbCB3aGVuIGNvbnRleHRtZW51IHNob3duL2Nsb3Nl
ZC4KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3
IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAg
ICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OndpbGxTaG93Q29udGV4dE1lbnUpOgorICAgICAg
ICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpyZXNwb25kVG9Db250ZXh0TWVudURpc21pc3NhbCk6
CisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuaDoKKwogMjAxMS0xMC0xOSAgS2VudGFybyBI
YXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWVzc2FnZUV2ZW50LmRhdGEg
Y2FuIGJlIHN0b3JlZCBhcyBTY3JpcHRWYWx1ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVy
LmNwcAppbmRleCA5NmVjNzdkLi4xMmVlZTFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w
YWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRs
ZXIuY3BwCkBAIC0yMjU5LDYgKzIyNTksMTYgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZUdl
c3R1cmVFdmVudChjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZW50KQogI2Vu
ZGlmCiAKICNpZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKK3ZvaWQgRXZlbnRIYW5kbGVyOjp3aWxs
U2hvd0NvbnRleHRNZW51KCkKK3sKKyAgICBtX2ZyYW1lLT5zZWxlY3Rpb24oKS0+c2V0Q2FyZXRC
bGlua2luZ1N1c3BlbmRlZCh0cnVlKTsKK30KKwordm9pZCBFdmVudEhhbmRsZXI6OnJlc3BvbmRU
b0NvbnRleHRNZW51RGlzbWlzc2FsKCkKK3sKKyAgICBtX2ZyYW1lLT5zZWxlY3Rpb24oKS0+c2V0
Q2FyZXRCbGlua2luZ1N1c3BlbmRlZChmYWxzZSk7Cit9CisKIGJvb2wgRXZlbnRIYW5kbGVyOjpz
ZW5kQ29udGV4dE1lbnVFdmVudChjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQmIGV2ZW50KQogewog
ICAgIERvY3VtZW50KiBkb2MgPSBtX2ZyYW1lLT5kb2N1bWVudCgpOwpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl
bnRIYW5kbGVyLmgKaW5kZXggOWNjMDNiZi4uNjNlZDBiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50
SGFuZGxlci5oCkBAIC0xNjMsNiArMTYzLDggQEAgcHVibGljOgogI2VuZGlmCiAKICNpZiBFTkFC
TEUoQ09OVEVYVF9NRU5VUykKKyAgICB2b2lkIHdpbGxTaG93Q29udGV4dE1lbnUoKTsKKyAgICB2
b2lkIHJlc3BvbmRUb0NvbnRleHRNZW51RGlzbWlzc2FsKCk7CiAgICAgYm9vbCBzZW5kQ29udGV4
dE1lbnVFdmVudChjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQmKTsKICAgICBib29sIHNlbmRDb250
ZXh0TWVudUV2ZW50Rm9yS2V5KCk7CiAjZW5kaWYK
</data>
<flag name="review"
          id="109658"
          type_id="1"
          status="-"
          setter="rniwa"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>111962</attachid>
            <date>2011-10-21 07:27:26 -0700</date>
            <delta_ts>2011-10-21 07:37:12 -0700</delta_ts>
            <desc>patch for chromium port changes.</desc>
            <filename>caret-webkit.patch</filename>
            <type>text/plain</type>
            <size>3737</size>
            <attacher name="chandra shekar vallala">chandra.vallala</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl
YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggYmIyMjMyZS4uNzI5NDhjNSAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j
aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMS0xMC0yMSAgQ2hhbmRyYSBT
aGVrYXIgVmFsbGFsYSAgPGNoYW5kcmEudmFsbGFsYUBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAg
SW4gaW5wdXQgZmllbGQgY2FyZXQgaXMgbm90IGJsaW5raW5nIGFmdGVyIGNvbnRleHQgbWVudSBo
aWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTEz
NworCisgICAgICAgIEFkZGVkIGEgbmV3IGZ1bmN0aW9uIGNvbnRleHRNZW51Q2xvc2VkIGluIFdl
YlZpZXdJbXBsIHRvIHJlc3VtZXMgdGhlIGNhcmV0IGJsaW5rIHRvIGFuaW1hdGUgc3RhdGUgCisg
ICAgICAgIHdoaWNoIGlzIHN1c3BlbmRlZCBiZWZvcmUgc2hvd2luZyB0aGUgY29udGV4dG1lbnUu
IFRoaXMgZnVuY3Rpb24gc2hvdWxkIGNhbGxlZCB3aGVuIGNvbnRleHQgbWVudSBpcyBkaXNtaXNz
ZWQuIAorICAgICAgICBFdmVudEhhbmRsZXI6OndpbGxTaG93Q29udGV4dE1lbnUgc2hvdWxkIGJl
IGNhbGxlZCB0byBzdXNwZW5kIHRoZSBjYXJldCBibGluayBiZWZvcmUgdGhlIGNvbnRleHQgbWVu
dSBzaG93bi4gCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgKiBwdWJsaWMvV2ViVmlldy5oOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Ojpjb250ZXh0
TWVudUNsb3NlZCk6CisgICAgICAgICogc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHA6Cisg
ICAgICAgIChXZWJLaXQ6OkNvbnRleHRNZW51Q2xpZW50SW1wbDo6Z2V0Q3VzdG9tTWVudUZyb21E
ZWZhdWx0SXRlbXMpOgorICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChX
ZWJLaXQ6OldlYlZpZXdJbXBsOjpjb250ZXh0TWVudUNsb3NlZCk6CisgICAgICAgICogc3JjL1dl
YlZpZXdJbXBsLmg6CisKIDIwMTEtMTAtMjEgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJv
bWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBXZWIgSW5zcGVjdG9yOiByZW1vdmUgZGVi
dWdnZXIgc3VwcG9ydCBmb3Igb3V0LW9mLXByb2Nlc3MgZGVkaWNhdGVkIHdvcmtlcnMKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaCBiL1NvdXJjZS9X
ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaAppbmRleCA3NWUwYmIwLi44MDc5YjRiIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKKysrIGIv
U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCkBAIC0zMjQsNyArMzI0LDgg
QEAgcHVibGljOgogCiAKICAgICAvLyBDb250ZXh0IG1lbnUgLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KLQorICAgIAorICAgIHZpcnR1YWwg
dm9pZCBjb250ZXh0TWVudUNsb3NlZCgpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBwZXJmb3JtQ3Vz
dG9tQ29udGV4dE1lbnVBY3Rpb24odW5zaWduZWQgYWN0aW9uKSA9IDA7CiAKIApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcCBi
L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKaW5k
ZXggZDE2MzMwNy4uNjI4NTE5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z
cmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt
L3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCkBAIC0xNTYsNiArMTU2LDggQEAgUGxhdGZv
cm1NZW51RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJv
bURlZmF1bHRJdGVtcygKIAogICAgIEhpdFRlc3RSZXN1bHQgciA9IG1fd2ViVmlldy0+cGFnZSgp
LT5jb250ZXh0TWVudUNvbnRyb2xsZXIoKS0+aGl0VGVzdFJlc3VsdCgpOwogICAgIEZyYW1lKiBz
ZWxlY3RlZEZyYW1lID0gci5pbm5lck5vblNoYXJlZE5vZGUoKS0+ZG9jdW1lbnQoKS0+ZnJhbWUo
KTsKKyAgICAKKyAgICBzZWxlY3RlZEZyYW1lLT5ldmVudEhhbmRsZXIoKS0+d2lsbFNob3dDb250
ZXh0TWVudSgpOwogCiAgICAgV2ViQ29udGV4dE1lbnVEYXRhIGRhdGE7CiAgICAgZGF0YS5tb3Vz
ZVBvc2l0aW9uID0gc2VsZWN0ZWRGcmFtZS0+dmlldygpLT5jb250ZW50c1RvV2luZG93KHIucG9p
bnQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w
bC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXgg
NGU4YzY2Yy4uM2E2M2NkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv
V2ViVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ
bXBsLmNwcApAQCAtMjI2OSw2ICsyMjY5LDIxIEBAIHZvaWQgV2ViVmlld0ltcGw6OmhpZGVQb3B1
cHMoKQogICAgIGhpZGVBdXRvZmlsbFBvcHVwKCk7CiB9CiAKK3ZvaWQgV2ViVmlld0ltcGw6OmNv
bnRleHRNZW51Q2xvc2VkKCkKK3sKKyAgICBpZiAoIW1fcGFnZSkKKyAgICAgICAgcmV0dXJuOwor
CisgICAgSGl0VGVzdFJlc3VsdCByZXN1bHQgPSBtX3BhZ2UtPmNvbnRleHRNZW51Q29udHJvbGxl
cigpLT5oaXRUZXN0UmVzdWx0KCk7CisKKyAgICBOb2RlKiBub2RlID0gcmVzdWx0LmlubmVyTm9u
U2hhcmVkTm9kZSgpOworICAgIGlmICghbm9kZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgbm9k
ZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPnJlc3BvbmRUb0NvbnRleHRN
ZW51RGlzbWlzc2FsKCk7CisKK30KKwogdm9pZCBXZWJWaWV3SW1wbDo6cGVyZm9ybUN1c3RvbUNv
bnRleHRNZW51QWN0aW9uKHVuc2lnbmVkIGFjdGlvbikKIHsKICAgICBpZiAoIW1fcGFnZSkKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmggYi9Tb3Vy
Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCmluZGV4IDVhMWRkMTUuLjk2OGMz
NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgK
KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaApAQCAtMjIwLDYg
KzIyMCw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVu
c2lnbmVkIGFjdGl2ZUZvcmVncm91bmRDb2xvciwKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHVuc2lnbmVkIGluYWN0aXZlQmFja2dyb3VuZENvbG9yLAogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW5hY3RpdmVGb3JlZ3JvdW5kQ29sb3Ip
OworICAgIHZpcnR1YWwgdm9pZCBjb250ZXh0TWVudUNsb3NlZCgpOwogICAgIHZpcnR1YWwgdm9p
ZCBwZXJmb3JtQ3VzdG9tQ29udGV4dE1lbnVBY3Rpb24odW5zaWduZWQgYWN0aW9uKTsKICAgICB2
aXJ0dWFsIHZvaWQgZXhpdEZ1bGxzY3JlZW4oKTsKIAo=
</data>
<flag name="review"
          id="109917"
          type_id="1"
          status="-"
          setter="fishd"
    />
    <flag name="commit-queue"
          id="109918"
          type_id="3"
          status="-"
          setter="fishd"
    />
          </attachment>
      

    </bug>

</bugzilla>