69134 2011-09-30 00:07:23 -0700 [Qt][WK2] Fix failing "narrow" tests after migrating to refactored Qt5 2011-10-03 03:15:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 69104 1 ossy vestbo ossy yael oldest_to_newest 475950 0 ossy 2011-09-30 00:07:23 -0700 There are zillion similar failing tests. It seems the page is so narrow. For example: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r96349%20%2812586%29/css2.1/20110323/absolute-non-replaced-height-001-pretty-diff.html -layer at (0,0) size 800x600 -RenderView at (0,0) size 800x600 -layer at (0,0) size 800x22 +RenderView at (0,0) size 0x0 +layer at (0,0) size 0x304 +layer at (0,0) size 0x304 It seems that the width of the size is 0 pixel. :o 476117 1 vestbo 2011-09-30 08:59:02 -0700 Got a fix. 476255 2 109327 vestbo 2011-09-30 12:44:57 -0700 Created attachment 109327 Patch 476270 3 109327 vestbo 2011-09-30 13:05:28 -0700 Comment on attachment 109327 Patch Landed in r96416 476864 4 ossy 2011-10-03 03:15:33 -0700 This bug was fixed ... but css tests still fail because of metric differences. A volunteer have to check them manually one by one. :-/ 109327 2011-09-30 12:44:57 -0700 2011-09-30 13:05:28 -0700 Patch bug-69134-20110930214455.patch text/plain 3768 vestbo U3VidmVyc2lvbiBSZXZpc2lvbjogOTY0MTQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiNmM4N2ExMGM2ZDVlNjkzMzY0NmQzNmRkOWZhNGE5Y2Uz MmU4MDRkLi5mNjM2NWNiMzQxOTdlZjcwMWFmNDE0YTU4ZmM2YTdlYWZkNzVhOWNhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTEtMDktMzAgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEu Y29tPgorCisgICAgICAgIFtRdF0gTWFrZSBzdXJlIFdUUiBzaXplcyB0aGUgd2luZG93IGFuZCBp dGVtIGNvcnJlY3RseQorCisgICAgICAgIFJldmlzaW9uIDk2MzQ1IGNoYW5nZWQgdGhlIGxvZ2lj IGZvciBob3cgdGhlIHZpZXcgYW5kCisgICAgICAgIHdpbmRvdyB3YXMgY3JlYXRlZCwgYnV0IG1p c3NlZCBhIHZpdGFsIHBhcnQsIHNldHRpbmcKKyAgICAgICAgdGhlIHNpemUuCisKKyAgICAgICAg V2Ugbm93IHVzZSBhIFFTR1ZpZXcgZm9yIHRoZSB3aW5kb3csIHRoYXQgaGFzIGEgc2ltcGxlCisg ICAgICAgIGl0ZW0gYXMgaXRzIHJvb3Qgb2JqZWN0IHRoYXQgaXMgYWx3YXlzIHJlc2l6ZWQgdG8g Zml0CisgICAgICAgIHdpdGhpbiB0aGUgd2luZG93LiBUaGUgd2VidmlldyBpcyB0aGVuIHBhcmVu dGVkIHRvIHRoZQorICAgICAgICByb290IG9iamVjdCBhbmQgc2V0IHRvIGFuY2hvcnMuZmlsbDog cGFyZW50LiBUaGF0IHdheQorICAgICAgICBhbnkgd2luZG93IGdlb21ldHJ5IGNoYW5nZXMgd2ls bCBwcm9wYWdhdGUgdG8gdGhlIHdlYgorICAgICAgICB2aWV3LgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTEzNAorCisgICAgICAgIFJldmlld2Vk IGJ5IEFuZHJlYXMgS2xpbmcuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1BsYXRmb3Jt V2ViVmlldy5oOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3 UXQuY3BwOgorCiAyMDExLTA5LTMwICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1 c2lvbi5tb2JpPgogCiAgICAgICAgIFtFRkxdIE9ubHkgc2F2ZSB0aGUgY3VycmVudCB2aWV3cG9y dCBpbiBQaXhlbER1bXBTdXBwb3J0RWZsLgpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9QbGF0Zm9ybVdlYlZpZXcuaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1X ZWJWaWV3LmgKaW5kZXggNTI4NGU4N2Q2N2UzNDgyZThjOWYyYTdjZjljNWUwNzEyYjFjZDY1OC4u MWNmZjY4OGU4OTZkNTNmYTdmZmRmYjI5MTcxN2I0M2FhZmNhOWNjZSAxMDA2NDQKLS0tIGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcuaAorKysgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL1BsYXRmb3JtV2ViVmlldy5oCkBAIC0yOSw4ICsyOSw4IEBACiAjaWYgZGVmaW5l ZChCVUlMRElOR19RVF9fKQogY2xhc3MgUURlc2t0b3BXZWJWaWV3OwogdHlwZWRlZiBRRGVza3Rv cFdlYlZpZXcqIFBsYXRmb3JtV0tWaWV3OwotY2xhc3MgUVNHQ2FudmFzOwotdHlwZWRlZiBRU0dD YW52YXMqIFBsYXRmb3JtV2luZG93OworY2xhc3MgUVNHVmlldzsKK3R5cGVkZWYgUVNHVmlldyog UGxhdGZvcm1XaW5kb3c7CiAjZWxpZiBkZWZpbmVkKF9fQVBQTEVfXykgJiYgX19BUFBMRV9fCiAj aWYgX19PQkpDX18KIEBjbGFzcyBXS1ZpZXc7CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv cXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwCmluZGV4IGYxZTBiNjk3MzQxMjEyZTJiMTFkZTIyNjNj YzkwNzc1NjFkNWY2OWYuLjkzZjA2YzcxMTczYWVhZWNiMGQyOGI5OTBjZmM4ZGNiMGEwNmU3ODIg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQu Y3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3Bw CkBAIC0zMCwyMCArMzAsNDYgQEAKICNpbmNsdWRlICJxZGVza3RvcHdlYnZpZXcuaCIKIAogI2lu Y2x1ZGUgPFFBcHBsaWNhdGlvbj4KLSNpbmNsdWRlIDxRdERlY2xhcmF0aXZlL3FzZ2NhbnZhcy5o PgorI2luY2x1ZGUgPFFEZWNsYXJhdGl2ZVByb3BlcnR5PgorI2luY2x1ZGUgPFFTR1ZpZXc+CiAK IG5hbWVzcGFjZSBXVFIgewogCitjbGFzcyBXcmFwcGVyV2luZG93IDogcHVibGljIFFTR1ZpZXcg eworICAgIFFfT0JKRUNUCitwdWJsaWM6CisgICAgV3JhcHBlcldpbmRvdyhRU0dJdGVtKiB2aWV3 KQorICAgICAgICA6IFFTR1ZpZXcoUVVybCgiZGF0YTp0ZXh0L3BsYWluLGltcG9ydCBRdFF1aWNr IDIuMFxuSXRlbSB7IG9iamVjdE5hbWU6ICdyb290JyB9IikpCisgICAgICAgICwgbV92aWV3KHZp ZXcpCisgICAgeworICAgICAgICBjb25uZWN0KHRoaXMsIFNJR05BTChzdGF0dXNDaGFuZ2VkKFFT R1ZpZXc6OlN0YXR1cykpLCBTTE9UKGhhbmRsZVN0YXR1c0NoYW5nZWQoUVNHVmlldzo6U3RhdHVz KSkpOworICAgIH0KKworcHJpdmF0ZSBzbG90czoKKyAgICB2b2lkIGhhbmRsZVN0YXR1c0NoYW5n ZWQoUVNHVmlldzo6U3RhdHVzIHN0YXR1cykKKyAgICB7CisgICAgICAgIGlmIChzdGF0dXMgIT0g UVNHVmlldzo6UmVhZHkpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgc2V0R2VvbWV0 cnkoMCwgMCwgODAwLCA2MDApOworICAgICAgICBzZXRSZXNpemVNb2RlKFFTR1ZpZXc6OlNpemVS b290T2JqZWN0VG9WaWV3KTsKKworICAgICAgICBtX3ZpZXctPnNldFBhcmVudEl0ZW0ocm9vdE9i amVjdCgpKTsKKyAgICAgICAgUURlY2xhcmF0aXZlUHJvcGVydHk6OndyaXRlKG1fdmlldywgImFu Y2hvcnMuZmlsbCIsIHFWYXJpYW50RnJvbVZhbHVlKHJvb3RPYmplY3QoKSkpOworCisgICAgICAg IFFGb2N1c0V2ZW50IGV2KFFFdmVudDo6V2luZG93QWN0aXZhdGUpOworICAgICAgICBRQXBwbGlj YXRpb246OnNlbmRFdmVudChtX3ZpZXcsICZldik7CisgICAgICAgIG1fdmlldy0+c2V0Rm9jdXMo UXQ6Ok90aGVyRm9jdXNSZWFzb24pOworICAgIH0KKworcHJpdmF0ZToKKyAgICBRU0dJdGVtKiBt X3ZpZXc7Cit9OworCiBQbGF0Zm9ybVdlYlZpZXc6OlBsYXRmb3JtV2ViVmlldyhXS0NvbnRleHRS ZWYgY29udGV4dFJlZiwgV0tQYWdlR3JvdXBSZWYgcGFnZUdyb3VwUmVmKQogICAgIDogbV92aWV3 KG5ldyBRRGVza3RvcFdlYlZpZXcoY29udGV4dFJlZiwgcGFnZUdyb3VwUmVmKSkKLSAgICAsIG1f d2luZG93KG5ldyBRU0dDYW52YXMpCisgICAgLCBtX3dpbmRvdyhuZXcgV3JhcHBlcldpbmRvdyht X3ZpZXcpKQogewotICAgIG1fdmlldy0+c2V0UGFyZW50KG1fd2luZG93LT5yb290SXRlbSgpKTsK LSAgICBtX3dpbmRvdy0+c2V0R2VvbWV0cnkoMCwgMCwgODAwLCA2MDApOwotCi0gICAgUUZvY3Vz RXZlbnQgZXYoUUV2ZW50OjpXaW5kb3dBY3RpdmF0ZSk7Ci0gICAgUUFwcGxpY2F0aW9uOjpzZW5k RXZlbnQobV92aWV3LCAmZXYpOwotICAgIG1fdmlldy0+c2V0Rm9jdXMoUXQ6Ok90aGVyRm9jdXNS ZWFzb24pOwogfQogCiBQbGF0Zm9ybVdlYlZpZXc6On5QbGF0Zm9ybVdlYlZpZXcoKQpAQCAtOTMs MyArMTE5LDUgQEAgdm9pZCBQbGF0Zm9ybVdlYlZpZXc6OnBvc3RFdmVudChRRXZlbnQqIGV2ZW50 KQogfQogCiB9IC8vIG5hbWVzcGFjZSBXVFIKKworI2luY2x1ZGUgIlBsYXRmb3JtV2ViVmlld1F0 Lm1vYyIK