69133 2011-09-30 00:01:46 -0700 Fix bug in getHostCallReturnValue of DFG JIT on X86 2011-09-30 13:35:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough webkit.review.bot oldest_to_newest 475942 0 yuqiang.xian 2011-09-30 00:01:46 -0700 We need to insert the additional argument in the stack slot before return address instead of simply pushing it afterwards. Also getHostCallReturnValue* should be attributed as stdcall to make the stack cleaned up by the callee. 475946 1 109260 yuqiang.xian 2011-09-30 00:04:43 -0700 Created attachment 109260 proposed patch 476284 2 109260 webkit.review.bot 2011-09-30 13:35:14 -0700 Comment on attachment 109260 proposed patch Clearing flags on attachment: 109260 Committed r96419: <http://trac.webkit.org/changeset/96419> 476285 3 webkit.review.bot 2011-09-30 13:35:18 -0700 All reviewed patches have been landed. Closing bug. 109260 2011-09-30 00:04:43 -0700 2011-09-30 13:35:14 -0700 proposed patch 69133.patch text/plain 2135 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTYzOTEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDktMjkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgRml4IGJ1ZyBpbiBnZXRIb3N0Q2FsbFJldHVyblZhbHVlIG9mIERGRyBKSVQgb24gWDg2 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTEzMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQg dG8gaW5zZXJ0IHRoZSBhZGRpdGlvbmFsIGFyZ3VtZW50IGluIHRoZSBzdGFjayBzbG90IGJlZm9y ZQorICAgICAgICByZXR1cm4gYWRkcmVzcyBpbnN0ZWFkIG9mIHNpbXBseSBwdXNoaW5nIGl0IGFm dGVyd2FyZHMuCisgICAgICAgIEFsc28gZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSogc2hvdWxkIGJl IGF0dHJpYnV0ZWQgYXMgc3RkY2FsbAorICAgICAgICB0byBtYWtlIHRoZSBzdGFjayBjbGVhbmVk IHVwIGJ5IHRoZSBjYWxsZWUuCisKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0aW9ucy5jcHA6CisK IDIwMTEtMDktMjkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CiAKICAg ICAgICAgQWRkIG9wX2NhbGwvb3BfY29uc3RydWN0b3Igc3VwcG9ydCB0byBKU1ZBTFVFMzJfNjQg REZHIEpJVApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMu Y3BwCShyZXZpc2lvbiA5NjM5MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3Bl cmF0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzMiw4ICs1MzIsOCBAQCBSZWdpc3RlclNp emVkQm9vbGVhbiBERkdfT1BFUkFUSU9OIG9wZXJhCiAgICAgcmV0dXJuIEpTVmFsdWU6OnN0cmlj dEVxdWFsKGV4ZWMsIEpTVmFsdWU6OmRlY29kZShlbmNvZGVkT3AxKSwgSlNWYWx1ZTo6ZGVjb2Rl KGVuY29kZWRPcDIpKTsKIH0KIAotRW5jb2RlZEpTVmFsdWUgZ2V0SG9zdENhbGxSZXR1cm5WYWx1 ZSgpOwotRW5jb2RlZEpTVmFsdWUgZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZVdpdGhFeGVjU3RhdGUo RXhlY1N0YXRlKik7CitFbmNvZGVkSlNWYWx1ZSBERkdfT1BFUkFUSU9OIGdldEhvc3RDYWxsUmV0 dXJuVmFsdWUoKTsKK0VuY29kZWRKU1ZhbHVlIERGR19PUEVSQVRJT04gZ2V0SG9zdENhbGxSZXR1 cm5WYWx1ZVdpdGhFeGVjU3RhdGUoRXhlY1N0YXRlKik7CiAKICNpZiBDUFUoWDg2XzY0KQogYXNt ICgKQEAgLTU0OCwxMiArNTQ4LDE1IEBAIGFzbSAoCiAiLmdsb2JsICIgU1lNQk9MX1NUUklORyhn ZXRIb3N0Q2FsbFJldHVyblZhbHVlKSAiXG4iCiBTWU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0 dXJuVmFsdWUpICI6IiAiXG4iCiAgICAgIm1vdiAtNDAoJWVkaSksICVlZGlcbiIKLSAgICAicHVz aCAlZWRpXG4iCisgICAgIm1vdiAoJWVzcCksICVlY3hcbiIKKyAgICAibW92ICVlZGksICglZXNw KVxuIgorICAgICJsZWEgLTQoJWVzcCksICVlc3BcbiIKKyAgICAibW92ICVlY3gsICglZXNwKVxu IgogICAgICJqbXAgIiBTWU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFsdWVXaXRoRXhl Y1N0YXRlKSAiXG4iCiApOwogI2VuZGlmCiAKLUVuY29kZWRKU1ZhbHVlIGdldEhvc3RDYWxsUmV0 dXJuVmFsdWVXaXRoRXhlY1N0YXRlKEV4ZWNTdGF0ZSogZXhlYykKK0VuY29kZWRKU1ZhbHVlIERG R19PUEVSQVRJT04gZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZVdpdGhFeGVjU3RhdGUoRXhlY1N0YXRl KiBleGVjKQogewogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoZXhlYy0+Z2xvYmFsRGF0YSgp Lmhvc3RDYWxsUmV0dXJuVmFsdWUpOwogfQo=