<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>69130</bug_id>
          
          <creation_ts>2011-09-29 23:55:10 -0700</creation_ts>
          <short_desc>LayoutTests: Rewrite fast/dom/HTMLInputElement/input-size-attribute.html</short_desc>
          <delta_ts>2011-09-30 09:59:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Antaryami Pandia">xqb748</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>darin</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>475934</commentid>
    <comment_count>0</comment_count>
    <who name="Antaryami Pandia">xqb748</who>
    <bug_when>2011-09-29 23:55:10 -0700</bug_when>
    <thetext>Rewrite fast/dom/HTMLInputElement/input-size-attribute.html with new style. 

older style:-
input.setAttribute(&quot;size&quot;, &quot;-1&quot;);
shouldBe(&quot;input.size&quot;, &quot;20&quot;);

with new style:-
shouldBe(&quot;input.setAttribute(&apos;size&apos;, &apos;-1&apos;); input.size&quot;, &quot;20&quot;);</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>475938</commentid>
    <comment_count>1</comment_count>
      <attachid>109257</attachid>
    <who name="Antaryami Pandia">xqb748</who>
    <bug_when>2011-09-29 23:59:55 -0700</bug_when>
    <thetext>Created attachment 109257
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476114</commentid>
    <comment_count>2</comment_count>
      <attachid>109257</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2011-09-30 08:56:11 -0700</bug_when>
    <thetext>Comment on attachment 109257
Patch

In the future, please put some rationale in bug and/or ChangeLog. It&apos;s not always as easy to guess why a rewrite/refactoring is attempted as it is for this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476137</commentid>
    <comment_count>3</comment_count>
      <attachid>109257</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-09-30 09:59:17 -0700</bug_when>
    <thetext>Comment on attachment 109257
Patch

Clearing flags on attachment: 109257

Committed r96403: &lt;http://trac.webkit.org/changeset/96403&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476138</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-09-30 09:59:21 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>109257</attachid>
            <date>2011-09-29 23:59:55 -0700</date>
            <delta_ts>2011-09-30 09:59:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>69130.txt</filename>
            <type>text/plain</type>
            <size>0</size>
            <attacher name="Antaryami Pandia">xqb748</attacher>
            
              <data encoding="base64"></data>

          </attachment>
      

    </bug>

</bugzilla>