69129 2011-09-29 23:46:26 -0700 [Qt][WK2] Fix sputnik tests after migrating to refactored Qt5 2011-10-05 09:45:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 69104 1 ossy webkit-unassigned ossy yael oldest_to_newest 475929 0 ossy 2011-09-29 23:46:26 -0700 All of them fail with this fail: (missing space after PASS text) --- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A1.1_T1-expected.txt +++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A1.1_T1-actual.txt @@ -1,6 +1,6 @@ S7.2_A1.1_T1 "-PASS " "+PASS" TEST COMPLETE 475933 1 ossy 2011-09-29 23:53:14 -0700 There are 5010(all!) failing sputnik tests skipped in qt-wk2/Skipped now. (And there are 470 sputnik tests run and pass on the WK2 bot.) 475958 2 ossy 2011-09-30 00:19:10 -0700 Similar whitespace differences: - http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r96349%20%2812586%29/editing/undo/undo-deleteWord-pretty-diff.html - http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r96349%20%2812586%29/editing/undo/5658727-pretty-diff.html - ... 476016 3 ossy 2011-09-30 03:52:45 -0700 javascript code in sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A1.1_T1.html which print PASS message: ... function printTestPassed(msg) { testPrint('<span><span class="pass">PASS</span> ' + escapeHTML(msg) + '</span>'); } ... It seems Qt eat somehow the space after the PASS, before the escapeHTML(msg). 478438 4 ossy 2011-10-05 09:45:44 -0700 Sputnik tests work with newer Qt5, so I unskipped them: http://trac.webkit.org/changeset/96714