69126 2011-09-29 22:21:31 -0700 DFG operation results are not set correctly in JSVALUE32_64 DFG JIT 2011-09-30 19:13:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough webkit.review.bot oldest_to_newest 475901 0 yuqiang.xian 2011-09-29 22:21:31 -0700 The setupResults routine has the bug of reversing the source and destination. Also some other trivial (but stupid) bugs need to be fixed in JSVALUE32_64 DFG JIT. 475903 1 109250 yuqiang.xian 2011-09-29 22:24:30 -0700 Created attachment 109250 the patch 476503 2 109250 webkit.review.bot 2011-09-30 19:13:42 -0700 Comment on attachment 109250 the patch Clearing flags on attachment: 109250 Committed r96451: <http://trac.webkit.org/changeset/96451> 476504 3 webkit.review.bot 2011-09-30 19:13:47 -0700 All reviewed patches have been landed. Closing bug. 109250 2011-09-29 22:24:30 -0700 2011-09-30 19:13:42 -0700 the patch 69126.patch text/plain 4771 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTYzODkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDktMjkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgREZHIG9wZXJhdGlvbiByZXN1bHRzIGFyZSBub3Qgc2V0IGNvcnJlY3RseSBpbiBKU1ZB TFVFMzJfNjQgREZHIEpJVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjkxMjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgc2V0dXBSZXN1bHRzIHJvdXRpbmUgaGFzIHRoZSBidWcgb2YgcmV2ZXJzaW5n IHRoZSBzb3VyY2UgYW5kIGRlc3RpbmF0aW9uLiAKKyAgICAgICAgQWxzbyBzb21lIG90aGVyIHRy aXZpYWwgKGJ1dCBzdHVwaWQpIGJ1Z3MgbmVlZCB0byBiZSBmaXhlZCBpbiBKU1ZBTFVFMzJfNjQg REZHIEpJVC4KKworICAgICAgICAqIGRmZy9ERkdKSVRDb2RlR2VuZXJhdG9yLmg6CisgICAgICAg IChKU0M6OkRGRzo6c2V0dXBUd29TdHViQXJncyk6CisgICAgICAgIChKU0M6OkRGRzo6c2V0dXBS ZXN1bHRzKToKKyAgICAgICAgKiBkZmcvREZHSklUQ29kZUdlbmVyYXRvcjMyXzY0LmNwcDoKKyAg ICAgICAgKEpTQzo6REZHOjpKSVRDb2RlR2VuZXJhdG9yOjpmaWxsSlNWYWx1ZSk6CisgICAgICAg IChKU0M6OkRGRzo6SklUQ29kZUdlbmVyYXRvcjo6bm9uU3BlY3VsYXRpdmVWYWx1ZVRvSW50MzIp OgorICAgICAgICAoSlNDOjpERkc6OkpJVENvZGVHZW5lcmF0b3I6Om5vblNwZWN1bGF0aXZlTm9u UGVlcGhvbGVDb21wYXJlKToKKwogMjAxMS0wOS0yOSAgWXVxaWFuZyBYaWFuICA8eXVxaWFuZy54 aWFuQGludGVsLmNvbT4KIAogICAgICAgICBERkcgSklUIC0gcmVnaXN0ZXIgbm90IHVubG9ja2Vk IGFmdGVyIHVzYWdlIGluIEFyaXRoRGl2CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0pJVENvZGVHZW5lcmF0b3IzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2VuZXJhdG9yMzJfNjQuY3BwCShyZXZpc2lvbiA5NjM4 OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZUdlbmVyYXRvcjMyXzY0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUzLDcgKzI1Myw2IEBAIGJvb2wgSklUQ29kZUdlbmVy YXRvcjo6ZmlsbEpTVmFsdWUoTm9kZUkKICAgICAgICAgR1BSUmVnIGdwciA9IGluZm8uZ3ByKCk7 CiAgICAgICAgIC8vIElmIHRoZSByZWdpc3RlciBoYXMgYWxyZWFkeSBiZWVuIGxvY2tlZCB3ZSBu ZWVkIHRvIHRha2UgYSBjb3B5LgogICAgICAgICAvLyBJZiBub3QsIHdlJ2xsIHplcm8gZXh0ZW5k IGluIHBsYWNlLCBzbyBtYXJrIG9uIHRoZSBpbmZvIHRoYXQgdGhpcyBpcyBub3cgdHlwZSBEYXRh Rm9ybWF0SW50ZWdlciwgbm90IERhdGFGb3JtYXRKU0ludGVnZXIuCi0gICAgICAgIHRhZ0dQUiA9 IGFsbG9jYXRlKCk7CiAgICAgICAgIGlmIChtX2dwcnMuaXNMb2NrZWQoZ3ByKSkgewogICAgICAg ICAgICAgcGF5bG9hZEdQUiA9IGFsbG9jYXRlKCk7CiAgICAgICAgICAgICBtX2ppdC5tb3ZlKGdw ciwgcGF5bG9hZEdQUik7CkBAIC0yNjEsNiArMjYwLDcgQEAgYm9vbCBKSVRDb2RlR2VuZXJhdG9y OjpmaWxsSlNWYWx1ZShOb2RlSQogICAgICAgICAgICAgcGF5bG9hZEdQUiA9IGdwcjsKICAgICAg ICAgICAgIG1fZ3Bycy5sb2NrKGdwcik7CiAgICAgICAgIH0KKyAgICAgICAgdGFnR1BSID0gYWxs b2NhdGUoKTsKICAgICAgICAgbV9qaXQubW92ZShpbmZvLnJlZ2lzdGVyRm9ybWF0KCkgPT0gRGF0 YUZvcm1hdEludGVnZXIgPyBKSVRDb21waWxlcjo6VHJ1c3RlZEltbTMyKEpTVmFsdWU6OkludDMy VGFnKSA6IEpJVENvbXBpbGVyOjpUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6Q2VsbFRhZyksIHRhZ0dQ Uik7CiAgICAgICAgIG1fZ3Bycy5yZWxlYXNlKGdwcik7CiAgICAgICAgIG1fZ3Bycy5yZXRhaW4o dGFnR1BSLCB2aXJ0dWFsUmVnaXN0ZXIsIFNwaWxsT3JkZXJKUyk7CkBAIC0zODYsOSArMzg2LDEx IEBAIHZvaWQgSklUQ29kZUdlbmVyYXRvcjo6bm9uU3BlY3VsYXRpdmVWYWwKIAogICAgICAgICBz aWxlbnRTcGlsbEFsbFJlZ2lzdGVycyhncHIpOwogCi0gICAgICAgIG1faml0Lm1vdmVEb3VibGUo ZnByLCBGUFJJbmZvOjphcmd1bWVudEZQUjApOworICAgICAgICBtX2ppdC5zdWJQdHIoVHJ1c3Rl ZEltbTMyKHNpemVvZihkb3VibGUpKSwgSklUQ29tcGlsZXI6OnN0YWNrUG9pbnRlclJlZ2lzdGVy KTsKKyAgICAgICAgbV9qaXQuc3RvcmVEb3VibGUoZnByLCBKSVRDb21waWxlcjo6c3RhY2tQb2lu dGVyUmVnaXN0ZXIpOwogICAgICAgICBhcHBlbmRDYWxsV2l0aEV4Y2VwdGlvbkNoZWNrKHRvSW50 MzIpOwogICAgICAgICBtX2ppdC5tb3ZlKEdQUkluZm86OnJldHVyblZhbHVlR1BSLCBncHIpOwor ICAgICAgICBtX2ppdC5hZGRQdHIoVHJ1c3RlZEltbTMyKHNpemVvZihkb3VibGUpKSwgSklUQ29t cGlsZXI6OnN0YWNrUG9pbnRlclJlZ2lzdGVyKTsKIAogICAgICAgICBzaWxlbnRGaWxsQWxsUmVn aXN0ZXJzKGdwcik7CiAKQEAgLTEzNTMsNyArMTM1NSw3IEBAIHZvaWQgSklUQ29kZUdlbmVyYXRv cjo6bm9uU3BlY3VsYXRpdmVOb24KICAgICB9IGVsc2UgewogICAgICAgICBHUFJUZW1wb3Jhcnkg cmVzdWx0VGFnKHRoaXMsIGFyZzEpOwogICAgICAgICBHUFJUZW1wb3JhcnkgcmVzdWx0UGF5bG9h ZCh0aGlzLCBhcmcxLCBmYWxzZSk7Ci0gICAgICAgIEdQUlJlZyByZXN1bHRUYWdHUFIgPSByZXN1 bHRQYXlsb2FkLmdwcigpOworICAgICAgICBHUFJSZWcgcmVzdWx0VGFnR1BSID0gcmVzdWx0VGFn LmdwcigpOwogICAgICAgICBHUFJSZWcgcmVzdWx0UGF5bG9hZEdQUiA9IHJlc3VsdFBheWxvYWQu Z3ByKCk7CiAKICAgICAgICAgYXJnMS51c2UoKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHSklUQ29kZUdlbmVyYXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHSklUQ29kZUdlbmVyYXRvci5oCShyZXZpc2lvbiA5NjM4OSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZUdlbmVyYXRvci5oCSh3b3JraW5nIGNv cHkpCkBAIC05MTAsNiArOTEwLDcgQEAgcHJvdGVjdGVkOgogICAgICAgICBtX2dlbmVyYXRpb25J bmZvW25vZGUudmlydHVhbFJlZ2lzdGVyKCldLmluaXRDb25zdGFudChub2RlSW5kZXgsIG5vZGUu cmVmQ291bnQoKSk7CiAgICAgfQogCisjaWYgQ1BVKFg4Nl82NCkKICAgICAvLyBUaGVzZSBtZXRo b2RzIHVzZWQgdG8gc29ydCBhcmd1bWVudHMgaW50byB0aGUgY29ycmVjdCByZWdpc3RlcnMuCiAg ICAgdGVtcGxhdGU8R1BSUmVnIGRlc3RBLCBHUFJSZWcgZGVzdEI+CiAgICAgdm9pZCBzZXR1cFR3 b1N0dWJBcmdzKEdQUlJlZyBzcmNBLCBHUFJSZWcgc3JjQikKQEAgLTkzOSw3ICs5NDAsNiBAQCBw cm90ZWN0ZWQ6CiAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgbV9qaXQuc3dhcChkZXN0QSwg ZGVzdEIpOwogICAgIH0KLSNpZiBDUFUoWDg2XzY0KQogICAgIHRlbXBsYXRlPEZQUlJlZyBkZXN0 QSwgRlBSUmVnIGRlc3RCPgogICAgIHZvaWQgc2V0dXBUd29TdHViQXJncyhGUFJSZWcgc3JjQSwg RlBSUmVnIHNyY0IpCiAgICAgewpAQCAtMTE3MSw3ICsxMTcxLDIxIEBAIHByb3RlY3RlZDoKIAog ICAgIHZvaWQgc2V0dXBSZXN1bHRzKEdQUlJlZyB0YWcsIEdQUlJlZyBwYXlsb2FkKQogICAgIHsK LSAgICAgICAgc2V0dXBUd29TdHViQXJnczxHUFJJbmZvOjpyZXR1cm5WYWx1ZUdQUiwgR1BSSW5m bzo6cmV0dXJuVmFsdWVHUFIyPihwYXlsb2FkLCB0YWcpOworICAgICAgICBHUFJSZWcgc3JjQSA9 IEdQUkluZm86OnJldHVyblZhbHVlR1BSOworICAgICAgICBHUFJSZWcgc3JjQiA9IEdQUkluZm86 OnJldHVyblZhbHVlR1BSMjsKKyAgICAgICAgR1BSUmVnIGRlc3RBID0gcGF5bG9hZDsKKyAgICAg ICAgR1BSUmVnIGRlc3RCID0gdGFnOworCisgICAgICAgIGlmIChzcmNCICE9IGRlc3RBKSB7Cisg ICAgICAgICAgICAvLyBIYW5kbGUgdGhlIGVhc3kgY2FzZXMgLSB0d28gc2ltcGxlIG1vdmVzLgor ICAgICAgICAgICAgbV9qaXQubW92ZShzcmNBLCBkZXN0QSk7CisgICAgICAgICAgICBtX2ppdC5t b3ZlKHNyY0IsIGRlc3RCKTsKKyAgICAgICAgfSBlbHNlIGlmIChzcmNBICE9IGRlc3RCKSB7Cisg ICAgICAgICAgICAvLyBIYW5kbGUgdGhlIG5vbi1zd2FwIGNhc2UgLSBqdXN0IHB1dCBzcmNCIGlu IHBsYWNlIGZpcnN0LgorICAgICAgICAgICAgbV9qaXQubW92ZShzcmNCLCBkZXN0Qik7CisgICAg ICAgICAgICBtX2ppdC5tb3ZlKHNyY0EsIGRlc3RBKTsKKyAgICAgICAgfSBlbHNlCisgICAgICAg ICAgICBtX2ppdC5zd2FwKGRlc3RBLCBkZXN0Qik7CiAgICAgfQogCiAgICAgLy8gVGhlc2UgbWV0 aG9kcyBhZGQgY2FsbHMgdG8gQysrIGhlbHBlciBmdW5jdGlvbnMuCg==