69121 2011-09-29 19:24:11 -0700 run-api-tests fails on chromium-win bot 2011-09-29 22:05:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 wangxianzhu webkit-unassigned abarth rniwa tony webkit.review.bot oldest_to_newest 475830 0 wangxianzhu 2011-09-29 19:24:11 -0700 The log shows: Running build-api-tests 'Tools\Scripts\build-api-tests' is not recognized as an internal or external command, operable program or batch file. Compiling TestWebKitAPI failed! I guess we can't execute 'Tools\Scripts\build-api-tests' (with chdirWebKit()) directly from a perl script on Windows, but must execute with with 'perl ...'. 475840 1 109242 wangxianzhu 2011-09-29 19:39:54 -0700 Created attachment 109242 patch 475842 2 109244 wangxianzhu 2011-09-29 19:44:11 -0700 Created attachment 109244 patch (fixed a grammar error in help message) 475851 3 109244 abarth 2011-09-29 20:23:06 -0700 Comment on attachment 109244 patch (fixed a grammar error in help message) View in context: https://bugs.webkit.org/attachment.cgi?id=109244&action=review > Tools/Scripts/run-api-tests:68 > + --[no-]build Build (or do not build) unit tests prior to running (default: $buildDefault. No use for Chromium as buile-webkit builds everything) Not used for Chromium because build-webkit builds everything Actually, I'd skip this part of the change. > Tools/Scripts/run-api-tests:85 > -buildTestTool() if $build; > +buildTestTool() if $build && !isChromium(); I'd also skip this part. > Tools/Scripts/run-api-tests:285 > - my $buildProcess = open3($childIn, $childOut, $childErr, $pathToBuildTestTool, @args) or die "Failed to run " . $buildTestTool; > + my $buildProcess = open3($childIn, $childOut, $childErr, "perl", $pathToBuildTestTool, @args) or die "Failed to run " . $buildTestTool; This is the only part that's needed. Are you sure you don't need to put $pathToBuildTestTool into @args? I'm somewhat of a Perl novice. :) 475857 4 109244 wangxianzhu 2011-09-29 20:52:52 -0700 Comment on attachment 109244 patch (fixed a grammar error in help message) View in context: https://bugs.webkit.org/attachment.cgi?id=109244&action=review >> Tools/Scripts/run-api-tests:68 >> + --[no-]build Build (or do not build) unit tests prior to running (default: $buildDefault. No use for Chromium as buile-webkit builds everything) > > Not used for Chromium because build-webkit builds everything > > Actually, I'd skip this part of the change. Done. >> Tools/Scripts/run-api-tests:85 >> +buildTestTool() if $build && !isChromium(); > > I'd also skip this part. Done. >> Tools/Scripts/run-api-tests:285 >> + my $buildProcess = open3($childIn, $childOut, $childErr, "perl", $pathToBuildTestTool, @args) or die "Failed to run " . $buildTestTool; > > This is the only part that's needed. > > Are you sure you don't need to put $pathToBuildTestTool into @args? I'm somewhat of a Perl novice. :) I saw the same usage in old-run-webkit-tests (line 1444), and it works at least on Linux. I'm Perl novice too :) 475858 5 109249 wangxianzhu 2011-09-29 20:53:02 -0700 Created attachment 109249 patch v3 475862 6 109249 abarth 2011-09-29 21:01:21 -0700 Comment on attachment 109249 patch v3 Thanks! 475891 7 109249 webkit.review.bot 2011-09-29 22:04:58 -0700 Comment on attachment 109249 patch v3 Clearing flags on attachment: 109249 Committed r96388: <http://trac.webkit.org/changeset/96388> 475892 8 webkit.review.bot 2011-09-29 22:05:03 -0700 All reviewed patches have been landed. Closing bug. 109242 2011-09-29 19:39:54 -0700 2011-09-29 19:44:11 -0700 patch 69121 text/plain 2125 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk2MzgzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDktMjkgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBydW4tYXBpLXRlc3RzIGZhaWxzIG9uIGNocm9taXVtLXdpbiBib3QK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MTIxCisK KyAgICAgICAgT24gV2luZG93cyBydW5uaW5nIGEgcGVybCBzY3JpcHQgbmVlZHMgdGhlIGludGVy cHJldGVyLgorICAgICAgICBCeSB0aGUgd2F5LCBhdm9pZCB1bm5lY2Vzc2FyeSBidWlsZC1hcGkt dGVzdHMgZm9yIENocm9taXVtLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy9ydW4tYXBpLXRlc3RzOgorICAgICAgICAoYnVpbGRUZXN0 VG9vbCk6CisKIDIwMTEtMDktMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBBdHRlbXB0IHRvIG1ha2UgdGhpcyB0b29sIHdvcmsgb24gV2luZG93cy4KSW5kZXg6 IFRvb2xzL1NjcmlwdHMvcnVuLWFwaS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3J1bi1hcGktdGVzdHMJKHJldmlzaW9uIDk2MzgyKQorKysgVG9vbHMvU2NyaXB0cy9ydW4tYXBp LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC02NSw3ICs2NSw3IEBAIFVzYWdlOiAkcHJvZ3JhbU5h bWUgW29wdGlvbnNdCiAgIC0taGVscCAgICAgICAgICAgICAgICBTaG93IHRoaXMgaGVscCBtZXNz YWdlCiAgIC12fC0tdmVyYm9zZSAgICAgICAgICBWZXJib3NlIG91dHB1dAogICAtZHwtLWR1bXAt dGVzdHMgICAgICAgRHVtcCB0aGUgbmFtZXMgb2YgdGVzdGNhc2VzIHdpdGhvdXQgcnVubmluZyB0 aGVtCi0gIC0tW25vLV1idWlsZCAgICAgICAgICBCdWlsZCAob3IgZG8gbm90IGJ1aWxkKSB1bml0 IHRlc3RzIHByaW9yIHRvIHJ1bm5pbmcgKGRlZmF1bHQ6ICRidWlsZERlZmF1bHQpCisgIC0tW25v LV1idWlsZCAgICAgICAgICBCdWlsZCAob3IgZG8gbm90IGJ1aWxkKSB1bml0IHRlc3RzIHByaW9y IHRvIHJ1bm5pbmcgKGRlZmF1bHQ6ICRidWlsZERlZmF1bHQuIE5vIHVzZSBmb3IgQ2hyb21pdW0g YXMgaXQgYnVpbGQgZXZlcnl0aGluZyBpbiBidWlsZC13ZWJraXQpCiAgIC0tY2hyb21pdW0gICAg ICAgICAgICBSdW4gdGhlIENocm9taXVtIHBvcnQgb24gTWFjL1dpbi9MaW51eAogRU9GCiAKQEAg LTgyLDcgKzgyLDcgQEAgaWYgKCRzaG93SGVscCkgewogfQogCiBzZXRDb25maWd1cmF0aW9uKCk7 Ci1idWlsZFRlc3RUb29sKCkgaWYgJGJ1aWxkOworYnVpbGRUZXN0VG9vbCgpIGlmICRidWlsZCAm JiAhaXNDaHJvbWl1bSgpOwogc2V0UGF0aEZvclJ1bm5pbmdXZWJLaXRBcHAoXCVFTlYpOwogbXkg JXRlc3RzVG9SdW4gPSBwb3B1bGF0ZVRlc3RzKCk7CiAKQEAgLTI4Miw3ICsyODIsNyBAQCBzdWIg YnVpbGRUZXN0VG9vbCgpCiAKICAgICBteSBAYXJncyA9IGFyZ3VtZW50c0ZvckNvbmZpZ3VyYXRp b24oKTsKICAgICBteSAkcGF0aFRvQnVpbGRUZXN0VG9vbCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUo IlRvb2xzIiwgIlNjcmlwdHMiLCAkYnVpbGRUZXN0VG9vbCk7Ci0gICAgbXkgJGJ1aWxkUHJvY2Vz cyA9IG9wZW4zKCRjaGlsZEluLCAkY2hpbGRPdXQsICRjaGlsZEVyciwgJHBhdGhUb0J1aWxkVGVz dFRvb2wsIEBhcmdzKSBvciBkaWUgIkZhaWxlZCB0byBydW4gIiAuICRidWlsZFRlc3RUb29sOwor ICAgIG15ICRidWlsZFByb2Nlc3MgPSBvcGVuMygkY2hpbGRJbiwgJGNoaWxkT3V0LCAkY2hpbGRF cnIsICJwZXJsIiwgJHBhdGhUb0J1aWxkVGVzdFRvb2wsIEBhcmdzKSBvciBkaWUgIkZhaWxlZCB0 byBydW4gIiAuICRidWlsZFRlc3RUb29sOwogCiAgICAgY2xvc2UoJGNoaWxkSW4pOwogICAgIGNs b3NlKCRjaGlsZE91dCk7Cg== 109244 2011-09-29 19:44:11 -0700 2011-09-29 20:53:02 -0700 patch (fixed a grammar error in help message) 69121 text/plain 2120 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk2MzgzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDktMjkgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBydW4tYXBpLXRlc3RzIGZhaWxzIG9uIGNocm9taXVtLXdpbiBib3QK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MTIxCisK KyAgICAgICAgT24gV2luZG93cyBydW5uaW5nIGEgcGVybCBzY3JpcHQgbmVlZHMgdGhlIGludGVy cHJldGVyLgorICAgICAgICBCeSB0aGUgd2F5LCBhdm9pZCB1bm5lY2Vzc2FyeSBidWlsZC1hcGkt dGVzdHMgZm9yIENocm9taXVtLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy9ydW4tYXBpLXRlc3RzOgorICAgICAgICAoYnVpbGRUZXN0 VG9vbCk6CisKIDIwMTEtMDktMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBBdHRlbXB0IHRvIG1ha2UgdGhpcyB0b29sIHdvcmsgb24gV2luZG93cy4KSW5kZXg6 IFRvb2xzL1NjcmlwdHMvcnVuLWFwaS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3J1bi1hcGktdGVzdHMJKHJldmlzaW9uIDk2MzgyKQorKysgVG9vbHMvU2NyaXB0cy9ydW4tYXBp LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC02NSw3ICs2NSw3IEBAIFVzYWdlOiAkcHJvZ3JhbU5h bWUgW29wdGlvbnNdCiAgIC0taGVscCAgICAgICAgICAgICAgICBTaG93IHRoaXMgaGVscCBtZXNz YWdlCiAgIC12fC0tdmVyYm9zZSAgICAgICAgICBWZXJib3NlIG91dHB1dAogICAtZHwtLWR1bXAt dGVzdHMgICAgICAgRHVtcCB0aGUgbmFtZXMgb2YgdGVzdGNhc2VzIHdpdGhvdXQgcnVubmluZyB0 aGVtCi0gIC0tW25vLV1idWlsZCAgICAgICAgICBCdWlsZCAob3IgZG8gbm90IGJ1aWxkKSB1bml0 IHRlc3RzIHByaW9yIHRvIHJ1bm5pbmcgKGRlZmF1bHQ6ICRidWlsZERlZmF1bHQpCisgIC0tW25v LV1idWlsZCAgICAgICAgICBCdWlsZCAob3IgZG8gbm90IGJ1aWxkKSB1bml0IHRlc3RzIHByaW9y IHRvIHJ1bm5pbmcgKGRlZmF1bHQ6ICRidWlsZERlZmF1bHQuIE5vIHVzZSBmb3IgQ2hyb21pdW0g YXMgYnVpbGUtd2Via2l0IGJ1aWxkcyBldmVyeXRoaW5nKQogICAtLWNocm9taXVtICAgICAgICAg ICAgUnVuIHRoZSBDaHJvbWl1bSBwb3J0IG9uIE1hYy9XaW4vTGludXgKIEVPRgogCkBAIC04Miw3 ICs4Miw3IEBAIGlmICgkc2hvd0hlbHApIHsKIH0KIAogc2V0Q29uZmlndXJhdGlvbigpOwotYnVp bGRUZXN0VG9vbCgpIGlmICRidWlsZDsKK2J1aWxkVGVzdFRvb2woKSBpZiAkYnVpbGQgJiYgIWlz Q2hyb21pdW0oKTsKIHNldFBhdGhGb3JSdW5uaW5nV2ViS2l0QXBwKFwlRU5WKTsKIG15ICV0ZXN0 c1RvUnVuID0gcG9wdWxhdGVUZXN0cygpOwogCkBAIC0yODIsNyArMjgyLDcgQEAgc3ViIGJ1aWxk VGVzdFRvb2woKQogCiAgICAgbXkgQGFyZ3MgPSBhcmd1bWVudHNGb3JDb25maWd1cmF0aW9uKCk7 CiAgICAgbXkgJHBhdGhUb0J1aWxkVGVzdFRvb2wgPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCJUb29s cyIsICJTY3JpcHRzIiwgJGJ1aWxkVGVzdFRvb2wpOwotICAgIG15ICRidWlsZFByb2Nlc3MgPSBv cGVuMygkY2hpbGRJbiwgJGNoaWxkT3V0LCAkY2hpbGRFcnIsICRwYXRoVG9CdWlsZFRlc3RUb29s LCBAYXJncykgb3IgZGllICJGYWlsZWQgdG8gcnVuICIgLiAkYnVpbGRUZXN0VG9vbDsKKyAgICBt eSAkYnVpbGRQcm9jZXNzID0gb3BlbjMoJGNoaWxkSW4sICRjaGlsZE91dCwgJGNoaWxkRXJyLCAi cGVybCIsICRwYXRoVG9CdWlsZFRlc3RUb29sLCBAYXJncykgb3IgZGllICJGYWlsZWQgdG8gcnVu ICIgLiAkYnVpbGRUZXN0VG9vbDsKIAogICAgIGNsb3NlKCRjaGlsZEluKTsKICAgICBjbG9zZSgk Y2hpbGRPdXQpOwo= 109249 2011-09-29 20:53:02 -0700 2011-09-29 22:04:58 -0700 patch v3 69121a text/plain 1304 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk2MzgzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDktMjkgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBydW4tYXBpLXRlc3RzIGZhaWxzIG9uIGNocm9taXVtLXdpbiBib3QK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MTIxCisK KyAgICAgICAgT24gV2luZG93cyBydW5uaW5nIGEgcGVybCBzY3JpcHQgbmVlZHMgdGhlIGludGVy cHJldGVyLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy9ydW4tYXBpLXRlc3RzOgorICAgICAgICAoYnVpbGRUZXN0VG9vbCk6CisKIDIw MTEtMDktMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBBdHRl bXB0IHRvIG1ha2UgdGhpcyB0b29sIHdvcmsgb24gV2luZG93cy4KSW5kZXg6IFRvb2xzL1Njcmlw dHMvcnVuLWFwaS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1hcGktdGVz dHMJKHJldmlzaW9uIDk2MzgyKQorKysgVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzCSh3b3Jr aW5nIGNvcHkpCkBAIC0yODIsNyArMjgyLDcgQEAgc3ViIGJ1aWxkVGVzdFRvb2woKQogCiAgICAg bXkgQGFyZ3MgPSBhcmd1bWVudHNGb3JDb25maWd1cmF0aW9uKCk7CiAgICAgbXkgJHBhdGhUb0J1 aWxkVGVzdFRvb2wgPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCJUb29scyIsICJTY3JpcHRzIiwgJGJ1 aWxkVGVzdFRvb2wpOwotICAgIG15ICRidWlsZFByb2Nlc3MgPSBvcGVuMygkY2hpbGRJbiwgJGNo aWxkT3V0LCAkY2hpbGRFcnIsICRwYXRoVG9CdWlsZFRlc3RUb29sLCBAYXJncykgb3IgZGllICJG YWlsZWQgdG8gcnVuICIgLiAkYnVpbGRUZXN0VG9vbDsKKyAgICBteSAkYnVpbGRQcm9jZXNzID0g b3BlbjMoJGNoaWxkSW4sICRjaGlsZE91dCwgJGNoaWxkRXJyLCAicGVybCIsICRwYXRoVG9CdWls ZFRlc3RUb29sLCBAYXJncykgb3IgZGllICJGYWlsZWQgdG8gcnVuICIgLiAkYnVpbGRUZXN0VG9v bDsKIAogICAgIGNsb3NlKCRjaGlsZEluKTsKICAgICBjbG9zZSgkY2hpbGRPdXQpOwo=