69119 2011-09-29 18:54:41 -0700 Remove an unused member in RenderTable::ColumnStruct 2011-10-02 12:40:19 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix webkit.review.bot oldest_to_newest 475810 0 jchaffraix 2011-09-29 18:54:41 -0700 m_width was added several years ago and its users were changed so it is not needed. The code would love a refactoring to extract some of the logic out of RenderTable (the handling columns information would be one). However the code hasn't been seriously challenged so let's just reap the benefit from removing this member. 475815 1 109237 jchaffraix 2011-09-29 19:02:48 -0700 Created attachment 109237 Proposed removal 476163 2 109237 darin 2011-09-30 10:35:05 -0700 Comment on attachment 109237 Proposed removal Seems like ColumnStruct is not much of a struct any more. 476699 3 109237 jchaffraix 2011-10-02 11:37:35 -0700 Comment on attachment 109237 Proposed removal > Seems like ColumnStruct is not much of a struct any more. Yep, it will need to be removed or the position folded into the structure. No sure which one makes more sense for now. 476705 4 109237 webkit.review.bot 2011-10-02 12:40:16 -0700 Comment on attachment 109237 Proposed removal Clearing flags on attachment: 109237 Committed r96476: <http://trac.webkit.org/changeset/96476> 476706 5 webkit.review.bot 2011-10-02 12:40:19 -0700 All reviewed patches have been landed. Closing bug. 109237 2011-09-29 19:02:48 -0700 2011-10-02 12:40:16 -0700 Proposed removal bug-69119-20110929190247.patch text/plain 1785 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTYyNDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NzQxZjNjYWVkMWI3ZTg5 MzE5YmFhNzg3OGZkNmI3NmQ4ZDg5YTVhLi43MWI4NWM3NjVlZGEwMzRjMDE4Mjk0OWE4YjQ3NGQ5 ZGZhZWE1NDRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDktMjkgIEp1bGll biBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIGFu IHVudXNlZCBtZW1iZXIgaW4gUmVuZGVyVGFibGU6OkNvbHVtblN0cnVjdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkxMTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyB0ZXN0IGFzIHRoZXJlIHNob3Vs ZCBiZSBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgVGhlIG1lbWJlciB3YXMgYWRk ZWQgc2V2ZXJhbCB5ZWFycyBhZ28gYW5kIGl0cyB1c2VycyB3ZXJlIHJlbW92ZWQgb3IgY2hhbmdl ZC4gVGhlIGNvZGUgd291bGQKKyAgICAgICAgbmVlZCBhIHJlZmFjdG9yaW5nIGJ1dCB0aGlzIHdv dWxkIGJlIHRyaWNreSB0byBnZXQgcmlnaHQuIFRoaXMgY2hhbmdlIGp1c3QgcmVtb3ZlcyB0aGUg bWVtYmVyCisgICAgICAgIHRvIHJlYXAgdGhlIHNob3J0LXRlcm0gYmVuZWZpdHMuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRh YmxlOjpDb2x1bW5TdHJ1Y3Q6OkNvbHVtblN0cnVjdCk6IFJlbW92ZSBhbnl0aGluZyBhc3NvY2lh dGVkIHdpdGggbV93aWR0aC4KKwogMjAxMS0wOS0yOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgogCiAgICAgICAgIENTUCBkb2Vzbid0IHdvcmsgZm9yIGEgd2lkZSB2YXJpZXR5IG9m IGNhc2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUu aCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5oCmluZGV4IGYxOGI4NDBm YmNlM2Q3YTVjZTJiMDY4MDJkY2IzYmU0MGU3NTFlZWUuLjNmN2Q1OTJlYzdkMDg1OWFiN2QyZjhi ZjU3NDAyNzBmZTQwODlkNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUYWJsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5o CkBAIC0xMjYsMTggKzEyNiwxMiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGFkZENoaWxk KFJlbmRlck9iamVjdCogY2hpbGQsIFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQgPSAwKTsKIAog ICAgIHN0cnVjdCBDb2x1bW5TdHJ1Y3QgewotICAgICAgICBlbnVtIHsKLSAgICAgICAgICAgIFdp ZHRoVW5kZWZpbmVkID0gMHhmZmZmCi0gICAgICAgIH07Ci0KICAgICAgICAgQ29sdW1uU3RydWN0 KCkKICAgICAgICAgICAgIDogc3BhbigxKQotICAgICAgICAgICAgLCB3aWR0aChXaWR0aFVuZGVm aW5lZCkKICAgICAgICAgewogICAgICAgICB9CiAKICAgICAgICAgdW5zaWduZWQgc3BhbjsKLSAg ICAgICAgdW5zaWduZWQgd2lkdGg7IC8vIHRoZSBjYWxjdWxhdGVkIHBvc2l0aW9uIG9mIHRoZSBj b2x1bW4KICAgICB9OwogCiAgICAgVmVjdG9yPENvbHVtblN0cnVjdD4mIGNvbHVtbnMoKSB7IHJl dHVybiBtX2NvbHVtbnM7IH0K