69095 2011-09-29 10:43:48 -0700 REGRESSION(r94274): cloned text input loses value 2011-10-03 16:01:48 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED http://www.ptable.com/ HasReduction, Regression P1 Normal --- 1 michael rniwa ap darin dglazkov morrita rniwa rolandsteiner tkent oldest_to_newest 475517 0 michael 2011-09-29 10:43:48 -0700 Nightly Webkit and Chrome builds introduce a regression causing the temperature input box (left of Helium) on ptable.com to reset to 0. Site does some elaborate cloneNode operations to animate the slider and input box. Bug does not occur in Safari 5.1 or Chrome 14. Initial load of the site should show "273" in input box rather than 0. 475740 1 michael 2011-09-29 16:20:48 -0700 Regression occurred between r94213 and r94287. 475889 2 ap 2011-09-29 22:03:25 -0700 Thanks for finding the regression range! Not sure what change is the cause, maybe <http://trac.webkit.org/changeset/94252>? 476162 3 ap 2011-09-30 10:34:27 -0700 Further reduced to r94273-94287, so it's not r94252. There aren't many suspicious changes in this range, the most related being <http://trac.webkit.org/changeset/94274>. 476433 4 109379 rniwa 2011-09-30 17:22:37 -0700 Created attachment 109379 reduction Here's a reduction. The third text field has the value 999 on Chrome 14 but has 0 on ToT WebKit. 476442 5 109381 rniwa 2011-09-30 17:28:20 -0700 Created attachment 109381 somewhat refined reduction In this version, you can see that the last input element has the value "999" but what's shown on the scree is "0". 476443 6 rniwa 2011-09-30 17:28:54 -0700 Looking at the bug and the regression range, this is definitely a regression from r94274. 476495 7 109390 rniwa 2011-09-30 18:43:14 -0700 Created attachment 109390 DRT test Here's a complete reduction. 476512 8 rniwa 2011-09-30 19:34:53 -0700 The problem is that we're not copying the value stored separately from the value content attribute (default value) in cloneNode(true). 477264 9 rniwa 2011-10-03 14:58:17 -0700 (In reply to comment #8) > The problem is that we're not copying the value stored separately from the value content attribute (default value) in cloneNode(true). Well, this isn't true. m_valueIfDirty is properly copied in copyNonAttributeProperties. The problem is that this function is not updating inner element text. Will upload a patch in a minute. 477282 10 109539 rniwa 2011-10-03 15:20:55 -0700 Created attachment 109539 fixes the bug 477287 11 rniwa 2011-10-03 15:28:51 -0700 Wow, that was quick! Thanks for the review, Darin. 477310 12 rniwa 2011-10-03 16:01:48 -0700 Committed r96552: <http://trac.webkit.org/changeset/96552> 109379 2011-09-30 17:22:37 -0700 2011-09-30 17:28:20 -0700 reduction bug69095.html text/html 518 rniwa PCFET0NUWVBFIEhUTUw+CjxodG1sPgo8aGVhZD4KPC9oZWFkPgo8Ym9keT4KPGlucHV0IGlkPSJT bGlkZXJEaXNwbGF5IiBjbGFzcz0iU2xpZGVyRGlzcGxheSIgdHlwZT0ibnVtYmVyIiB2YWx1ZT0i MCI+CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KCmZ1bmN0aW9uIHJ1bihhLCBiKSB7 CiAgICB2YXIgbiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJTbGlkZXJEaXNwbGF5Iik7CiAg ICB2YXIgZCA9IG4ucGFyZW50Tm9kZS5jbG9uZU5vZGUodHJ1ZSk7CgogICAgbi5wYXJlbnROb2Rl LnBhcmVudE5vZGUuYXBwZW5kQ2hpbGQoZCk7CiAgICBuID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoIlNsaWRlckRpc3BsYXkiKTsKCiAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeyBuLnZhbHVl ID0gOTk5OyB9LCAwKTsKfQoKcnVuKGZhbHNlLCAiYm90dG9tIik7CnNldFRpbWVvdXQoZnVuY3Rp b24oKSB7cnVuKHRydWUsICJib3R0b20iKTt9LCAyMDApOwoKPC9zY3JpcHQ+CjwvYm9keT4KPC9o dG1sPgo= 109381 2011-09-30 17:28:20 -0700 2011-09-30 18:43:14 -0700 somewhat refined reduction bug69095.html text/html 830 rniwa PCFET0NUWVBFIEhUTUw+CjxodG1sPgo8Ym9keT4KPHByZSBpZD0ibG9nIj48L3ByZT4KPGlucHV0 IGlkPSJTbGlkZXJEaXNwbGF5IiBjbGFzcz0iU2xpZGVyRGlzcGxheSIgdHlwZT0ibnVtYmVyIiB2 YWx1ZT0iMCI+CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KCmZ1bmN0aW9uIHJ1bihh LCBiKSB7CiAgICB2YXIgbiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJTbGlkZXJEaXNwbGF5 Iik7CiAgICB2YXIgZCA9IG4ucGFyZW50Tm9kZS5jbG9uZU5vZGUodHJ1ZSk7CgogICAgbi5wYXJl bnROb2RlLnBhcmVudE5vZGUuYXBwZW5kQ2hpbGQoZCk7CiAgICBuID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoIlNsaWRlckRpc3BsYXkiKTsKCiAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewog ICAgICAgIG4udmFsdWUgPSA5OTk7CiAgICAgICAgdmFyIGlucHV0cyA9IGRvY3VtZW50LmdldEVs ZW1lbnRzQnlUYWdOYW1lKCdpbnB1dCcpOwogICAgICAgIGlmIChpbnB1dHMubGVuZ3RoIDwgMykK ICAgICAgICAgICAgcmV0dXJuOwogICAgICAgIHZhciBsb2cgPSAnJzsKICAgICAgICBmb3IgKHZh ciBpID0gMDsgaSA8IGlucHV0cy5sZW5ndGg7IGkrKykgewogICAgICAgICAgICBsb2cgKz0gaW5w dXRzW2ldLnZhbHVlICsgJywnOwogICAgICAgIH0KICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnbG9nJykudGV4dENvbnRlbnQgPSBsb2c7CiAgICB9LCAwKTsKfQoKcnVuKGZhbHNlLCAi Ym90dG9tIik7CnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7cnVuKHRydWUsICJib3R0b20iKTt9LCAy MDApOwoKPC9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPgo= 109390 2011-09-30 18:43:14 -0700 2011-09-30 18:43:14 -0700 DRT test bug69095.html text/html 558 rniwa PCFET0NUWVBFIEhUTUw+CjxodG1sPgo8Ym9keT4KPHByZSBpZD0ibG9nIj48L3ByZT4KPGRpdj48 aW5wdXQgaWQ9InRlc3QiIHRpdGxlPSIxIiB0eXBlPSJ0ZXh0IiB2YWx1ZT0iRkFJTCI+PC9kaXY+ CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KCnZhciB0ZXN0ID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3Rlc3QnKTsKdGVzdC52YWx1ZSA9ICdQQVNTJzsKCnZhciB4ID0gdGVzdC5v ZmZzZXRMZWZ0OyAvLyBGb3JjZSBsYXlvdXQKCnZhciBjbG9uZSA9IHRlc3QuY2xvbmVOb2RlKHRy dWUpOwp0ZXN0LnBhcmVudE5vZGUuYXBwZW5kQ2hpbGQoY2xvbmUpOwp0ZXN0LnZhbHVlID0gJyc7 CgpjbG9uZS5mb2N1cygpOwpjbG9uZS5zZWxlY3Rpb25TdGFydCA9IGNsb25lLnNlbGVjdGlvbkVu ZCA9IGNsb25lLnZhbHVlLmxlbmd0aDsKZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0luc2VydFRleHQn LCBmYWxzZSwgJ0VEJyk7Cgpkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbG9nJykudGV4dENvbnRl bnQgPSBjbG9uZS52YWx1ZTsKCjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 109539 2011-10-03 15:20:55 -0700 2011-10-03 15:22:06 -0700 fixes the bug bug-69095-20111003152054.patch text/plain 3847 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2NTQ3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMDMgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyOTQyNzQpOiBj bG9uZWQgdGV4dCBpbnB1dCBsb3NlcyB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkwOTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdhcyBjYXVzZWQgYnkgY29weU5vbkF0dHJpYnV0 ZVByb3BlcnRpZXMgbm90IHVwZGF0aW5nIGlubmVyIGVsZW1lbnQgdGV4dCBhZnRlciBjb3B5aW5n CisgICAgICAgIG1fdmFsdWVJZkRpcnR5LiBGaXhlZCB0aGUgYnVnIGJ5IGNhbGxpbmcgdXBkYXRl SW5uZXJUZXh0VmFsdWUuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9jbG9uZS1pbnB1dC13 aXRoLWRpcnR5LXZhbHVlLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Ojpjb3B5Tm9uQXR0cmlidXRl UHJvcGVydGllcyk6CisKIDIwMTEtMDktMjIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFJlbmFtZSBtYW55IG9idmlvdXNseS1jb3JyZWN0IGNhbGwgc2l0ZXMgaW4g V2ViQ29yZSB1c2luZyByZWxlYXNlUmVmIHRvIHVzZSBpdCBieSBpdHMgbmV3IG5hbWUgbGVha1Jl ZgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCShyZXZpc2lv biA5NjUxNikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEwMjcsNiArMTAyNyw5IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6 Y29weU5vbkF0dHJpYnV0ZVAKICAgICBtX2lzSW5kZXRlcm1pbmF0ZSA9IHNvdXJjZUVsZW1lbnQt Pm1faXNJbmRldGVybWluYXRlOwogCiAgICAgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OmNv cHlOb25BdHRyaWJ1dGVQcm9wZXJ0aWVzKHNvdXJjZSk7CisKKyAgICBzZXRGb3JtQ29udHJvbFZh bHVlTWF0Y2hlc1JlbmRlcmVyKGZhbHNlKTsKKyAgICB1cGRhdGVJbm5lclRleHRWYWx1ZSgpOwog fQogCiBTdHJpbmcgSFRNTElucHV0RWxlbWVudDo6dmFsdWUoKSBjb25zdApJbmRleDogTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2 aXNpb24gOTY1NDcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0xMC0wMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KKworICAgICAgICBSRUdSRVNTSU9OKHI5NDI3NCk6IGNsb25lZCB0ZXh0IGlucHV0IGxvc2Vz IHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 OTA5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZGVkIGEgcmVncmVzc2lvbiB0ZXN0IHRoYXQgY2xvbmVzIGFuIGlucHV0IGVsZW1lbnQgd2l0aCBh IGRpcnR5IHZhbHVlLgorICAgICAgICBUaGUgY2xvbmVkIGlucHV0IGVsZW1lbnQgc2hvdWxkIGhh dmUgdGhlIGVkaXRlZCB2YWx1ZS4KKworICAgICAgICAqIGZhc3QvZm9ybXMvY2xvbmUtaW5wdXQt d2l0aC1kaXJ0eS12YWx1ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9y bXMvY2xvbmUtaW5wdXQtd2l0aC1kaXJ0eS12YWx1ZS5odG1sOiBBZGRlZC4KKwogMjAxMS0xMC0w MyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVwZGF0ZSByZXN1 bHRzIHRvIGFjY291bnQgZm9yIFdpbmRvd3MgVmlzdGEuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL2Nsb25lLWlucHV0LXdpdGgtZGlydHktdmFsdWUtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvY2xvbmUtaW5wdXQtd2l0aC1kaXJ0eS12YWx1 ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2Ns b25lLWlucHV0LXdpdGgtZGlydHktdmFsdWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDQgQEAKK1RoaXMgdGVzdHMgY2xvbmluZyBhbiBpbnB1dCBlbGVtZW50IHdpdGggYW4g ZWRpdGVkIHZhbHVlLiBUaGUgY2xvbmVkIGlucHV0IGVsZW1lbnQgc2hvdWxkIHJldGFpbiB0aGUg ZWRpdGVkIHZhbHVlIGFuZCB5b3Ugc2hvdWxkIHNlZSBQQVNTRUQgYmxvdy4KKworUEFTU0VECisK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvY2xvbmUtaW5wdXQtd2l0aC1kaXJ0eS12YWx1 ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvY2xvbmUtaW5wdXQt d2l0aC1kaXJ0eS12YWx1ZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9jbG9uZS1pbnB1dC13aXRoLWRpcnR5LXZhbHVlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMzAgQEAKKzwhRE9DVFlQRSBIVE1MPgorPGh0bWw+Cis8Ym9keT4KKzxwPlRoaXMgdGVz dHMgY2xvbmluZyBhbiBpbnB1dCBlbGVtZW50IHdpdGggYW4gZWRpdGVkIHZhbHVlLgorVGhlIGNs b25lZCBpbnB1dCBlbGVtZW50IHNob3VsZCByZXRhaW4gdGhlIGVkaXRlZCB2YWx1ZSBhbmQgeW91 IHNob3VsZCBzZWUgUEFTU0VEIGJsb3cuPC9wPgorPHByZSBpZD0ibG9nIj48L3ByZT4KKzxkaXY+ PGlucHV0IGlkPSJ0ZXN0IiB0aXRsZT0iMSIgdHlwZT0idGV4dCIgdmFsdWU9IkZBSUwiPjwvZGl2 PgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCitpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKwor dmFyIHRlc3QgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpOwordGVzdC52YWx1ZSA9 ICdQQVNTJzsKKwordmFyIHggPSB0ZXN0Lm9mZnNldExlZnQ7IC8vIEZvcmNlIGxheW91dAorCit2 YXIgY2xvbmUgPSB0ZXN0LmNsb25lTm9kZSh0cnVlKTsKK3Rlc3QucGFyZW50Tm9kZS5hcHBlbmRD aGlsZChjbG9uZSk7Cit0ZXN0LnZhbHVlID0gJyc7CisKK2Nsb25lLmZvY3VzKCk7CitjbG9uZS5z ZWxlY3Rpb25TdGFydCA9IGNsb25lLnNlbGVjdGlvbkVuZCA9IGNsb25lLnZhbHVlLmxlbmd0aDsK K2RvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRUZXh0JywgZmFsc2UsICdFRCcpOworCitkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnbG9nJykudGV4dENvbnRlbnQgPSBjbG9uZS52YWx1ZTsKKwor PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==