69094 2011-09-29 10:37:57 -0700 Shrink HTMLAnchorElement on 32-bit. 2011-09-29 14:01:26 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling darin webkit.review.bot oldest_to_newest 475513 0 kling 2011-09-29 10:37:57 -0700 SSIA. 475514 1 109174 kling 2011-09-29 10:40:21 -0700 Created attachment 109174 Proposed patch 475640 2 109174 webkit.review.bot 2011-09-29 13:29:23 -0700 Comment on attachment 109174 Proposed patch Clearing flags on attachment: 109174 Committed r96352: <http://trac.webkit.org/changeset/96352> 475641 3 webkit.review.bot 2011-09-29 13:29:27 -0700 All reviewed patches have been landed. Closing bug. 475650 4 darin 2011-09-29 13:37:44 -0700 Seems a little strange to use 31 bits for link relations since there are 18 of them total, not 31! 475655 5 kling 2011-09-29 13:43:18 -0700 (In reply to comment #4) > Seems a little strange to use 31 bits for link relations since there are 18 of them total, not 31! I thought I was being a little future proof, since we had 31 bits available anyway. I don't mind changing it to 18 bits wide if you prefer. 475658 6 darin 2011-09-29 13:45:58 -0700 If I was doing this I would add a comment to the end of the enum mentioning the bitfield below and have the bitfield be exactly the right size. 475664 7 109199 kling 2011-09-29 13:57:16 -0700 Created attachment 109199 Proposed follow-up patch 109174 2011-09-29 10:40:21 -0700 2011-09-29 13:29:23 -0700 Proposed patch bug-69094.diff text/plain 1235 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NzI3MzBjLi4xNjliMzNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDktMjkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFNocmluayBIVE1MQW5jaG9yRWxlbWVudCBvbiAzMi1iaXQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTA5NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9IVE1MQW5jaG9yRWxlbWVudC5o OiBQYWNrIG1lbWJlcnMgaW50byBhIGJpdGZpZWxkLgorCiAyMDExLTA5LTI5ICBJbHlhIFRpa2hv bm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBV SSBwZXJmb3JtYW5jZSB0ZXN0IGZvciBuZXR3b3JrIHBhbmVsIGlzIGluY29ycmVjdC4gVGhlIHRp bWUgaXMgaW5jbHVkaW5nIGEgdGltZW91dCBiZXR3ZWVuIHNjaGVkdWxlZCByZWZyZXNoIGFuZCBh Y3R1YWwgcmVmcmVzaC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hv ckVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuaAppbmRl eCA5NDdmNzQ2Li45Mjc3ZWQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxB bmNob3JFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQW5jaG9yRWxlbWVu dC5oCkBAIC0xMjYsOCArMTI2LDggQEAgcHJpdmF0ZToKICAgICBib29sIHRyZWF0TGlua0FzTGl2 ZUZvckV2ZW50VHlwZShFdmVudFR5cGUpIGNvbnN0OwogCiAgICAgUmVmUHRyPEVsZW1lbnQ+IG1f cm9vdEVkaXRhYmxlRWxlbWVudEZvclNlbGVjdGlvbk9uTW91c2VEb3duOwotICAgIGJvb2wgbV93 YXNTaGlmdEtleURvd25Pbk1vdXNlRG93bjsKLSAgICB1aW50MzJfdCBtX2xpbmtSZWxhdGlvbnM7 CisgICAgYm9vbCBtX3dhc1NoaWZ0S2V5RG93bk9uTW91c2VEb3duIDogMTsKKyAgICB1aW50MzJf dCBtX2xpbmtSZWxhdGlvbnMgOiAzMTsKIH07CiAKIC8vIEZ1bmN0aW9ucyBzaGFyZWQgd2l0aCB0 aGUgb3RoZXIgYW5jaG9yIGVsZW1lbnRzIChpLmUuLCBTVkcpLgo= 109199 2011-09-29 13:57:16 -0700 2011-09-29 14:01:26 -0700 Proposed follow-up patch bug-69094-follow.diff text/plain 1444 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MmM2Y2U4Li5iNjdlMDZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDktMjkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFNocmluayBIVE1MQW5jaG9yRWxlbWVudCBvbiAzMi1iaXQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTA5NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNocmluayBtX2xpbmtSZWxhdGlvbnMgZG93 biB0byAxOCBiaXRzIGFzIHN1Z2dlc3RlZCBieSBEYXJpbi4KKyAgICAgICAgQWRkZWQgYSBjb21t ZW50IGFib3V0IHRoZSBlbnVtIGZpdHRpbmcgaW50byB0aGUgYml0ZmllbGQuCisKKyAgICAgICAg KiBodG1sL0hUTUxBbmNob3JFbGVtZW50Lmg6CisKIDIwMTEtMDktMjkgIFJ5b3N1a2UgTml3YSAg PHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIGRpcmVjdCByZWFkcyB0byBtX2Zp cnN0Tm9kZUluc2VydGVkIGFuZCBtX2xhc3RMZWFmSW5zZXJ0ZWQgaW4gUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1l bnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuaAppbmRleCA5Mjc3 ZWQzLi44ZDAyZTE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBbmNob3JF bGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQW5jaG9yRWxlbWVudC5oCkBA IC01MCw2ICs1MCw3IEBAIGVudW0gewogLy8gICAgIFJlbGF0aW9uVGFnICAgICAgICAgPSAweDAw MDEwMDAwLAogLy8gICAgIFJlbGF0aW9uVXAgICAgICAgICAgPSAweDAwMDIwMDAwLAogfTsKKy8v IFRoZSBtX2xpbmtSZWxhdGlvbnMgYml0ZmllbGQgYmVsb3cgaXMgc2l6ZWQgdG8gZml0IHRoZXNl IHZhbHVlcyBleGFjdGx5LgogCiBjbGFzcyBIVE1MQW5jaG9yRWxlbWVudCA6IHB1YmxpYyBIVE1M RWxlbWVudCB7CiBwdWJsaWM6CkBAIC0xMjcsNyArMTI4LDcgQEAgcHJpdmF0ZToKIAogICAgIFJl ZlB0cjxFbGVtZW50PiBtX3Jvb3RFZGl0YWJsZUVsZW1lbnRGb3JTZWxlY3Rpb25Pbk1vdXNlRG93 bjsKICAgICBib29sIG1fd2FzU2hpZnRLZXlEb3duT25Nb3VzZURvd24gOiAxOwotICAgIHVpbnQz Ml90IG1fbGlua1JlbGF0aW9ucyA6IDMxOworICAgIHVpbnQzMl90IG1fbGlua1JlbGF0aW9ucyA6 IDE4OwogfTsKIAogLy8gRnVuY3Rpb25zIHNoYXJlZCB3aXRoIHRoZSBvdGhlciBhbmNob3IgZWxl bWVudHMgKGkuZS4sIFNWRykuCg==