69081 2011-09-29 04:10:52 -0700 Web Inspector: speed-up Network panel. Change _staleResources type from array to object. 2011-09-29 04:58:35 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 475360 0 loislo 2011-09-29 04:10:52 -0700 there is a test with 30 requests. For the each stage of loading the resource we have an entry in _staleResources array. There is at least 4 stages per request. _refresh function is creating/updating the resource row for each such entry. this array can be replaced with a hash map just because the resource associated with the entry is the same for all such entries with the same request id. 475363 1 109147 loislo 2011-09-29 04:20:33 -0700 Created attachment 109147 Patch 475376 2 loislo 2011-09-29 04:58:35 -0700 Committed r96321: <http://trac.webkit.org/changeset/96321> 109147 2011-09-29 04:20:33 -0700 2011-09-29 04:50:35 -0700 Patch bug-69081-20110929152030.patch text/plain 4873 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogOTYzMTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYWZlMjE5NWQ2ZGJkYWI0 ZGQwYWFkMzM3NWQ5ZThkMDk0ZmY1ZjZlLi44YTQ1MWY0YmNhMDk2NmZjMjUwMTA3YWU0YTZmY2Zm NTlhZmRjZDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDktMjkgIElseWEg VGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHNwZWVkLXVwIE5ldHdvcmsgcGFuZWwuIENoYW5nZSBfc3RhbGVSZXNvdXJjZXMgdHlwZSBm cm9tIGFycmF5IHRvIG9iamVjdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY5MDgxCisKKyAgICAgICAgVGhlcmUgaXMgYSB0ZXN0IHdpdGggMzAgcmVx dWVzdHMuCisgICAgICAgIEZvciB0aGUgZWFjaCBzdGFnZSBvZiBsb2FkaW5nIGEgcmVzb3VyY2Ug d2UgaGF2ZSBhbiBlbnRyeSBpbiBfc3RhbGVSZXNvdXJjZXMgYXJyYXkuIFRoZXJlIGFyZSBhdCBs ZWFzdCA0IHN0YWdlcyBwZXIgcmVxdWVzdC4KKyAgICAgICAgTmV0d29ya0xvZ1ZpZXcuX3JlZnJl c2ggZnVuY3Rpb24gaXMgY3JlYXRpbmcvdXBkYXRpbmcgdGhlIHJlc291cmNlIHJvdyBmb3IgdGhl IGVhY2ggc3VjaCBlbnRyeS4KKyAgICAgICAgVGhpcyBhcnJheSBjYW4gYmUgcmVwbGFjZWQgd2l0 aCBhIGhhc2ggbWFwIGp1c3QgYmVjYXVzZSB0aGUgcmVzb3VyY2UgYXNzb2NpYXRlZCB3aXRoIHRo ZSBlbnRyeSBpcyB0aGUgc2FtZSBmb3IgYWxsIHRoZSBlbnRyaWVzIHdpdGggdGhlIHNhbWUgcmVx dWVzdCBpZC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUZXN0OiBpbnNwZWN0b3IvcGVyZm9ybWFuY2UvcmVzb3VyY2VzL25ldHdvcmstYXBwZW5kLTMw LXJlcXVlc3RzLmh0bWwKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1Bh bmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dWaWV3KToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5OZXR3b3JrTG9nVmlldy5wcm90b3R5cGUuX2ludmFsaWRhdGVBbGxJdGVt cyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29ya0xvZ1ZpZXcucHJvdG90eXBlLnJlZnJl c2gpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dWaWV3LnByb3RvdHlwZS5fcmVz ZXQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dWaWV3LnByb3RvdHlwZS5fcmVm cmVzaFJlc291cmNlKToKKwogMjAxMS0wOS0yOCAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IG5ldHdvcmsgbG9nIHZpZXcgcmVm cmVzaCBvcHRpbWl6YXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL05ldHdvcmtQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvTmV0d29ya1BhbmVsLmpzCmluZGV4IDU1NTQ2MjA5NWQ3MDY2NWM5ZTY3MGMxYjdmZTdh MTYyNDQ2Yjk0YTkuLjUzMWNjNDg4OTM0NDgzNmY0MmZiMDk2NGFkYmM1N2UwYmY3Y2NmMDIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVs LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVs LmpzCkBAIC00Miw3ICs0Miw3IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrTG9nVmlldyA9IGZ1bmN0 aW9uKHBhcmVudEVsZW1lbnQpCiAgICAgdGhpcy5fcmVzb3VyY2VzID0gW107CiAgICAgdGhpcy5f cmVzb3VyY2VzQnlJZCA9IHt9OwogICAgIHRoaXMuX3Jlc291cmNlc0J5VVJMID0ge307Ci0gICAg dGhpcy5fc3RhbGVSZXNvdXJjZXMgPSBbXTsKKyAgICB0aGlzLl9zdGFsZVJlc291cmNlcyA9IHt9 OwogICAgIHRoaXMuX3Jlc291cmNlR3JpZE5vZGVzID0ge307CiAgICAgdGhpcy5fbGFzdFJlc291 cmNlR3JpZE5vZGVJZCA9IDA7CiAgICAgdGhpcy5fbWFpblJlc291cmNlTG9hZFRpbWUgPSAtMTsK QEAgLTU3OCw3ICs1NzgsMTAgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dWaWV3LnByb3RvdHlw ZSA9IHsKIAogICAgIF9pbnZhbGlkYXRlQWxsSXRlbXM6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAg ICAgIHRoaXMuX3N0YWxlUmVzb3VyY2VzID0gdGhpcy5fcmVzb3VyY2VzLnNsaWNlKCk7CisgICAg ICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5fcmVzb3VyY2VzLmxlbmd0aDsgKytpKSB7Cisg ICAgICAgICAgICB2YXIgcmVzb3VyY2UgPSB0aGlzLl9yZXNvdXJjZXNbaV07CisgICAgICAgICAg ICB0aGlzLl9zdGFsZVJlc291cmNlc1tyZXNvdXJjZS5yZXF1ZXN0SWRdID0gcmVzb3VyY2U7Cisg ICAgICAgIH0KICAgICB9LAogCiAgICAgZ2V0IGNhbGN1bGF0b3IoKQpAQCAtNjYwLDE1ICs2NjMs MTQgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dWaWV3LnByb3RvdHlwZSA9IHsKIAogICAgICAg ICB0aGlzLl9yZW1vdmVBbGxOb2RlSGlnaGxpZ2h0cygpOwogICAgICAgICB2YXIgd2FzU2Nyb2xs ZWRUb0xhc3RSb3cgPSB0aGlzLl9kYXRhR3JpZC5pc1Njcm9sbGVkVG9MYXN0Um93KCk7Ci0gICAg ICAgIHZhciBzdGFsZUl0ZW1zTGVuZ3RoID0gdGhpcy5fc3RhbGVSZXNvdXJjZXMubGVuZ3RoOwog ICAgICAgICB2YXIgYm91bmRhcmllc0NoYW5nZWQgPSBmYWxzZTsKICAgICAgICAgaWYgKHRoaXMu Y2FsY3VsYXRvci51cGRhdGVCb3VuZGFyaWVzRm9yRXZlbnRUaW1lKSB7CiAgICAgICAgICAgICBi b3VuZGFyaWVzQ2hhbmdlZCA9IHRoaXMuY2FsY3VsYXRvci51cGRhdGVCb3VuZGFyaWVzRm9yRXZl bnRUaW1lKHRoaXMuX21haW5SZXNvdXJjZUxvYWRUaW1lKSB8fCBib3VuZGFyaWVzQ2hhbmdlZDsK ICAgICAgICAgICAgIGJvdW5kYXJpZXNDaGFuZ2VkID0gdGhpcy5jYWxjdWxhdG9yLnVwZGF0ZUJv dW5kYXJpZXNGb3JFdmVudFRpbWUodGhpcy5fbWFpblJlc291cmNlRE9NQ29udGVudFRpbWUpIHx8 IGJvdW5kYXJpZXNDaGFuZ2VkOwogICAgICAgICB9CiAKLSAgICAgICAgZm9yICh2YXIgaSA9IDA7 IGkgPCBzdGFsZUl0ZW1zTGVuZ3RoOyArK2kpIHsKLSAgICAgICAgICAgIHZhciByZXNvdXJjZSA9 IHRoaXMuX3N0YWxlUmVzb3VyY2VzW2ldOworICAgICAgICBmb3IgKHZhciByZXNvdXJjZUlkIGlu IHRoaXMuX3N0YWxlUmVzb3VyY2VzKSB7CisgICAgICAgICAgICB2YXIgcmVzb3VyY2UgPSB0aGlz Ll9zdGFsZVJlc291cmNlc1tyZXNvdXJjZUlkXTsKICAgICAgICAgICAgIHZhciBub2RlID0gdGhp cy5fcmVzb3VyY2VHcmlkTm9kZShyZXNvdXJjZSk7CiAgICAgICAgICAgICBpZiAoIW5vZGUpIHsK ICAgICAgICAgICAgICAgICAvLyBDcmVhdGUgdGhlIHRpbWVsaW5lIHRyZWUgZWxlbWVudCBhbmQg Z3JhcGguCkBAIC02ODcsMTMgKzY4OSwxMiBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya0xvZ1ZpZXcu cHJvdG90eXBlID0gewogICAgICAgICBpZiAoYm91bmRhcmllc0NoYW5nZWQpIHsKICAgICAgICAg ICAgIC8vIFRoZSBib3VuZGFyaWVzIGNoYW5nZWQsIHNvIGFsbCBpdGVtIGdyYXBocyBhcmUgc3Rh bGUuCiAgICAgICAgICAgICB0aGlzLl9pbnZhbGlkYXRlQWxsSXRlbXMoKTsKLSAgICAgICAgICAg IHN0YWxlSXRlbXNMZW5ndGggPSB0aGlzLl9zdGFsZVJlc291cmNlcy5sZW5ndGg7CiAgICAgICAg IH0KIAotICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHN0YWxlSXRlbXNMZW5ndGg7ICsraSkK LSAgICAgICAgICAgIHRoaXMuX3Jlc291cmNlR3JpZE5vZGUodGhpcy5fc3RhbGVSZXNvdXJjZXNb aV0pLnJlZnJlc2hHcmFwaCh0aGlzLmNhbGN1bGF0b3IpOworICAgICAgICBmb3IgKHZhciByZXNv dXJjZUlkIGluIHRoaXMuX3N0YWxlUmVzb3VyY2VzKQorICAgICAgICAgICAgdGhpcy5fcmVzb3Vy Y2VHcmlkTm9kZSh0aGlzLl9zdGFsZVJlc291cmNlc1tyZXNvdXJjZUlkXSkucmVmcmVzaEdyYXBo KHRoaXMuY2FsY3VsYXRvcik7CiAKLSAgICAgICAgdGhpcy5fc3RhbGVSZXNvdXJjZXMgPSBbXTsK KyAgICAgICAgdGhpcy5fc3RhbGVSZXNvdXJjZXMgPSB7fTsKICAgICAgICAgdGhpcy5fc29ydEl0 ZW1zKCk7CiAgICAgICAgIHRoaXMuX3VwZGF0ZVN1bW1hcnlCYXIoKTsKICAgICAgICAgdGhpcy5f ZGF0YUdyaWQudXBkYXRlV2lkdGhzKCk7CkBAIC03MjEsNyArNzIyLDcgQEAgV2ViSW5zcGVjdG9y Lk5ldHdvcmtMb2dWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fcmVzb3VyY2VzID0g W107CiAgICAgICAgIHRoaXMuX3Jlc291cmNlc0J5SWQgPSB7fTsKICAgICAgICAgdGhpcy5fcmVz b3VyY2VzQnlVUkwgPSB7fTsKLSAgICAgICAgdGhpcy5fc3RhbGVSZXNvdXJjZXMgPSBbXTsKKyAg ICAgICAgdGhpcy5fc3RhbGVSZXNvdXJjZXMgPSB7fTsKICAgICAgICAgdGhpcy5fcmVzb3VyY2VH cmlkTm9kZXMgPSB7fTsKIAogICAgICAgICBpZiAodGhpcy5fZGF0YUdyaWQpIHsKQEAgLTc4Miw3 ICs3ODMsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya0xvZ1ZpZXcucHJvdG90eXBlID0gewogCiAg ICAgX3JlZnJlc2hSZXNvdXJjZTogZnVuY3Rpb24ocmVzb3VyY2UpCiAgICAgewotICAgICAgICB0 aGlzLl9zdGFsZVJlc291cmNlcy5wdXNoKHJlc291cmNlKTsKKyAgICAgICAgdGhpcy5fc3RhbGVS ZXNvdXJjZXNbcmVzb3VyY2UucmVxdWVzdElkXSA9IHJlc291cmNlOwogICAgICAgICB0aGlzLl9z Y2hlZHVsZVJlZnJlc2goKTsKICAgICB9LAogCg==