69080 2011-09-29 03:56:16 -0700 [WEBKIT2] Fix for compilation warnings in WebContext.cpp 2011-12-01 23:02:12 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 gouthamj webkit-unassigned webkit.review.bot oldest_to_newest 475357 0 gouthamj 2011-09-29 03:56:16 -0700 We get following compilation warnings while building WebContext.cpp, CC Source/WebKit2/UIProcess/API/gtk/tests/Programs_unittests_webkit2_testloading-testloading.o CC Tools/GtkLauncher/Programs_GtkLauncher2-main.o /bin/mkdir -p ./.deps/DerivedSources ../../Source/WebKit2/UIProcess/WebContext.cpp: In member function ‘void WebKit::WebContext::processDidFinishLaunching(WebKit::WebProcessProxy*)’: ../../Source/WebKit2/UIProcess/WebContext.cpp:325:95: warning: format ‘%llu’ expects type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’ ../../Source/WebKit2/UIProcess/WebContext.cpp: In member function ‘void WebKit::WebContext::startMemorySampler(double)’: ../../Source/WebKit2/UIProcess/WebContext.cpp:741:91: warning: format ‘%llu’ expects type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’ This is because, format-specifier llu expects 'unsigned long long int', whereas in Linux uint64_t is 'unsigned long int'. Type-casting to 'unsigned long long int' instead of 'uint64_t' should work in all platforms. 475358 1 109146 gouthamj 2011-09-29 03:57:50 -0700 Created attachment 109146 Warning fix 485421 2 109146 darin 2011-10-17 13:03:15 -0700 Comment on attachment 109146 Warning fix View in context: https://bugs.webkit.org/attachment.cgi?id=109146&action=review > Source/WebKit2/UIProcess/WebContext.cpp:325 > + String sampleLogFilePath = String::format("WebProcess%llu", static_cast<unsigned long long int>(now)); No reason to include the word “int”. > Source/WebKit2/UIProcess/WebContext.cpp:741 > + String sampleLogFilePath = String::format("WebProcess%llu", static_cast<unsigned long long int>(now)); No reason to include the word “int”. 486901 3 111652 gouthamj 2011-10-19 11:32:42 -0700 Created attachment 111652 Warning fix 513513 4 111652 morrita 2011-12-01 22:37:52 -0800 Comment on attachment 111652 Warning fix Looks ultra-trivial and addressed Darin's point. r+ing. 513532 5 111652 webkit.review.bot 2011-12-01 23:02:08 -0800 Comment on attachment 111652 Warning fix Clearing flags on attachment: 111652 Committed r101746: <http://trac.webkit.org/changeset/101746> 513533 6 webkit.review.bot 2011-12-01 23:02:12 -0800 All reviewed patches have been landed. Closing bug. 109146 2011-09-29 03:57:50 -0700 2011-10-19 11:32:42 -0700 Warning fix WarningFix.diff text/plain 2317 gouthamj ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NjA2MmU3Li5kMzczZGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDktMjkgIEdvdXRoYW0gSiAgPGdvdXRoYW1qQG1vdG9yb2xhLmNvbT4KKworICAg ICAgICBbV0VCS0lUMl0gRml4IGZvciBjb21waWxhdGlvbiB3YXJuaW5ncyBpbiBXZWJDb250ZXh0 LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njkw ODAKKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2FybmluZyBpbiBXZWJLaXQyIGJ1aWxkcy4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6cHJvY2Vz c0RpZEZpbmlzaExhdW5jaGluZyk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OnN0YXJ0 TWVtb3J5U2FtcGxlcik6CisKIDIwMTEtMDktMjggIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNv bkBpZ2FsaWEuY29tPgogCiAgICAgICAgIEZpeCB0aGUgV2ViR0wgYnVpbGQgb24gV2ViS2l0MiBH VEsrLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCmluZGV4IDEyODljMzIu LjBlYzg1NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKQEAgLTMy Miw3ICszMjIsNyBAQCB2b2lkIFdlYkNvbnRleHQ6OnByb2Nlc3NEaWRGaW5pc2hMYXVuY2hpbmco V2ViUHJvY2Vzc1Byb3h5KiBwcm9jZXNzKQogICAgIGlmIChtX21lbW9yeVNhbXBsZXJFbmFibGVk KSB7CiAgICAgICAgIFNhbmRib3hFeHRlbnNpb246OkhhbmRsZSBzYW1wbGVMb2dTYW5kYm94SGFu ZGxlOyAgICAgICAgCiAgICAgICAgIGRvdWJsZSBub3cgPSBXVEY6OmN1cnJlbnRUaW1lKCk7Ci0g ICAgICAgIFN0cmluZyBzYW1wbGVMb2dGaWxlUGF0aCA9IFN0cmluZzo6Zm9ybWF0KCJXZWJQcm9j ZXNzJWxsdSIsIHN0YXRpY19jYXN0PHVpbnQ2NF90Pihub3cpKTsKKyAgICAgICAgU3RyaW5nIHNh bXBsZUxvZ0ZpbGVQYXRoID0gU3RyaW5nOjpmb3JtYXQoIldlYlByb2Nlc3MlbGx1Iiwgc3RhdGlj X2Nhc3Q8dW5zaWduZWQgbG9uZyBsb25nIGludD4obm93KSk7CiAgICAgICAgIHNhbXBsZUxvZ0Zp bGVQYXRoID0gU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlRm9yVGVtcG9yYXJ5RmlsZShz YW1wbGVMb2dGaWxlUGF0aCwgU2FuZGJveEV4dGVuc2lvbjo6V3JpdGVPbmx5LCBzYW1wbGVMb2dT YW5kYm94SGFuZGxlKTsKICAgICAgICAgCiAgICAgICAgIG1fcHJvY2Vzcy0+c2VuZChNZXNzYWdl czo6V2ViUHJvY2Vzczo6U3RhcnRNZW1vcnlTYW1wbGVyKHNhbXBsZUxvZ1NhbmRib3hIYW5kbGUs IHNhbXBsZUxvZ0ZpbGVQYXRoLCBtX21lbW9yeVNhbXBsZXJJbnRlcnZhbCksIDApOwpAQCAtNzM4 LDcgKzczOCw3IEBAIHZvaWQgV2ViQ29udGV4dDo6c3RhcnRNZW1vcnlTYW1wbGVyKGNvbnN0IGRv dWJsZSBpbnRlcnZhbCkKICAgICAvLyBGb3IgV2ViUHJvY2VzcwogICAgIFNhbmRib3hFeHRlbnNp b246OkhhbmRsZSBzYW1wbGVMb2dTYW5kYm94SGFuZGxlOyAgICAKICAgICBkb3VibGUgbm93ID0g V1RGOjpjdXJyZW50VGltZSgpOwotICAgIFN0cmluZyBzYW1wbGVMb2dGaWxlUGF0aCA9IFN0cmlu Zzo6Zm9ybWF0KCJXZWJQcm9jZXNzJWxsdSIsIHN0YXRpY19jYXN0PHVpbnQ2NF90Pihub3cpKTsK KyAgICBTdHJpbmcgc2FtcGxlTG9nRmlsZVBhdGggPSBTdHJpbmc6OmZvcm1hdCgiV2ViUHJvY2Vz cyVsbHUiLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBsb25nIGxvbmcgaW50Pihub3cpKTsKICAgICBz YW1wbGVMb2dGaWxlUGF0aCA9IFNhbmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZUZvclRlbXBv cmFyeUZpbGUoc2FtcGxlTG9nRmlsZVBhdGgsIFNhbmRib3hFeHRlbnNpb246OldyaXRlT25seSwg c2FtcGxlTG9nU2FuZGJveEhhbmRsZSk7CiAgICAgCiAgICAgc2VuZFRvQWxsUHJvY2Vzc2VzKE1l c3NhZ2VzOjpXZWJQcm9jZXNzOjpTdGFydE1lbW9yeVNhbXBsZXIoc2FtcGxlTG9nU2FuZGJveEhh bmRsZSwgc2FtcGxlTG9nRmlsZVBhdGgsIGludGVydmFsKSk7Cg== 111652 2011-10-19 11:32:42 -0700 2011-12-01 23:02:08 -0800 Warning fix Reworked.diff text/plain 2367 gouthamj ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjNzM3MDQxLi40NTYzOGZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMTkgIEdvdXRoYW0gSiAgPGdvdXRoYW1qQG1vdG9yb2xhLmNvbT4KKworICAg ICAgICBbV0VCS0lUMl0gRml4IGZvciBjb21waWxhdGlvbiB3YXJuaW5ncyBpbiBXZWJDb250ZXh0 LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njkw ODAKKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2FybmluZyBpbiBXZWJLaXQyIGJ1aWxkcy4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6cHJvY2Vz c0RpZEZpbmlzaExhdW5jaGluZyk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OnN0YXJ0 TWVtb3J5U2FtcGxlcik6CisKIDIwMTEtMTAtMTcgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQG1v dG9yb2xhLmNvbT4KIAogICAgICAgICBbV2ViS2l0Ml1bZ3RrXSBSZW5hbWUgV0VCS0lUX1BPTElD WV9FUlJPUl9DQU5OT1RfU0hPV19VUkwgdG8gV0VCS0lUX1BPTElDWV9FUlJPUl9DQU5OT1RfU0hP V19VUkkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNw cCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcAppbmRleCBiZTA3YzNj Li4yODdhMmVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4 dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCkBAIC0z MjYsNyArMzI2LDcgQEAgdm9pZCBXZWJDb250ZXh0Ojpwcm9jZXNzRGlkRmluaXNoTGF1bmNoaW5n KFdlYlByb2Nlc3NQcm94eSogcHJvY2VzcykKICAgICBpZiAobV9tZW1vcnlTYW1wbGVyRW5hYmxl ZCkgewogICAgICAgICBTYW5kYm94RXh0ZW5zaW9uOjpIYW5kbGUgc2FtcGxlTG9nU2FuZGJveEhh bmRsZTsgICAgICAgIAogICAgICAgICBkb3VibGUgbm93ID0gV1RGOjpjdXJyZW50VGltZSgpOwot ICAgICAgICBTdHJpbmcgc2FtcGxlTG9nRmlsZVBhdGggPSBTdHJpbmc6OmZvcm1hdCgiV2ViUHJv Y2VzcyVsbHUiLCBzdGF0aWNfY2FzdDx1aW50NjRfdD4obm93KSk7CisgICAgICAgIFN0cmluZyBz YW1wbGVMb2dGaWxlUGF0aCA9IFN0cmluZzo6Zm9ybWF0KCJXZWJQcm9jZXNzJWxsdSIsIHN0YXRp Y19jYXN0PHVuc2lnbmVkIGxvbmcgbG9uZz4obm93KSk7CiAgICAgICAgIHNhbXBsZUxvZ0ZpbGVQ YXRoID0gU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlRm9yVGVtcG9yYXJ5RmlsZShzYW1w bGVMb2dGaWxlUGF0aCwgU2FuZGJveEV4dGVuc2lvbjo6V3JpdGVPbmx5LCBzYW1wbGVMb2dTYW5k Ym94SGFuZGxlKTsKICAgICAgICAgCiAgICAgICAgIG1fcHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6 V2ViUHJvY2Vzczo6U3RhcnRNZW1vcnlTYW1wbGVyKHNhbXBsZUxvZ1NhbmRib3hIYW5kbGUsIHNh bXBsZUxvZ0ZpbGVQYXRoLCBtX21lbW9yeVNhbXBsZXJJbnRlcnZhbCksIDApOwpAQCAtNzUzLDcg Kzc1Myw3IEBAIHZvaWQgV2ViQ29udGV4dDo6c3RhcnRNZW1vcnlTYW1wbGVyKGNvbnN0IGRvdWJs ZSBpbnRlcnZhbCkKICAgICAvLyBGb3IgV2ViUHJvY2VzcwogICAgIFNhbmRib3hFeHRlbnNpb246 OkhhbmRsZSBzYW1wbGVMb2dTYW5kYm94SGFuZGxlOyAgICAKICAgICBkb3VibGUgbm93ID0gV1RG OjpjdXJyZW50VGltZSgpOwotICAgIFN0cmluZyBzYW1wbGVMb2dGaWxlUGF0aCA9IFN0cmluZzo6 Zm9ybWF0KCJXZWJQcm9jZXNzJWxsdSIsIHN0YXRpY19jYXN0PHVpbnQ2NF90Pihub3cpKTsKKyAg ICBTdHJpbmcgc2FtcGxlTG9nRmlsZVBhdGggPSBTdHJpbmc6OmZvcm1hdCgiV2ViUHJvY2VzcyVs bHUiLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBsb25nIGxvbmc+KG5vdykpOwogICAgIHNhbXBsZUxv Z0ZpbGVQYXRoID0gU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlRm9yVGVtcG9yYXJ5Rmls ZShzYW1wbGVMb2dGaWxlUGF0aCwgU2FuZGJveEV4dGVuc2lvbjo6V3JpdGVPbmx5LCBzYW1wbGVM b2dTYW5kYm94SGFuZGxlKTsKICAgICAKICAgICBzZW5kVG9BbGxQcm9jZXNzZXMoTWVzc2FnZXM6 OldlYlByb2Nlc3M6OlN0YXJ0TWVtb3J5U2FtcGxlcihzYW1wbGVMb2dTYW5kYm94SGFuZGxlLCBz YW1wbGVMb2dGaWxlUGF0aCwgaW50ZXJ2YWwpKTsK