69079 2011-09-29 03:36:04 -0700 [GTK] Explicitly call destructors for objects initialized with placement new syntax 2011-09-29 03:59:15 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned pnormand oldest_to_newest 475353 0 cgarcia 2011-09-29 03:36:04 -0700 Tehere are several places where we are using the placement new syntax but we are not calling the destructors 475354 1 109144 cgarcia 2011-09-29 03:38:25 -0700 Created attachment 109144 Patch 475356 2 109144 xan.lopez 2011-09-29 03:55:21 -0700 Comment on attachment 109144 Patch Looks good to me. 475359 3 cgarcia 2011-09-29 03:59:15 -0700 Committed r96317: <http://trac.webkit.org/changeset/96317> 109144 2011-09-29 03:38:25 -0700 2011-09-29 03:55:20 -0700 Patch wk2-memleaks.diff text/plain 3985 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NjA2MmU3Li45NTI0NTViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDktMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEV4cGxpY2l0bHkgY2FsbCBkZXN0cnVjdG9ycyBmb3Igb2JqZWN0 cyBpbml0aWFsaXplZCB3aXRoIHBsYWNlbWVudCBuZXcgc3ludGF4CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTA3OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 V2ViQ29udGV4dC5jcHA6CisgICAgICAgICh3ZWJraXRXZWJDb250ZXh0RmluYWxpemUpOiBDYWxs IH5XZWJLaXRXZWJDb250ZXh0UHJpdmF0ZSgpLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYkxvYWRlckNsaWVudC5jcHA6CisgICAgICAgICh3ZWJraXRXZWJMb2FkZXJDbGll bnRGaW5hbGl6ZSk6IENhbGwgfldlYktpdFdlYkxvYWRlckNsaWVudCgpLgorICAgICAgICAod2Vi a2l0X3dlYl9sb2FkZXJfY2xpZW50X2NsYXNzX2luaXQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwOgorICAgICAgICAod2Via2l0V2ViVmlld0ZpbmFsaXpl KTogQ2FsbCB+V2ViS2l0V2ViVmlld1ByaXZhdGUoKS4KKyAgICAgICAgKHdlYmtpdF93ZWJfdmll d19jbGFzc19pbml0KToKKwogMjAxMS0wOS0yOCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29u QGlnYWxpYS5jb20+CiAKICAgICAgICAgRml4IHRoZSBXZWJHTCBidWlsZCBvbiBXZWJLaXQyIEdU SysuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YkNvbnRleHQuY3BwCmluZGV4IGEwMGRiNDkuLmVhZGExYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuY3BwCkBAIC0zNiw2 ICszNiwxMCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJDb250ZXh0RmluYWxpemUoR09iamVjdCog b2JqZWN0KQogCiAgICAgV0tSZWxlYXNlKGNvbnRleHQtPnByaXYtPmNvbnRleHQpOwogICAgIGNv bnRleHQtPnByaXYtPmNvbnRleHQgPSAwOworCisgICAgY29udGV4dC0+cHJpdi0+fldlYktpdFdl YkNvbnRleHRQcml2YXRlKCk7CisKKyAgICBHX09CSkVDVF9DTEFTUyh3ZWJraXRfd2ViX2NvbnRl eHRfcGFyZW50X2NsYXNzKS0+ZmluYWxpemUob2JqZWN0KTsKIH0KIAogc3RhdGljIHZvaWQgd2Vi a2l0X3dlYl9jb250ZXh0X2luaXQoV2ViS2l0V2ViQ29udGV4dCogd2ViQ29udGV4dCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkxvYWRlckNs aWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJMb2Fk ZXJDbGllbnQuY3BwCmluZGV4IDQzMDA5ZjUuLmQ2MjMwMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkxvYWRlckNsaWVudC5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViTG9hZGVyQ2xpZW50LmNw cApAQCAtMTgyLDYgKzE4MiwxMiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJMb2FkZXJDbGllbnRH ZXRQcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BJZCwgR1ZhbAogICAgIH0KIH0K IAorc3RhdGljIHZvaWQgd2Via2l0V2ViTG9hZGVyQ2xpZW50RmluYWxpemUoR09iamVjdCogb2Jq ZWN0KQoreworICAgIFdFQktJVF9XRUJfTE9BREVSX0NMSUVOVChvYmplY3QpLT5wcml2LT5+V2Vi S2l0V2ViTG9hZGVyQ2xpZW50UHJpdmF0ZSgpOworICAgIEdfT0JKRUNUX0NMQVNTKHdlYmtpdF93 ZWJfbG9hZGVyX2NsaWVudF9wYXJlbnRfY2xhc3MpLT5maW5hbGl6ZShvYmplY3QpOworfQorCiBz dGF0aWMgdm9pZCB3ZWJraXRfd2ViX2xvYWRlcl9jbGllbnRfaW5pdChXZWJLaXRXZWJMb2FkZXJD bGllbnQqIGNsaWVudCkKIHsKICAgICBXZWJLaXRXZWJMb2FkZXJDbGllbnRQcml2YXRlKiBwcml2 ID0gR19UWVBFX0lOU1RBTkNFX0dFVF9QUklWQVRFKGNsaWVudCwgV0VCS0lUX1RZUEVfV0VCX0xP QURFUl9DTElFTlQsIFdlYktpdFdlYkxvYWRlckNsaWVudFByaXZhdGUpOwpAQCAtMTk2LDYgKzIw Miw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfbG9hZGVyX2NsaWVudF9jbGFzc19pbml0KFdl YktpdFdlYkxvYWRlckNsaWVudENsYXNzKiBjbGllCiAgICAgb2JqZWN0Q2xhc3MtPnNldF9wcm9w ZXJ0eSA9IHdlYmtpdFdlYkxvYWRlckNsaWVudFNldFByb3BlcnR5OwogICAgIG9iamVjdENsYXNz LT5nZXRfcHJvcGVydHkgPSB3ZWJraXRXZWJMb2FkZXJDbGllbnRHZXRQcm9wZXJ0eTsKICAgICBv YmplY3RDbGFzcy0+Y29uc3RydWN0ZWQgPSB3ZWJraXRXZWJMb2FkZXJDbGllbnRDb25zdHJ1Y3Rl ZDsKKyAgICBvYmplY3RDbGFzcy0+ZmluYWxpemUgPSB3ZWJraXRXZWJMb2FkZXJDbGllbnRGaW5h bGl6ZTsKIAogICAgIC8qKgogICAgICAqIFdlYktpdFdlYlZpZXc6d2ViLXZpZXc6CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCmluZGV4 IGIyZmM3MjQuLjkyZGFhMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCkBAIC04Myw2ICs4MywxMiBAQCBzdGF0aWMgdm9pZCB3 ZWJraXRXZWJWaWV3R2V0UHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9wSWQsIEdW YWx1ZSogdmFsdQogICAgIH0KIH0KIAorc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0ZpbmFsaXpl KEdPYmplY3QqIG9iamVjdCkKK3sKKyAgICBXRUJLSVRfV0VCX1ZJRVcob2JqZWN0KS0+cHJpdi0+ fldlYktpdFdlYlZpZXdQcml2YXRlKCk7CisgICAgR19PQkpFQ1RfQ0xBU1Mod2Via2l0X3dlYl92 aWV3X3BhcmVudF9jbGFzcyktPmZpbmFsaXplKG9iamVjdCk7Cit9CisKIHN0YXRpYyB2b2lkIHdl YmtpdF93ZWJfdmlld19pbml0KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiB7CiAgICAgV2ViS2l0 V2ViVmlld1ByaXZhdGUqIHByaXYgPSBHX1RZUEVfSU5TVEFOQ0VfR0VUX1BSSVZBVEUod2ViVmll dywgV0VCS0lUX1RZUEVfV0VCX1ZJRVcsIFdlYktpdFdlYlZpZXdQcml2YXRlKTsKQEAgLTk3LDYg KzEwMyw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdl YlZpZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAgIGdPYmplY3RDbGFzcy0+Y29uc3RydWN0ZWQg PSB3ZWJraXRXZWJWaWV3Q29uc3RydWN0ZWQ7CiAgICAgZ09iamVjdENsYXNzLT5zZXRfcHJvcGVy dHkgPSB3ZWJraXRXZWJWaWV3U2V0UHJvcGVydHk7CiAgICAgZ09iamVjdENsYXNzLT5nZXRfcHJv cGVydHkgPSB3ZWJraXRXZWJWaWV3R2V0UHJvcGVydHk7CisgICAgZ09iamVjdENsYXNzLT5maW5h bGl6ZSA9IHdlYmtpdFdlYlZpZXdGaW5hbGl6ZTsKIAogICAgIGdfdHlwZV9jbGFzc19hZGRfcHJp dmF0ZSh3ZWJWaWV3Q2xhc3MsIHNpemVvZihXZWJLaXRXZWJWaWV3UHJpdmF0ZSkpOwogCg==