69075 2011-09-29 02:02:03 -0700 bug fixes for CreateThis, NewObject and GetByOffset in JSVALUE32_64 DFG JIT 2011-09-29 12:06:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough webkit.review.bot oldest_to_newest 475320 0 yuqiang.xian 2011-09-29 02:02:03 -0700 Arguments are not passed correctly for CreateThis and NewObject. The child node is incorrectly "used" by twice for GetbyOffset. 475321 1 109136 yuqiang.xian 2011-09-29 02:05:23 -0700 Created attachment 109136 the patch 475582 2 109136 webkit.review.bot 2011-09-29 12:06:47 -0700 Comment on attachment 109136 the patch Clearing flags on attachment: 109136 Committed r96344: <http://trac.webkit.org/changeset/96344> 475583 3 webkit.review.bot 2011-09-29 12:06:51 -0700 All reviewed patches have been landed. Closing bug. 109136 2011-09-29 02:05:23 -0700 2011-09-29 12:06:46 -0700 the patch 69075.patch text/plain 2504 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTYzMTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDktMjkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgQnVnIGZpeGVzIGZvciBDcmVhdGVUaGlzLCBOZXdPYmplY3QgYW5kIEdldEJ5T2Zmc2V0 IGluIEpTVkFMVUUzMl82NCBERkcgSklUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02OTA3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwOgorICAgICAg ICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlKToKKwogMjAxMS0wOS0yOSAgWXVx aWFuZyBYaWFuICA8eXVxaWFuZy54aWFuQGludGVsLmNvbT4KIAogICAgICAgICBKU1ZBTFVFMzJf NjQgREZHIEpJVCBmYWlsZWQgdG8gYmUgYnVpbHQgb24gMzItYml0IExpbnV4IGR1ZSB0byBpbmNv cnJlY3Qgb3ZlcmxvYWRlZCBPcEluZm8gY29uc3RydWN0b3IKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkocmV2aXNp b24gOTYzMTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklU MzJfNjQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjc0LDggKzE2NzQsOSBAQCB2b2lkIFNwZWN1 bGF0aXZlSklUOjpjb21waWxlKE5vZGUmIG5vZGUpCiAgICAgICAgIHNsb3dQYXRoLmxpbmsoJm1f aml0KTsKICAgICAgICAgCiAgICAgICAgIHNpbGVudFNwaWxsQWxsUmVnaXN0ZXJzKHJlc3VsdEdQ Uik7Ci0gICAgICAgIG1faml0Lm1vdmUocHJvdG9HUFIsIEdQUkluZm86OmFyZ3VtZW50R1BSMSk7 Ci0gICAgICAgIG1faml0Lm1vdmUoR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsIEdQUkluZm86 OmFyZ3VtZW50R1BSMCk7CisgICAgICAgIG1faml0LnB1c2goVHJ1c3RlZEltbTMyKEpTVmFsdWU6 OkNlbGxUYWcpKTsKKyAgICAgICAgbV9qaXQucHVzaChwcm90b0dQUik7CisgICAgICAgIG1faml0 LnB1c2goR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIpOwogICAgICAgICBhcHBlbmRDYWxsV2l0 aEV4Y2VwdGlvbkNoZWNrKG9wZXJhdGlvbkNyZWF0ZVRoaXMpOwogICAgICAgICBtX2ppdC5tb3Zl KEdQUkluZm86OnJldHVyblZhbHVlR1BSLCByZXN1bHRHUFIpOwogICAgICAgICBzaWxlbnRGaWxs QWxsUmVnaXN0ZXJzKHJlc3VsdEdQUik7CkBAIC0xNzAyLDcgKzE3MDMsNyBAQCB2b2lkIFNwZWN1 bGF0aXZlSklUOjpjb21waWxlKE5vZGUmIG5vZGUpCiAgICAgICAgIHNsb3dQYXRoLmxpbmsoJm1f aml0KTsKICAgICAgICAgCiAgICAgICAgIHNpbGVudFNwaWxsQWxsUmVnaXN0ZXJzKHJlc3VsdEdQ Uik7Ci0gICAgICAgIG1faml0Lm1vdmUoR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsIEdQUklu Zm86OmFyZ3VtZW50R1BSMCk7CisgICAgICAgIG1faml0LnB1c2goR1BSSW5mbzo6Y2FsbEZyYW1l UmVnaXN0ZXIpOwogICAgICAgICBhcHBlbmRDYWxsV2l0aEV4Y2VwdGlvbkNoZWNrKG9wZXJhdGlv bk5ld09iamVjdCk7CiAgICAgICAgIG1faml0Lm1vdmUoR1BSSW5mbzo6cmV0dXJuVmFsdWVHUFIs IHJlc3VsdEdQUik7CiAgICAgICAgIHNpbGVudEZpbGxBbGxSZWdpc3RlcnMocmVzdWx0R1BSKTsK QEAgLTE4MzQsNyArMTgzNSw2IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSYg bm9kZSkKICAgICAgICAgR1BSUmVnIHJlc3VsdFRhZ0dQUiA9IHJlc3VsdFRhZy5ncHIoKTsKICAg ICAgICAgR1BSUmVnIHJlc3VsdFBheWxvYWRHUFIgPSByZXN1bHRQYXlsb2FkLmdwcigpOwogICAg ICAgICAKLSAgICAgICAgc3RvcmFnZS51c2UoKTsKICAgICAgICAgU3RvcmFnZUFjY2Vzc0RhdGEm IHN0b3JhZ2VBY2Nlc3NEYXRhID0gbV9qaXQuZ3JhcGgoKS5tX3N0b3JhZ2VBY2Nlc3NEYXRhW25v ZGUuc3RvcmFnZUFjY2Vzc0RhdGFJbmRleCgpXTsKICAgICAgICAgCiAgICAgICAgIG1faml0Lmxv YWQzMihKSVRDb21waWxlcjo6QWRkcmVzcyhzdG9yYWdlR1BSLCBzdG9yYWdlQWNjZXNzRGF0YS5v ZmZzZXQgKiBzaXplb2YoRW5jb2RlZEpTVmFsdWUpICsgT0JKRUNUX09GRlNFVE9GKEVuY29kZWRW YWx1ZURlc2NyaXB0b3IsIGFzQml0cy5wYXlsb2FkKSksIHJlc3VsdFBheWxvYWRHUFIpOwo=