69063 2011-09-28 23:41:50 -0700 [Chromium] Forward fullscreenchanged event to plugins 2013-04-12 07:00:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 koz koz brettw darin dglazkov fishd jeremya schenney webkit.review.bot oldest_to_newest 475257 0 koz 2011-09-28 23:41:50 -0700 Forward fullscreenchanged event to plugins 475259 1 109125 koz 2011-09-28 23:42:19 -0700 Created attachment 109125 Patch 475336 2 109125 webkit.review.bot 2011-09-29 02:53:02 -0700 Comment on attachment 109125 Patch Attachment 109125 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9880864 475662 3 koz 2011-09-29 13:48:06 -0700 Please note, this patch depends on the Chromium-side patch here: http://codereview.chromium.org/8065026. 478919 4 109910 polina 2011-10-05 20:55:16 -0700 Created attachment 109910 Patch 478921 5 webkit.review.bot 2011-10-05 20:57:35 -0700 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 478924 6 109910 webkit.review.bot 2011-10-05 21:01:58 -0700 Comment on attachment 109910 Patch Attachment 109910 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9969123 478925 7 109910 fishd 2011-10-05 21:07:54 -0700 Comment on attachment 109910 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109910&action=review > Source/WebKit/chromium/public/WebPlugin.h:86 > + virtual void onFullscreenChange() { } nit: we normally use the convention of didSomeEvent or willDoSomeEvent instead of onEvent. that way the before/after relation is made clear. we already have WebViewClient::{enter,exit}FullscreenForNode. that is driven from ChromeClient::{enter,exit}FullscreenForNode. had you considered using that? 479498 8 110026 polina 2011-10-06 14:36:46 -0700 Created attachment 110026 Patch 479499 9 110026 polina 2011-10-06 14:39:25 -0700 Comment on attachment 110026 Patch Renamed onFullscreenChange to handleFullscreenChangeEvent. There are already did and willDo versions of fullscreen functions and their purpose is different - performing an action as opposed to notifying about it. Please let me know if the new name is appropriate. 479502 10 110026 polina 2011-10-06 14:43:24 -0700 Comment on attachment 110026 Patch The existing implementation for entering/exiting fullscreen mode uses WebKit::ChromeClientImpl::{enter,exit}FullscreenForElement. WebKit::ChromeClientImpl::{enter,exit}FullscreenForNode is unused and calls UNIMPLEMENTED code in RenderView. 479835 11 110026 fishd 2011-10-06 23:54:01 -0700 Comment on attachment 110026 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110026&action=review > Source/WebKit/chromium/ChangeLog:63 > +>>>>>>> .r96838 oops > Source/WebKit/chromium/public/WebPlugin.h:86 > + virtual void handleFullscreenChangeEvent() { } nit: didChangeFullscreenState would probably be more consistent with the way we name other notifications of state changes. > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:194 > + m_webPlugin->handleFullscreenChangeEvent(); i'm still not sure that this is the best solution. can the page intercept this event and prevent its delivery to the WebPluginContainerImpl? if it did that, then perhaps we might miss a notification that we switched into fullscreen mode? could a page construct a fullscreenchange event and dispatch it manually to the plugin to confuse the plugin? this is why i was thinking that we should use the ChromeClient methods as a signal since those cannot be intercepted or faked. 874663 12 schenney 2013-04-12 07:00:25 -0700 https://code.google.com/p/chromium/issues/detail?id=230802 109125 2011-09-28 23:42:19 -0700 2012-02-16 14:40:43 -0800 Patch bug-69063-20110929164217.patch text/plain 1578 koz U3VidmVyc2lvbiBSZXZpc2lvbjogOTYyOTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg Y2I4ODZlZGM5ZDMzNGRiZmI1ZGM3N2JjMTZhZGNiYjgzOGVlZTY3Ny4uMjhiOWJhM2E2MWQ0NGIw MzcyNzA1OWMwN2YyYTU3OGU1N2U0ODZjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0wOS0yOCAgSmFtZXMgS296aWFuc2tpICA8a296QGNocm9taXVt Lm9yZz4KKworICAgICAgICBGb3J3YXJkIGZ1bGxzY3JlZW5jaGFuZ2VkIGV2ZW50IHRvIHBsdWdp bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MDYz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMv V2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBsdWdpbkNv bnRhaW5lckltcGw6OmhhbmRsZUV2ZW50KToKKwogMjAxMS0wOS0yOCAgRmFkeSBTYW11ZWwgIDxm c2FtdWVsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFNlcGVyYXRlIEdUSyBz cGVjaWZpYyBHeXAgcnVsZXMgZnJvbSBYMTEgR3lwIHJ1bGVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCmluZGV4IDQ2YWFh MjU1MGMyZjc5YzAzYjhkOGY3YzU2ODM4ZTMyMmUzZTYxNGQuLjA2NTNjNzc4NmM3MTIwMzQ1NDE0 YjMxM2YyZTUxNTM2ZmFjMjNmZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCkBAIC0xOTAsNiArMTkwLDggQEAgdm9p ZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpoYW5kbGVFdmVudChFdmVudCogZXZlbnQpCiAgICAg ICAgIGhhbmRsZVdoZWVsRXZlbnQoc3RhdGljX2Nhc3Q8V2hlZWxFdmVudCo+KGV2ZW50KSk7CiAg ICAgZWxzZSBpZiAoZXZlbnQtPmlzS2V5Ym9hcmRFdmVudCgpKQogICAgICAgICBoYW5kbGVLZXli b2FyZEV2ZW50KHN0YXRpY19jYXN0PEtleWJvYXJkRXZlbnQqPihldmVudCkpOworICAgIGVsc2Ug aWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLndlYmtpdGZ1bGxzY3JlZW5jaGFuZ2VF dmVudCkKKyAgICAgICAgbV93ZWJQbHVnaW4tPm9uRnVsbHNjcmVlbkNoYW5nZWQoKTsKIAogICAg IC8vIEZJWE1FOiBpdCB3b3VsZCBiZSBjbGVhbmVyIGlmIFdpZGdldDo6aGFuZGxlRXZlbnQgcmV0 dXJuZWQgdHJ1ZS9mYWxzZSBhbmQKICAgICAvLyBIVE1MUGx1Z2luRWxlbWVudCBjYWxsZWQgc2V0 RGVmYXVsdEhhbmRsZWQgb3IgZGVmYXVsdEV2ZW50SGFuZGxlci4K 109910 2011-10-05 20:55:16 -0700 2011-10-06 14:36:41 -0700 Patch bug-69063-20111005205515.patch text/plain 2976 polina SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5Njc4NCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMDUgIFBvbGluYSBTb2tvbG92YSAgPHBvbGluYUBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgRm9yd2FyZCB3ZWJraXRmdWxsc2NyZWVuY2hhbmdlIGV2ZW50IHRvIFdlYlBsdWdp bnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTA2 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVi bGljL1dlYlBsdWdpbi5oOgorICAgICAgICAoV2ViS2l0OjpXZWJQbHVnaW46Om9uRnVsbHNjcmVl bkNoYW5nZSk6CisgICAgICAgICogc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJQbHVnaW5Db250YWluZXJJbXBsOjpoYW5kbGVFdmVudCk6CisKIDIw MTEtMTAtMDUgIEFsZXhlaSBTdml0a2luZSAgPGFzdml0a2luZUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgTWFrZSBkZXN0cnVjdG9yIG9mIFdlYlVSTExvYWRlckNsaWVudCB2aXJ0dWFsLgpJbmRl eDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGx1Z2luLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGx1Z2luLmgJKHJldmlzaW9uIDk2 Nzc5KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGx1Z2luLmgJKHdvcmtp bmcgY29weSkKQEAgLTgyLDYgKzgyLDkgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRG YWlsTG9hZGluZ0ZyYW1lUmVxdWVzdCgKICAgICAgICAgY29uc3QgV2ViVVJMJiwgdm9pZCogbm90 aWZ5RGF0YSwgY29uc3QgV2ViVVJMRXJyb3ImKSA9IDA7CiAKKyAgICAvLyBDYWxsZWQgaW4gcmVz cG9uc2UgdG8gdHJhbnNpdGlvbiB0by9mcm9tIGZ1bGxzY3JlZW4gbW9kZS4KKyAgICB2aXJ0dWFs IHZvaWQgb25GdWxsc2NyZWVuQ2hhbmdlKCkgeyB9CisKICAgICAvLyBQcmludGluZyBpbnRlcmZh Y2UuCiAgICAgLy8gV2hldGhlciB0aGUgcGx1Z2luIHN1cHBvcnRzIGl0cyBvd24gcGFnaW5hdGVk IHByaW50LiBUaGUgb3RoZXIgcHJpbnQKICAgICAvLyBpbnRlcmZhY2UgbWV0aG9kcyBhcmUgY2Fs bGVkIG9ubHkgaWYgdGhpcyBtZXRob2QgcmV0dXJucyB0cnVlLgpAQCAtMTA3LDggKzExMCw4IEBA IHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0Wm9vbUxldmVsKGRvdWJsZSBsZXZlbCwgYm9v bCB0ZXh0T25seSkgeyB9CiAKICAgICAvLyBGaW5kIGludGVyZmFjZS4KLSAgICAvLyBTdGFydCBh IG5ldyBzZWFyY2guICBUaGUgcGx1Z2luIHNob3VsZCBzZWFyY2ggZm9yIGEgbGl0dGxlIGJpdCBh dCBhIHRpbWUgc28gdGhhdCBpdAotICAgIC8vIGRvZXNuJ3QgYmxvY2sgdGhlIHRocmVhZCBpbiBj YXNlIG9mIGEgbGFyZ2UgZG9jdW1lbnQuICBUaGUgcmVzdWx0cywgYWxvbmcgd2l0aCB0aGUKKyAg ICAvLyBTdGFydCBhIG5ldyBzZWFyY2guIFRoZSBwbHVnaW4gc2hvdWxkIHNlYXJjaCBmb3IgYSBs aXR0bGUgYml0IGF0IGEgdGltZSBzbyB0aGF0IGl0CisgICAgLy8gZG9lc24ndCBibG9jayB0aGUg dGhyZWFkIGluIGNhc2Ugb2YgYSBsYXJnZSBkb2N1bWVudC4gVGhlIHJlc3VsdHMsIGFsb25nIHdp dGggdGhlCiAgICAgLy8gZmluZCdzIGlkZW50aWZpZXIsIHNob3VsZCBiZSBzZW50IGFzeW5jaHJv bm91c2x5IHRvIFdlYkZyYW1lQ2xpZW50J3MgcmVwb3J0RmluZEluUGFnZSogbWV0aG9kcy4KICAg ICAvLyBSZXR1cm5zIHRydWUgaWYgdGhlIHNlYXJjaCBzdGFydGVkLCBvciBmYWxzZSBpZiB0aGUg cGx1Z2luIGRvZXNuJ3Qgc3VwcG9ydCBzZWFyY2guCiAgICAgdmlydHVhbCBib29sIHN0YXJ0Rmlu ZChjb25zdCBXZWJTdHJpbmcmIHNlYXJjaFRleHQsIGJvb2wgY2FzZVNlbnNpdGl2ZSwgaW50IGlk ZW50aWZpZXIpIHsgcmV0dXJuIGZhbHNlOyB9CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAkocmV2aXNpb24gOTY3 NzkpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBs LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkwLDYgKzE5MCw4IEBAIHZvaWQgV2ViUGx1Z2luQ29u dGFpbmVySW1wbDo6aGFuZGxlRXZlbnQKICAgICAgICAgaGFuZGxlV2hlZWxFdmVudChzdGF0aWNf Y2FzdDxXaGVlbEV2ZW50Kj4oZXZlbnQpKTsKICAgICBlbHNlIGlmIChldmVudC0+aXNLZXlib2Fy ZEV2ZW50KCkpCiAgICAgICAgIGhhbmRsZUtleWJvYXJkRXZlbnQoc3RhdGljX2Nhc3Q8S2V5Ym9h cmRFdmVudCo+KGV2ZW50KSk7CisgICAgZWxzZSBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5h bWVzKCkud2Via2l0ZnVsbHNjcmVlbmNoYW5nZUV2ZW50KQorICAgICAgICAgbV93ZWJQbHVnaW4t Pm9uRnVsbHNjcmVlbkNoYW5nZWQoKTsKIAogICAgIC8vIEZJWE1FOiBpdCB3b3VsZCBiZSBjbGVh bmVyIGlmIFdpZGdldDo6aGFuZGxlRXZlbnQgcmV0dXJuZWQgdHJ1ZS9mYWxzZSBhbmQKICAgICAv LyBIVE1MUGx1Z2luRWxlbWVudCBjYWxsZWQgc2V0RGVmYXVsdEhhbmRsZWQgb3IgZGVmYXVsdEV2 ZW50SGFuZGxlci4K 110026 2011-10-06 14:36:46 -0700 2011-10-06 23:54:01 -0700 Patch bug-69063-20111006143645.patch text/plain 3303 polina SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5Njg1MikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMDYgIFBvbGluYSBTb2tvbG92YSAgPHBvbGluYUBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgRm9yd2FyZCB3ZWJraXRmdWxsc2NyZWVuY2hhbmdlIGV2ZW50IHRvIFdlYlBsdWdp bnMuCisgICAgICAgIFRoZSBldmVudCBpcyBkaXNwYXRjaGVkIHdoZW4gcGx1Z2luIGVsZW1lbnQg ZW50ZXJzL2V4aXRzIGZ1bGxzY3JlZW4gbW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MDYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViUGx1Z2luLmg6CisgICAgICAgIChXZWJL aXQ6OldlYlBsdWdpbjo6b25GdWxsc2NyZWVuQ2hhbmdlKToKKyAgICAgICAgKiBzcmMvV2ViUGx1 Z2luQ29udGFpbmVySW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5l ckltcGw6OmhhbmRsZUV2ZW50KToKKwogMjAxMS0xMC0wNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQu cmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjk2NzkxLgpAQCAtNDcsNiArNjAsNyBAQAogICAgICAgICAqIHRlc3RzL0NDTGF5ZXJUcmVlSG9z dFRlc3QuY3BwOgogICAgICAgICAoV1RGOjpDQ0xheWVyVHJlZUhvc3RUZXN0OjpDQ0xheWVyVHJl ZUhvc3RUZXN0KToKIAorPj4+Pj4+PiAucjk2ODM4CiAyMDExLTEwLTA1ICBBbGV4ZWkgU3ZpdGtp bmUgIDxhc3ZpdGtpbmVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1ha2UgZGVzdHJ1Y3RvciBv ZiBXZWJVUkxMb2FkZXJDbGllbnQgdmlydHVhbC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYlBsdWdpbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYlBsdWdpbi5oCShyZXZpc2lvbiA5Njg1MikKKysrIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlBsdWdpbi5oCSh3b3JraW5nIGNvcHkpCkBAIC04Miw2ICs4Miw5 IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgZGlkRmFpbExvYWRpbmdGcmFtZVJlcXVlc3Qo CiAgICAgICAgIGNvbnN0IFdlYlVSTCYsIHZvaWQqIG5vdGlmeURhdGEsIGNvbnN0IFdlYlVSTEVy cm9yJikgPSAwOwogCisgICAgLy8gQ2FsbGVkIHdoZW4gZnVsbHNjcmVlbmNoYW5nZSBldmVudCBp cyBkaXNwYXRjaGVkLgorICAgIHZpcnR1YWwgdm9pZCBoYW5kbGVGdWxsc2NyZWVuQ2hhbmdlRXZl bnQoKSB7IH0KKwogICAgIC8vIFByaW50aW5nIGludGVyZmFjZS4KICAgICAvLyBXaGV0aGVyIHRo ZSBwbHVnaW4gc3VwcG9ydHMgaXRzIG93biBwYWdpbmF0ZWQgcHJpbnQuIFRoZSBvdGhlciBwcmlu dAogICAgIC8vIGludGVyZmFjZSBtZXRob2RzIGFyZSBjYWxsZWQgb25seSBpZiB0aGlzIG1ldGhv ZCByZXR1cm5zIHRydWUuCkBAIC0xMDcsOCArMTEwLDggQEAgcHVibGljOgogICAgIHZpcnR1YWwg dm9pZCBzZXRab29tTGV2ZWwoZG91YmxlIGxldmVsLCBib29sIHRleHRPbmx5KSB7IH0KIAogICAg IC8vIEZpbmQgaW50ZXJmYWNlLgotICAgIC8vIFN0YXJ0IGEgbmV3IHNlYXJjaC4gIFRoZSBwbHVn aW4gc2hvdWxkIHNlYXJjaCBmb3IgYSBsaXR0bGUgYml0IGF0IGEgdGltZSBzbyB0aGF0IGl0Ci0g ICAgLy8gZG9lc24ndCBibG9jayB0aGUgdGhyZWFkIGluIGNhc2Ugb2YgYSBsYXJnZSBkb2N1bWVu dC4gIFRoZSByZXN1bHRzLCBhbG9uZyB3aXRoIHRoZQorICAgIC8vIFN0YXJ0IGEgbmV3IHNlYXJj aC4gVGhlIHBsdWdpbiBzaG91bGQgc2VhcmNoIGZvciBhIGxpdHRsZSBiaXQgYXQgYSB0aW1lIHNv IHRoYXQgaXQKKyAgICAvLyBkb2Vzbid0IGJsb2NrIHRoZSB0aHJlYWQgaW4gY2FzZSBvZiBhIGxh cmdlIGRvY3VtZW50LiBUaGUgcmVzdWx0cywgYWxvbmcgd2l0aCB0aGUKICAgICAvLyBmaW5kJ3Mg aWRlbnRpZmllciwgc2hvdWxkIGJlIHNlbnQgYXN5bmNocm9ub3VzbHkgdG8gV2ViRnJhbWVDbGll bnQncyByZXBvcnRGaW5kSW5QYWdlKiBtZXRob2RzLgogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0 aGUgc2VhcmNoIHN0YXJ0ZWQsIG9yIGZhbHNlIGlmIHRoZSBwbHVnaW4gZG9lc24ndCBzdXBwb3J0 IHNlYXJjaC4KICAgICB2aXJ0dWFsIGJvb2wgc3RhcnRGaW5kKGNvbnN0IFdlYlN0cmluZyYgc2Vh cmNoVGV4dCwgYm9vbCBjYXNlU2Vuc2l0aXZlLCBpbnQgaWRlbnRpZmllcikgeyByZXR1cm4gZmFs c2U7IH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5l ckltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBs dWdpbkNvbnRhaW5lckltcGwuY3BwCShyZXZpc2lvbiA5Njg1MikKKysrIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xOTAsNiArMTkwLDggQEAgdm9pZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpoYW5kbGVFdmVu dAogICAgICAgICBoYW5kbGVXaGVlbEV2ZW50KHN0YXRpY19jYXN0PFdoZWVsRXZlbnQqPihldmVu dCkpOwogICAgIGVsc2UgaWYgKGV2ZW50LT5pc0tleWJvYXJkRXZlbnQoKSkKICAgICAgICAgaGFu ZGxlS2V5Ym9hcmRFdmVudChzdGF0aWNfY2FzdDxLZXlib2FyZEV2ZW50Kj4oZXZlbnQpKTsKKyAg ICBlbHNlIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS53ZWJraXRmdWxsc2NyZWVu Y2hhbmdlRXZlbnQpCisgICAgICAgIG1fd2ViUGx1Z2luLT5oYW5kbGVGdWxsc2NyZWVuQ2hhbmdl RXZlbnQoKTsKIAogICAgIC8vIEZJWE1FOiBpdCB3b3VsZCBiZSBjbGVhbmVyIGlmIFdpZGdldDo6 aGFuZGxlRXZlbnQgcmV0dXJuZWQgdHJ1ZS9mYWxzZSBhbmQKICAgICAvLyBIVE1MUGx1Z2luRWxl bWVudCBjYWxsZWQgc2V0RGVmYXVsdEhhbmRsZWQgb3IgZGVmYXVsdEV2ZW50SGFuZGxlci4K