69061 2011-09-28 23:14:55 -0700 [EFL] Only set when the custom encoding is different from existing value 2011-10-04 21:55:19 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim gyuyoung.kim leandro lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 475246 0 gyuyoung.kim 2011-09-28 23:14:55 -0700 ewk_view_setting_encoding_custom_set() has set a new custom encoding unconditionally despite new custom encoding is same with existing value. This patch sets only new custom encoding when new custom encoding value is different from existing value. 475254 1 109124 gyuyoung.kim 2011-09-28 23:37:23 -0700 Created attachment 109124 Patch 475393 2 109124 leandro 2011-09-29 06:18:52 -0700 Comment on attachment 109124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109124&action=review Although this check could be made inside the embedder, it is harmless enough to be inside EWK. The change looks fine, just a minor nit in the ChangeLog entry. > Source/WebKit/efl/ChangeLog:10 > + ewk_view_setting_encoding_custom_set() has set a new custom encoding unconditionally > + despite new custom encoding is same with existing value. This patch sets only new > + custom encoding when new custom encoding value is different from existing value. ewk_view_setting_encoding_custom_set() sets a new custom ... value, reloading the page even when not needed. This patch sets the custom encoding only when the new value differs from the current value. 475756 3 109221 gyuyoung.kim 2011-09-29 16:48:16 -0700 Created attachment 109221 Patch 475757 4 gyuyoung.kim 2011-09-29 16:49:52 -0700 Leandro, thank you for your comment. I modify ChangeLog again. 476066 5 109221 leandro 2011-09-30 06:50:01 -0700 Comment on attachment 109221 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109221&action=review > Source/WebKit/efl/ChangeLog:10 > + ewk_view_setting_encoding_custom_set() has set a new custom encoding value, reloading > + the page even when not needed. This patch sets the custom encoding only when new value > + differ. Sorry to nitpick, but I think something along the lines of "Only set the custom encoding value if it is different from the current value, to avoid reloading the page." would be more clear. 477344 6 109551 gyuyoung.kim 2011-10-03 16:52:49 -0700 Created attachment 109551 Patch 477345 7 gyuyoung.kim 2011-10-03 16:53:09 -0700 I modify it again. 477588 8 109551 leandro 2011-10-04 07:26:01 -0700 Comment on attachment 109551 Patch Informal r+. 478143 9 109551 morrita 2011-10-04 20:49:44 -0700 Comment on attachment 109551 Patch Rubberstamped. 478160 10 109551 webkit.review.bot 2011-10-04 21:55:15 -0700 Comment on attachment 109551 Patch Clearing flags on attachment: 109551 Committed r96676: <http://trac.webkit.org/changeset/96676> 478161 11 webkit.review.bot 2011-10-04 21:55:19 -0700 All reviewed patches have been landed. Closing bug. 109124 2011-09-28 23:37:23 -0700 2011-09-29 16:48:10 -0700 Patch bug-69061-20110929153723.patch text/plain 1886 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogOTYzMDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA3MzI1ZDUxYmIx NDZkMTRkMWU1ODg1YTUyMWE0YjViZmI3ZDJmM2ZhLi4xM2NmMjcxM2FmZmZlNzk2N2Q0ZTE2NDBj ZjVlOWIwZjlmNmNjNzI5IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEt MDktMjggIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAg ICBbRUZMXSBPbmx5IHNldCB3aGVuIHRoZSBjdXN0b20gZW5jb2RpbmcgaXMgZGlmZmVyZW50IGZy b20gZXhpc3RpbmcgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY5MDYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0KCkgaGFzIHNldCBh IG5ldyBjdXN0b20gZW5jb2RpbmcgdW5jb25kaXRpb25hbGx5CisgICAgICAgIGRlc3BpdGUgbmV3 IGN1c3RvbSBlbmNvZGluZyBpcyBzYW1lIHdpdGggZXhpc3RpbmcgdmFsdWUuIFRoaXMgcGF0Y2gg c2V0cyBvbmx5IG5ldworICAgICAgICBjdXN0b20gZW5jb2Rpbmcgd2hlbiBuZXcgY3VzdG9tIGVu Y29kaW5nIHZhbHVlIGlzIGRpZmZlcmVudCBmcm9tIGV4aXN0aW5nIHZhbHVlLgorCisgICAgICAg ICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X3NldHRpbmdfZW5jb2Rpbmdf Y3VzdG9tX3NldCk6CisKIDIwMTEtMDktMjggIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ft c3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gUmVtb3ZlIHVzZWxlc3MgYXNzaWdubWVudCBjb2Rl IGluIF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV96b29tX3NldF9pbnRlcm5hbC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDQ3ODY5YzY4YjM4MDhjYWQxMDQyMTZlYmFjYjNiZWYw ZTY1NjQ2YWQuLmFmNTZjODM5YmQyMTI4NDgxZmU3NzkyYjQ0MjUwZjNkYzcxOWE4MjMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtMjA3Nyw5ICsyMDc3LDggQEAgRWluYV9Cb29s IGV3a192aWV3X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX3NldChFdmFzX09iamVjdCogbywgY29u c3QgY2hhciogZW5jb2QKICAgICBFdmFzX09iamVjdCogbWFpbl9mcmFtZSA9IGV3a192aWV3X2Zy YW1lX21haW5fZ2V0KG8pOwogICAgIFdlYkNvcmU6OkZyYW1lKiBjb3JlX2ZyYW1lID0gZXdrX2Zy YW1lX2NvcmVfZ2V0KG1haW5fZnJhbWUpOwogICAgIERCRygiJXMiLCBlbmNvZGluZyk7Ci0gICAg ZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZwcml2LT5zZXR0aW5ncy5lbmNvZGluZ19jdXN0b20s IGVuY29kaW5nKTsKLSAgICBjb3JlX2ZyYW1lLT5sb2FkZXIoKS0+cmVsb2FkV2l0aE92ZXJyaWRl RW5jb2RpbmcoU3RyaW5nOjpmcm9tVVRGOChlbmNvZGluZykpOwotCisgICAgaWYgKGVpbmFfc3Ry aW5nc2hhcmVfcmVwbGFjZSgmcHJpdi0+c2V0dGluZ3MuZW5jb2RpbmdfY3VzdG9tLCBlbmNvZGlu ZykpCisgICAgICAgIGNvcmVfZnJhbWUtPmxvYWRlcigpLT5yZWxvYWRXaXRoT3ZlcnJpZGVFbmNv ZGluZyhTdHJpbmc6OmZyb21VVEY4KGVuY29kaW5nKSk7CiAgICAgcmV0dXJuIEVJTkFfVFJVRTsK IH0KIAo= 109221 2011-09-29 16:48:16 -0700 2011-10-03 16:52:42 -0700 Patch bug-69061-20110930084816.patch text/plain 1782 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogOTYzNzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA4ZWUyZmIxY2Qz ZjgwMzE3MTIzMzAzMGJjNGUzM2U0MDI2M2YwYzdkLi4wOGFiOGNjYWU3MTY0NjEyYzVlMjc1NzU0 NDRiMmUzYWU4ZWRhNWQ1IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEt MDktMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAg ICBbRUZMXSBPbmx5IHNldCB3aGVuIHRoZSBjdXN0b20gZW5jb2RpbmcgaXMgZGlmZmVyZW50IGZy b20gZXhpc3RpbmcgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY5MDYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0KCkgaGFzIHNldCBh IG5ldyBjdXN0b20gZW5jb2RpbmcgdmFsdWUsIHJlbG9hZGluZworICAgICAgICB0aGUgcGFnZSBl dmVuIHdoZW4gbm90IG5lZWRlZC4gVGhpcyBwYXRjaCBzZXRzIHRoZSBjdXN0b20gZW5jb2Rpbmcg b25seSB3aGVuIG5ldyB2YWx1ZQorICAgICAgICBkaWZmZXIuCisKKyAgICAgICAgKiBld2svZXdr X3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0 KToKKwogMjAxMS0wOS0yOSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9mdXNpb24u bW9iaT4KIAogICAgICAgICBbRUZMXSBBUEkgdG8gZ2V0IHBsYWluIHRleHQgb2YgdGhlIGZyYW1l CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA0Nzg2OWM2OGIzODA4Y2FkMTA0MjE2 ZWJhY2IzYmVmMGU2NTY0NmFkLi5hZjU2YzgzOWJkMjEyODQ4MWZlNzc5MmI0NDI1MGYzZGM3MTlh ODIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTIwNzcsOSArMjA3Nyw4IEBA IEVpbmFfQm9vbCBld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9zZXQoRXZhc19PYmpl Y3QqIG8sIGNvbnN0IGNoYXIqIGVuY29kCiAgICAgRXZhc19PYmplY3QqIG1haW5fZnJhbWUgPSBl d2tfdmlld19mcmFtZV9tYWluX2dldChvKTsKICAgICBXZWJDb3JlOjpGcmFtZSogY29yZV9mcmFt ZSA9IGV3a19mcmFtZV9jb3JlX2dldChtYWluX2ZyYW1lKTsKICAgICBEQkcoIiVzIiwgZW5jb2Rp bmcpOwotICAgIGVpbmFfc3RyaW5nc2hhcmVfcmVwbGFjZSgmcHJpdi0+c2V0dGluZ3MuZW5jb2Rp bmdfY3VzdG9tLCBlbmNvZGluZyk7Ci0gICAgY29yZV9mcmFtZS0+bG9hZGVyKCktPnJlbG9hZFdp dGhPdmVycmlkZUVuY29kaW5nKFN0cmluZzo6ZnJvbVVURjgoZW5jb2RpbmcpKTsKLQorICAgIGlm IChlaW5hX3N0cmluZ3NoYXJlX3JlcGxhY2UoJnByaXYtPnNldHRpbmdzLmVuY29kaW5nX2N1c3Rv bSwgZW5jb2RpbmcpKQorICAgICAgICBjb3JlX2ZyYW1lLT5sb2FkZXIoKS0+cmVsb2FkV2l0aE92 ZXJyaWRlRW5jb2RpbmcoU3RyaW5nOjpmcm9tVVRGOChlbmNvZGluZykpOwogICAgIHJldHVybiBF SU5BX1RSVUU7CiB9CiAK 109551 2011-10-03 16:52:49 -0700 2011-10-04 21:55:15 -0700 Patch bug-69061-20111004085250.patch text/plain 1696 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogOTY1NTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA2NDczOWM5MWY2 MjY4NjcxMTg0ZGY3ZmVlNzcyNzMzOTcyMmY0YTZhLi40ODYyMWViMzAxNmQ0MGVmODcwNWI5MjFl ZmI2YTRlNjQxYzM0ODM5IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MTAtMDMgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAg ICBbRUZMXSBPbmx5IHNldCB3aGVuIHRoZSBjdXN0b20gZW5jb2RpbmcgaXMgZGlmZmVyZW50IGZy b20gZXhpc3RpbmcgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY5MDYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgT25seSBzZXQgdGhlIGN1c3RvbSBlbmNvZGluZyB2YWx1ZSBpZiBpdCBpcyBkaWZm ZXJlbnQgZnJvbSB0aGUgY3VycmVudCB2YWx1ZSwgdG8gYXZvaWQKKyAgICAgICAgcmVsb2FkaW5n IHRoZSBwYWdlLgorCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192 aWV3X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX3NldCk6CisKIDIwMTEtMTAtMDMgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIFJlbmFtZSBld2tf dGlsZWRfKi5jIHRvIGV3a190aWxlZF8qLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAK aW5kZXggNTk5MDZlMzJmMTc4NjI5NTM4MWM1YjcwM2E2M2EyMDQ1NGJjZTQwZC4uYWNjNzVhNGE5 NzczZDc2NzFlZjkyMjljZDRlMTE1MTBjYTA3YjdmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3Zp ZXcuY3BwCkBAIC0yMDczLDkgKzIwNzMsOCBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfc2V0dGluZ19l bmNvZGluZ19jdXN0b21fc2V0KEV2YXNfT2JqZWN0KiBvLCBjb25zdCBjaGFyKiBlbmNvZAogICAg IEV2YXNfT2JqZWN0KiBtYWluX2ZyYW1lID0gZXdrX3ZpZXdfZnJhbWVfbWFpbl9nZXQobyk7CiAg ICAgV2ViQ29yZTo6RnJhbWUqIGNvcmVfZnJhbWUgPSBld2tfZnJhbWVfY29yZV9nZXQobWFpbl9m cmFtZSk7CiAgICAgREJHKCIlcyIsIGVuY29kaW5nKTsKLSAgICBlaW5hX3N0cmluZ3NoYXJlX3Jl cGxhY2UoJnByaXYtPnNldHRpbmdzLmVuY29kaW5nX2N1c3RvbSwgZW5jb2RpbmcpOwotICAgIGNv cmVfZnJhbWUtPmxvYWRlcigpLT5yZWxvYWRXaXRoT3ZlcnJpZGVFbmNvZGluZyhTdHJpbmc6OmZy b21VVEY4KGVuY29kaW5nKSk7Ci0KKyAgICBpZiAoZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZw cml2LT5zZXR0aW5ncy5lbmNvZGluZ19jdXN0b20sIGVuY29kaW5nKSkKKyAgICAgICAgY29yZV9m cmFtZS0+bG9hZGVyKCktPnJlbG9hZFdpdGhPdmVycmlkZUVuY29kaW5nKFN0cmluZzo6ZnJvbVVU RjgoZW5jb2RpbmcpKTsKICAgICByZXR1cm4gRUlOQV9UUlVFOwogfQogCg==