69056 2011-09-28 18:43:44 -0700 Check behavior of tabindex attribute with a large number 2011-10-20 23:52:28 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 68981 1 tkent tkent dbates oldest_to_newest 475172 0 tkent 2011-09-28 18:43:44 -0700 Bug 68981 exposed that we had never checked overflow of the attribute value. 476818 1 109444 tkent 2011-10-02 23:48:35 -0700 Created attachment 109444 Patch 484767 2 109444 dbates 2011-10-16 05:33:34 -0700 Comment on attachment 109444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109444&action=review > LayoutTests/fast/dom/tabindex-defaults.html:11 > +<div id="console"></div> > + > +<div id=container> Nit: This patch is inconsistent in its use of quotes around attribute values. I suggest picking one style for consistency. For example, on line 9 you put quotes around the attribute value of id, but on line 10 you don't. Similar inconsistencies can be seen in the rest of the HTML markup in this file. > LayoutTests/fast/dom/tabindex-defaults.html:31 > +var anchor = document.getElementById('a1'); > +var button = document.getElementById('b1'); > +var input = document.getElementById('i1'); > +var select = document.getElementById('s1'); > +var textarea = document.getElementById('t1'); > +var editableDiv = document.getElementById('e1'); > +var normalDiv = document.getElementById('u1'); This is fine as-is. For your consideration, I suggest renaming the ids of the elements to match these variable names. That is, rename "a1" to "anchor", rename "b1" to "button", and so forth. 488218 3 tkent 2011-10-20 23:51:32 -0700 Committed r98075: <http://trac.webkit.org/changeset/98075> 488219 4 tkent 2011-10-20 23:52:28 -0700 (In reply to comment #2) > (From update of attachment 109444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109444&action=review Thank you for your comments. I update the patch for your comments, and landed it. 109444 2011-10-02 23:48:35 -0700 2011-10-16 05:33:34 -0700 Patch bug-69056-20111003154834.patch text/plain 5445 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTY0ODIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4Y2U3YTlkM2RhNjY1ZGE4YWMyY2Nh MjEyMjI5Y2Y1M2VmZWEzYTQ1Li40Y2E4ZWVkZDE3NWZhMGViMmZkZmI2OGIxODI0MDcxYTRkZjM1 ZjIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMDIgIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBhIHRlc3QgdG8gY2hlY2sgYmVoYXZpb3Ig b2YgdGFiaW5kZXggYXR0cmlidXRlIHdpdGggYSBsYXJnZSBudW1iZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MDU2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjk2MjkwIGNoYW5nZWQgdGhlIGJlaGF2 aW9yIG9mIGludGVnZXIgcGFyc2luZyBzbyB0aGF0IGxhcmdlCisgICAgICAgIG51bWJlciBzdHJp bmdzIHdoaWNoIGNhbiBub3QgYmUgcmVwcmVzZW50ZWQgaW4gMzIgYml0IGludGVnZXJzCisgICAg ICAgIG1ha2VzIGFuIGVycm9yLiBCZWZvcmUgcjk2MjkwLCB3ZSBoYWQgYXNzdW1lZCBzdWNoIGxh cmdlIG51bWJlcnMKKyAgICAgICAgYXJlIGVxdWl2ZWxlbnQgdG8gMC4gV2UgYXNzdW1lIHRoZW0g aW52YWxpZCB2YWx1ZXMuCisKKyAgICAgICAgKiBmYXN0L2RvbS90YWJpbmRleC1kZWZhdWx0cy1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL3RhYmluZGV4LWRlZmF1bHRz Lmh0bWw6IEFkZGVkLgorCiAyMDExLTEwLTAyICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xv dWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWcgNjc0NTUgLSBEaWZmZXJlbnQgcmVndWxhciBl eHByZXNzaW9uIHJlc3VsdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vdGFiaW5k ZXgtZGVmYXVsdHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vdGFiaW5kZXgt ZGVmYXVsdHMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmJjNjBiYmI2NDlhMThhN2EwZDdjOTVl MDdhNDk5ZWY0NzU5NmY4ZDkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Rv bS90YWJpbmRleC1kZWZhdWx0cy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyNyBAQAorRGVmYXVs dCB2YWx1ZSBvZiB0YWJJbmRleCBJREwgYXR0cmlidXRlCisKK1BBU1MgYW5jaG9yLnRhYkluZGV4 IGlzIDAKK1BBU1MgYnV0dG9uLnRhYkluZGV4IGlzIDAKK1BBU1MgaW5wdXQudGFiSW5kZXggaXMg MAorUEFTUyBzZWxlY3QudGFiSW5kZXggaXMgMAorUEFTUyB0ZXh0YXJlYS50YWJJbmRleCBpcyAw CitQQVNTIGVkaXRhYmxlRGl2LnRhYkluZGV4IGlzIDAKK1BBU1Mgbm9ybWFsRGl2LnRhYkluZGV4 IGlzIC0xCitQQVNTIGFuY2hvci5zZXRBdHRyaWJ1dGUoInRhYmluZGV4IiwgImludmFsaWQiKTsg YW5jaG9yLnRhYkluZGV4IGlzIDAKK1BBU1MgYnV0dG9uLnNldEF0dHJpYnV0ZSgidGFiaW5kZXgi LCAiaW52YWxpZCIpOyBidXR0b24udGFiSW5kZXggaXMgMAorUEFTUyBpbnB1dC5zZXRBdHRyaWJ1 dGUoInRhYmluZGV4IiwgImludmFsaWQiKTsgaW5wdXQudGFiSW5kZXggaXMgMAorUEFTUyBzZWxl Y3Quc2V0QXR0cmlidXRlKCJ0YWJpbmRleCIsICJpbnZhbGlkIik7IHNlbGVjdC50YWJJbmRleCBp cyAwCitQQVNTIHRleHRhcmVhLnNldEF0dHJpYnV0ZSgidGFiaW5kZXgiLCAiaW52YWxpZCIpOyB0 ZXh0YXJlYS50YWJJbmRleCBpcyAwCitQQVNTIGVkaXRhYmxlRGl2LnNldEF0dHJpYnV0ZSgidGFi aW5kZXgiLCAiaW52YWxpZCIpOyBlZGl0YWJsZURpdi50YWJJbmRleCBpcyAwCitQQVNTIG5vcm1h bERpdi5zZXRBdHRyaWJ1dGUoInRhYmluZGV4IiwgImludmFsaWQiKTsgbm9ybWFsRGl2LnRhYklu ZGV4IGlzIC0xCitQQVNTIGFuY2hvci5zZXRBdHRyaWJ1dGUoInRhYmluZGV4IiwgIjk5OTk5OTk5 OTkiKTsgYW5jaG9yLnRhYkluZGV4IGlzIDAKK1BBU1MgYnV0dG9uLnNldEF0dHJpYnV0ZSgidGFi aW5kZXgiLCAiOTk5OTk5OTk5OSIpOyBidXR0b24udGFiSW5kZXggaXMgMAorUEFTUyBpbnB1dC5z ZXRBdHRyaWJ1dGUoInRhYmluZGV4IiwgIjk5OTk5OTk5OTkiKTsgaW5wdXQudGFiSW5kZXggaXMg MAorUEFTUyBzZWxlY3Quc2V0QXR0cmlidXRlKCJ0YWJpbmRleCIsICI5OTk5OTk5OTk5Iik7IHNl bGVjdC50YWJJbmRleCBpcyAwCitQQVNTIHRleHRhcmVhLnNldEF0dHJpYnV0ZSgidGFiaW5kZXgi LCAiOTk5OTk5OTk5OSIpOyB0ZXh0YXJlYS50YWJJbmRleCBpcyAwCitQQVNTIGVkaXRhYmxlRGl2 LnNldEF0dHJpYnV0ZSgidGFiaW5kZXgiLCAiOTk5OTk5OTk5OSIpOyBlZGl0YWJsZURpdi50YWJJ bmRleCBpcyAwCitQQVNTIG5vcm1hbERpdi5zZXRBdHRyaWJ1dGUoInRhYmluZGV4IiwgIjk5OTk5 OTk5OTkiKTsgbm9ybWFsRGl2LnRhYkluZGV4IGlzIC0xCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9kb20vdGFiaW5kZXgtZGVmYXVsdHMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3RhYmlu ZGV4LWRlZmF1bHRzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNGVlMmFjOWE4NGU5YTEwYzkwNzMxZDQ4MTJl ZWE4MTdmYTAzMGJhOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3Rh YmluZGV4LWRlZmF1bHRzLmh0bWwKQEAgLTAsMCArMSw2MiBAQAorPCFET0NUWVBFIEhUTUw+Cis8 aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9qcy9yZXNvdXJj ZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlv biI+RGVmYXVsdCB2YWx1ZSBvZiB0YWJJbmRleCBJREwgYXR0cmlidXRlPC9wPgorPGRpdiBpZD0i Y29uc29sZSI+PC9kaXY+CisKKzxkaXYgaWQ9Y29udGFpbmVyPgorPCEtLSBGb2N1c2FibGUgZWxl bWVudHMgLS0+Cis8YSBpZD1hMSBocmVmPSJ0YWJpbmRleC1kZWZhdWx0cy5odG1sIj5hbmNob3I8 L2E+Cis8YnV0dG9uIGlkPWIxPmJ1dHRvbjwvYnV0dG9uPgorPGlucHV0IGlkPWkxPgorPHNlbGVj dCBpZD1zMT48L3NlbGVjdD4KKzx0ZXh0YXJlYSBpZD10MT48L3RleHRhcmVhPgorPGRpdiBpZD1l MSBjb250ZW50ZWRpdGFibGU9dHJ1ZT48L2Rpdj4KKworPCEtLSBVbmZvY3VzYWJsZSBlbGVtZW50 IC0tPgorPGRpdiBpZD11MT48L2Rpdj4KKzwvZGl2PgorCis8c2NyaXB0PgordmFyIGFuY2hvciA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdhMScpOwordmFyIGJ1dHRvbiA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdiMScpOwordmFyIGlucHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2kxJyk7Cit2YXIgc2VsZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3MxJyk7Cit2YXIg dGV4dGFyZWEgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndDEnKTsKK3ZhciBlZGl0YWJsZURp diA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdlMScpOwordmFyIG5vcm1hbERpdiA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCd1MScpOworCitzaG91bGRCZSgnYW5jaG9yLnRhYkluZGV4Jywg JzAnKTsKK3Nob3VsZEJlKCdidXR0b24udGFiSW5kZXgnLCAnMCcpOworc2hvdWxkQmUoJ2lucHV0 LnRhYkluZGV4JywgJzAnKTsKK3Nob3VsZEJlKCdzZWxlY3QudGFiSW5kZXgnLCAnMCcpOworc2hv dWxkQmUoJ3RleHRhcmVhLnRhYkluZGV4JywgJzAnKTsKK3Nob3VsZEJlKCdlZGl0YWJsZURpdi50 YWJJbmRleCcsICcwJyk7CitzaG91bGRCZSgnbm9ybWFsRGl2LnRhYkluZGV4JywgJy0xJyk7CisK K3Nob3VsZEJlKCdhbmNob3Iuc2V0QXR0cmlidXRlKCJ0YWJpbmRleCIsICJpbnZhbGlkIik7IGFu Y2hvci50YWJJbmRleCcsICcwJyk7CitzaG91bGRCZSgnYnV0dG9uLnNldEF0dHJpYnV0ZSgidGFi aW5kZXgiLCAiaW52YWxpZCIpOyBidXR0b24udGFiSW5kZXgnLCAnMCcpOworc2hvdWxkQmUoJ2lu cHV0LnNldEF0dHJpYnV0ZSgidGFiaW5kZXgiLCAiaW52YWxpZCIpOyBpbnB1dC50YWJJbmRleCcs ICcwJyk7CitzaG91bGRCZSgnc2VsZWN0LnNldEF0dHJpYnV0ZSgidGFiaW5kZXgiLCAiaW52YWxp ZCIpOyBzZWxlY3QudGFiSW5kZXgnLCAnMCcpOworc2hvdWxkQmUoJ3RleHRhcmVhLnNldEF0dHJp YnV0ZSgidGFiaW5kZXgiLCAiaW52YWxpZCIpOyB0ZXh0YXJlYS50YWJJbmRleCcsICcwJyk7Citz aG91bGRCZSgnZWRpdGFibGVEaXYuc2V0QXR0cmlidXRlKCJ0YWJpbmRleCIsICJpbnZhbGlkIik7 IGVkaXRhYmxlRGl2LnRhYkluZGV4JywgJzAnKTsKK3Nob3VsZEJlKCdub3JtYWxEaXYuc2V0QXR0 cmlidXRlKCJ0YWJpbmRleCIsICJpbnZhbGlkIik7IG5vcm1hbERpdi50YWJJbmRleCcsICctMScp OworCitzaG91bGRCZSgnYW5jaG9yLnNldEF0dHJpYnV0ZSgidGFiaW5kZXgiLCAiOTk5OTk5OTk5 OSIpOyBhbmNob3IudGFiSW5kZXgnLCAnMCcpOworc2hvdWxkQmUoJ2J1dHRvbi5zZXRBdHRyaWJ1 dGUoInRhYmluZGV4IiwgIjk5OTk5OTk5OTkiKTsgYnV0dG9uLnRhYkluZGV4JywgJzAnKTsKK3No b3VsZEJlKCdpbnB1dC5zZXRBdHRyaWJ1dGUoInRhYmluZGV4IiwgIjk5OTk5OTk5OTkiKTsgaW5w dXQudGFiSW5kZXgnLCAnMCcpOworc2hvdWxkQmUoJ3NlbGVjdC5zZXRBdHRyaWJ1dGUoInRhYmlu ZGV4IiwgIjk5OTk5OTk5OTkiKTsgc2VsZWN0LnRhYkluZGV4JywgJzAnKTsKK3Nob3VsZEJlKCd0 ZXh0YXJlYS5zZXRBdHRyaWJ1dGUoInRhYmluZGV4IiwgIjk5OTk5OTk5OTkiKTsgdGV4dGFyZWEu dGFiSW5kZXgnLCAnMCcpOworc2hvdWxkQmUoJ2VkaXRhYmxlRGl2LnNldEF0dHJpYnV0ZSgidGFi aW5kZXgiLCAiOTk5OTk5OTk5OSIpOyBlZGl0YWJsZURpdi50YWJJbmRleCcsICcwJyk7CitzaG91 bGRCZSgnbm9ybWFsRGl2LnNldEF0dHJpYnV0ZSgidGFiaW5kZXgiLCAiOTk5OTk5OTk5OSIpOyBu b3JtYWxEaXYudGFiSW5kZXgnLCAnLTEnKTsKKworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2Nv bnRhaW5lcicpLmlubmVySFRNTCA9ICcnOwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7 Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K