69055 2011-09-28 18:42:41 -0700 Check behavior of border attribute with a large number 2011-10-21 01:23:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 68981 1 tkent tkent dbates oldest_to_newest 475171 0 tkent 2011-09-28 18:42:41 -0700 Bug 68981 exposed that we had never checked overflow of the attribute value. 476833 1 109448 tkent 2011-10-03 00:43:36 -0700 Created attachment 109448 Patch 484768 2 109448 dbates 2011-10-16 05:43:33 -0700 Comment on attachment 109448 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109448&action=review > LayoutTests/fast/dom/HTMLImageElement/image-with-invalid-border-expected.html:3 > +<p>Img elements with invalid border attribute should have the same appearnace with an img element without border attribute.</p> appearnace => appearance "with an" => "as an" > LayoutTests/fast/dom/HTMLImageElement/image-with-invalid-border.html:3 > +<p>Img elements with invalid border attribute should have the same appearnace with an img element without border attribute.</p> Ditto. > LayoutTests/fast/dom/HTMLImageElement/image-with-invalid-border.html:5 > +<img src="resources/blue_rect.jpg" border=invalid> > +<img src="resources/blue_rect.jpg" border=9999999999> Nit: This is OK as-is. For your consideration, I suggest putting quotes around the attribute value for border so to be consistent with the quoting of the attribute value src. Throughout this patch there is an inconsistent quoting style for attribute values. I suggest choosing a style for consistency. > LayoutTests/fast/dom/HTMLInputElement/input-with-invalid-border-expected.html:3 > +<p>Image input elements with invalid border attribute should have the same appearnace with an image input element without border attribute.</p> Ditto. > LayoutTests/fast/dom/HTMLInputElement/input-with-invalid-border.html:3 > +<p>Image input elements with invalid border attribute should have the same appearnace with an image input element without border attribute.</p> Ditto. > LayoutTests/fast/dom/HTMLObjectElement/object-with-invalid-border-expected.html:3 > +<p>Object elements with invalid border attribute should have the same appearnace with an object element without border attribute.</p> Ditto. > LayoutTests/fast/dom/HTMLObjectElement/object-with-invalid-border.html:3 > +<p>Object elements with invalid border attribute should have the same appearnace with an object element without border attribute.</p> Ditto. 488250 3 tkent 2011-10-21 01:19:58 -0700 Daniel, thank you for reviewing. I'll follow your comments and land the patch. 488254 4 tkent 2011-10-21 01:23:14 -0700 Committed r98083: <http://trac.webkit.org/changeset/98083> 109448 2011-10-03 00:43:36 -0700 2011-10-16 05:43:32 -0700 Patch bug-69055-20111003164335.patch text/plain 5173 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTY0ODIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4Y2U3YTlkM2RhNjY1ZGE4YWMyY2Nh MjEyMjI5Y2Y1M2VmZWEzYTQ1Li42Nzk5N2NlZDQ1ZmM4MDQzOWQ5NjMxMjJhOGQyZjkwNGQ3MzIw ZjNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMTAtMDMgIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCB0ZXN0cyB0byBjaGVjayBiZWhhdmlvciBv ZiBib3JkZXIgYXR0cmlidXRlIHdpdGggYSBsYXJnZSBudW1iZXIgb3IgYW4gaW52YWxpZCB2YWx1 ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MDU1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjk2Mjkw IGNoYW5nZWQgdGhlIGJlaGF2aW9yIG9mIGludGVnZXIgcGFyc2luZyBzbyB0aGF0IGxhcmdlCisg ICAgICAgIG51bWJlciBzdHJpbmdzIHdoaWNoIGNhbiBub3QgYmUgcmVwcmVzZW50ZWQgaW4gMzIg Yml0IGludGVnZXJzCisgICAgICAgIG1ha2VzIGFuIGVycm9yLiBIb3dldmVyLCBib3JkZXIgYXR0 cmlidXRlIGJlaGF2aW9yIHdhc24ndCBjaGFuZ2VkCisgICAgICAgIGJ5IHI5NjI5MCBiZWNhdXNl IGl0cyBkZWZhdWx0IHZhbHVlIGlzIDAgYW5kCisgICAgICAgIHBhcnNlSFRNTE5vbk5lZ2F0aXZl SW50ZWdlcigpIGhhZCBzZXQgMCBpbiBhIGNhc2Ugb2Ygb3ZlcmZsb3cuCisKKyAgICAgICAgKiBm YXN0L2RvbS9IVE1MSW1hZ2VFbGVtZW50L2ltYWdlLXdpdGgtaW52YWxpZC1ib3JkZXItZXhwZWN0 ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTEltYWdlRWxlbWVudC9pbWFn ZS13aXRoLWludmFsaWQtYm9yZGVyLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hU TUxJbnB1dEVsZW1lbnQvaW5wdXQtd2l0aC1pbnZhbGlkLWJvcmRlci1leHBlY3RlZC5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2lucHV0LXdpdGgtaW52 YWxpZC1ib3JkZXIuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTE9iamVjdEVs ZW1lbnQvb2JqZWN0LXdpdGgtaW52YWxpZC1ib3JkZXItZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisg ICAgICAgICogZmFzdC9kb20vSFRNTE9iamVjdEVsZW1lbnQvb2JqZWN0LXdpdGgtaW52YWxpZC1i b3JkZXIuaHRtbDogQWRkZWQuCisKIDIwMTEtMTAtMDIgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFy cmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1ZyA2NzQ1NSAtIERpZmZlcmVudCByZWd1 bGFyIGV4cHJlc3Npb24gcmVzdWx0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9I VE1MSW1hZ2VFbGVtZW50L2ltYWdlLXdpdGgtaW52YWxpZC1ib3JkZXItZXhwZWN0ZWQuaHRtbCBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxJbWFnZUVsZW1lbnQvaW1hZ2Utd2l0aC1pbnZhbGlk LWJvcmRlci1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjRmMTBlMzI2ZTI5ZjgyNzg5NjY0MDM4 YjkzMTUyYjI0ZGJjNGNlZTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Rv bS9IVE1MSW1hZ2VFbGVtZW50L2ltYWdlLXdpdGgtaW52YWxpZC1ib3JkZXItZXhwZWN0ZWQuaHRt bApAQCAtMCwwICsxLDYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGJvZHk+Cis8cD5JbWcgZWxlbWVu dHMgd2l0aCBpbnZhbGlkIGJvcmRlciBhdHRyaWJ1dGUgc2hvdWxkIGhhdmUgdGhlIHNhbWUgYXBw ZWFybmFjZSB3aXRoIGFuIGltZyBlbGVtZW50IHdpdGhvdXQgYm9yZGVyIGF0dHJpYnV0ZS48L3A+ Cis8aW1nIHNyYz0icmVzb3VyY2VzL2JsdWVfcmVjdC5qcGciPgorPGltZyBzcmM9InJlc291cmNl cy9ibHVlX3JlY3QuanBnIj4KKzwvYm9keT4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL0hUTUxJbWFnZUVsZW1lbnQvaW1hZ2Utd2l0aC1pbnZhbGlkLWJvcmRlci5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vSFRNTEltYWdlRWxlbWVudC9pbWFnZS13aXRoLWludmFsaWQtYm9y ZGVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uN2ViY2MzMWExMGU1YWQxNzg4ZWJkODM0MmU1MmUzMjk2YzI0 NjUzMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxJbWFnZUVs ZW1lbnQvaW1hZ2Utd2l0aC1pbnZhbGlkLWJvcmRlci5odG1sCkBAIC0wLDAgKzEsNiBAQAorPCFE T0NUWVBFIGh0bWw+Cis8Ym9keT4KKzxwPkltZyBlbGVtZW50cyB3aXRoIGludmFsaWQgYm9yZGVy IGF0dHJpYnV0ZSBzaG91bGQgaGF2ZSB0aGUgc2FtZSBhcHBlYXJuYWNlIHdpdGggYW4gaW1nIGVs ZW1lbnQgd2l0aG91dCBib3JkZXIgYXR0cmlidXRlLjwvcD4KKzxpbWcgc3JjPSJyZXNvdXJjZXMv Ymx1ZV9yZWN0LmpwZyIgYm9yZGVyPWludmFsaWQ+Cis8aW1nIHNyYz0icmVzb3VyY2VzL2JsdWVf cmVjdC5qcGciIGJvcmRlcj05OTk5OTk5OTk5PgorPC9ib2R5PgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9pbnB1dC13aXRoLWludmFsaWQtYm9yZGVy LWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2lu cHV0LXdpdGgtaW52YWxpZC1ib3JkZXItZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45MWY5ODM5 YTQ4MTVmYWY4Mjg3OTg2MmU2YjlhZjhmYTYwYWZiZjU3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9pbnB1dC13aXRoLWludmFsaWQtYm9y ZGVyLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw2IEBACis8IURPQ1RZUEUgaHRtbD4KKzxib2R5 PgorPHA+SW1hZ2UgaW5wdXQgZWxlbWVudHMgd2l0aCBpbnZhbGlkIGJvcmRlciBhdHRyaWJ1dGUg c2hvdWxkIGhhdmUgdGhlIHNhbWUgYXBwZWFybmFjZSB3aXRoIGFuIGltYWdlIGlucHV0IGVsZW1l bnQgd2l0aG91dCBib3JkZXIgYXR0cmlidXRlLjwvcD4KKzxpbnB1dCB0eXBlPWltYWdlPgorPGlu cHV0IHR5cGU9aW1hZ2U+Cis8L2JvZHk+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Rv bS9IVE1MSW5wdXRFbGVtZW50L2lucHV0LXdpdGgtaW52YWxpZC1ib3JkZXIuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvaW5wdXQtd2l0aC1pbnZhbGlkLWJvcmRl ci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjJjN2VhMmZmNjAwODc0NzlkZDM0YjEwYjY5YTcxN2U2OTU5ODk1 N2YKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRFbGVt ZW50L2lucHV0LXdpdGgtaW52YWxpZC1ib3JkZXIuaHRtbApAQCAtMCwwICsxLDYgQEAKKzwhRE9D VFlQRSBodG1sPgorPGJvZHk+Cis8cD5JbWFnZSBpbnB1dCBlbGVtZW50cyB3aXRoIGludmFsaWQg Ym9yZGVyIGF0dHJpYnV0ZSBzaG91bGQgaGF2ZSB0aGUgc2FtZSBhcHBlYXJuYWNlIHdpdGggYW4g aW1hZ2UgaW5wdXQgZWxlbWVudCB3aXRob3V0IGJvcmRlciBhdHRyaWJ1dGUuPC9wPgorPGlucHV0 IHR5cGU9aW1hZ2UgYm9yZGVyPWludmFsaWQ+Cis8aW5wdXQgdHlwZT1pbWFnZSBib3JkZXI9OTk5 OTk5OTk5OT4KKzwvYm9keT4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxP YmplY3RFbGVtZW50L29iamVjdC13aXRoLWludmFsaWQtYm9yZGVyLWV4cGVjdGVkLmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MT2JqZWN0RWxlbWVudC9vYmplY3Qtd2l0aC1pbnZhbGlk LWJvcmRlci1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjRlYjlkMDkxZGEwMzFhZjk0Y2ZmMDQ4 ZDU2ZTEyMjc2ZDRjYWJkMmQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Rv bS9IVE1MT2JqZWN0RWxlbWVudC9vYmplY3Qtd2l0aC1pbnZhbGlkLWJvcmRlci1leHBlY3RlZC5o dG1sCkBAIC0wLDAgKzEsNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8Ym9keT4KKzxwPk9iamVjdCBl bGVtZW50cyB3aXRoIGludmFsaWQgYm9yZGVyIGF0dHJpYnV0ZSBzaG91bGQgaGF2ZSB0aGUgc2Ft ZSBhcHBlYXJuYWNlIHdpdGggYW4gb2JqZWN0IGVsZW1lbnQgd2l0aG91dCBib3JkZXIgYXR0cmli dXRlLjwvcD4KKzxvYmplY3Q+PC9vYmplY3Q+Cis8b2JqZWN0Pjwvb2JqZWN0PgorPC9ib2R5Pgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTE9iamVjdEVsZW1lbnQvb2JqZWN0 LXdpdGgtaW52YWxpZC1ib3JkZXIuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxPYmpl Y3RFbGVtZW50L29iamVjdC13aXRoLWludmFsaWQtYm9yZGVyLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTdl NDZmNzkwNWZjZmExZDM4MzYyMTQ5ZThmZmM0NjNhMWJiNmVkNQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxPYmplY3RFbGVtZW50L29iamVjdC13aXRoLWludmFs aWQtYm9yZGVyLmh0bWwKQEAgLTAsMCArMSw2IEBACis8IURPQ1RZUEUgaHRtbD4KKzxib2R5Pgor PHA+T2JqZWN0IGVsZW1lbnRzIHdpdGggaW52YWxpZCBib3JkZXIgYXR0cmlidXRlIHNob3VsZCBo YXZlIHRoZSBzYW1lIGFwcGVhcm5hY2Ugd2l0aCBhbiBvYmplY3QgZWxlbWVudCB3aXRob3V0IGJv cmRlciBhdHRyaWJ1dGUuPC9wPgorPG9iamVjdCBib3JkZXI9aW52YWxpZD48L29iamVjdD4KKzxv YmplY3QgYm9yZGVyPTk5OTk5OTk5OTk+PC9vYmplY3Q+Cis8L2JvZHk+Cg==