69054 2011-09-28 18:16:45 -0700 JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor 2011-09-29 00:51:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough webkit.review.bot oldest_to_newest 475158 0 yuqiang.xian 2011-09-28 18:16:45 -0700 size_t is equal to uint32_t on most 32-bit platforms, except for Mac OS. 475160 1 109110 yuqiang.xian 2011-09-28 18:20:00 -0700 Created attachment 109110 proposed patch 475261 2 109110 barraclough 2011-09-28 23:46:42 -0700 Comment on attachment 109110 proposed patch Maybe we should just do away with this constructor - could be worth examining it's uses, I think in many cases the arguments might make more sense as size_t's (e.g. subscripts to arrays in CodeBlock). But seems sensible for now. 475297 3 109110 webkit.review.bot 2011-09-29 00:51:55 -0700 Comment on attachment 109110 proposed patch Clearing flags on attachment: 109110 Committed r96309: <http://trac.webkit.org/changeset/96309> 475298 4 webkit.review.bot 2011-09-29 00:51:59 -0700 All reviewed patches have been landed. Closing bug. 109110 2011-09-28 18:20:00 -0700 2011-09-29 00:51:55 -0700 proposed patch 69054.patch text/plain 1392 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTYyODIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDktMjggIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgSlNWQUxVRTMyXzY0IERGRyBKSVQgZmFpbGVkIHRvIGJlIGJ1aWx0IG9uIDMyLWJpdCBM aW51eCBkdWUgdG8gaW5jb3JyZWN0IG92ZXJsb2FkZWQgT3BJbmZvIGNvbnN0cnVjdG9yCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTA1NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHNpemVfdCBpcyBlcXVh bCB0byB1aW50MzJfdCBvbiBtb3N0IDMyLWJpdCBwbGF0Zm9ybXMsIGV4Y2VwdCBmb3IgTWFjIE9T LgorCisgICAgICAgICogZGZnL0RGR05vZGUuaDoKKwogMjAxMS0wOS0yOCAgRmlsaXAgUGl6bG8g IDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIERGRyBKSVQgZmFsbHMgYmFjayBvbiBudW1l cmljYWwgY29tcGFyaXNvbnMgd2hlbiBpdCBkb2VzIG5vdApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdOb2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdOb2RlLmgJKHJldmlzaW9uIDk2MjgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdOb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTM0Miw3ICszNDIsOSBAQCBlbnVtIE5v ZGVUeXBlIHsKIHN0cnVjdCBPcEluZm8gewogICAgIGV4cGxpY2l0IE9wSW5mbyhpbnQzMl90IHZh bHVlKSA6IG1fdmFsdWUoc3RhdGljX2Nhc3Q8dWludHB0cl90Pih2YWx1ZSkpIHsgfQogICAgIGV4 cGxpY2l0IE9wSW5mbyh1aW50MzJfdCB2YWx1ZSkgOiBtX3ZhbHVlKHN0YXRpY19jYXN0PHVpbnRw dHJfdD4odmFsdWUpKSB7IH0KKyNpZiBPUyhEQVJXSU4pIHx8IFVTRShKU1ZBTFVFNjQpCiAgICAg ZXhwbGljaXQgT3BJbmZvKHNpemVfdCB2YWx1ZSkgOiBtX3ZhbHVlKHN0YXRpY19jYXN0PHVpbnRw dHJfdD4odmFsdWUpKSB7IH0KKyNlbmRpZgogICAgIGV4cGxpY2l0IE9wSW5mbyh2b2lkKiB2YWx1 ZSkgOiBtX3ZhbHVlKHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90Pih2YWx1ZSkpIHsgfQogICAg IHVpbnRwdHJfdCBtX3ZhbHVlOwogfTsK