6905 2006-01-28 23:16:14 -0800 DumpRenderTree needs a way to force painting (to allow invalidation tests) 2006-04-23 12:18:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric webkit-unassigned ap justin.garcia mitz oldest_to_newest 30477 0 eric 2006-01-28 23:16:14 -0800 DumpRenderTree needs a way to force painting (to allow invalidation tests) 39916 1 7850 mitz 2006-04-20 08:36:00 -0700 Created attachment 7850 Patch 39917 2 7850 darin 2006-04-20 09:25:02 -0700 Comment on attachment 7850 Patch Looks like a good start. 39918 3 7850 darin 2006-04-20 09:26:15 -0700 Comment on attachment 7850 Patch To be more clear what I mean about that, I think eventually we want to come up with a testing approach that detects if we repaint too much as well as something that detects when we repaint too little. 40132 4 mitz 2006-04-22 01:32:43 -0700 (In reply to comment #3) > (From update of attachment 7850 [edit]) > To be more clear what I mean about that, I think eventually we want to come up > with a testing approach that detects if we repaint too much as well as > something that detects when we repaint too little. > Something like - (void)display { NSView *webView = [frame webView]; [webView display]; [webView lockFocus]; [[NSColor blackColor] set]; NSRectFill([webView frame]); [webView unlockFocus]; readFromWindow = YES; } Will let you see exactly what was repainted (except if it was black). 40134 5 mitz 2006-04-22 01:52:35 -0700 (In reply to comment #4) > [[NSColor blackColor] set]; or perhaps better yet, [[[NSColor blackColor] colorWithAlphaComponent:0.5] set]; 7850 2006-04-20 08:36:00 -0700 2006-04-20 09:25:02 -0700 Patch 6905_r1.patch text/plain 3353 mitz SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzOTg2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDYtIyMtIyMgIE1pdHogUGV0dGVsICA8b3Bl bmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgLSBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hv d19idWcuY2dpP2lkPTY5MDUKKyAgICAgICAgICBEdW1wUmVuZGVyVHJlZSBuZWVkcyBhIHdheSB0 byBmb3JjZSBwYWludGluZyAodG8gYWxsb3cgaW52YWxpZGF0aW9uIHRlc3RzKQorCisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUubToKKyAgICAgICAgKGR1bXApOiBJZiBk aXNwbGF5KCkgaGFzIGJlZW4gY2FsbGVkIGR1cmluZyB0aGUgdGVzdCwgZ3JhYiB0aGUgcGl4ZWxz IGZyb20KKyAgICAgICAgdGhlIHZpZXcsIGFmdGVyIGxldHRpbmcgaXQgcmVwYWludCBpbnZhbGlk YXRlZCByZWN0cy4KKyAgICAgICAgKCtbTGF5b3V0VGVzdENvbnRyb2xsZXIgaXNTZWxlY3RvckV4 Y2x1ZGVkRnJvbVdlYlNjcmlwdDpdKToKKyAgICAgICAgKC1bTGF5b3V0VGVzdENvbnRyb2xsZXIg ZGlzcGxheV0pOiBBZGRlZC4gQ2FsbHMgLWRpc3BsYXkgb24gdGhlIHZpZXcKKyAgICAgICAgYW5k IGNoYW5nZXMgdGhlIHN1YnNlcXVlbnQgYmVoYXZpb3Igb2YgZHVtcCgpLgorICAgICAgICAoZHVt cFJlbmRlclRyZWUpOgorCiAyMDA2LTA0LTE4ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNv bT4KIAogICAgICAgICAtIGF0dGVtcHQgdG8gZml4IFdpbmRvd3MgYnVpbGRib3QKSW5kZXg6IFdl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLm0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUubQkocmV2aXNpb24gMTM5 ODYpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5tCSh3b3Jr aW5nIGNvcHkpCkBAIC04Niw2ICs4Niw3IEBAIHN0YXRpYyBCT09MIGR1bXBTZWxlY3Rpb25SZWN0 Owogc3RhdGljIEJPT0wgZHVtcFRpdGxlQ2hhbmdlczsKIHN0YXRpYyBpbnQgZHVtcFBpeGVscyA9 IE5POwogc3RhdGljIGludCBkdW1wQWxsUGl4ZWxzID0gTk87CitzdGF0aWMgQk9PTCByZWFkRnJv bVdpbmRvdyA9IE5POwogc3RhdGljIGludCB0ZXN0UmVwYWludERlZmF1bHQgPSBOTzsKIHN0YXRp YyBCT09MIHRlc3RSZXBhaW50ID0gTk87CiBzdGF0aWMgaW50IHJlcGFpbnRTd2VlcEhvcml6b250 YWxseURlZmF1bHQgPSBOTzsKQEAgLTM5Nyw3ICszOTgsMTUgQEAgc3RhdGljIHZvaWQgZHVtcCh2 b2lkKQogICAgICAgICAgICAgTlNHcmFwaGljc0NvbnRleHQqIG5zQ29udGV4dCA9IFtOU0dyYXBo aWNzQ29udGV4dCBncmFwaGljc0NvbnRleHRXaXRoR3JhcGhpY3NQb3J0OmNnQ29udGV4dCBmbGlw cGVkOk5PXTsKICAgICAgICAgICAgIFtOU0dyYXBoaWNzQ29udGV4dCBzZXRDdXJyZW50Q29udGV4 dDpuc0NvbnRleHRdOwogCi0gICAgICAgICAgICBpZiAoIXRlc3RSZXBhaW50KQorICAgICAgICAg ICAgaWYgKHJlYWRGcm9tV2luZG93KSB7CisgICAgICAgICAgICAgICAgTlNCaXRtYXBJbWFnZVJl cCAqaW1hZ2VSZXA7CisgICAgICAgICAgICAgICAgW3ZpZXcgZGlzcGxheUlmTmVlZGVkXTsKKyAg ICAgICAgICAgICAgICBbdmlldyBsb2NrRm9jdXNdOworICAgICAgICAgICAgICAgIGltYWdlUmVw ID0gW1tOU0JpdG1hcEltYWdlUmVwIGFsbG9jXSBpbml0V2l0aEZvY3VzZWRWaWV3UmVjdDpbdmll dyBmcmFtZV1dOworICAgICAgICAgICAgICAgIFt2aWV3IHVubG9ja0ZvY3VzXTsKKyAgICAgICAg ICAgICAgICBbaW1hZ2VSZXAgZHJhd107CisgICAgICAgICAgICAgICAgW2ltYWdlUmVwIHJlbGVh c2VdOworICAgICAgICAgICAgfSBlbHNlIGlmICghdGVzdFJlcGFpbnQpCiAgICAgICAgICAgICAg ICAgW3ZpZXcgZGlzcGxheVJlY3RJZ25vcmluZ09wYWNpdHk6TlNNYWtlUmVjdCgwLCAwLCB3ZWJW aWV3U2l6ZS53aWR0aCwgd2ViVmlld1NpemUuaGVpZ2h0KSBpbkNvbnRleHQ6bnNDb250ZXh0XTsK ICAgICAgICAgICAgIGVsc2UgaWYgKCFyZXBhaW50U3dlZXBIb3Jpem9udGFsbHkpIHsKICAgICAg ICAgICAgICAgICBOU1JlY3QgbGluZSA9IE5TTWFrZVJlY3QoMCwgMCwgd2ViVmlld1NpemUud2lk dGgsIDEpOwpAQCAtNTc4LDYgKzU4Nyw3IEBAIHN0YXRpYyB2b2lkIGR1bXAodm9pZCkKICAgICAg ICAgICAgIHx8IGFTZWxlY3RvciA9PSBAc2VsZWN0b3Ioc2V0V2luZG93SXNLZXk6KQogICAgICAg ICAgICAgfHwgYVNlbGVjdG9yID09IEBzZWxlY3RvcihzZXRNYWluRnJhbWVJc0ZpcnN0UmVzcG9u ZGVyOikKICAgICAgICAgICAgIHx8IGFTZWxlY3RvciA9PSBAc2VsZWN0b3IoZHVtcFNlbGVjdGlv blJlY3QpCisgICAgICAgICAgICB8fCBhU2VsZWN0b3IgPT0gQHNlbGVjdG9yKGRpc3BsYXkpCiAg ICAgICAgICAgICB8fCBhU2VsZWN0b3IgPT0gQHNlbGVjdG9yKHRlc3RSZXBhaW50KQogICAgICAg ICAgICAgfHwgYVNlbGVjdG9yID09IEBzZWxlY3RvcihyZXBhaW50U3dlZXBIb3Jpem9udGFsbHkp KQogICAgICAgICByZXR1cm4gTk87CkBAIC02MzksNiArNjQ5LDEyIEBAIHN0YXRpYyB2b2lkIGR1 bXAodm9pZCkKICAgICAgICAgWyhXZWJIVE1MVmlldyAqKWRvY3VtZW50VmlldyBfdXBkYXRlRm9j dXNTdGF0ZV07CiB9CiAKKy0gKHZvaWQpZGlzcGxheQoreworICAgIFtbZnJhbWUgd2ViVmlld10g ZGlzcGxheV07CisgICAgcmVhZEZyb21XaW5kb3cgPSBZRVM7Cit9CisKIC0gKHZvaWQpdGVzdFJl cGFpbnQKIHsKICAgICB0ZXN0UmVwYWludCA9IFlFUzsKQEAgLTY4Miw2ICs2OTgsNyBAQCBzdGF0 aWMgdm9pZCBkdW1wUmVuZGVyVHJlZShjb25zdCBjaGFyICpwCiAgICAgZHVtcEFzVGV4dCA9IE5P OwogICAgIGR1bXBTZWxlY3Rpb25SZWN0ID0gTk87CiAgICAgZHVtcFRpdGxlQ2hhbmdlcyA9IE5P OworICAgIHJlYWRGcm9tV2luZG93ID0gTk87CiAgICAgdGVzdFJlcGFpbnQgPSB0ZXN0UmVwYWlu dERlZmF1bHQ7CiAgICAgcmVwYWludFN3ZWVwSG9yaXpvbnRhbGx5ID0gcmVwYWludFN3ZWVwSG9y aXpvbnRhbGx5RGVmYXVsdDsKICAgICBpZiAoY3VycmVudFRlc3QgIT0gbmlsKQo=