69042 2011-09-28 17:07:54 -0700 Remove unused createRootLayerPainter from CCLayerTreeHostClient 2011-09-28 18:28:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 piman webkit-unassigned jamesr webkit.review.bot oldest_to_newest 475095 0 piman 2011-09-28 17:07:54 -0700 Remove unused createRootLayerPainter from CCLayerTreeHostClient 475099 1 109097 piman 2011-09-28 17:08:41 -0700 Created attachment 109097 Patch 475117 2 jamesr 2011-09-28 17:28:04 -0700 Feel free to kill the implementations too: Source/WebKit/chromium/src/WebViewImpl.cpp Source/WebKit/chromium/src/WebViewImpl.h Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 475128 3 109104 piman 2011-09-28 17:47:48 -0700 Created attachment 109104 Patch 475130 4 piman 2011-09-28 17:48:40 -0700 (In reply to comment #2) > Feel free to kill the implementations too: > > Source/WebKit/chromium/src/WebViewImpl.cpp > Source/WebKit/chromium/src/WebViewImpl.h > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp Gone in latest patch. 475132 5 109104 jamesr 2011-09-28 17:49:42 -0700 Comment on attachment 109104 Patch Out, out vile dead code! 475163 6 109104 webkit.review.bot 2011-09-28 18:28:00 -0700 Comment on attachment 109104 Patch Clearing flags on attachment: 109104 Committed r96283: <http://trac.webkit.org/changeset/96283> 475164 7 webkit.review.bot 2011-09-28 18:28:03 -0700 All reviewed patches have been landed. Closing bug. 109097 2011-09-28 17:08:41 -0700 2011-09-28 17:47:44 -0700 Patch bug-69042-20110928170840.patch text/plain 1550 piman U3VidmVyc2lvbiBSZXZpc2lvbjogOTYyNjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMDgwYzgwMDAyZTFkNTIz MjcyYjM3NDZkZWVkNGRkZWZiYTVjZjZiLi41MzkwZDAzYjdlZjE1MTYyMjNlMzIxYjE0MmUwMDQ0 NjQ2NjYwNjhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMjggIEFudG9p bmUgTGFib3VyICA8cGltYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQg Y3JlYXRlUm9vdExheWVyUGFpbnRlciBmcm9tIENDTGF5ZXJUcmVlSG9zdENsaWVudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkwNDIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdCBuZWVk ZWQ6IG5vIHNlbWFudGljIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5oOgorCiAyMDExLTA5LTI4ICBTZXJnZXkgR2xhenVu b3YgIDxzZXJnLmdsYXp1bm92QGdtYWlsLmNvbT4KIAogICAgICAgICBKYXZhU2NyaXB0IGdlbmVy YXRlZCBkb2N1bWVudHMgZG9uJ3QgaW5oZXJpdCB0aGUgY29va2llIFVSTApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVI b3N0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xh eWVyVHJlZUhvc3QuaAppbmRleCBjOTA1MDk0MzkyNjc1ZjFlNjNlMTg1NzczOTRjYTYyZjQzMjQy MWUzLi41NGFkNGMwMDIyMjk2ZGY3ZThiMTZlNjcyMDA5MDVhN2I3ZDRlNTIyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJl ZUhvc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9j Yy9DQ0xheWVyVHJlZUhvc3QuaApAQCAtNTMsNyArNTMsNiBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIGFuaW1hdGVBbmRMYXlvdXQoZG91YmxlIGZyYW1lQmVnaW5UaW1lKSA9IDA7CiAgICAg dmlydHVhbCBQYXNzT3duUHRyPENDVGhyZWFkPiBjcmVhdGVDb21wb3NpdG9yVGhyZWFkKCkgPSAw OwogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxHcmFwaGljc0NvbnRleHQzRD4gY3JlYXRlTGF5ZXJU cmVlSG9zdENvbnRleHQzRCgpID0gMDsKLSAgICB2aXJ0dWFsIFBhc3NPd25QdHI8TGF5ZXJQYWlu dGVyQ2hyb21pdW0+IGNyZWF0ZVJvb3RMYXllclBhaW50ZXIoKSA9IDA7CiAgICAgdmlydHVhbCB2 b2lkIGRpZFJlY3JlYXRlR3JhcGhpY3NDb250ZXh0KGJvb2wgc3VjY2VzcykgPSAwOwogI2lmICFV U0UoVEhSRUFERURfQ09NUE9TSVRJTkcpCiAgICAgdmlydHVhbCB2b2lkIHNjaGVkdWxlQ29tcG9z aXRlKCkgPSAwOwo= 109104 2011-09-28 17:47:48 -0700 2011-09-28 18:27:59 -0700 Patch bug-69042-20110928174747.patch text/plain 3759 piman U3VidmVyc2lvbiBSZXZpc2lvbjogOTYyNjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMDgwYzgwMDAyZTFkNTIz MjcyYjM3NDZkZWVkNGRkZWZiYTVjZjZiLi41MzkwZDAzYjdlZjE1MTYyMjNlMzIxYjE0MmUwMDQ0 NjQ2NjYwNjhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMjggIEFudG9p bmUgTGFib3VyICA8cGltYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQg Y3JlYXRlUm9vdExheWVyUGFpbnRlciBmcm9tIENDTGF5ZXJUcmVlSG9zdENsaWVudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkwNDIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdCBuZWVk ZWQ6IG5vIHNlbWFudGljIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5oOgorCiAyMDExLTA5LTI4ICBTZXJnZXkgR2xhenVu b3YgIDxzZXJnLmdsYXp1bm92QGdtYWlsLmNvbT4KIAogICAgICAgICBKYXZhU2NyaXB0IGdlbmVy YXRlZCBkb2N1bWVudHMgZG9uJ3QgaW5oZXJpdCB0aGUgY29va2llIFVSTApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVI b3N0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xh eWVyVHJlZUhvc3QuaAppbmRleCBjOTA1MDk0MzkyNjc1ZjFlNjNlMTg1NzczOTRjYTYyZjQzMjQy MWUzLi41NGFkNGMwMDIyMjk2ZGY3ZThiMTZlNjcyMDA5MDVhN2I3ZDRlNTIyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJl ZUhvc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9j Yy9DQ0xheWVyVHJlZUhvc3QuaApAQCAtNTMsNyArNTMsNiBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIGFuaW1hdGVBbmRMYXlvdXQoZG91YmxlIGZyYW1lQmVnaW5UaW1lKSA9IDA7CiAgICAg dmlydHVhbCBQYXNzT3duUHRyPENDVGhyZWFkPiBjcmVhdGVDb21wb3NpdG9yVGhyZWFkKCkgPSAw OwogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxHcmFwaGljc0NvbnRleHQzRD4gY3JlYXRlTGF5ZXJU cmVlSG9zdENvbnRleHQzRCgpID0gMDsKLSAgICB2aXJ0dWFsIFBhc3NPd25QdHI8TGF5ZXJQYWlu dGVyQ2hyb21pdW0+IGNyZWF0ZVJvb3RMYXllclBhaW50ZXIoKSA9IDA7CiAgICAgdmlydHVhbCB2 b2lkIGRpZFJlY3JlYXRlR3JhcGhpY3NDb250ZXh0KGJvb2wgc3VjY2VzcykgPSAwOwogI2lmICFV U0UoVEhSRUFERURfQ09NUE9TSVRJTkcpCiAgICAgdmlydHVhbCB2b2lkIHNjaGVkdWxlQ29tcG9z aXRlKCkgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmlu ZGV4IGZjMDZjNjU5Y2JmZTQxMjQ1OWUyNzBjYzg1NTlmZDI5MWU2NTg1YTkuLjAxMTI1NmI2MzI2 OGZhMzdiODI4OTA0YmQzOWZlMTcxNTk2ZTRhMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTI3MDQsMTEgKzI3MDQsNiBAQCBQYXNzUmVmUHRyPEdy YXBoaWNzQ29udGV4dDNEPiBXZWJWaWV3SW1wbDo6Y3JlYXRlTGF5ZXJUcmVlSG9zdENvbnRleHQz RCgpCiAgICAgcmV0dXJuIGNvbnRleHQ7CiB9CiAKLVBhc3NPd25QdHI8TGF5ZXJQYWludGVyQ2hy b21pdW0+IFdlYlZpZXdJbXBsOjpjcmVhdGVSb290TGF5ZXJQYWludGVyKCkKLXsKLSAgICByZXR1 cm4gV2ViVmlld0ltcGxDb250ZW50UGFpbnRlcjo6Y3JlYXRlKHRoaXMpOwotfQotCiB2b2lkIFdl YlZpZXdJbXBsOjphbmltYXRlQW5kTGF5b3V0KGRvdWJsZSBmcmFtZUJlZ2luVGltZSkKIHsKICAg ICBhbmltYXRlKGZyYW1lQmVnaW5UaW1lKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW aWV3SW1wbC5oCmluZGV4IGM5ODkyY2MxNTkxNTVlMDEwZmMwNTQ5MDBlODJmYTE5M2Y4Y2YxN2Uu LmIzOTU0OWE5YmMwMDZkN2IyYWI4MGYzYzFiYTY3YmY2YWIxNTU1MzUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaApAQCAtMjIxLDcgKzIyMSw2IEBAIHB1YmxpYzoK ICAgICB2aXJ0dWFsIHZvaWQgYW5pbWF0ZUFuZExheW91dChkb3VibGUgZnJhbWVCZWdpblRpbWUp OwogICAgIHZpcnR1YWwgUGFzc093blB0cjxXZWJDb3JlOjpDQ1RocmVhZD4gY3JlYXRlQ29tcG9z aXRvclRocmVhZCgpOwogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxXZWJDb3JlOjpHcmFwaGljc0Nv bnRleHQzRD4gY3JlYXRlTGF5ZXJUcmVlSG9zdENvbnRleHQzRCgpOwotICAgIHZpcnR1YWwgUGFz c093blB0cjxXZWJDb3JlOjpMYXllclBhaW50ZXJDaHJvbWl1bT4gY3JlYXRlUm9vdExheWVyUGFp bnRlcigpOwogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNyZWF0ZUdyYXBoaWNzQ29udGV4dChib29s IHN1Y2Nlc3MpOwogI2lmICFVU0UoVEhSRUFERURfQ09NUE9TSVRJTkcpCiAgICAgdmlydHVhbCB2 b2lkIHNjaGVkdWxlQ29tcG9zaXRlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdFRlc3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RUZXN0LmNwcAppbmRleCAzMzQwNTBkYjVkOTZjZjdmMjNk NTJlMmJlODg2ZTQxNjMzNmIyNzI1Li42NzNiMWY1M2M3NTk5MzA5Y2FmMTI2MDYwYzA1MWNjMGRl N2E4Y2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJU cmVlSG9zdFRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXll clRyZWVIb3N0VGVzdC5jcHAKQEAgLTMxLDcgKzMxLDYgQEAKICNpbmNsdWRlICJDQ1RocmVhZElt cGwuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQzRFByaXZhdGUuaCIKICNpbmNsdWRlICJM YXllckNocm9taXVtLmgiCi0jaW5jbHVkZSAiTGF5ZXJQYWludGVyQ2hyb21pdW0uaCIKICNpbmNs dWRlICJNb2NrV2ViR3JhcGhpY3NDb250ZXh0M0QuaCIKICNpbmNsdWRlICJUZXh0dXJlTWFuYWdl ci5oIgogI2luY2x1ZGUgImNjL0NDTGF5ZXJUcmVlSG9zdEltcGwuaCIKQEAgLTE2MSwxMSArMTYw LDYgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gY29udGV4dDsKICAgICB9CiAKLSAgICB2aXJ0 dWFsIFBhc3NPd25QdHI8TGF5ZXJQYWludGVyQ2hyb21pdW0+IGNyZWF0ZVJvb3RMYXllclBhaW50 ZXIoKQotICAgIHsKLSAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0gICAgfQotCiAgICAgdmlydHVh bCB2b2lkIGRpZFJlY3JlYXRlR3JhcGhpY3NDb250ZXh0KGJvb2wpCiAgICAgewogICAgIH0K