69039 2011-09-28 16:17:10 -0700 Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows.. 2011-09-30 14:38:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 levin levin abarth levin webkit.review.bot oldest_to_newest 475067 0 levin 2011-09-28 16:17:10 -0700 Need to check sys.platform and return if Windows. 476288 1 109339 levin 2011-09-30 13:40:20 -0700 Created attachment 109339 Patch 476289 2 109340 levin 2011-09-30 13:42:51 -0700 Created attachment 109340 Patch 476305 3 109340 webkit.review.bot 2011-09-30 14:14:14 -0700 Comment on attachment 109340 Patch Rejecting attachment 109340 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: 3305e141b1894930d4e6e809ed5f283c61f93e96 r96423 = 10e9ed80779e02bdb3af2a2cf49a19d95093cc9a Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9888922 476327 4 levin 2011-09-30 14:38:08 -0700 Bummer I deleted the Reviewed by line :( Committed (by hand) as http://trac.webkit.org/changeset/96428. 109339 2011-09-30 13:40:20 -0700 2011-09-30 13:42:47 -0700 Patch bug-69039-20110930134018.patch text/plain 1875 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTY0MTgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMmI5YzMxMjI0NGNkOGMxMjk0N2M3NjA4ZDU5NGMzZTE4 NGY1Yzc3Li42NGNmNjNmMDc1ZTcxOWQyZTQzNGU3ZmI2NjhhM2I5ZWFlNzNmZDViIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEg QEAKKzIwMTEtMDktMzAgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIE5lZWQgdG8gc2tpcCB3ZWJraXRweS5jb21tb24uY2hlY2tvdXQuYmFzZWxpbmVvcHRpbWl6 ZXJfdW5pdHRlc3QuQmFzZWxpbmVPcHRpbWl6ZXJUZXN0IG9uIFdpbmRvd3MuLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkwMzkKKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2Jhc2VsaW5lb3B0aW1pemVyX3VuaXR0 ZXN0LnB5OgorICAgICAgICBBY3R1YWxseSBza2lwIG9ubHkgb25lIHNwZWNpZmljIHRlc3QgdGhh dCBpcyBmYWlsaW5nIG9uIFdpbmRvd3MuCisKIDIwMTEtMDktMzAgIFRvciBBcm5lIFZlc3Riw7gg IDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gUHJldmVudCBxRGVi dWcoKSBvdXRwdXQgZnJvbSBEUlQgYW5kIFdUUiB1bmxlc3MgLS12ZXJib3NlCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9iYXNlbGluZW9wdGltaXpl cl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2Jh c2VsaW5lb3B0aW1pemVyX3VuaXR0ZXN0LnB5CmluZGV4IGQ1ZWUzZjUwNmE1YWJkYmYyYTZlYTk2 ODdiNDU0OTllOGY1Nzc1N2UuLjIxYjBkMzNlZjdlMTVmMjgzMWJhZGQ5MjJiOWM2YTUxZTcwNWI1 YzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2Jh c2VsaW5lb3B0aW1pemVyX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NoZWNrb3V0L2Jhc2VsaW5lb3B0aW1pemVyX3VuaXR0ZXN0LnB5CkBAIC0yNyw2ICsy Nyw3IEBACiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lC SUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKIGltcG9ydCB1bml0dGVzdAoraW1wb3J0IHN5cwogCiBm cm9tIHdlYmtpdHB5LmNvbW1vbi5jaGVja291dC5iYXNlbGluZW9wdGltaXplciBpbXBvcnQgQmFz ZWxpbmVPcHRpbWl6ZXIKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5maWxlc3lzdGVtX21v Y2sgaW1wb3J0IE1vY2tGaWxlU3lzdGVtCkBAIC0xMzAsNiArMTMxLDkgQEAgY2xhc3MgQmFzZWxp bmVPcHRpbWl6ZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgfSkKIAogICAgIGRl ZiB0ZXN0X2NvbXBsZXhfc2hhZG93aW5nKHNlbGYpOgorICAgICAgICAjIFRoaXMgdGVzdCByZWxp ZXMgb24gT1Mgc3BlY2lmaWMgZnVuY3Rpb25hbGl0eSwgc28gaXQgZG9lc24ndCB3b3JrIG9uIFdp bmRvd3MuCisgICAgICAgIGlmIHN5cy5wbGF0Zm9ybSA9PSAnd2luMzInOgorICAgICAgICAgICAg cmV0dXJuCiAgICAgICAgIHNlbGYuX2Fzc2VydE9wdGltaXphdGlvbih7CiAgICAgICAgICAgICAn TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2luJzogJzQ2MmQwM2I5YzAyNWRiMWIwMzky ZDc0NTMzMTBkYmVlNWY5YTllNzQnLAogICAgICAgICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYyc6ICc1ZGFhNzhlNTVmMDVkOWYwZDFiYjFmMzJiMGNkMWJjM2EwMWU5MzY0JywK 109340 2011-09-30 13:42:51 -0700 2011-09-30 14:14:13 -0700 Patch bug-69039-20110930134250.patch text/plain 1881 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTY0MTgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMmI5YzMxMjI0NGNkOGMxMjk0N2M3NjA4ZDU5NGMzZTE4 NGY1Yzc3Li42NGNmNjNmMDc1ZTcxOWQyZTQzNGU3ZmI2NjhhM2I5ZWFlNzNmZDViIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEg QEAKKzIwMTEtMDktMzAgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIE5lZWQgdG8gc2tpcCB3ZWJraXRweS5jb21tb24uY2hlY2tvdXQuYmFzZWxpbmVvcHRpbWl6 ZXJfdW5pdHRlc3QuQmFzZWxpbmVPcHRpbWl6ZXJUZXN0IG9uIFdpbmRvd3MuLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjkwMzkKKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2Jhc2VsaW5lb3B0aW1pemVyX3VuaXR0 ZXN0LnB5OgorICAgICAgICBBY3R1YWxseSBza2lwIG9ubHkgb25lIHNwZWNpZmljIHRlc3QgdGhh dCBpcyBmYWlsaW5nIG9uIFdpbmRvd3MuCisKIDIwMTEtMDktMzAgIFRvciBBcm5lIFZlc3Riw7gg IDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gUHJldmVudCBxRGVi dWcoKSBvdXRwdXQgZnJvbSBEUlQgYW5kIFdUUiB1bmxlc3MgLS12ZXJib3NlCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9iYXNlbGluZW9wdGltaXpl cl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2Jh c2VsaW5lb3B0aW1pemVyX3VuaXR0ZXN0LnB5CmluZGV4IGQ1ZWUzZjUwNmE1YWJkYmYyYTZlYTk2 ODdiNDU0OTllOGY1Nzc1N2UuLmJjZmU1MzJjODM2ZDM3NzkyOTg1NGRkNWY0ZjAwZGI0ZmYzNWJk NjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2Jh c2VsaW5lb3B0aW1pemVyX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NoZWNrb3V0L2Jhc2VsaW5lb3B0aW1pemVyX3VuaXR0ZXN0LnB5CkBAIC0yNiw2ICsy Niw3IEBACiAjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4g QU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklT RUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCitpbXBvcnQgc3lzCiBpbXBv cnQgdW5pdHRlc3QKIAogZnJvbSB3ZWJraXRweS5jb21tb24uY2hlY2tvdXQuYmFzZWxpbmVvcHRp bWl6ZXIgaW1wb3J0IEJhc2VsaW5lT3B0aW1pemVyCkBAIC0xMzAsNiArMTMxLDkgQEAgY2xhc3Mg QmFzZWxpbmVPcHRpbWl6ZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgfSkKIAog ICAgIGRlZiB0ZXN0X2NvbXBsZXhfc2hhZG93aW5nKHNlbGYpOgorICAgICAgICAjIFRoaXMgdGVz dCByZWxpZXMgb24gT1Mgc3BlY2lmaWMgZnVuY3Rpb25hbGl0eSwgc28gaXQgZG9lc24ndCB3b3Jr IG9uIFdpbmRvd3MuCisgICAgICAgIGlmIHN5cy5wbGF0Zm9ybSA9PSAnd2luMzInOgorICAgICAg ICAgICAgcmV0dXJuCiAgICAgICAgIHNlbGYuX2Fzc2VydE9wdGltaXphdGlvbih7CiAgICAgICAg ICAgICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2luJzogJzQ2MmQwM2I5YzAyNWRi MWIwMzkyZDc0NTMzMTBkYmVlNWY5YTllNzQnLAogICAgICAgICAgICAgJ0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYyc6ICc1ZGFhNzhlNTVmMDVkOWYwZDFiYjFmMzJiMGNkMWJjM2EwMWU5MzY0JywK