69005 2011-09-28 09:29:18 -0700 Web Inspector: optional arguments support for the frontend needs to be extended. 2011-09-28 09:56:27 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 474766 0 loislo 2011-09-28 09:29:18 -0700 Generator supports optional arguments but they are transferred by value. It is not suitable if the used type doesn't have operator bool. I'll transfer such arguments by pointer. 474778 1 109030 loislo 2011-09-28 09:37:20 -0700 Created attachment 109030 Patch 474795 2 loislo 2011-09-28 09:56:27 -0700 Committed r96227: <http://trac.webkit.org/changeset/96227> 109030 2011-09-28 09:37:20 -0700 2011-09-28 09:46:12 -0700 Patch bug-69005-20110928203718.patch text/plain 7565 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogOTYyMjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ODJjOGFhNWExZDExMTVk OWE3OWNlOWU5ZmRhNjI0YWU2MWI3OWNiLi43MzIyODdjNGRlZDBkYmY3MmM0MzY5NWUwY2ZmM2Zk ZjdmM2VlMDc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDktMjggIElseWEg VGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IG9wdGlvbmFsIGFyZ3VtZW50cyBzdXBwb3J0IGZvciB0aGUgZnJvbnRlbmQgbmVlZHMgdG8g YmUgZXh0ZW5kZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02OTAwNQorCisgICAgICAgIEdlbmVyYXRvciBzdXBwb3J0cyBvcHRpb25hbCBhcmd1bWVu dHMgYnV0IHRoZXkgYXJlIHRyYW5zZmVycmVkIGJ5IHZhbHVlLgorICAgICAgICBJdCBpcyBub3Qg c3VpdGFibGUgaWYgdGhlIHVzZWQgdHlwZSBkb2Vzbid0IGhhdmUgb3BlcmF0b3IgYm9vbC4KKyAg ICAgICAgSSdsbCB0cmFuc2ZlciBzdWNoIGFyZ3VtZW50cyBieSBwb2ludGVyLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkIGlzIHRoZSB0ZXN0 LgorCisgICAgICAgICogaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucG06CisgICAg ICAgIChnZW5lcmF0ZUZyb250ZW5kRnVuY3Rpb24pOgorICAgICAgICAocGFyYW1UeXBlVHJhaXRz KToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpkaWRQYXJzZVNvdXJjZSk6Cisg ICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9yUmVzb3VyY2VBZ2VudDo6ZGlkRmFpbExvYWRpbmcpOgorCiAyMDEx LTA5LTI4ICBBbnRhcnlhbWkgUGFuZGlhICA8YW50YXJ5YW1pLnBhbmRpYUBtb3Rvcm9sYS5jb20+ CiAKICAgICAgICAgUmVmbGVjdGVkIGF0dHJpYnV0ZSBpbnB1dC5zaXplIHdyYXBzIG9uIG5lZ2F0 aXZlIHZhbHVlcyAoQ2hyb21lKSwgb3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnBtIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucG0KaW5kZXggYTRmNzJlYmY2NmVhOTRjNzBlNDViNDlk OTA2NTMyNDBmY2Y0NGNjMS4uNzJlMjE4M2MxZjI5YzQ2Nzk1ODkyNjA1MGNiZDk4NGNhOTM5Y2Ex OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNw ZWN0b3IucG0KKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNw ZWN0b3IucG0KQEAgLTEzNCw2ICsxMzQsOCBAQCAkdHlwZVRyYW5zZm9ybXsiVmFsdWUifSA9IHsK IH07CiAkdHlwZVRyYW5zZm9ybXsiU3RyaW5nIn0gPSB7CiAgICAgInBhcmFtIiA9PiAiY29uc3Qg U3RyaW5nJiIsCisgICAgIm9wdGlvbmFsX3BhcmFtIiA9PiAiY29uc3QgU3RyaW5nKiBjb25zdCIs CisgICAgIm9wdGlvbmFsX3ZhbHVlQWNjZXNzb3IiID0+ICIqIiwKICAgICAidmFyaWFibGUiID0+ ICJTdHJpbmciLAogICAgICJyZXR1cm4iID0+ICJTdHJpbmciLAogICAgICJkZWZhdWx0VmFsdWUi ID0+ICJcIlwiIiwKQEAgLTE0NCw2ICsxNDYsOCBAQCAkdHlwZVRyYW5zZm9ybXsiU3RyaW5nIn0g PSB7CiB9OwogJHR5cGVUcmFuc2Zvcm17ImxvbmcifSA9IHsKICAgICAicGFyYW0iID0+ICJsb25n IiwKKyAgICAib3B0aW9uYWxfcGFyYW0iID0+ICJjb25zdCBsb25nKiBjb25zdCIsCisgICAgIm9w dGlvbmFsX3ZhbHVlQWNjZXNzb3IiID0+ICIqIiwKICAgICAidmFyaWFibGUiID0+ICJsb25nIiwK ICAgICAiZGVmYXVsdFZhbHVlIiA9PiAiMCIsCiAgICAgImZvcndhcmQiID0+ICIiLApAQCAtMTUz LDYgKzE1Nyw4IEBAICR0eXBlVHJhbnNmb3JteyJsb25nIn0gPSB7CiB9OwogJHR5cGVUcmFuc2Zv cm17ImludCJ9ID0gewogICAgICJwYXJhbSIgPT4gImludCIsCisgICAgIm9wdGlvbmFsX3BhcmFt IiA9PiAiY29uc3QgaW50KiBjb25zdCIsCisgICAgIm9wdGlvbmFsX3ZhbHVlQWNjZXNzb3IiID0+ ICIqIiwKICAgICAidmFyaWFibGUiID0+ICJpbnQiLAogICAgICJkZWZhdWx0VmFsdWUiID0+ICIw IiwKICAgICAiZm9yd2FyZCIgPT4gIiIsCkBAIC0xNjIsNiArMTY4LDggQEAgJHR5cGVUcmFuc2Zv cm17ImludCJ9ID0gewogfTsKICR0eXBlVHJhbnNmb3JteyJ1bnNpZ25lZCBsb25nIn0gPSB7CiAg ICAgInBhcmFtIiA9PiAidW5zaWduZWQgbG9uZyIsCisgICAgIm9wdGlvbmFsX3BhcmFtIiA9PiAi Y29uc3QgdW5zaWduZWQgbG9uZyogY29uc3QiLAorICAgICJvcHRpb25hbF92YWx1ZUFjY2Vzc29y IiA9PiAiKiIsCiAgICAgInZhcmlhYmxlIiA9PiAidW5zaWduZWQgbG9uZyIsCiAgICAgImRlZmF1 bHRWYWx1ZSIgPT4gIjB1IiwKICAgICAiZm9yd2FyZCIgPT4gIiIsCkBAIC0xNzEsNiArMTc5LDgg QEAgJHR5cGVUcmFuc2Zvcm17InVuc2lnbmVkIGxvbmcifSA9IHsKIH07CiAkdHlwZVRyYW5zZm9y bXsidW5zaWduZWQgaW50In0gPSB7CiAgICAgInBhcmFtIiA9PiAidW5zaWduZWQgaW50IiwKKyAg ICAib3B0aW9uYWxfcGFyYW0iID0+ICJjb25zdCB1bnNpZ25lZCBpbnQqIGNvbnN0IiwKKyAgICAi b3B0aW9uYWxfdmFsdWVBY2Nlc3NvciIgPT4gIioiLAogICAgICJ2YXJpYWJsZSIgPT4gInVuc2ln bmVkIGludCIsCiAgICAgImRlZmF1bHRWYWx1ZSIgPT4gIjB1IiwKICAgICAiZm9yd2FyZCIgPT4g IiIsCkBAIC0xODAsNiArMTkwLDggQEAgJHR5cGVUcmFuc2Zvcm17InVuc2lnbmVkIGludCJ9ID0g ewogfTsKICR0eXBlVHJhbnNmb3JteyJkb3VibGUifSA9IHsKICAgICAicGFyYW0iID0+ICJkb3Vi bGUiLAorICAgICJvcHRpb25hbF9wYXJhbSIgPT4gImNvbnN0IGRvdWJsZSogY29uc3QiLAorICAg ICJvcHRpb25hbF92YWx1ZUFjY2Vzc29yIiA9PiAiKiIsCiAgICAgInZhcmlhYmxlIiA9PiAiZG91 YmxlIiwKICAgICAiZGVmYXVsdFZhbHVlIiA9PiAiMC4wIiwKICAgICAiZm9yd2FyZCIgPT4gIiIs CkBAIC0xODksNiArMjAxLDggQEAgJHR5cGVUcmFuc2Zvcm17ImRvdWJsZSJ9ID0gewogfTsKICR0 eXBlVHJhbnNmb3JteyJib29sZWFuIn0gPSB7CiAgICAgInBhcmFtIiA9PiAiYm9vbCIsCisgICAg Im9wdGlvbmFsX3BhcmFtIiA9PiAiY29uc3QgYm9vbCogY29uc3QiLAorICAgICJvcHRpb25hbF92 YWx1ZUFjY2Vzc29yIiA9PiAiKiIsCiAgICAgInZhcmlhYmxlIj0+ICJib29sIiwKICAgICAiZGVm YXVsdFZhbHVlIiA9PiAiZmFsc2UiLAogICAgICJmb3J3YXJkIiA9PiAiIiwKQEAgLTM3Niw3ICsz OTAsNyBAQCBzdWIgZ2VuZXJhdGVGcm9udGVuZEZ1bmN0aW9uCiAgICAgbXkgJGRvbWFpbiA9ICRp bnRlcmZhY2UtPm5hbWU7CiAgICAgbXkgQGFyZ3NGaWx0ZXJlZCA9IGdyZXAoJF8tPmRpcmVjdGlv biBlcSAib3V0IiwgQHskZnVuY3Rpb24tPnBhcmFtZXRlcnN9KTsgIyBqdXN0IGtlZXAgb25seSBv dXQgcGFyYW1ldGVycyBmb3IgZnJvbnRlbmQgaW50ZXJmYWNlLgogICAgIG1hcCgkZnJvbnRlbmRU eXBlc3skXy0+dHlwZX0gPSAxLCBAYXJnc0ZpbHRlcmVkKTsgIyByZWdpc3RlciByZXF1aXJlZCB0 eXBlcy4KLSAgICBteSAkYXJndW1lbnRzID0gam9pbigiLCAiLCBtYXAodHlwZVRyYWl0cygkXy0+ dHlwZSwgInBhcmFtIikgLiAiICIgLiAkXy0+bmFtZSwgQGFyZ3NGaWx0ZXJlZCkpOyAjIHByZXBh cmUgYXJndW1lbnRzIGZvciBmdW5jdGlvbiBzaWduYXR1cmUuCisgICAgbXkgJGFyZ3VtZW50cyA9 IGpvaW4oIiwgIiwgbWFwKHBhcmFtVHlwZVRyYWl0cygkXywgInBhcmFtIikgLiAiICIgLiAkXy0+ bmFtZSwgQGFyZ3NGaWx0ZXJlZCkpOyAjIHByZXBhcmUgYXJndW1lbnRzIGZvciBmdW5jdGlvbiBz aWduYXR1cmUuCiAKICAgICBteSAkc2lnbmF0dXJlID0gIiAgICAgICAgdm9pZCAke2Z1bmN0aW9u TmFtZX0oJHthcmd1bWVudHN9KTsiOwogICAgICEkYWdlbnQtPnttZXRob2RTaWduYXR1cmVzfS0+ eyRzaWduYXR1cmV9IHx8IGRpZSAiRHVwbGljYXRlIGZyb250ZW5kIGZ1bmN0aW9uIHdhcyBkZXRl Y3RlZCBmb3Igc2lnbmF0dXJlICckc2lnbmF0dXJlJy4iOwpAQCAtMzkzLDcgKzQwNyw3IEBAIHN1 YiBnZW5lcmF0ZUZyb250ZW5kRnVuY3Rpb24KIAogICAgICAgICBmb3JlYWNoIG15ICRwYXJhbWV0 ZXIgKEBhcmdzRmlsdGVyZWQpIHsKICAgICAgICAgICAgIG15ICRvcHRpb25hbCA9ICRwYXJhbWV0 ZXItPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJvcHRpb25hbCJ9ID8gImlmICgiIC4gJHBhcmFtZXRl ci0+bmFtZSAuICIpXG4gICAgICAgICIgOiAiIjsKLSAgICAgICAgICAgIHB1c2goQGZ1bmN0aW9u LCAiICAgICIgLiAkb3B0aW9uYWwgLiAicGFyYW1zT2JqZWN0LT5zZXQiIC4gdHlwZVRyYWl0cygk cGFyYW1ldGVyLT50eXBlLCAiSlNPTlR5cGUiKSAuICIoXCIiIC4gJHBhcmFtZXRlci0+bmFtZSAu ICJcIiwgIiAuICRwYXJhbWV0ZXItPm5hbWUgLiAiKTsiKTsKKyAgICAgICAgICAgIHB1c2goQGZ1 bmN0aW9uLCAiICAgICIgLiAkb3B0aW9uYWwgLiAicGFyYW1zT2JqZWN0LT5zZXQiIC4gcGFyYW1U eXBlVHJhaXRzKCRwYXJhbWV0ZXIsICJKU09OVHlwZSIpIC4gIihcIiIgLiAkcGFyYW1ldGVyLT5u YW1lIC4gIlwiLCAiIC4gcGFyYW1UeXBlVHJhaXRzKCRwYXJhbWV0ZXIsICJ2YWx1ZUFjY2Vzc29y IikgLiAkcGFyYW1ldGVyLT5uYW1lIC4gIik7Iik7CiAgICAgICAgIH0KICAgICAgICAgcHVzaChA ZnVuY3Rpb24sICIgICAgJHtmdW5jdGlvbk5hbWV9TWVzc2FnZS0+c2V0T2JqZWN0KFwicGFyYW1z XCIsIHBhcmFtc09iamVjdCk7Iik7CiAgICAgfQpAQCAtMTA5Niw2ICsxMTEwLDE4IEBAIHN1YiB0 eXBlVHJhaXRzCiAgICAgcmV0dXJuICR0eXBlVHJhbnNmb3JteyR0eXBlfS0+eyR0cmFpdH07CiB9 CiAKK3N1YiBwYXJhbVR5cGVUcmFpdHMKK3sKKyAgICBteSAkcGFyYW1EZXNjcmlwdGlvbiA9IHNo aWZ0OworICAgIG15ICR0cmFpdCA9IHNoaWZ0OworICAgIGlmICgkcGFyYW1EZXNjcmlwdGlvbi0+ ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57Im9wdGlvbmFsIn0pIHsKKyAgICAgICAgbXkgJG9wdGlvbmFs UmVzdWx0ID0gdHlwZVRyYWl0cygkcGFyYW1EZXNjcmlwdGlvbi0+dHlwZSwgIm9wdGlvbmFsXyIg LiAkdHJhaXQpOworICAgICAgICByZXR1cm4gJG9wdGlvbmFsUmVzdWx0IGlmIGRlZmluZWQgJG9w dGlvbmFsUmVzdWx0OworICAgIH0KKyAgICBteSAkcmVzdWx0ID0gdHlwZVRyYWl0cygkcGFyYW1E ZXNjcmlwdGlvbi0+dHlwZSwgJHRyYWl0KTsKKyAgICByZXR1cm4gZGVmaW5lZCAkcmVzdWx0ID8g JHJlc3VsdCA6ICIiOworfQorCiBzdWIgZ2VuZXJhdGVCYWNrZW5kQWdlbnRGaWVsZHNBbmRDb25z dHJ1Y3RvcgogewogICAgIG15IEBhcmd1bWVudHM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKaW5kZXggYjhmYmI1ZDliYWEyMDc4 MDFjOTA0OTVjYzMwNTI1MzlmYTljY2RlYi4uMGIyMTIwZGJhODBhZTdmMjkyZTMyOGZlYzU3NDNi MzMxOWU4MTI5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckRlYnVnZ2VyQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JEZWJ1Z2dlckFnZW50LmNwcApAQCAtNDM3LDcgKzQzNyw3IEBAIFBhc3NSZWZQdHI8SW5zcGVj dG9yQXJyYXk+IEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmN1cnJlbnRDYWxsRnJhbWVzKCkKIHZv aWQgSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6ZGlkUGFyc2VTb3VyY2UoY29uc3QgU3RyaW5nJiBz Y3JpcHRJZCwgY29uc3QgU2NyaXB0JiBzY3JpcHQpCiB7CiAgICAgLy8gRG9uJ3Qgc2VuZCBzY3Jp cHQgY29udGVudCB0byB0aGUgZnJvbnQgZW5kIHVudGlsIGl0J3MgcmVhbGx5IG5lZWRlZC4KLSAg ICBtX2Zyb250ZW5kLT5zY3JpcHRQYXJzZWQoc2NyaXB0SWQsIHNjcmlwdC51cmwsIHNjcmlwdC5z dGFydExpbmUsIHNjcmlwdC5zdGFydENvbHVtbiwgc2NyaXB0LmVuZExpbmUsIHNjcmlwdC5lbmRD b2x1bW4sIHNjcmlwdC5pc0NvbnRlbnRTY3JpcHQpOworICAgIG1fZnJvbnRlbmQtPnNjcmlwdFBh cnNlZChzY3JpcHRJZCwgc2NyaXB0LnVybCwgc2NyaXB0LnN0YXJ0TGluZSwgc2NyaXB0LnN0YXJ0 Q29sdW1uLCBzY3JpcHQuZW5kTGluZSwgc2NyaXB0LmVuZENvbHVtbiwgc2NyaXB0LmlzQ29udGVu dFNjcmlwdCA/ICZzY3JpcHQuaXNDb250ZW50U2NyaXB0IDogMCk7CiAKICAgICBtX3NjcmlwdHMu c2V0KHNjcmlwdElkLCBzY3JpcHQpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHAKaW5kZXggNzdlNWQ2ZGE1ZjVjODEzZDFhMjA3 NGYxNzA3M2NmNzEwZGRkNWMyNy4uYTc5MzYzMDM4YjJhZjYzMDlmODVjMjZlNWEyM2QwZmNmYTNi ZDAyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291 cmNlQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXNv dXJjZUFnZW50LmNwcApAQCAtMjk5LDcgKzI5OSw4IEBAIHZvaWQgSW5zcGVjdG9yUmVzb3VyY2VB Z2VudDo6ZGlkRmFpbExvYWRpbmcodW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBEb2N1bWVudExv CiAgICAgICAgICAgICBtX3Jlc291cmNlc0RhdGEtPmFkZFJlc291cmNlU2hhcmVkQnVmZmVyKHJl cXVlc3RJZCwgZnJhbWUtPmxvYWRlcigpLT5kb2N1bWVudExvYWRlcigpLT5tYWluUmVzb3VyY2VE YXRhKCksIGZyYW1lLT5kb2N1bWVudCgpLT5pbnB1dEVuY29kaW5nKCkpOwogICAgIH0KIAotICAg IG1fZnJvbnRlbmQtPmxvYWRpbmdGYWlsZWQocmVxdWVzdElkLCBjdXJyZW50VGltZSgpLCBlcnJv ci5sb2NhbGl6ZWREZXNjcmlwdGlvbigpLCBlcnJvci5pc0NhbmNlbGxhdGlvbigpKTsKKyAgICBi b29sIGNhbmNlbGVkID0gZXJyb3IuaXNDYW5jZWxsYXRpb24oKTsKKyAgICBtX2Zyb250ZW5kLT5s b2FkaW5nRmFpbGVkKHJlcXVlc3RJZCwgY3VycmVudFRpbWUoKSwgZXJyb3IubG9jYWxpemVkRGVz Y3JpcHRpb24oKSwgY2FuY2VsZWQgPyAmY2FuY2VsZWQgOiAwKTsKIH0KIAogdm9pZCBJbnNwZWN0 b3JSZXNvdXJjZUFnZW50OjpkaWRMb2FkUmVzb3VyY2VGcm9tTWVtb3J5Q2FjaGUoRG9jdW1lbnRM b2FkZXIqIGxvYWRlciwgQ2FjaGVkUmVzb3VyY2UqIHJlc291cmNlKQo=