69004 2011-09-28 08:25:31 -0700 REGRESSION(r96060) It made plugins/js-from-destroy.html crash in debug mode 2011-09-28 12:54:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P1 Critical --- 67443 1 ossy japhet ap japhet koivisto ossy webkit.review.bot oldest_to_newest 474738 0 ossy 2011-09-28 08:25:31 -0700 Leopard: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r96219%20(33811)/plugins/js-from-destroy-crash-log.txt Qt: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Debug/r96218%20(18602)/plugins/js-from-destroy-crash-log.txt GTK: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r96215%20(17521)/plugins/js-from-destroy-crash-log.txt 474790 1 japhet 2011-09-28 09:53:09 -0700 The GTK stack is empty, and the Leopard stack doesn't yet make sense to me. The Qt stack looks to me like ResourceLoader::m_documentLoader is possible due to an unintentional re-ordering in r96060. I'll get a patch ready for that. 474794 2 japhet 2011-09-28 09:55:47 -0700 (In reply to comment #1) > The GTK stack is empty, and the Leopard stack doesn't yet make sense to me. > > The Qt stack looks to me like ResourceLoader::m_documentLoader is possible due to an unintentional re-ordering in r96060. I'll get a patch ready for that. Wow, I fail at proofreading. That should have been: The Qt stack looks to me like ResourceLoader::m_documentLoader is null, which is possible due to an unintentional re-ordering in r96060. 474850 3 109039 japhet 2011-09-28 11:06:22 -0700 Created attachment 109039 Move DocumentLoader null check back to SubresourceLoader::create() 474923 4 109039 webkit.review.bot 2011-09-28 12:46:17 -0700 Comment on attachment 109039 Move DocumentLoader null check back to SubresourceLoader::create() Rejecting attachment 109039 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/9888257 474928 5 109039 ossy 2011-09-28 12:54:47 -0700 Comment on attachment 109039 Move DocumentLoader null check back to SubresourceLoader::create() Clearing flags on attachment: 109039 Committed r96249: <http://trac.webkit.org/changeset/96249> 474929 6 ossy 2011-09-28 12:54:55 -0700 All reviewed patches have been landed. Closing bug. 109039 2011-09-28 11:06:22 -0700 2011-09-28 12:54:47 -0700 Move DocumentLoader null check back to SubresourceLoader::create() adl.txt text/plain 3460 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2MjM3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMjggIE5hdGUgQ2hh cGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYSByZWdyZXNzaW9uIGlu IHI5NjA2MC4gUmVzb3VyY2VMb2FkZXIgc2hvdWxkbid0IGdldAorICAgICAgICBpbml0aWFsaXpl ZCB3aXRoIGEgbnVsbCBEb2N1bWVudExvYWRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY5MDA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyBzaG91bGQgZml4IGEgZGVidWcgY3Jhc2ggaW4gc29t ZSBwbGF0Zm9ybXMgaW4KKyAgICAgICAgcGx1Z2lucy9qcy1mcm9tLWRlc3Ryb3kuaHRtbAorCisg ICAgICAgICogbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl c291cmNlTG9hZGVyOjppbml0KTogTW92ZSB0aGUgYWN0aXZlRG9jdW1lbnRMb2FkZXIoKSBudWxs IGNoZWNrcyBiYWNrCisgICAgICAgICAgICB0byBTdWJyZXNvdWNlTG9hZGVyOjpjcmVhdGUoKS4K KyAgICAgICAgKiBsb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U3VicmVzb3VyY2VMb2FkZXI6OmNyZWF0ZSk6CisKIDIwMTEtMDktMjggIEZhZHkgU2FtdWVs ICA8ZnNhbXVlbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBTZXBlcmF0ZSBH VEsgc3BlY2lmaWMgR3lwIHJ1bGVzIGZyb20gWDExIEd5cCBydWxlcwpJbmRleDogU291cmNlL1dl YkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiA5NjIyNykKKysrIFNvdXJj ZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEx MywxMiArMTEzLDYgQEAKICAgICAKICAgICBSZXNvdXJjZVJlcXVlc3QgY2xpZW50UmVxdWVzdChy KTsKICAgICAKLSAgICBGcmFtZUxvYWRlciogZnJhbWVMb2FkZXIgPSBtX2ZyYW1lLT5sb2FkZXIo KTsKLSAgICBpZiAobV9vcHRpb25zLnNlY3VyaXR5Q2hlY2sgPT0gRG9TZWN1cml0eUNoZWNrICYm IChmcmFtZUxvYWRlci0+c3RhdGUoKSA9PSBGcmFtZVN0YXRlUHJvdmlzaW9uYWwgfHwgIWZyYW1l TG9hZGVyLT5hY3RpdmVEb2N1bWVudExvYWRlcigpIHx8IGZyYW1lTG9hZGVyLT5hY3RpdmVEb2N1 bWVudExvYWRlcigpLT5pc1N0b3BwaW5nKCkpKSB7Ci0gICAgICAgIHJlbGVhc2VSZXNvdXJjZXMo KTsKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KLSAgICAKICAgICBpZiAobV9vcHRpb25z LnNlY3VyaXR5Q2hlY2sgPT0gRG9TZWN1cml0eUNoZWNrICYmICFtX2ZyYW1lLT5kb2N1bWVudCgp LT5zZWN1cml0eU9yaWdpbigpLT5jYW5EaXNwbGF5KGNsaWVudFJlcXVlc3QudXJsKCkpKSB7CiAg ICAgICAgIEZyYW1lTG9hZGVyOjpyZXBvcnRMb2NhbExvYWRGYWlsZWQobV9mcmFtZS5nZXQoKSwg Y2xpZW50UmVxdWVzdC51cmwoKS5zdHJpbmcoKSk7CiAgICAgICAgIHJlbGVhc2VSZXNvdXJjZXMo KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAko cmV2aXNpb24gOTYyMjcpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2Fk ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Niw3ICs2NiwxMCBAQAogICAgIGlmICghZnJhbWUp CiAgICAgICAgIHJldHVybiAwOwogCi0gICAgRnJhbWVMb2FkZXIqIGZsID0gZnJhbWUtPmxvYWRl cigpOworICAgIEZyYW1lTG9hZGVyKiBmcmFtZUxvYWRlciA9IGZyYW1lLT5sb2FkZXIoKTsKKyAg ICBpZiAob3B0aW9ucy5zZWN1cml0eUNoZWNrID09IERvU2VjdXJpdHlDaGVjayAmJiAoZnJhbWVM b2FkZXItPnN0YXRlKCkgPT0gRnJhbWVTdGF0ZVByb3Zpc2lvbmFsIHx8ICFmcmFtZUxvYWRlci0+ YWN0aXZlRG9jdW1lbnRMb2FkZXIoKSB8fCBmcmFtZUxvYWRlci0+YWN0aXZlRG9jdW1lbnRMb2Fk ZXIoKS0+aXNTdG9wcGluZygpKSkKKyAgICAgICAgcmV0dXJuIDA7CisKICAgICBSZXNvdXJjZVJl cXVlc3QgbmV3UmVxdWVzdCA9IHJlcXVlc3Q7CiAKICAgICAvLyBOb3RlOiBXZSBza2lwIHRoZSBD b250ZW50LVNlY3VyaXR5LVBvbGljeSBjaGVjayBoZXJlIGJlY2F1c2Ugd2UgY2hlY2sKQEAgLTc2 LDggKzc5LDggQEAKICAgICBTdHJpbmcgb3V0Z29pbmdSZWZlcnJlcjsKICAgICBTdHJpbmcgb3V0 Z29pbmdPcmlnaW47CiAgICAgaWYgKHJlcXVlc3QuaHR0cFJlZmVycmVyKCkuaXNOdWxsKCkpIHsK LSAgICAgICAgb3V0Z29pbmdSZWZlcnJlciA9IGZsLT5vdXRnb2luZ1JlZmVycmVyKCk7Ci0gICAg ICAgIG91dGdvaW5nT3JpZ2luID0gZmwtPm91dGdvaW5nT3JpZ2luKCk7CisgICAgICAgIG91dGdv aW5nUmVmZXJyZXIgPSBmcmFtZUxvYWRlci0+b3V0Z29pbmdSZWZlcnJlcigpOworICAgICAgICBv dXRnb2luZ09yaWdpbiA9IGZyYW1lTG9hZGVyLT5vdXRnb2luZ09yaWdpbigpOwogICAgIH0gZWxz ZSB7CiAgICAgICAgIG91dGdvaW5nUmVmZXJyZXIgPSByZXF1ZXN0Lmh0dHBSZWZlcnJlcigpOwog ICAgICAgICBvdXRnb2luZ09yaWdpbiA9IFNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tU3RyaW5n KG91dGdvaW5nUmVmZXJyZXIpLT50b1N0cmluZygpOwpAQCAtODksNyArOTIsNyBAQAogICAgICAg ICBuZXdSZXF1ZXN0LnNldEhUVFBSZWZlcnJlcihvdXRnb2luZ1JlZmVycmVyKTsKICAgICBGcmFt ZUxvYWRlcjo6YWRkSFRUUE9yaWdpbklmTmVlZGVkKG5ld1JlcXVlc3QsIG91dGdvaW5nT3JpZ2lu KTsKIAotICAgIGZsLT5hZGRFeHRyYUZpZWxkc1RvU3VicmVzb3VyY2VSZXF1ZXN0KG5ld1JlcXVl c3QpOworICAgIGZyYW1lTG9hZGVyLT5hZGRFeHRyYUZpZWxkc1RvU3VicmVzb3VyY2VSZXF1ZXN0 KG5ld1JlcXVlc3QpOwogCiAgICAgUmVmUHRyPFN1YnJlc291cmNlTG9hZGVyPiBzdWJsb2FkZXIo YWRvcHRSZWYobmV3IFN1YnJlc291cmNlTG9hZGVyKGZyYW1lLCBjbGllbnQsIG9wdGlvbnMpKSk7 CiAgICAgaWYgKCFzdWJsb2FkZXItPmluaXQobmV3UmVxdWVzdCkpCg==