68992 2011-09-28 03:38:46 -0700 [GTK] missing WebKit2 support in run-gtk-tests 2011-09-28 04:25:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned cgarcia oldest_to_newest 474646 0 pnormand 2011-09-28 03:38:46 -0700 The script assumes all tests are in Programs/unittests but the webkit2 tests and inside a webkit2 directory there. 474647 1 108997 pnormand 2011-09-28 03:40:24 -0700 Created attachment 108997 proposed patch 474648 2 108997 cgarcia 2011-09-28 03:45:28 -0700 Comment on attachment 108997 proposed patch Looks good to me. Now we should make sure all tests are named test*. Maybe we should move webkit1 test into a webkit directory so that we have Programs/unittests/webkit/* and Programs/unittests/webkit2/* 474655 3 pnormand 2011-09-28 04:02:55 -0700 (In reply to comment #2) > (From update of attachment 108997 [details]) > Looks good to me. Now we should make sure all tests are named test*. Maybe we should move webkit1 test into a webkit directory so that we have Programs/unittests/webkit/* and Programs/unittests/webkit2/* Yes that would be better indeed. I think it could be done in a follow-up patch, I wanted to keep this one minimal to get the API tests back up on the bots. 474658 4 cgarcia 2011-09-28 04:16:45 -0700 Yes, I meant in a following patch indeed. 474664 5 pnormand 2011-09-28 04:25:15 -0700 Committed r96214: <http://trac.webkit.org/changeset/96214> 108997 2011-09-28 03:40:24 -0700 2011-09-28 04:21:43 -0700 proposed patch proposed-patch.patch text/plain 1506 pnormand RnJvbSBlN2U2N2MwY2U1OTYwYWM1MzhhY2EyMjg2ODQ2NDJiZjhjY2JiOWE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDI4IFNlcCAyMDExIDEyOjM5OjU4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgIHwgICAxMCAr KysrKysrKysrCiBUb29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMgfCAgICA1ICsrKystCiAyIGZp bGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGY0M2VkZTIuLmVlMDY3 MDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0wOS0yOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gbWlzc2luZyBXZWJLaXQyIHN1cHBvcnQgaW4gcnVu LWd0ay10ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Njg5OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvcnVuLWd0ay10ZXN0czogR2V0IHRoZSBXZWJLaXQyIHRlc3RzIHRvIHJ1biBm cm9tIHRoZQorICAgICAgICB3ZWJraXQyIGRpcmVjdG9yeS4KKwogMjAxMS0wOS0yNyAgUGhpbGlw cGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gYnVpbGQt d2Via2l0IC0tbm8td2Via2l0MiBzdGlsbCBidWlsZHMgV2ViS2l0MgpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCmlu ZGV4IGQzZTA1NjAuLjJmYjY1YjcgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10 ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKQEAgLTI4LDcgKzI4LDEwIEBA IHVzZSB3ZWJraXRkaXJzOwogc2V0Q29uZmlndXJhdGlvbigpOwogCiBteSAkcHJvZHVjdERpciA9 IHByb2R1Y3REaXIoKTsKLW15IEB1bml0VGVzdHMgPSBnbG9iICAkcHJvZHVjdERpciAuICIvUHJv Z3JhbXMvdW5pdHRlc3RzLyoiOworbXkgJHRlc3RzRGlyID0gJHByb2R1Y3REaXIgLiAiL1Byb2dy YW1zL3VuaXR0ZXN0cyIgOworbXkgQHVuaXRUZXN0cyA9IGdsb2IgICR0ZXN0c0RpciAuICIvdGVz dCoiOworbXkgQHdlYmtpdDJVbml0VGVzdHMgPSBnbG9iICAkdGVzdHNEaXIgLiAiL3dlYmtpdDIv dGVzdCoiOworcHVzaCBAdW5pdFRlc3RzLCBAd2Via2l0MlVuaXRUZXN0czsKIGlmICgkI3VuaXRU ZXN0cyA8IDEpIHsKICAgICBkaWUgIkVSUk9SOiB0ZXN0cyBub3QgZm91bmQgaW4gJHByb2R1Y3RE aXIuXG4iOwogfQotLSAKMS43LjcucmMx