68988 2011-09-28 02:32:56 -0700 [chromium skia] PNGImageEncoder: hoist constants out of the encoding loop 2011-09-29 10:15:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon jbauman kbr webkit.review.bot oldest_to_newest 474616 0 noel.gordon 2011-09-28 02:32:56 -0700 [chromium skia] PNGImageEncoder: hoist constants out of the encoding loop 474624 1 108992 noel.gordon 2011-09-28 02:45:47 -0700 Created attachment 108992 Patch 475483 2 108992 kbr 2011-09-29 09:58:01 -0700 Comment on attachment 108992 Patch Looks good. r=me 475501 3 108992 webkit.review.bot 2011-09-29 10:15:42 -0700 Comment on attachment 108992 Patch Clearing flags on attachment: 108992 Committed r96338: <http://trac.webkit.org/changeset/96338> 475502 4 webkit.review.bot 2011-09-29 10:15:46 -0700 All reviewed patches have been landed. Closing bug. 108992 2011-09-28 02:45:47 -0700 2011-09-29 10:15:42 -0700 Patch bug-68988-20110928194545.patch text/plain 3774 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogOTYxOTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NTRhNTVhMjk5ZjI0YTc4 ZDJhMjRiMWU2OGM4MGYzODQxYWYwMjVkLi5hMzZhNjVhN2EyOTkwODhiOWYzZjMwODM4NDZmNTY0 MWY0ZTE2NjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMjggIE5vZWwg R29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisgICAgICAgIFtjaHJvbWl1bSBza2lh XSBQTkdJbWFnZUVuY29kZXI6IGhvaXN0IGNvbnN0YW50cyBvdXQgb2YgdGhlIGVuY29kaW5nIGxv b3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4OTg4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiAgQ292ZXJlZCBieSBleGlzdGluZyBjYW52YXMgMmQgYW5kIDNkIHRlc3RzLgorICAg ICAgICBjYW52YXMvcGhpbGlwL3Rlc3RzL3RvRGF0YVVSTC5wbmcuKi5odG1sCisgICAgICAgIGZh c3QvY2FudmFzL3RvRGF0YVVSTC1hbHBoYS5odG1sCisgICAgICAgIGZhc3QvY2FudmFzL3dlYmds L3ByZW11bHRpcGx5YWxwaGEtdGVzdC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1l bmNvZGVycy9za2lhL1BOR0ltYWdlRW5jb2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjplbmNv ZGVQaXhlbHMpOiAgTW92ZSBjb25zdGFudCBvdXQgb2YgdGhlIGVuY29kaW5nIGxvb3AuCisgICAg ICAgIChXZWJDb3JlOjpQTkdJbWFnZUVuY29kZXI6OmVuY29kZSk6ICBDb25zaXN0ZW5jeSAmIHN0 eWxlOiBjYWxsIGVuY29kZVBpeGVscygpCisgICAgICAgIGp1c3QgbGlrZSB3ZSBkbyBpbiB0aGUg SlBFRyBlbmNvZGVyLgorCiAyMDExLTA5LTI3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFNpbXBsaWZ5IFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpwb3NpdGlv bkF0U3RhcnRPZkluc2VydGVkQ29udGVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9QTkdJbWFnZUVuY29kZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9QTkdJbWFnZUVuY29kZXIuY3BwCmlu ZGV4IDNkNTc5ODdmOWE0NGUzNzU3MTM1MWZjY2UyYTdjNDAwYmZjYWZmNjIuLjVjMTE2MmJmYjc1 NWUzNGNhMDVkZjNiN2U2MzUyNTc4OGUwNGIxNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvUE5HSW1hZ2VFbmNvZGVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9za2lhL1BOR0ltYWdlRW5jb2Rl ci5jcHAKQEAgLTY4LDEwICs2OCw4IEBAIHN0YXRpYyB2b2lkIHByZU11bHRpcGxpZWRCR1JBdG9S R0JBKGNvbnN0IHZvaWQqIHBpeGVscywgaW50IHBpeGVsQ291bnQsIHVuc2lnbmVkCiAgICAgfQog fQogCi1zdGF0aWMgYm9vbCBlbmNvZGVQaXhlbHMoY29uc3QgSW50U2l6ZSYgaW5wdXRTaXplLCB1 bnNpZ25lZCBjaGFyKiBpbnB1dFBpeGVscywKLSAgICAgICAgICAgICAgICAgICAgICAgICBib29s IHByZW11bHRpcGxpZWQsIFZlY3Rvcjx1bnNpZ25lZCBjaGFyPiogb3V0cHV0KQorc3RhdGljIGJv b2wgZW5jb2RlUGl4ZWxzKEludFNpemUgaW1hZ2VTaXplLCB1bnNpZ25lZCBjaGFyKiBpbnB1dFBp eGVscywgYm9vbCBwcmVtdWx0aXBsaWVkLCBWZWN0b3I8dW5zaWduZWQgY2hhcj4qIG91dHB1dCkK IHsKLSAgICBJbnRTaXplIGltYWdlU2l6ZShpbnB1dFNpemUpOwogICAgIGltYWdlU2l6ZS5jbGFt cE5lZ2F0aXZlVG9aZXJvKCk7CiAgICAgVmVjdG9yPHVuc2lnbmVkIGNoYXI+IHJvdzsKIApAQCAt MTAxLDEzICs5OSwxNCBAQCBzdGF0aWMgYm9vbCBlbmNvZGVQaXhlbHMoY29uc3QgSW50U2l6ZSYg aW5wdXRTaXplLCB1bnNpZ25lZCBjaGFyKiBpbnB1dFBpeGVscywKIAogICAgIHVuc2lnbmVkIGNo YXIqIHBpeGVscyA9IGlucHV0UGl4ZWxzOwogICAgIHJvdy5yZXNpemUoaW1hZ2VTaXplLndpZHRo KCkgKiBzaXplb2YoU2tQTUNvbG9yKSk7CisgICAgY29uc3Qgc2l6ZV90IHBpeGVsUm93U3RyaWRl ID0gaW1hZ2VTaXplLndpZHRoKCkgKiA0OwogICAgIGZvciAoaW50IHkgPSAwOyB5IDwgaW1hZ2VT aXplLmhlaWdodCgpOyArK3kpIHsKICAgICAgICAgaWYgKHByZW11bHRpcGxpZWQpIHsKICAgICAg ICAgICAgIHByZU11bHRpcGxpZWRCR1JBdG9SR0JBKHBpeGVscywgaW1hZ2VTaXplLndpZHRoKCks IHJvdy5kYXRhKCkpOwogICAgICAgICAgICAgcG5nX3dyaXRlX3JvdyhwbmcsIHJvdy5kYXRhKCkp OwogICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIHBuZ193cml0ZV9yb3cocG5nLCBwaXhlbHMp OwotICAgICAgICBwaXhlbHMgKz0gaW1hZ2VTaXplLndpZHRoKCkgKiA0OworICAgICAgICBwaXhl bHMgKz0gcGl4ZWxSb3dTdHJpZGU7CiAgICAgfQogCiAgICAgcG5nX3dyaXRlX2VuZChwbmcsIGlu Zm8pOwpAQCAtMTE3LDE3ICsxMTYsMTcgQEAgc3RhdGljIGJvb2wgZW5jb2RlUGl4ZWxzKGNvbnN0 IEludFNpemUmIGlucHV0U2l6ZSwgdW5zaWduZWQgY2hhciogaW5wdXRQaXhlbHMsCiAKIGJvb2wg UE5HSW1hZ2VFbmNvZGVyOjplbmNvZGUoY29uc3QgU2tCaXRtYXAmIGJpdG1hcCwgVmVjdG9yPHVu c2lnbmVkIGNoYXI+KiBvdXRwdXQpCiB7CisgICAgU2tBdXRvTG9ja1BpeGVscyBiaXRtYXBMb2Nr KGJpdG1hcCk7CisKICAgICBpZiAoYml0bWFwLmNvbmZpZygpICE9IFNrQml0bWFwOjprQVJHQl84 ODg4X0NvbmZpZykKLSAgICAgICAgcmV0dXJuIGZhbHNlOyAvLyBPbmx5IHN1cHBvcnQgQVJHQiAz MiBicHAgc2tpYSBiaXRtYXBzLgorICAgICAgICByZXR1cm4gZmFsc2U7IC8vIE9ubHkgc3VwcG9y dCAzMiBiaXQvcGl4ZWwgc2tpYSBiaXRtYXBzLgogCi0gICAgU2tBdXRvTG9ja1BpeGVscyBiaXRt YXBMb2NrKGJpdG1hcCk7Ci0gICAgSW50U2l6ZSBpbWFnZVNpemUoYml0bWFwLndpZHRoKCksIGJp dG1hcC5oZWlnaHQoKSk7Ci0gICAgcmV0dXJuIGVuY29kZVBpeGVscyhpbWFnZVNpemUsIHN0YXRp Y19jYXN0PHVuc2lnbmVkIGNoYXIqPihiaXRtYXAuZ2V0UGl4ZWxzKCkpLCB0cnVlLCBvdXRwdXQp OworICAgIHJldHVybiBlbmNvZGVQaXhlbHMoSW50U2l6ZShiaXRtYXAud2lkdGgoKSwgYml0bWFw LmhlaWdodCgpKSwgc3RhdGljX2Nhc3Q8dW5zaWduZWQgY2hhcio+KGJpdG1hcC5nZXRQaXhlbHMo KSksIHRydWUsIG91dHB1dCk7CiB9CiAKLWJvb2wgUE5HSW1hZ2VFbmNvZGVyOjplbmNvZGUoY29u c3QgSW1hZ2VEYXRhJiBiaXRtYXAsIFZlY3Rvcjx1bnNpZ25lZCBjaGFyPiogb3V0cHV0KQorYm9v bCBQTkdJbWFnZUVuY29kZXI6OmVuY29kZShjb25zdCBJbWFnZURhdGEmIGltYWdlRGF0YSwgVmVj dG9yPHVuc2lnbmVkIGNoYXI+KiBvdXRwdXQpCiB7Ci0gICAgcmV0dXJuIGVuY29kZVBpeGVscyhi aXRtYXAuc2l6ZSgpLCBiaXRtYXAuZGF0YSgpLT5kYXRhKCktPmRhdGEoKSwgZmFsc2UsIG91dHB1 dCk7CisgICAgcmV0dXJuIGVuY29kZVBpeGVscyhpbWFnZURhdGEuc2l6ZSgpLCBpbWFnZURhdGEu ZGF0YSgpLT5kYXRhKCktPmRhdGEoKSwgZmFsc2UsIG91dHB1dCk7CiB9CiAKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUK